84339 2012-04-19 07:24:21 -0700 [Chromium] Call sampleGamepads directly 2012-04-19 08:57:48 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 82948 1 pilgrim pilgrim abarth fishd haraken webkit.review.bot oldest_to_newest 605558 0 pilgrim 2012-04-19 07:24:21 -0700 [Chromium] Call sampleGamepads directly 605560 1 137898 pilgrim 2012-04-19 07:25:15 -0700 Created attachment 137898 Patch 605562 2 137898 haraken 2012-04-19 07:29:32 -0700 Comment on attachment 137898 Patch OK. (BTW, does this change require r+ from API reviewers?) 605578 3 pilgrim 2012-04-19 07:52:34 -0700 (In reply to comment #2) > (From update of attachment 137898 [details]) > OK. (BTW, does this change require r+ from API reviewers?) No idea. Whom should I ask? 605593 4 haraken 2012-04-19 08:05:59 -0700 >> OK. (BTW, does this change require r+ from API reviewers?) > > No idea. Whom should I ask? I think no need. If it is necessary, webkit-bot automatically notifies us about it:) 605612 5 137898 webkit.review.bot 2012-04-19 08:57:43 -0700 Comment on attachment 137898 Patch Clearing flags on attachment: 137898 Committed r114635: <http://trac.webkit.org/changeset/114635> 605613 6 webkit.review.bot 2012-04-19 08:57:48 -0700 All reviewed patches have been landed. Closing bug. 137898 2012-04-19 07:25:15 -0700 2012-04-19 08:57:42 -0700 Patch bug-84339-20120419102501.patch text/plain 5545 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDYyOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTE5ICBNYXJrIFBp bGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIENhbGwg c2FtcGxlR2FtZXBhZHMgZGlyZWN0bHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTg0MzM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUGFydCBvZiBhIHJlZmFjdG9yaW5nIHNlcmllcy4gU2VlIHRyYWNraW5n IGJ1ZyA4Mjk0OC4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL0dhbWVwYWRzQ2hyb21p dW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6c2FtcGxlR2FtZXBhZHMpOgorICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtU3VwcG9ydC5oOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChQbGF0Zm9ybVN1cHBvcnQpOgorCiAyMDEyLTA0LTE5ICBWc2V2b2xvZCBWbGFzb3Yg IDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHgtZnJhbWUg c2VjdXJpdHkgZXJyb3JzIGxvZ2dlZCB3aGVuIHR5cGluZyBpbiB0aGUgY29uc29sZSBhcmUgYW5u b3lpbmcuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9HYW1lcGFkc0No cm9taXVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9HYW1lcGFkc0Nocm9taXVtLmNwcAkocmV2aXNpb24gMTE0NjI5KQorKysgU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vR2FtZXBhZHNDaHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTI5LDcgKzI5LDggQEAKICNpZiBFTkFCTEUoR0FNRVBBRCkKIAogI2luY2x1ZGUgIkdhbWVw YWRMaXN0LmgiCi0jaW5jbHVkZSAiUGxhdGZvcm1TdXBwb3J0LmgiCisKKyNpbmNsdWRlIDxwdWJs aWMvUGxhdGZvcm0uaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC0zNyw3ICszOCwyNSBA QCBjbGFzcyBHYW1lcGFkTGlzdDsKIAogdm9pZCBzYW1wbGVHYW1lcGFkcyhHYW1lcGFkTGlzdCog aW50bykKIHsKLSAgICBQbGF0Zm9ybVN1cHBvcnQ6OnNhbXBsZUdhbWVwYWRzKGludG8pOworICAg IFdlYktpdDo6V2ViR2FtZXBhZHMgZ2FtZXBhZHM7CisKKyAgICBXZWJLaXQ6OlBsYXRmb3JtOjpj dXJyZW50KCktPnNhbXBsZUdhbWVwYWRzKGdhbWVwYWRzKTsKKworICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBXZWJLaXQ6OldlYkdhbWVwYWRzOjppdGVtc0xlbmd0aENhcDsgKytpKSB7Cisg ICAgICAgIFdlYktpdDo6V2ViR2FtZXBhZCYgd2ViR2FtZXBhZCA9IGdhbWVwYWRzLml0ZW1zW2ld OworICAgICAgICBpZiAoaSA8IGdhbWVwYWRzLmxlbmd0aCAmJiB3ZWJHYW1lcGFkLmNvbm5lY3Rl ZCkgeworICAgICAgICAgICAgUmVmUHRyPEdhbWVwYWQ+IGdhbWVwYWQgPSBpbnRvLT5pdGVtKGkp OworICAgICAgICAgICAgaWYgKCFnYW1lcGFkKQorICAgICAgICAgICAgICAgIGdhbWVwYWQgPSBH YW1lcGFkOjpjcmVhdGUoKTsKKyAgICAgICAgICAgIGdhbWVwYWQtPmlkKHdlYkdhbWVwYWQuaWQp OworICAgICAgICAgICAgZ2FtZXBhZC0+aW5kZXgoaSk7CisgICAgICAgICAgICBnYW1lcGFkLT50 aW1lc3RhbXAod2ViR2FtZXBhZC50aW1lc3RhbXApOworICAgICAgICAgICAgZ2FtZXBhZC0+YXhl cyh3ZWJHYW1lcGFkLmF4ZXNMZW5ndGgsIHdlYkdhbWVwYWQuYXhlcyk7CisgICAgICAgICAgICBn YW1lcGFkLT5idXR0b25zKHdlYkdhbWVwYWQuYnV0dG9uc0xlbmd0aCwgd2ViR2FtZXBhZC5idXR0 b25zKTsKKyAgICAgICAgICAgIGludG8tPnNldChpLCBnYW1lcGFkKTsKKyAgICAgICAgfSBlbHNl CisgICAgICAgICAgICBpbnRvLT5zZXQoaSwgMCk7CisgICAgfQogfQogCiB9CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVN1cHBvcnQuaAko cmV2aXNpb24gMTE0NjI5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vUGxh dGZvcm1TdXBwb3J0LmgJKHdvcmtpbmcgY29weSkKQEAgLTcyLDcgKzcyLDYgQEAgY2xhc3MgQ29s b3I7CiBjbGFzcyBDdXJzb3I7CiBjbGFzcyBEb2N1bWVudDsKIGNsYXNzIEZyYW1lOwotY2xhc3Mg R2FtZXBhZExpc3Q7CiBjbGFzcyBHZW9sb2NhdGlvblNlcnZpY2VCcmlkZ2U7CiBjbGFzcyBHZW9s b2NhdGlvblNlcnZpY2VDaHJvbWl1bTsKIGNsYXNzIEdyYXBoaWNzQ29udGV4dDsKQEAgLTE4OCw5 ICsxODcsNiBAQCBwdWJsaWM6CiAgICAgLy8gSW5qZWN0cyBrZXkgdmlhIGtleVBhdGggaW50byB2 YWx1ZS4gUmV0dXJucyB0cnVlIG9uIHN1Y2Nlc3MuCiAgICAgc3RhdGljIFBhc3NSZWZQdHI8U2Vy aWFsaXplZFNjcmlwdFZhbHVlPiBpbmplY3RJREJLZXlJbnRvU2VyaWFsaXplZFZhbHVlKFBhc3NS ZWZQdHI8SURCS2V5PiwgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+LCBjb25zdCBT dHJpbmcmIGtleVBhdGgpOwogCi0gICAgLy8gR2FtZXBhZCAtLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQotICAgIHN0YXRpYyB2b2lkIHNh bXBsZUdhbWVwYWRzKEdhbWVwYWRMaXN0KiBpbnRvKTsKLQogICAgIC8vIEphdmFTY3JpcHQgLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAg ICAgc3RhdGljIHZvaWQgbm90aWZ5SlNPdXRPZk1lbW9yeShGcmFtZSopOwogICAgIHN0YXRpYyBi b29sIGFsbG93U2NyaXB0RGVzcGl0ZVNldHRpbmdzKGNvbnN0IEtVUkwmIGRvY3VtZW50VVJMKTsK SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMTQ2MjkpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTE5ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBbQ2hyb21pdW1dIENhbGwgc2FtcGxlR2FtZXBhZHMgZGlyZWN0bHkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MzM5CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFydCBvZiBhIHJlZmFjdG9y aW5nIHNlcmllcy4gU2VlIHRyYWNraW5nIGJ1ZyA4Mjk0OC4KKworICAgICAgICAqIHNyYy9QbGF0 Zm9ybVN1cHBvcnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1TdXBwb3J0Ojppbmpl Y3RJREJLZXlJbnRvU2VyaWFsaXplZFZhbHVlKToKKwogMjAxMi0wNC0xOCAgTmljbyBXZWJlciAg PHRoYWtpc0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtL21hY10gRml4IGJ1aWxk LgpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvUGxhdGZvcm1TdXBwb3J0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0Zm9ybVN1cHBvcnQu Y3BwCShyZXZpc2lvbiAxMTQ2MjkpCisrKyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9QbGF0 Zm9ybVN1cHBvcnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05Miw3ICs5Miw2IEBACiAjaW5jbHVk ZSAiQ29va2llLmgiCiAjaW5jbHVkZSAiRG9jdW1lbnQuaCIKICNpbmNsdWRlICJGcmFtZVZpZXcu aCIKLSNpbmNsdWRlICJHYW1lcGFkTGlzdC5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5o IgogI2luY2x1ZGUgIklEQkZhY3RvcnlCYWNrZW5kUHJveHkuaCIKICNpbmNsdWRlICJLVVJMLmgi CkBAIC01NDAsMzEgKzUzOSw2IEBAIFBhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBQ bGF0Zm8KICAgICByZXR1cm4gd2ViS2l0UGxhdGZvcm1TdXBwb3J0KCktPmluamVjdElEQktleUlu dG9TZXJpYWxpemVkVmFsdWUoa2V5LCB2YWx1ZSwga2V5UGF0aCk7CiB9CiAKLS8vIEdhbWVwYWQg LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KLQotdm9pZCBQbGF0Zm9ybVN1cHBvcnQ6OnNhbXBsZUdhbWVwYWRzKEdhbWVw YWRMaXN0KiBpbnRvKQotewotICAgIFdlYkdhbWVwYWRzIGdhbWVwYWRzOwotCi0gICAgd2ViS2l0 UGxhdGZvcm1TdXBwb3J0KCktPnNhbXBsZUdhbWVwYWRzKGdhbWVwYWRzKTsKLQotICAgIGZvciAo dW5zaWduZWQgaSA9IDA7IGkgPCBXZWJLaXQ6OldlYkdhbWVwYWRzOjppdGVtc0xlbmd0aENhcDsg KytpKSB7Ci0gICAgICAgIFdlYkdhbWVwYWQmIHdlYkdhbWVwYWQgPSBnYW1lcGFkcy5pdGVtc1tp XTsKLSAgICAgICAgaWYgKGkgPCBnYW1lcGFkcy5sZW5ndGggJiYgd2ViR2FtZXBhZC5jb25uZWN0 ZWQpIHsKLSAgICAgICAgICAgIFJlZlB0cjxHYW1lcGFkPiBnYW1lcGFkID0gaW50by0+aXRlbShp KTsKLSAgICAgICAgICAgIGlmICghZ2FtZXBhZCkKLSAgICAgICAgICAgICAgICBnYW1lcGFkID0g R2FtZXBhZDo6Y3JlYXRlKCk7Ci0gICAgICAgICAgICBnYW1lcGFkLT5pZCh3ZWJHYW1lcGFkLmlk KTsKLSAgICAgICAgICAgIGdhbWVwYWQtPmluZGV4KGkpOwotICAgICAgICAgICAgZ2FtZXBhZC0+ dGltZXN0YW1wKHdlYkdhbWVwYWQudGltZXN0YW1wKTsKLSAgICAgICAgICAgIGdhbWVwYWQtPmF4 ZXMod2ViR2FtZXBhZC5heGVzTGVuZ3RoLCB3ZWJHYW1lcGFkLmF4ZXMpOwotICAgICAgICAgICAg Z2FtZXBhZC0+YnV0dG9ucyh3ZWJHYW1lcGFkLmJ1dHRvbnNMZW5ndGgsIHdlYkdhbWVwYWQuYnV0 dG9ucyk7Ci0gICAgICAgICAgICBpbnRvLT5zZXQoaSwgZ2FtZXBhZCk7Ci0gICAgICAgIH0gZWxz ZQotICAgICAgICAgICAgaW50by0+c2V0KGksIDApOwotICAgIH0KLX0KLQogLy8gS2V5Z2VuIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQogCiBTdHJpbmcgUGxhdGZvcm1TdXBwb3J0OjpzaWduZWRQdWJsaWNLZXlBbmRD aGFsbGVuZ2VTdHJpbmcoCg==