84319 2012-04-18 22:58:04 -0700 [CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG 2012-04-18 23:56:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon eric mitz webkit.review.bot oldest_to_newest 605391 0 noel.gordon 2012-04-18 22:58:04 -0700 [CG] ImageBuffer::toDataURL: Remove alpha stuffing loop when encoding to JPEG 605394 1 137848 noel.gordon 2012-04-18 23:05:42 -0700 Created attachment 137848 Patch 605396 2 noel.gordon 2012-04-18 23:08:10 -0700 canvas/philip/tests/toDataURL.jpeg.alpha.html and fast/canvas/webgl/premultiplyalpha-test.html are passing locally for me with this change. 605405 3 137848 eric 2012-04-18 23:41:00 -0700 Comment on attachment 137848 Patch Yup! Looks right to me. 605410 4 137848 webkit.review.bot 2012-04-18 23:56:41 -0700 Comment on attachment 137848 Patch Clearing flags on attachment: 137848 Committed r114616: <http://trac.webkit.org/changeset/114616> 605411 5 webkit.review.bot 2012-04-18 23:56:45 -0700 All reviewed patches have been landed. Closing bug. 137848 2012-04-18 23:05:42 -0700 2012-04-18 23:56:40 -0700 Patch bug-84319-20120419160540.patch text/plain 2720 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcxYjcwOTdiM2UyMzg0 ZWU1NGJmMmVhNGU4MmRjNzhiZTZjZWZhOS4uODMyY2Y0ZjI5M2U3NTFlMDVkN2ZlZGRjOGE1NDFl MWQ1NGRjMDMyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTE4ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbQ0ddIEltYWdlQnVm ZmVyOjp0b0RhdGFVUkw6IFJlbW92ZSBhbHBoYSBzdHVmZmluZyBsb29wIHdoZW4gZW5jb2Rpbmcg dG8gSlBFRworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 ODQzMTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBjaGFuZ2UgaW4gYmVoYXZpb3IuIENvdmVyZWQgYnkgZXhpc3RpbmcgY2FudmFzIDJkIGFuZCAz ZCB0ZXN0czoKKworICAgICAgICAgIGNhbnZhcy9waGlsaXAvdGVzdHMvdG9EYXRhVVJMLmpwZWcu YWxwaGEuaHRtbAorICAgICAgICAgIGZhc3QvY2FudmFzL3dlYmdsL3ByZW11bHRpcGx5YWxwaGEt dGVzdC5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNH LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyOjp0b0RhdGFVUkwpOiBSZW1vdmUg dGhlIGFscGhhIHN0dWZmaW5nIGxvb3AgYW5kIGluc3RlYWQsCisgICAgICAgIG1ha2UgSlBFRyBl bmNvZGVyIGlnbm9yZSB0aGUgYWxwaGEgY2hhbm5lbCAoa0NHSW1hZ2VBbHBoYU5vbmVTa2lwTGFz dCkuCisKIDIwMTItMDQtMTggIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KIAog ICAgICAgICBbY2hyb21pdW1dIENvbnNvbGlkYXRlIGFkanVzdFRleHRSZW5kZXJNb2RlIGNvcHlw YXN0YSBpbnRvIFNraWEgY29udGV4dApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAppbmRleCA3NTJhYzRkMWZiMDM5OTg3ZTVi YWJkMTU0MTljYmVjMDE3YTZlMDA5Li43ZTkzMGQ1MjlkYzM3NDI0M2E3NDBiNDBlMWZlNGVmMjAw OGEzZjc2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9J bWFnZUJ1ZmZlckNHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j Zy9JbWFnZUJ1ZmZlckNHLmNwcApAQCAtNDQ5LDE3ICs0NDksMTMgQEAgU3RyaW5nIEltYWdlQnVm ZmVyOjp0b0RhdGFVUkwoY29uc3QgU3RyaW5nJiBtaW1lVHlwZSwgY29uc3QgZG91YmxlKiBxdWFs aXR5LCBDb28KICAgICAgICAgaWYgKCFwcmVtdWx0aXBsaWVkRGF0YSkKICAgICAgICAgICAgIHJl dHVybiAiZGF0YTosIjsKIAotICAgICAgICB1bnNpZ25lZCBjaGFyICpkYXRhID0gcHJlbXVsdGlw bGllZERhdGEtPmRhdGEoKTsKLSAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsb2dpY2FsU2l6 ZSgpLndpZHRoKCkgKiBsb2dpY2FsU2l6ZSgpLmhlaWdodCgpOyBpKyspCi0gICAgICAgICAgICBk YXRhW2kgKiA0ICsgM10gPSAyNTU7IC8vIFRoZSBkYXRhIGlzIHByZW11bHRpcGxpZWQsIHdlIGp1 c3QgbmVlZCB0byBtYWtlIGl0IG9wYXF1ZS4KLQogICAgICAgICBSZXRhaW5QdHI8Q0dEYXRhUHJv dmlkZXJSZWY+IGRhdGFQcm92aWRlcjsKLSAgICAgICAgZGF0YVByb3ZpZGVyLmFkb3B0Q0YoQ0dE YXRhUHJvdmlkZXJDcmVhdGVXaXRoRGF0YSgwLCBkYXRhLCA0ICogbG9naWNhbFNpemUoKS53aWR0 aCgpICogbG9naWNhbFNpemUoKS5oZWlnaHQoKSwgMCkpOworICAgICAgICBkYXRhUHJvdmlkZXIu YWRvcHRDRihDR0RhdGFQcm92aWRlckNyZWF0ZVdpdGhEYXRhKDAsIHByZW11bHRpcGxpZWREYXRh LT5kYXRhKCksIDQgKiBsb2dpY2FsU2l6ZSgpLndpZHRoKCkgKiBsb2dpY2FsU2l6ZSgpLmhlaWdo dCgpLCAwKSk7CiAgICAgICAgIGlmICghZGF0YVByb3ZpZGVyKQogICAgICAgICAgICAgcmV0dXJu ICJkYXRhOiwiOwogCiAgICAgICAgIGltYWdlLmFkb3B0Q0YoQ0dJbWFnZUNyZWF0ZShsb2dpY2Fs U2l6ZSgpLndpZHRoKCksIGxvZ2ljYWxTaXplKCkuaGVpZ2h0KCksIDgsIDMyLCA0ICogbG9naWNh bFNpemUoKS53aWR0aCgpLAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGV2 aWNlUkdCQ29sb3JTcGFjZVJlZigpLCBrQ0dCaXRtYXBCeXRlT3JkZXJEZWZhdWx0IHwga0NHSW1h Z2VBbHBoYUxhc3QsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZpY2VS R0JDb2xvclNwYWNlUmVmKCksIGtDR0JpdG1hcEJ5dGVPcmRlckRlZmF1bHQgfCBrQ0dJbWFnZUFs cGhhTm9uZVNraXBMYXN0LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZGF0 YVByb3ZpZGVyLmdldCgpLCAwLCBmYWxzZSwga0NHUmVuZGVyaW5nSW50ZW50RGVmYXVsdCkpOwog ICAgIH0gZWxzZSBpZiAobV9yZXNvbHV0aW9uU2NhbGUgPT0gMSkKICAgICAgICAgaW1hZ2UuYWRv cHRDRihjb3B5TmF0aXZlSW1hZ2UoQ29weUJhY2tpbmdTdG9yZSkpOwo=