84318 2012-04-18 22:49:53 -0700 AsyncFileSystem::openFileSystem is missing parameters 2014-01-28 08:11:51 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 82156 1 leo.yang leo.yang abarth andersca charles.wei eric rwlbuis staikos tonikitoo zimmermann oldest_to_newest 605384 0 leo.yang 2012-04-18 22:49:53 -0700 AsyncFileSystem::openFileSystem should take more parameters (SecurityOrigin and file system size) from LocalFileSystem::requestFileSystem. These parameter are required when opening a filesystem. 605400 1 137850 leo.yang 2012-04-18 23:15:40 -0700 Created attachment 137850 Patch 606098 2 137850 eric 2012-04-19 16:16:53 -0700 Comment on attachment 137850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137850&action=review > Source/WebCore/platform/AsyncFileSystem.cpp:67 > +void AsyncFileSystem::openFileSystem(ScriptExecutionContext*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks) ScriptExecutationContext is not a platofrm concept. I believe this is a layering violation. > Source/WebCore/platform/gtk/AsyncFileSystemGtk.cpp:50 > +void AsyncFileSystem::openFileSystem(SecurityOrigin*, const String& basePath, const String& storageIdentifier, Type type, long long, bool, PassOwnPtr<AsyncFileSystemCallbacks> callbacks) Similarly, I believe this to be a layering violation. 137850 2012-04-18 23:15:40 -0700 2012-04-19 16:16:52 -0700 Patch 0001-AsyncFileSystem-openFileSystem-is-missing-parameters.patch text/plain 9811 leo.yang RnJvbSA4OWJmMDFlNDkzOGI4OTg2ZWMzYjNlYTUxZTI4MDM1N2YyYmQ5YmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVvLnlhbmdAdG9yY2htb2JpbGUuY29tLmNu PgpEYXRlOiBUaHUsIDE5IEFwciAyMDEyIDE0OjE0OjMzICswODAwClN1YmplY3Q6IFtQQVRDSF0g QXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbSBpcyBtaXNzaW5nIHBhcmFtZXRlcnMKIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDMxOAoKUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCgpXaGVuIG9wZW5pbmcgYSBmaWxlIHN5c3RlbSBmb3IgY3JlYXRpb24g dGhlIHBsYXRmb3JtIHNob3VsZCBrbm93IHRoZSBxdW90YQpvZiB0aGUgZmlsZSBzeXN0ZW0gYW5k IHRoZSBzZWN1cml0eSBvcmlnaW4gb2YgdGhlIG9wZW5lci4gVGhlc2UgaW5mb3JtYXRpb24KaGF2 ZSBhbHJlYWR5IGJlZW4gdGhlcmUgaW4gdGhlIERPTSBpbnRlcmZhY2UgYnV0IHRoZXkgd2VyZW4n dCBwYXNzaW5nIGRvd24gdG8KdGhlIHBsYXRmb3JtIGxheWVyLiBUaGlzIHBhdGNoIGlzIGFkZGlu ZyB0aGVzZSAyIG1pc3NlZCBwYXJhbWV0ZXJzIHRvIHRoZQppbnRlcmZhY2Ugd2hpY2ggaXMgYmV0 d2VlbiBjcm9zcy1wbGF0Zm9ybSBhbmQgcGxhdGZvcm0gbGF5ZXIuCgpObyBmdW5jdGlvbmFsaXRp ZXMgY2hhbmdlZCwgbm8gbmV3IHRlc3RzLgoKKiBNb2R1bGVzL2ZpbGVzeXN0ZW0vTG9jYWxGaWxl U3lzdGVtLmNwcDoKKFdlYkNvcmU6Om9wZW5GaWxlU3lzdGVtKToKKFdlYkNvcmU6OkxvY2FsRmls ZVN5c3RlbTo6cmVhZEZpbGVTeXN0ZW0pOgooV2ViQ29yZTo6TG9jYWxGaWxlU3lzdGVtOjpyZXF1 ZXN0RmlsZVN5c3RlbSk6CiogcGxhdGZvcm0vQXN5bmNGaWxlU3lzdGVtLmNwcDoKKFdlYkNvcmU6 OkFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0pOgoqIHBsYXRmb3JtL0FzeW5jRmlsZVN5 c3RlbS5oOgooV2ViQ29yZSk6CihBc3luY0ZpbGVTeXN0ZW0pOgoqIHBsYXRmb3JtL2JsYWNrYmVy cnkvQXN5bmNGaWxlU3lzdGVtQmxhY2tCZXJyeS5jcHA6CihXZWJDb3JlOjpBc3luY0ZpbGVTeXN0 ZW06Om9wZW5GaWxlU3lzdGVtKToKKiBwbGF0Zm9ybS9ndGsvQXN5bmNGaWxlU3lzdGVtR3RrLmNw cDoKKFdlYkNvcmU6OkFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0pOgotLS0KIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAyOSArKysr KysrKysrKysrKysrKysrKwogLi4uL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmls ZVN5c3RlbS5jcHAgfCAgIDEwICsrKy0tLQogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQXN5bmNG aWxlU3lzdGVtLmNwcCAgICAgICAgfCAgICAzICstCiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9B c3luY0ZpbGVTeXN0ZW0uaCAgICAgICAgICB8ICAgIDMgKy0KIC4uLi9ibGFja2JlcnJ5L0FzeW5j RmlsZVN5c3RlbUJsYWNrQmVycnkuY3BwICAgICAgIHwgICAgMyArLQogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL0FzeW5jRmlsZVN5c3RlbUd0ay5jcHAgfCAgICAzICstCiA2IGZpbGVzIGNo YW5nZWQsIDQyIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY0 ZWRiMTkuLjBmYjU0NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwzMiBAQAorMjAxMi0wNC0xOCAg TGVvIFlhbmcgIDxsZW8ueWFuZ0B0b3JjaG1vYmlsZS5jb20uY24+CisKKyAgICAgICAgQXN5bmNG aWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbSBpcyBtaXNzaW5nIHBhcmFtZXRlcnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MzE4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBvcGVuaW5nIGEgZmls ZSBzeXN0ZW0gZm9yIGNyZWF0aW9uIHRoZSBwbGF0Zm9ybSBzaG91bGQga25vdyB0aGUgcXVvdGEK KyAgICAgICAgb2YgdGhlIGZpbGUgc3lzdGVtIGFuZCB0aGUgc2VjdXJpdHkgb3JpZ2luIG9mIHRo ZSBvcGVuZXIuIFRoZXNlIGluZm9ybWF0aW9uCisgICAgICAgIGhhdmUgYWxyZWFkeSBiZWVuIHRo ZXJlIGluIHRoZSBET00gaW50ZXJmYWNlIGJ1dCB0aGV5IHdlcmVuJ3QgcGFzc2luZyBkb3duIHRv CisgICAgICAgIHRoZSBwbGF0Zm9ybSBsYXllci4gVGhpcyBwYXRjaCBpcyBhZGRpbmcgdGhlc2Ug MiBtaXNzZWQgcGFyYW1ldGVycyB0byB0aGUKKyAgICAgICAgaW50ZXJmYWNlIHdoaWNoIGlzIGJl dHdlZW4gY3Jvc3MtcGxhdGZvcm0gYW5kIHBsYXRmb3JtIGxheWVyLgorCisgICAgICAgIE5vIGZ1 bmN0aW9uYWxpdGllcyBjaGFuZ2VkLCBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBNb2R1bGVz L2ZpbGVzeXN0ZW0vTG9jYWxGaWxlU3lzdGVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Om9wZW5G aWxlU3lzdGVtKToKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6cmVhZEZpbGVT eXN0ZW0pOgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxGaWxlU3lzdGVtOjpyZXF1ZXN0RmlsZVN5 c3RlbSk6CisgICAgICAgICogcGxhdGZvcm0vQXN5bmNGaWxlU3lzdGVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0pOgorICAgICAgICAqIHBs YXRmb3JtL0FzeW5jRmlsZVN5c3RlbS5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChB c3luY0ZpbGVTeXN0ZW0pOgorICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvQXN5bmNGaWxl U3lzdGVtQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBc3luY0ZpbGVTeXN0ZW06 Om9wZW5GaWxlU3lzdGVtKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvQXN5bmNGaWxlU3lzdGVt R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0 ZW0pOgorCiAyMDEyLTA0LTE4ICBFbWlsIEEgRWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkgcm91bmRpbmcvY29udmVyc2lvbnMgaW4gUmVuZGVy Qm94TW9kZWxPYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmlsZXN5 c3RlbS9Mb2NhbEZpbGVTeXN0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lz dGVtL0xvY2FsRmlsZVN5c3RlbS5jcHAKaW5kZXggOGYwMTY5ZS4uYzk1MGViMSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9maWxlc3lzdGVtL0xvY2FsRmlsZVN5c3RlbS5j cHAKQEAgLTc3LDIxICs3NywyMSBAQCBTdHJpbmcgTG9jYWxGaWxlU3lzdGVtOjpmaWxlU3lzdGVt QmFzZVBhdGgoKSBjb25zdAogICAgIHJldHVybiBtX2Jhc2VQYXRoOwogfQogCi1zdGF0aWMgdm9p ZCBvcGVuRmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgY29uc3QgU3RyaW5nJiBi YXNlUGF0aCwgY29uc3QgU3RyaW5nJiBpZGVudGlmaWVyLCBBc3luY0ZpbGVTeXN0ZW06OlR5cGUg dHlwZSwgYm9vbCBjcmVhdGUsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBj YWxsYmFja3MpCitzdGF0aWMgdm9pZCBvcGVuRmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250 ZXh0KiBjb250ZXh0LCBjb25zdCBTdHJpbmcmIGJhc2VQYXRoLCBjb25zdCBTdHJpbmcmIGlkZW50 aWZpZXIsIEFzeW5jRmlsZVN5c3RlbTo6VHlwZSB0eXBlLCBsb25nIGxvbmcgc2l6ZSwgYm9vbCBj cmVhdGUsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MpCiB7 Ci0gICAgQXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbShiYXNlUGF0aCwgaWRlbnRpZmll ciwgdHlwZSwgY3JlYXRlLCBjYWxsYmFja3MpOworICAgIEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZp bGVTeXN0ZW0oY29udGV4dCwgYmFzZVBhdGgsIGlkZW50aWZpZXIsIHR5cGUsIHNpemUsIGNyZWF0 ZSwgY2FsbGJhY2tzKTsKIH0KIAogdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJlYWRGaWxlU3lzdGVt KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEFzeW5jRmlsZVN5c3RlbTo6VHlwZSB0 eXBlLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJhY2tzLCBib29s KQogewogICAgIC8vIEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0gY2FsbHMgY2FsbGJh Y2tzIHN5bmNocm9ub3VzbHksIHNvIHRoZSBtZXRob2QgbmVlZHMgdG8gYmUgY2FsbGVkIGFzeW5j aHJvbm91c2x5LgotICAgIGNvbnRleHQtPnBvc3RUYXNrKGNyZWF0ZUNhbGxiYWNrVGFzaygmb3Bl bkZpbGVTeXN0ZW0sIGZpbGVTeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdp bigpLT5kYXRhYmFzZUlkZW50aWZpZXIoKSwgdHlwZSwgZmFsc2UsIGNhbGxiYWNrcykpOworICAg IGNvbnRleHQtPnBvc3RUYXNrKGNyZWF0ZUNhbGxiYWNrVGFzaygmb3BlbkZpbGVTeXN0ZW0sIGZp bGVTeXN0ZW1CYXNlUGF0aCgpLCBjb250ZXh0LT5zZWN1cml0eU9yaWdpbigpLT5kYXRhYmFzZUlk ZW50aWZpZXIoKSwgdHlwZSwgMCwgZmFsc2UsIGNhbGxiYWNrcykpOwogfQogCi12b2lkIExvY2Fs RmlsZVN5c3RlbTo6cmVxdWVzdEZpbGVTeXN0ZW0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29u dGV4dCwgQXN5bmNGaWxlU3lzdGVtOjpUeXBlIHR5cGUsIGxvbmcgbG9uZywgUGFzc093blB0cjxB c3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNhbGxiYWNrcywgYm9vbCkKK3ZvaWQgTG9jYWxGaWxl U3lzdGVtOjpyZXF1ZXN0RmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBBc3luY0ZpbGVTeXN0ZW06OlR5cGUgdHlwZSwgbG9uZyBsb25nIHNpemUsIFBhc3NPd25QdHI8 QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MsIGJvb2wpCiB7CiAgICAgLy8gQXN5 bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbSBjYWxscyBjYWxsYmFja3Mgc3luY2hyb25vdXNs eSwgc28gdGhlIG1ldGhvZCBuZWVkcyB0byBiZSBjYWxsZWQgYXN5bmNocm9ub3VzbHkuCi0gICAg Y29udGV4dC0+cG9zdFRhc2soY3JlYXRlQ2FsbGJhY2tUYXNrKCZvcGVuRmlsZVN5c3RlbSwgZmls ZVN5c3RlbUJhc2VQYXRoKCksIGNvbnRleHQtPnNlY3VyaXR5T3JpZ2luKCktPmRhdGFiYXNlSWRl bnRpZmllcigpLCB0eXBlLCB0cnVlLCBjYWxsYmFja3MpKTsKKyAgICBjb250ZXh0LT5wb3N0VGFz ayhjcmVhdGVDYWxsYmFja1Rhc2soJm9wZW5GaWxlU3lzdGVtLCBmaWxlU3lzdGVtQmFzZVBhdGgo KSwgY29udGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ZGF0YWJhc2VJZGVudGlmaWVyKCksIHR5cGUs IHNpemUsIHRydWUsIGNhbGxiYWNrcykpOwogfQogCiB9IC8vIG5hbWVzcGFjZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQXN5bmNGaWxlU3lzdGVtLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL0FzeW5jRmlsZVN5c3RlbS5jcHAKaW5kZXggODhhZDk4YS4uMGI0ZmZm YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vQXN5bmNGaWxlU3lzdGVtLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Bc3luY0ZpbGVTeXN0ZW0uY3BwCkBAIC0z Nyw2ICszNyw3IEBACiAjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgogI2luY2x1ZGUgIkZpbGVT eXN0ZW0uaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgorI2luY2x1ZGUgIlNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC02Myw3ICs2NCw3 IEBAIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtPiBBc3luY0ZpbGVTeXN0ZW06OmNyZWF0ZShU eXBlKQogICAgIHJldHVybiBudWxscHRyOwogfQogCi12b2lkIEFzeW5jRmlsZVN5c3RlbTo6b3Bl bkZpbGVTeXN0ZW0oY29uc3QgU3RyaW5nJiBiYXNlUGF0aCwgY29uc3QgU3RyaW5nJiBzdG9yYWdl SWRlbnRpZmllciwgVHlwZSB0eXBlLCBib29sLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNh bGxiYWNrcz4gY2FsbGJhY2tzKQordm9pZCBBc3luY0ZpbGVTeXN0ZW06Om9wZW5GaWxlU3lzdGVt KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBjb25zdCBTdHJpbmcmIGJhc2VQYXRoLCBjb25zdCBT dHJpbmcmIHN0b3JhZ2VJZGVudGlmaWVyLCBUeXBlIHR5cGUsIGxvbmcgbG9uZywgYm9vbCwgUGFz c093blB0cjxBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNhbGxiYWNrcykKIHsKICAgICBub3RJ bXBsZW1lbnRlZCgpOwogICAgIGNhbGxiYWNrcy0+ZGlkRmFpbChOT1RfU1VQUE9SVEVEX0VSUik7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Bc3luY0ZpbGVTeXN0ZW0uaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0FzeW5jRmlsZVN5c3RlbS5oCmluZGV4IDc3OTIxMDEu LjIwYTNlNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0FzeW5jRmlsZVN5 c3RlbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0FzeW5jRmlsZVN5c3RlbS5oCkBA IC00Myw2ICs0Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIEFzeW5jRmlsZVN5c3Rl bTsKIGNsYXNzIEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrczsKIGNsYXNzIEFzeW5jRmlsZVdyaXRl ckNsaWVudDsKK2NsYXNzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ7CiAKIC8vIFRoaXMgY2xhc3Mg cHJvdmlkZXMgYXN5bmMgaW50ZXJmYWNlIGZvciBwbGF0Zm9ybS1zcGVjaWZpYyBmaWxlIHN5c3Rl bSBpbXBsZW1lbnRhdGlvbi4gIE5vdGUgdGhhdCBhbGwgdGhlIG1ldGhvZHMgdGFrZSBwbGF0Zm9y bSBwYXRocy4KIGNsYXNzIEFzeW5jRmlsZVN5c3RlbSB7CkBAIC04Miw3ICs4Myw3IEBAIHB1Ymxp YzoKICAgICBzdGF0aWMgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW0+IGNyZWF0ZShUeXBlKTsK IAogICAgIC8vIE9wZW5zIGEgbmV3IGZpbGUgc3lzdGVtLiBUaGUgY3JlYXRlIHBhcmFtZXRlciBz cGVjaWZpZXMgd2hldGhlciBvciBub3QgdG8gY3JlYXRlIHRoZSBwYXRoIGlmIGl0IGRvZXMgbm90 IGFscmVhZHkgZXhpc3RzLgotICAgIHN0YXRpYyB2b2lkIG9wZW5GaWxlU3lzdGVtKGNvbnN0IFN0 cmluZyYgYmFzZVBhdGgsIGNvbnN0IFN0cmluZyYgc3RvcmFnZUlkZW50aWZpZXIsIFR5cGUsIGJv b2wgY3JlYXRlLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4pOworICAgIHN0 YXRpYyB2b2lkIG9wZW5GaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqLCBjb25zdCBT dHJpbmcmIGJhc2VQYXRoLCBjb25zdCBTdHJpbmcmIHN0b3JhZ2VJZGVudGlmaWVyLCBUeXBlLCBs b25nIGxvbmcgc2l6ZSwgYm9vbCBjcmVhdGUsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2Fs bGJhY2tzPik7CiAKICAgICAvLyBNb3ZlcyBhIGZpbGUgb3IgZGlyZWN0b3J5IGZyb20gc3JjUGF0 aCB0byBkZXN0UGF0aC4KICAgICAvLyBBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M6OmRpZFN1Y2Nl ZWQoKSBpcyBjYWxsZWQgd2hlbiB0aGUgb3BlcmF0aW9uIGlzIGNvbXBsZXRlZCBzdWNjZXNzZnVs bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0FzeW5j RmlsZVN5c3RlbUJsYWNrQmVycnkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2ti ZXJyeS9Bc3luY0ZpbGVTeXN0ZW1CbGFja0JlcnJ5LmNwcAppbmRleCA1ZmUyOTdlLi5lNjMxMjAx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0FzeW5jRmls ZVN5c3RlbUJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvQXN5bmNGaWxlU3lzdGVtQmxhY2tCZXJyeS5jcHAKQEAgLTI0LDYgKzI0LDcgQEAKICNp bmNsdWRlICJBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3MuaCIKICNpbmNsdWRlICJFeGNlcHRpb25D b2RlLmgiCiAjaW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlICJTZWN1cml0eU9y aWdpbi5oIgogCiAjaW5jbHVkZSA8d3RmL1VudXNlZFBhcmFtLmg+CiAKQEAgLTQ4LDcgKzQ5LDcg QEAgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW0+IEFzeW5jRmlsZVN5c3RlbTo6Y3JlYXRlKFR5 cGUgdHlwZSkKICAgICByZXR1cm4gYWRvcHRQdHIobmV3IEFzeW5jRmlsZVN5c3RlbUJsYWNrQmVy cnkodHlwZSkpOwogfQogCi12b2lkIEFzeW5jRmlsZVN5c3RlbTo6b3BlbkZpbGVTeXN0ZW0oY29u c3QgU3RyaW5nJiBiYXNlUGF0aCwgY29uc3QgU3RyaW5nJiBzdG9yYWdlSWRlbnRpZmllciwgVHlw ZSB0eXBlLCBib29sLCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJh Y2tzKQordm9pZCBBc3luY0ZpbGVTeXN0ZW06Om9wZW5GaWxlU3lzdGVtKFNlY3VyaXR5T3JpZ2lu KiwgY29uc3QgU3RyaW5nJiBiYXNlUGF0aCwgY29uc3QgU3RyaW5nJiBzdG9yYWdlSWRlbnRpZmll ciwgVHlwZSB0eXBlLCBsb25nIGxvbmcsIGJvb2wsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVt Q2FsbGJhY2tzPiBjYWxsYmFja3MpCiB7CiAgICAgVU5VU0VEX1BBUkFNKGJhc2VQYXRoKTsKICAg ICBVTlVTRURfUEFSQU0oc3RvcmFnZUlkZW50aWZpZXIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL0FzeW5jRmlsZVN5c3RlbUd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvQXN5bmNGaWxlU3lzdGVtR3RrLmNwcAppbmRleCBjMWRiMDA2Li44MTQz YmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQXN5bmNGaWxlU3lz dGVtR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvQXN5bmNGaWxlU3lz dGVtR3RrLmNwcApAQCAtMjYsNiArMjYsNyBAQAogI2luY2x1ZGUgIkFzeW5jRmlsZVN5c3RlbUNh bGxiYWNrcy5oIgogI2luY2x1ZGUgIkV4Y2VwdGlvbkNvZGUuaCIKICNpbmNsdWRlICJOb3RJbXBs ZW1lbnRlZC5oIgorI2luY2x1ZGUgIlNlY3VyaXR5T3JpZ2luLmgiCiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKIApAQCAtNDYsNyArNDcsNyBAQCBQYXNzT3duUHRyPEFzeW5jRmlsZVN5c3RlbT4gQXN5 bmNGaWxlU3lzdGVtOjpjcmVhdGUoVHlwZSB0eXBlKQogICAgIHJldHVybiBhZG9wdFB0cihuZXcg QXN5bmNGaWxlU3lzdGVtR3RrKHR5cGUpKTsKIH0KIAotdm9pZCBBc3luY0ZpbGVTeXN0ZW06Om9w ZW5GaWxlU3lzdGVtKGNvbnN0IFN0cmluZyYgYmFzZVBhdGgsIGNvbnN0IFN0cmluZyYgc3RvcmFn ZUlkZW50aWZpZXIsIFR5cGUgdHlwZSwgYm9vbCwgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW1D YWxsYmFja3M+IGNhbGxiYWNrcykKK3ZvaWQgQXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3Rl bShTZWN1cml0eU9yaWdpbiosIGNvbnN0IFN0cmluZyYgYmFzZVBhdGgsIGNvbnN0IFN0cmluZyYg c3RvcmFnZUlkZW50aWZpZXIsIFR5cGUgdHlwZSwgbG9uZyBsb25nLCBib29sLCBQYXNzT3duUHRy PEFzeW5jRmlsZVN5c3RlbUNhbGxiYWNrcz4gY2FsbGJhY2tzKQogewogICAgIG5vdEltcGxlbWVu dGVkKCk7CiAgICAgY2FsbGJhY2tzLT5kaWRGYWlsKE5PVF9TVVBQT1JURURfRVJSKTsKLS0gCjEu Ny41LjQKCg==