84313 2012-04-18 20:38:26 -0700 [Qt] Fix Qt-Mac build after libxml patch 2012-04-19 06:12:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noam noam hausmann kenneth vestbo webkit.review.bot oldest_to_newest 605340 0 noam 2012-04-18 20:38:26 -0700 [Qt] Fix Qt-Mac build after libxml patch 605341 1 137832 noam 2012-04-18 20:43:23 -0700 Created attachment 137832 Patch 605475 2 137832 hausmann 2012-04-19 03:36:50 -0700 Comment on attachment 137832 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137832&action=review > Source/WebCore/WebCore.pri:118 > + LIBS += -lxml2 -lxslt Shouldn't it be the other way around? pkg-config --libs prints -lxslt -lxml2 for me. 605527 3 137832 webkit.review.bot 2012-04-19 06:11:57 -0700 Comment on attachment 137832 Patch Clearing flags on attachment: 137832 Committed r114627: <http://trac.webkit.org/changeset/114627> 605528 4 webkit.review.bot 2012-04-19 06:12:07 -0700 All reviewed patches have been landed. Closing bug. 137832 2012-04-18 20:43:23 -0700 2012-04-19 06:11:57 -0700 Patch bug-84313-20120418204321.patch text/plain 1375 noam U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZmMTcxZjhjYjFhNWUw MmU1YWVjYzVkZDBlNzVlZGRkZGRkYTA5MS4uNmQ4Y2NjNTAxY2MxMmRjNzNlOWIxNWRkYmZjMTdh YWY2ZmM4MThmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA0LTE4ICBObydh bSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAgICAgW1F0XSBG aXggUXQtTWFjIGJ1aWxkIGFmdGVyIGxpYnhtbCBwYXRjaAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQzMTMKKworICAgICAgICBVc2UgZGlyZWN0IGlu Y2x1ZGUvbGlicmFyeSBwYXRocyBpbnN0ZWFkIG9mIFBLR0NPTkZJRyB3aGVuIG9uIE1hYy4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMsIGJ1aWxkIGZpeC4KKworICAgICAgICAqIFdlYkNvcmUucHJpOgorCiAyMDEyLTA0LTE4ICBW aW5lZXQgQ2hhdWRoYXJ5ICA8cmdmNzQ4QG1vdG9yb2xhLmNvbT4KIAogICAgICAgICBBZGQgUGFz c1RoaXM9KiB0byBzdXBwb3J0IHRoZSBjYWxsYmFja3Mgd2hpY2ggcmVxdWlyZXMgdG8gcGFzcyAi dGhpcyIgdmFsdWUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLnByaSBiL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCmluZGV4IGNkYWViNzMyNzg0N2Y5MjMzN2QzODJlMmUy ZTIxYzg1MjVlMTkwMzkuLmViYTI2ZGQxY2E3YzZiYjM4ZWFhMjgzMzgzMmE4ZjkxNWFmZGZmNjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpCisrKyBiL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmUucHJpCkBAIC0xMTMsNyArMTEzLDEyIEBAIElOQ0xVREVQQVRIICs9ICQkV0VC Q09SRV9HRU5FUkFURURfU09VUkNFU19ESVIKIAogY29udGFpbnMoREVGSU5FUywgRU5BQkxFX1hT TFQ9MSkgewogICAgIGNvbnRhaW5zKERFRklORVMsIFdURl9VU0VfTElCWE1MMj0xKSB7Ci0gICAg ICAgIFBLR0NPTkZJRyArPSBsaWJ4c2x0CisgICAgICAgIG1hYyB7CisgICAgICAgICAgICBJTkNM VURFUEFUSCArPSAvdXNyL2luY2x1ZGUvbGlieG1sMgorICAgICAgICAgICAgTElCUyArPSAtbHht bDIgLWx4c2x0CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBQS0dDT05GSUcgKz0gbGli eHNsdAorICAgICAgICB9CiAgICAgfSBlbHNlIHsKICAgICAgICAgUVQgKj0geG1scGF0dGVybnMK ICAgICB9Cg==