84292 2012-04-18 15:48:08 -0700 KeywordLookupGenerator.py should take an output file as an argument 2012-04-19 15:45:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 don.olmstead don.olmstead eric msaboff oliver webkit.review.bot oldest_to_newest 605173 0 don.olmstead 2012-04-18 15:48:08 -0700 Currently KeywordLookupGenerator.py writes to stdout only. The results are expected to be piped to a separate file when creating KeywordLookup.h. To make the script more friendly to GYP it should take an additional argument which specifies a file to write to. 605865 1 137970 don.olmstead 2012-04-19 14:06:38 -0700 Created attachment 137970 Patch 605877 2 137970 eric 2012-04-19 14:16:11 -0700 Comment on attachment 137970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:32 > +if (len(sys.argv) > 2): We should do the argument parsing separately, instead of re-using the args array in two places here. Otherwise seems OK. A hack, but OK. 605902 3 137970 eric 2012-04-19 14:26:48 -0700 Comment on attachment 137970 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137970&action=review > Source/JavaScriptCore/KeywordLookupGenerator.py:33 > + file_output = open(sys.argv[-1], "w") So I would use output_file_name = sys.argv[2] if len(sys.argsv) > 2 And then check "if output_file_name:" 605933 4 137977 don.olmstead 2012-04-19 14:42:46 -0700 Created attachment 137977 Patch 606027 5 137977 webkit.review.bot 2012-04-19 15:44:56 -0700 Comment on attachment 137977 Patch Clearing flags on attachment: 137977 Committed r114684: <http://trac.webkit.org/changeset/114684> 606028 6 webkit.review.bot 2012-04-19 15:45:01 -0700 All reviewed patches have been landed. Closing bug. 137970 2012-04-19 14:06:38 -0700 2012-04-19 14:42:42 -0700 Patch bug-84292-20120419140638.patch text/plain 2012 don.olmstead U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZDMxOGZjNGQwOWE0ZjE3NjU1MTMwMTg4MmY2YjRlNjdkY2NhYjJiLi5kODI0ZjU1ZWFiZDkyNTQ3 YTQyNzZjZGYyZWQ3M2FjYjgwNjVjMzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0wNC0xOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNv bnkuY29tPgorCisgICAgICAgIEtleXdvcmRMb29rdXBHZW5lcmF0b3IucHkgc2hvdWxkIHRha2Ug YW4gb3V0cHV0IGZpbGUgYXMgYW4gYXJndW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRXh0ZW5kZWQgS2V5d29yZExvb2t1cEdlbmVyYXRvciB0byBh Y2NlcHQgYW4gYWRkaXRpb25hbCBhcmd1bWVudCBzcGVjaWZ5aW5nIGFuIG91dHB1dCBmaWxlLiBJ ZiB0aGlzIGFyZ3VtZW50IGlzIGZvdW5kIHN0ZG91dCBpcyByZWRpcmVjdGVkIHRvIGEgZmlsZSBm b3IgdGhlIGR1cmF0aW9uIG9mIHRoZSBzY3JpcHQuCisKKyAgICAgICAgKiBLZXl3b3JkTG9va3Vw R2VuZXJhdG9yLnB5OgorCiAyMDEyLTA0LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgTExJbnQgbm8tSklUIGZhbGxiYWNrIG5hdGl2ZSBjYWxsIHRyYW1wb2xp bmUncyBleGNlcHRpb24gaGFuZGxlciBpbmNvcnJlY3RseSBhc3N1bWVzIHRoYXQKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5IGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkKaW5kZXggMjlmNTBk ZmUwNzQ5MzM4OTJmZjIwZGJjOTZmNDk2ZjBlMWE1MWNiMy4uODFmZmU0OWIxYzc0MzE0MGMzYmFi ZTgzNGFiNWQyYjA0MDFmMTNmNCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0tl eXdvcmRMb29rdXBHZW5lcmF0b3IucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0tleXdv cmRMb29rdXBHZW5lcmF0b3IucHkKQEAgLTEsNCArMSw1IEBACiAjIENvcHlyaWdodCAoQykgMjAx MSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxMiBT b255IE5ldHdvcmsgRW50ZXJ0YWlubWVudC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjcsNiArMjgsMTEgQEAgaW1wb3J0IG9wZXJhdG9yCiAK IGtleXdvcmRzVGV4dCA9IG9wZW4oc3lzLmFyZ3ZbMV0pLnJlYWQoKQogCisjIFJlZGlyZWN0IG91 dHB1dCB0byBhIGZpbGUgaWYgcmVxdWVzdGVkCitpZiAobGVuKHN5cy5hcmd2KSA+IDIpOgorICAg IGZpbGVfb3V0cHV0ID0gb3BlbihzeXMuYXJndlstMV0sICJ3IikKKyAgICBzeXMuc3Rkb3V0ID0g ZmlsZV9vdXRwdXQKKwogIyBPYnNlcnZlZCB3ZWlnaHRzIG9mIHRoZSBtb3N0IGNvbW1vbiBrZXl3 b3Jkcywgcm91bmRlZCB0byAyLnMuZAoga2V5V29yZFdlaWdodHMgPSB7CiAgICAgImNhdGNoIjog MC4wMSwKQEAgLTI4OCwzICsyOTQsOCBAQCBwcmludCgiIiIKICIiIikKIAogdHJpZS5wcmludEFz QygpCisKKyMgQ2xvc2UgdGhlIHJlZGlyZWN0ZWQgZmlsZSBpZiByZXF1ZXN0ZWQKK2lmIChsZW4o c3lzLmFyZ3YpID4gMik6CisgICAgZmlsZV9vdXRwdXQuY2xvc2UoKQorICAgIHN5cy5zdGRvdXQg PSBzeXMuX19zdGRvdXRfXwo= 137977 2012-04-19 14:42:46 -0700 2012-04-19 15:44:56 -0700 Patch bug-84292-20120419144246.patch text/plain 2138 don.olmstead U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NjY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ZDMxOGZjNGQwOWE0ZjE3NjU1MTMwMTg4MmY2YjRlNjdkY2NhYjJiLi5kODI0ZjU1ZWFiZDkyNTQ3 YTQyNzZjZGYyZWQ3M2FjYjgwNjVjMzY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxMi0wNC0xOSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQGFtLnNv bnkuY29tPgorCisgICAgICAgIEtleXdvcmRMb29rdXBHZW5lcmF0b3IucHkgc2hvdWxkIHRha2Ug YW4gb3V0cHV0IGZpbGUgYXMgYW4gYXJndW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRXh0ZW5kZWQgS2V5d29yZExvb2t1cEdlbmVyYXRvciB0byBh Y2NlcHQgYW4gYWRkaXRpb25hbCBhcmd1bWVudCBzcGVjaWZ5aW5nIGFuIG91dHB1dCBmaWxlLiBJ ZiB0aGlzIGFyZ3VtZW50IGlzIGZvdW5kIHN0ZG91dCBpcyByZWRpcmVjdGVkIHRvIGEgZmlsZSBm b3IgdGhlIGR1cmF0aW9uIG9mIHRoZSBzY3JpcHQuCisKKyAgICAgICAgKiBLZXl3b3JkTG9va3Vw R2VuZXJhdG9yLnB5OgorCiAyMDEyLTA0LTE5ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgTExJbnQgbm8tSklUIGZhbGxiYWNrIG5hdGl2ZSBjYWxsIHRyYW1wb2xp bmUncyBleGNlcHRpb24gaGFuZGxlciBpbmNvcnJlY3RseSBhc3N1bWVzIHRoYXQKZGlmZiAtLWdp dCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9LZXl3b3JkTG9va3VwR2VuZXJhdG9yLnB5IGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL0tleXdvcmRMb29rdXBHZW5lcmF0b3IucHkKaW5kZXggMjlmNTBk ZmUwNzQ5MzM4OTJmZjIwZGJjOTZmNDk2ZjBlMWE1MWNiMy4uNzQ4YWNmOWRjMTRiYWViM2I4NDIw M2U0NjU5MjAxMmJjMGQ2ZjliMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0tl eXdvcmRMb29rdXBHZW5lcmF0b3IucHkKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0tleXdv cmRMb29rdXBHZW5lcmF0b3IucHkKQEAgLTEsNCArMSw1IEBACiAjIENvcHlyaWdodCAoQykgMjAx MSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoQykgMjAxMiBT b255IE5ldHdvcmsgRW50ZXJ0YWlubWVudC4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVk aXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3 aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm b2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtMjcsNiArMjgsMTUgQEAgaW1wb3J0IG9wZXJhdG9yCiAK IGtleXdvcmRzVGV4dCA9IG9wZW4oc3lzLmFyZ3ZbMV0pLnJlYWQoKQogCisjIEEgc2Vjb25kIGFy Z3VtZW50IHNpZ25pZmllcyB0aGF0IHRoZSBvdXRwdXQKKyMgc2hvdWxkIGJlIHJlZGlyZWN0ZWQg dG8gYSBmaWxlCityZWRpcmVjdF90b19maWxlID0gbGVuKHN5cy5hcmd2KSA+IDIKKworIyBDaGFu Z2Ugc3Rkb3V0IHRvIHBvaW50IHRvIHRoZSBmaWxlIGlmIHJlcXVlc3RlZAoraWYgcmVkaXJlY3Rf dG9fZmlsZToKKyAgICBmaWxlX291dHB1dCA9IG9wZW4oc3lzLmFyZ3ZbLTFdLCAidyIpCisgICAg c3lzLnN0ZG91dCA9IGZpbGVfb3V0cHV0CisKICMgT2JzZXJ2ZWQgd2VpZ2h0cyBvZiB0aGUgbW9z dCBjb21tb24ga2V5d29yZHMsIHJvdW5kZWQgdG8gMi5zLmQKIGtleVdvcmRXZWlnaHRzID0gewog ICAgICJjYXRjaCI6IDAuMDEsCkBAIC0yODgsMyArMjk4LDggQEAgcHJpbnQoIiIiCiAiIiIpCiAK IHRyaWUucHJpbnRBc0MoKQorCisjIENsb3NlIHRoZSByZWRpcmVjdGVkIGZpbGUgaWYgcmVxdWVz dGVkCitpZiAocmVkaXJlY3RfdG9fZmlsZSk6CisgICAgZmlsZV9vdXRwdXQuY2xvc2UoKQorICAg IHN5cy5zdGRvdXQgPSBzeXMuX19zdGRvdXRfXwo=