84288 2012-04-18 15:04:13 -0700 Remove unnecessary rounding/conversions in RenderBoxModelObject 2012-04-18 22:40:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 eae eae eric jchaffraix leviw simon.fraser webkit.review.bot oldest_to_newest 605138 0 eae 2012-04-18 15:04:13 -0700 Since box shadow data is now using ints we no longer need a bunch of conversions. 605141 1 137780 eae 2012-04-18 15:08:19 -0700 Created attachment 137780 Patch 605373 2 137780 eric 2012-04-18 22:23:59 -0700 Comment on attachment 137780 Patch OK. 605380 3 137780 webkit.review.bot 2012-04-18 22:40:25 -0700 Comment on attachment 137780 Patch Clearing flags on attachment: 137780 Committed r114609: <http://trac.webkit.org/changeset/114609> 605381 4 webkit.review.bot 2012-04-18 22:40:29 -0700 All reviewed patches have been landed. Closing bug. 137780 2012-04-18 15:08:19 -0700 2012-04-18 22:40:25 -0700 Patch bug-84288-20120418150818.patch text/plain 2424 eae SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDU2NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTE4ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkg cm91bmRpbmcvY29udmVyc2lvbnMgaW4gUmVuZGVyQm94TW9kZWxPYmplY3QKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0Mjg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBjaGFu Z2UgaW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3hNb2Rl bE9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFp bnRCb3hTaGFkb3cpOgorICAgICAgICBSZW1vdmUgdW5uZWNlc3NhcnkgcGl4ZWxTbmFwcGluZyBs b2dpYyBhbmQgY2FzdHMgaW4gcGFpbnRCb3hTaGFkb3cgYXMKKyAgICAgICAgc2hhZG93IHJlY3Rz IGFyZSBub3cgaW50IGJhc2VkLgorCiAyMDEyLTA0LTE4ICBMdWtlIE1hY3BoZXJzb24gIDxtYWNw aGVyc29uQGNocm9taXVtLm9yZz4KIAogICAgICAgICBQcmV2ZW50IHBvdGVudGlhbCBudWxsIHBv aW50ZXIgZGVyZWZlcmVuY2UgaW4gQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eSgpLgpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmpl Y3QuY3BwCShyZXZpc2lvbiAxMTQ1NTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyQm94TW9kZWxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yODkyLDcgKzI4OTIsNyBA QCB2b2lkIFJlbmRlckJveE1vZGVsT2JqZWN0OjpwYWludEJveFNoYWRvCiAgICAgICAgICAgICAg ICAgaWYgKCFyZWN0VG9DbGlwT3V0LmlzRW1wdHkoKSkKICAgICAgICAgICAgICAgICAgICAgY29u dGV4dC0+Y2xpcE91dFJvdW5kZWRSZWN0KHJlY3RUb0NsaXBPdXQpOwogCi0gICAgICAgICAgICAg ICAgUm91bmRlZFJlY3QgaW5mbHVlbmNlUmVjdChwaXhlbFNuYXBwZWRJbnRSZWN0KHNoYWRvd1Jl Y3QpLCBib3JkZXIucmFkaWkoKSk7CisgICAgICAgICAgICAgICAgUm91bmRlZFJlY3QgaW5mbHVl bmNlUmVjdChzaGFkb3dSZWN0LCBib3JkZXIucmFkaWkoKSk7CiAgICAgICAgICAgICAgICAgaW5m bHVlbmNlUmVjdC5leHBhbmRSYWRpaSgyICogc2hhZG93Qmx1ciArIHNoYWRvd1NwcmVhZCk7CiAg ICAgICAgICAgICAgICAgaWYgKGFsbENvcm5lcnNDbGlwcGVkT3V0KGluZmx1ZW5jZVJlY3QsIGlu Zm8ucmVjdCkpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRleHQtPmZpbGxSZWN0KGZpbGxSZWN0 LnJlY3QoKSwgQ29sb3I6OmJsYWNrLCBzLT5jb2xvclNwYWNlKCkpOwpAQCAtMjk0Myw5ICsyOTQz LDkgQEAgdm9pZCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6cGFpbnRCb3hTaGFkbwogICAgICAgICAg ICAgfQogICAgICAgICAgICAgaWYgKCFpbmNsdWRlTG9naWNhbFJpZ2h0RWRnZSkgewogICAgICAg ICAgICAgICAgIGlmIChpc0hvcml6b250YWwpCi0gICAgICAgICAgICAgICAgICAgIGhvbGVSZWN0 LnNldFdpZHRoKGhvbGVSZWN0LndpZHRoKCkgLSBtaW48TGF5b3V0VW5pdD4oc2hhZG93T2Zmc2V0 LndpZHRoKCksIDApICsgc2hhZG93Qmx1cik7CisgICAgICAgICAgICAgICAgICAgIGhvbGVSZWN0 LnNldFdpZHRoKGhvbGVSZWN0LndpZHRoKCkgLSBtaW4oc2hhZG93T2Zmc2V0LndpZHRoKCksIDAp ICsgc2hhZG93Qmx1cik7CiAgICAgICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgICAg ICBob2xlUmVjdC5zZXRIZWlnaHQoaG9sZVJlY3QuaGVpZ2h0KCkgLSBtaW48TGF5b3V0VW5pdD4o c2hhZG93T2Zmc2V0LmhlaWdodCgpLCAwKSArIHNoYWRvd0JsdXIpOworICAgICAgICAgICAgICAg ICAgICBob2xlUmVjdC5zZXRIZWlnaHQoaG9sZVJlY3QuaGVpZ2h0KCkgLSBtaW4oc2hhZG93T2Zm c2V0LmhlaWdodCgpLCAwKSArIHNoYWRvd0JsdXIpOwogICAgICAgICAgICAgfQogCiAgICAgICAg ICAgICBDb2xvciBmaWxsQ29sb3Ioc2hhZG93Q29sb3IucmVkKCksIHNoYWRvd0NvbG9yLmdyZWVu KCksIHNoYWRvd0NvbG9yLmJsdWUoKSwgMjU1KTsK