84272 2012-04-18 13:18:57 -0700 JSVALUE32_64 should be able to perform division on ARM without crashing, and variables forced double should not be scrambled when performing OSR entry 2013-07-25 03:57:40 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned oldest_to_newest 605032 0 fpizlo 2012-04-18 13:18:57 -0700 Patch forthcoming. 605034 1 137754 fpizlo 2012-04-18 13:23:46 -0700 Created attachment 137754 the patch 605037 2 137754 ggaren 2012-04-18 13:26:39 -0700 Comment on attachment 137754 the patch r=me 605165 3 fpizlo 2012-04-18 15:33:33 -0700 Landed in http://trac.webkit.org/changeset/114570 911561 4 207446 chenzx 2013-07-25 03:57:40 -0700 Created attachment 207446 A testcase file which is related to this patch I have been recently investigate a calculating error problem in Sunspider math-cordic.js case, Which occurs in 2012/3's webkit, but fixed in 2013/4's webkit (qtwebkit-2.3.1), after a dozen of Git "bisect" compile, and finally I could locate to this patch, 137754 2012-04-18 13:23:46 -0700 2012-04-18 13:26:39 -0700 the patch fixdouble_patch_1.diff text/plain 2651 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0NTUwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDEyLTA0LTE4ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SlNWQUxVRTMyXzY0IHNob3VsZCBiZSBhYmxlIHRvIHBlcmZvcm0gZGl2aXNpb24gb24gQVJNIHdp dGhvdXQgY3Jhc2hpbmcsIGFuZCB2YXJpYWJsZXMKKyAgICAgICAgZm9yY2VkIGRvdWJsZSBzaG91 bGQgbm90IGJlIHNjcmFtYmxlZCB3aGVuIHBlcmZvcm1pbmcgT1NSIGVudHJ5CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDI3MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0ZpeHVwUGhhc2Uu Y3BwOgorICAgICAgICAoSlNDOjpERkc6OkZpeHVwUGhhc2U6OmZpeHVwTm9kZSk6CisgICAgICAg ICogZGZnL0RGR09TUkVudHJ5LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpwcmVwYXJlT1NSRW50 cnkpOgorCiAyMDEyLTA0LTE4ICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29t PgogCiAgICAgICAgIFJlbW92ZSBtX3N1YmNsYXNzRGF0YSBmcm9tIEpTQXJyYXksIG1vdmUgdGhl IGF0dHJpYnV0ZSB0byBzdWJjbGFzcyBhcyBuZWVkZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkocmV2aXNpb24gMTE0NDU5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjUwLDcgKzI1MCw2IEBAIHByaXZhdGU6CiAgICAgICAgIGNhc2UgQXJpdGhNaW46CiAgICAgICAg IGNhc2UgQXJpdGhNYXg6CiAgICAgICAgIGNhc2UgQXJpdGhNdWw6Ci0gICAgICAgIGNhc2UgQXJp dGhEaXY6CiAgICAgICAgIGNhc2UgQXJpdGhNb2Q6IHsKICAgICAgICAgICAgIGlmIChOb2RlOjpz aG91bGRTcGVjdWxhdGVJbnRlZ2VyKG1fZ3JhcGhbbm9kZS5jaGlsZDEoKV0sIG1fZ3JhcGhbbm9k ZS5jaGlsZDIoKV0pCiAgICAgICAgICAgICAgICAgJiYgbm9kZS5jYW5TcGVjdWxhdGVJbnRlZ2Vy KCkpCkBAIC0yNjAsNiArMjU5LDE2IEBAIHByaXZhdGU6CiAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgfQogICAgICAgICAgICAgCisgICAgICAgIGNhc2UgQXJpdGhEaXY6IHsKKyAgICAgICAg ICAgIGlmIChpc1g4NigpCisgICAgICAgICAgICAgICAgJiYgTm9kZTo6c2hvdWxkU3BlY3VsYXRl SW50ZWdlcihtX2dyYXBoW25vZGUuY2hpbGQxKCldLCBtX2dyYXBoW25vZGUuY2hpbGQyKCldKQor ICAgICAgICAgICAgICAgICYmIG5vZGUuY2FuU3BlY3VsYXRlSW50ZWdlcigpKQorICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgZml4RG91YmxlRWRnZSgwKTsKKyAgICAgICAgICAg IGZpeERvdWJsZUVkZ2UoMSk7CisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgfQorICAgICAg ICAgICAgCiAgICAgICAgIGNhc2UgQXJpdGhBYnM6IHsKICAgICAgICAgICAgIGlmIChtX2dyYXBo W25vZGUuY2hpbGQxKCldLnNob3VsZFNwZWN1bGF0ZUludGVnZXIoKQogICAgICAgICAgICAgICAg ICYmIG5vZGUuY2FuU3BlY3VsYXRlSW50ZWdlcigpKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdPU1JFbnRyeS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdPU1JFbnRyeS5jcHAJKHJldmlzaW9uIDExNDQ1OSkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHT1NSRW50cnkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsMTMg KzE0MSwxMSBAQCB2b2lkKiBwcmVwYXJlT1NSRW50cnkoRXhlY1N0YXRlKiBleGVjLCBDCiAgICAg ZGF0YUxvZygiICAgIE9TUiBzaG91bGQgc3VjY2VlZC5cbiIpOwogI2VuZGlmCiAgICAgCi0jaWYg VVNFKEpTVkFMVUU2NCkKICAgICAvLyAzKSBQZXJmb3JtIGRhdGEgZm9ybWF0IGNvbnZlcnNpb25z LgogICAgIGZvciAoc2l6ZV90IGxvY2FsID0gMDsgbG9jYWwgPCBlbnRyeS0+bV9leHBlY3RlZFZh bHVlcy5udW1iZXJPZkxvY2FscygpOyArK2xvY2FsKSB7CiAgICAgICAgIGlmIChlbnRyeS0+bV9s b2NhbHNGb3JjZWREb3VibGUuZ2V0KGxvY2FsKSkKICAgICAgICAgICAgICpiaXR3aXNlX2Nhc3Q8 ZG91YmxlKj4oZXhlYy0+cmVnaXN0ZXJzKCkgKyBsb2NhbCkgPSBleGVjLT5yZWdpc3RlcnMoKVts b2NhbF0uanNWYWx1ZSgpLmFzTnVtYmVyKCk7CiAgICAgfQotI2VuZGlmCiAgICAgCiAgICAgLy8g NCkgRml4IHRoZSBjYWxsIGZyYW1lLgogICAgIAo= 207446 2013-07-25 03:57:40 -0700 2013-07-25 03:57:40 -0700 A testcase file which is related to this patch sunspider-math-cordic-test.html text/html 3861 chenzx PGJvZHk+DQo8cHJlIGlkPSJpbmZvIj4NCjwvcHJlPg0KPHNjcmlwdD4NCi8vLy8vLiBTdGFydCBD T1JESUMNCnZhciBBR19DT05TVCA9IDAuNjA3MjUyOTM1MDsNCg0KZnVuY3Rpb24gRklYRUQoWCkN CnsNCiAgcmV0dXJuIFggKiA2NTUzNi4wOw0KfQ0KDQpmdW5jdGlvbiBGTE9BVChYKQ0Kew0KICBy ZXR1cm4gWCAvIDY1NTM2LjA7DQp9DQoNCmZ1bmN0aW9uIERFRzJSQUQoWCkNCnsNCiAgcmV0dXJu IDAuMDE3NDUzICogKFgpOw0KfQ0KDQp2YXIgQW5nbGVzID0gWw0KICBGSVhFRCg0NS4wKSwgRklY RUQoMjYuNTY1KSwgRklYRUQoMTQuMDM2MiksIEZJWEVEKDcuMTI1MDIpLA0KICBGSVhFRCgzLjU3 NjMzKSwgRklYRUQoMS43ODk5MSksIEZJWEVEKDAuODk1MTc0KSwgRklYRUQoMC40NDc2MTQpLA0K ICBGSVhFRCgwLjIyMzgxMSksIEZJWEVEKDAuMTExOTA2KSwgRklYRUQoMC4wNTU5NTMpLA0KICBG SVhFRCgwLjAyNzk3NykgDQogICAgICAgICAgICAgIF07DQoNCnZhciBUYXJnZXQgPSAyOC4wMjc7 DQoNCi8vdmFyIGVycm9yX3NuYXBzaG90ID0gbnVsbDsNCg0KZnVuY3Rpb24gY29yZGljc2luY29z KFRhcmdldCkgew0KICAgIHZhciBYOw0KICAgIHZhciBZOw0KICAgIHZhciBUYXJnZXRBbmdsZTsN CiAgICB2YXIgQ3VyckFuZ2xlOw0KICAgIHZhciBTdGVwOw0KIA0KICAgIFggPSBGSVhFRChBR19D T05TVCk7ICAgICAgICAgLyogQUdfQ09OU1QgKiBjb3MoMCkgKi8NCiAgICBZID0gMDsgICAgICAg ICAgICAgICAgICAgICAgIC8qIEFHX0NPTlNUICogc2luKDApICovDQoNCiAgICBUYXJnZXRBbmds ZSA9IEZJWEVEKFRhcmdldCk7DQogICAgQ3VyckFuZ2xlID0gMDsNCiAgICBmb3IgKFN0ZXAgPSAw OyBTdGVwIDwgMTI7IFN0ZXArKykgew0KICAgICAgICB2YXIgTmV3WDsNCiAgICAgICAgaWYgKFRh cmdldEFuZ2xlID4gQ3VyckFuZ2xlKSB7DQogICAgICAgICAgICBOZXdYID0gWCAtIChZID4+IFN0 ZXApOw0KICAgICAgICAgICAgWSA9IChYID4+IFN0ZXApICsgWTsNCiAgICAgICAgICAgIFggPSBO ZXdYOw0KICAgICAgICAgICAgQ3VyckFuZ2xlICs9IEFuZ2xlc1tTdGVwXTsNCiAgICAgICAgfSBl bHNlIHsNCiAgICAgICAgICAgIE5ld1ggPSBYICsgKFkgPj4gU3RlcCk7DQogICAgICAgICAgICBZ ID0gLShYID4+IFN0ZXApICsgWTsNCiAgICAgICAgICAgIFggPSBOZXdYOw0KICAgICAgICAgICAg Q3VyckFuZ2xlIC09IEFuZ2xlc1tTdGVwXTsNCiAgICAgICAgfQ0KICAgIH0NCg0KICAgIHZhciBS RVNVTFQgPSBGTE9BVChYKSAqIEZMT0FUKFkpOw0KICAgIGNvbnNvbGUuYXNzZXJ0KCBSRVNVTFQ9 PTAuNDE0NTAyODE4NzUwMDE3OSApOw0KICAgIC8qDQogICAgaWYoIFJFU1VMVCA9PSAwLjE2ODY3 Nzg5NjUwNzQ5MDg4IHx8IFJFU1VMVCA9PSAtMC4xNjg1NDM5NTI2NjYxMjI5ICApew0KICAgICAg ICAvL2xvZygiWD0iK1grIiwgWT0iK1krIiwgVGFyZ2V0QW5nbGU9IitUYXJnZXRBbmdsZSsiLCBD dXJyQW5nbGU9IitDdXJyQW5nbGUrIiwgU3RlcD0iK1N0ZXApOw0KICAgICAgICAvL2Vycm9yX3Nu YXBzaG90ID0geyJYIjpYLCAiWSI6WSwgIlRhcmdldEFuZ2xlIjpUYXJnZXRBbmdsZSwgIkN1cnJB bmdsZSI6Q3VyckFuZ2xlLCAiU3RlcCI6U3RlcH07DQogICAgICAgIHRocm93ICJFcnJvciEhIGNv cmRpY3NpbmNvcyBnb3QgaW52YWxpZCByZXN1bHQiOw0KICAgIH0vLyovDQogICAgcmV0dXJuIFJF U1VMVDsNCn0NCg0KLy8vLy8gRW5kIENPUkRJQw0KZnVuY3Rpb24gbG9nKHN0cil7DQogICAgaWYo Y29uc29sZSAmJiBjb25zb2xlLmxvZyApDQogICAgICAgIGNvbnNvbGUubG9nKHN0cik7DQogICAg ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImluZm8iKS5hcHBlbmRDaGlsZCggZG9jdW1lbnQuY3Jl YXRlVGV4dE5vZGUoc3RyKSApOw0KfQ0KDQpmdW5jdGlvbiBjb3JkaWMoIHJ1bnMgKSB7DQogIC8v dmFyIFMgPSBbXTsNCiAgdmFyIHRvdGFsID0gMDsNCiAgZm9yICggdmFyIGkgPSAwIDsgaSA8IHJ1 bnMgOyBpKysgKSB7DQogICAgICB2YXIgdGhpc1ZhbHVlID0gY29yZGljc2luY29zKFRhcmdldCk7 DQogICAgICAvL1MucHVzaCgiY29yZGljc2luY29zKCIrVGFyZ2V0KyIpPSIrdGhpc1ZhbHVlKTsN CiAgICAgIHRvdGFsICs9IHRoaXNWYWx1ZTsNCiAgfQ0KICAvL2xvZyhTLmpvaW4oIlxyXG4iKSk7 DQogIHJldHVybiB0b3RhbDsNCn0NCg0KdmFyIGV4cGVjdGVkID0gMTAzNjIuNTcwNDY4NzU1ODg4 Ow0KICB2YXIgdG90YWwgPSBjb3JkaWMoMjUwMDApOw0KICBpZiggdG90YWwgIT0gZXhwZWN0ZWQp DQogICAgbG9nKCJFUlJPUjogYmFkIHJlc3VsdDogZXhwZWN0ZWQ9IiArIGV4cGVjdGVkICsgIiBi dXQgZ290IGNvcmRpYygyNTAwMCk9IiArIHRvdGFsICk7DQogIGVsc2UNCiAgICBsb2coIlNVQ0NF U1M6IGV4cGVjdGVkPSIgKyBleHBlY3RlZCArICIgZXF1YWxzIGNvcmRpYygyNTAwMCk9IiArIHRv dGFsICk7DQoNCi8qDQp0cnl7DQogIHZhciBleHBlY3RlZCA9IDEwMzYyLjU3MDQ2ODc1NTg4ODsN CiAgdmFyIHRvdGFsID0gY29yZGljKDI1MDAwKTsNCiAgaWYoIHRvdGFsICE9IGV4cGVjdGVkKQ0K ICAgIGxvZygiRVJST1I6IGJhZCByZXN1bHQ6IGV4cGVjdGVkPSIgKyBleHBlY3RlZCArICIgYnV0 IGdvdCBjb3JkaWMoMjUwMDApPSIgKyB0b3RhbCApOw0KfWNhdGNoKGUpew0KICBpZihlcnJvcl9z bmFwc2hvdCE9bnVsbCl7DQogICAgbG9nKCJYPSIrZXJyb3Jfc25hcHNob3QuWCsiLCBZPSIrZXJy b3Jfc25hcHNob3QuWSsiLCBUYXJnZXRBbmdsZT0iK2Vycm9yX3NuYXBzaG90LlRhcmdldEFuZ2xl KyIsIEN1cnJBbmdsZT0iK2Vycm9yX3NuYXBzaG90LkN1cnJBbmdsZSsiLCBTdGVwPSIrZXJyb3Jf c25hcHNob3QuU3RlcCk7DQogIH0NCn0NCiovDQoNCi8qDQpmdW5jdGlvbiBjb3JkaWMyKCBydW5z ICkgew0KICB2YXIgdG90YWwgPSAwOw0KICBmb3IgKCB2YXIgaSA9IDAgOyBpIDwgcnVucyA7IGkr KyApIHsNCiAgICAgIHZhciB0aGlzVmFsdWUgPSAwLjQxNDUwMjgxODc1MDAxNzk7Ly9jb3JkaWNz aW5jb3MoVGFyZ2V0KTsNCiAgICAgIHRvdGFsICs9IHRoaXNWYWx1ZTsNCiAgfQ0KICByZXR1cm4g dG90YWw7DQp9DQp2YXIgZXhwZWN0ZWQyID0gMTAzNjIuNTcwNDY4NzU1ODg4Ow0KdmFyIHRvdGFs MiA9IGNvcmRpYzIoMjUwMDApOw0KaWYoIHRvdGFsMiAhPSBleHBlY3RlZDIpDQogICAgbG9nKCJF UlJPUjI6IGJhZCByZXN1bHQ6IGV4cGVjdGVkPSIgKyBleHBlY3RlZCArICIgYnV0IGdvdCBjb3Jk aWMoMjUwMDApPSIgKyB0b3RhbCApOw0KKi8NCg0KLyoNCnZhciBKcyA9IFsxLCAxMCwgMTAwLCAx MDAwLCA1MDAwLCAyNTAwMF07DQp2YXIgaj0wOw0KdmFyIEggPSBzZXRUaW1lb3V0KGZ1bmN0aW9u ICgpew0KICAvL2Zvcig7IGo8SnMubGVuZ3RoOyBqKyspew0KICAgIHZhciBKID0gSnNbal07DQog ICAgdmFyIHRvdGFsID0gY29yZGljKDI1MDAwL0opOw0KICAgIGxvZygiaj0iK2orIiwgY29yZGlj KCIrMjUwMDAvSisiKT0iK3RvdGFsKyIsIGV4cGVjdGVkLyIrSisiPSIrZXhwZWN0ZWQvSik7DQog ICAgaWYoIHRvdGFsICE9IGV4cGVjdGVkL0opDQogICAgICAgIGxvZygiRVJST1I6IGJhZCByZXN1 bHQ6IGV4cGVjdGVkLyIrSisiPSIgKyBleHBlY3RlZC9KICsgIiBidXQgZ290IGNvcmRpYygyNTAw MC8iK0orIik9IiArIHRvdGFsICk7DQogICAgaWYoIGo+PUpzLmxlbmd0aC0xICl7DQogICAgICAg IGNsZWFyVGltZW91dChIKTsNCiAgICAgICAgcmV0dXJuOw0KICAgIH1lbHNlew0KICAgICAgICAr K2o7DQogICAgICAgIEggPSBzZXRUaW1lb3V0KGFyZ3VtZW50cy5jYWxsZWUsIDEpOw0KICAgIH0N CiAgLy99DQp9LCAxKTsNCiovDQo8L3NjcmlwdD4NCjwvYm9keT4NCg0K