84260 2012-04-18 11:32:06 -0700 REGRESSION(102040): Auto-table layout with percent width doesn't shrink-to-fit content a cell with colspan 2012-04-18 16:08:17 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jchaffraix jchaffraix ojan webkit.review.bot oldest_to_newest 604931 0 jchaffraix 2012-04-18 11:32:06 -0700 This is an unexpected change of bug 34758. Bug 34758 made us abide by percent width when there are only percent columns on a colspan. The bug is simple and stems from the fact that we are setting the min / max effective column width but forget to update the cell's min / max (remaining) logical width like the rest of the code. Patch and test case to follow shortly. 604965 1 137735 jchaffraix 2012-04-18 11:56:00 -0700 Created attachment 137735 Propsed patch 1: Account for allocated min / max cell's logical width. 605193 2 137735 webkit.review.bot 2012-04-18 16:08:11 -0700 Comment on attachment 137735 Propsed patch 1: Account for allocated min / max cell's logical width. Clearing flags on attachment: 137735 Committed r114574: <http://trac.webkit.org/changeset/114574> 605194 3 webkit.review.bot 2012-04-18 16:08:17 -0700 All reviewed patches have been landed. Closing bug. 137735 2012-04-18 11:56:00 -0700 2012-04-18 16:08:11 -0700 Propsed patch 1: Account for allocated min / max cell's logical width. bug-84260-20120418115558.patch text/plain 6276 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDBiYzlhZDY2ZDI5ODQ3 ZjczNDQwOWQwNjQ1MWYyODdhNzVkOTEyOC4uYzNlMzRjOGNkY2ZlMGI2NzM2NjAyMTlmODA0ZDFm M2U3ODY2ODM5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTE4ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJ T04oMTAyMDQwKTogQXV0by10YWJsZSBsYXlvdXQgd2l0aCBwZXJjZW50IHdpZHRoIGRvZXNuJ3Qg c2hyaW5rLXRvLWZpdCBjb250ZW50IGEgY2VsbCB3aXRoIGNvbHNwYW4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjYwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHM6IGZhc3QvdGFibGUvdGQtd2lk dGgtZmlmdHktcGVyY2VudC1yZWdyZXNzaW9uLWV4cGVjdGVkLmh0bWwKKyAgICAgICAgICAgICAg IGZhc3QvdGFibGUvdGQtd2lkdGgtZmlmdHktcGVyY2VudC1yZWdyZXNzaW9uLmh0bWwKKworICAg ICAgICAqIHJlbmRlcmluZy9BdXRvVGFibGVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXV0b1RhYmxlTGF5b3V0OjpjYWxjRWZmZWN0aXZlTG9naWNhbFdpZHRoKToKKyAgICAgICAgQXMg d2UgYXJlIHNwcmVhZGluZyB0aGUgY2VsbCdzIG1pbiAvIG1heCBsb2dpY2FsIHdpZHRoLCB3ZSBz aG91bGQgYmUgdXBkYXRpbmcgdGhlbS4KKyAgICAgICAgVGhpcyBwcmV2ZW50cyB0aGUgZm9sbG93 aW5nIGxvZ2ljIGdldHRpbmcgY29uZnVzZWQgYW5kIGFsbG9jYXRpbmcgbW9yZSB0aGFuIG5lZWRl ZC4KKwogMjAxMi0wNC0xOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBEYXRhR3JpZCBzaG91bGQgdXNlIGV4cGxpY2l0IHJv b3Qgbm9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0F1dG9UYWJsZUxh eW91dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNwcApp bmRleCA3MmM3ODBjODZkNTY0NTUyZWFkMjY0NjViMDEzMWVlMDg4MjhlZjgzLi43NDRhMTJiOTFh M2JiOTIzYTRjNGVkMTllMzc1YzU4ZjNkNTJhMzk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvQXV0b1RhYmxlTGF5b3V0LmNwcApAQCAtNDAyLDEzICs0MDIsMjMgQEAgaW50IEF1dG9U YWJsZUxheW91dDo6Y2FsY0VmZmVjdGl2ZUxvZ2ljYWxXaWR0aCgpCiAgICAgICAgICAgICAgICAg fQogICAgICAgICAgICAgfSBlbHNlIGlmIChhbGxDb2xzQXJlUGVyY2VudCkgewogICAgICAgICAg ICAgICAgIC8vIEluIHRoaXMgY2FzZSwgd2UganVzdCBzcGxpdCB0aGUgY29sc3BhbidzIG1pbiBh bWQgbWF4IHdpZHRocyBmb2xsb3dpbmcgdGhlIHBlcmNlbnRhZ2UuCisgICAgICAgICAgICAgICAg aW50IGFsbG9jYXRlZE1pbkxvZ2ljYWxXaWR0aCA9IDA7CisgICAgICAgICAgICAgICAgZmxvYXQg YWxsb2NhdGVkTWF4TG9naWNhbFdpZHRoID0gMDsKICAgICAgICAgICAgICAgICBmb3IgKHVuc2ln bmVkIHBvcyA9IGVmZkNvbDsgcG9zIDwgbGFzdENvbDsgKytwb3MpIHsKICAgICAgICAgICAgICAg ICAgICAgQVNTRVJUKG1fbGF5b3V0U3RydWN0W3Bvc10ubG9naWNhbFdpZHRoLmlzUGVyY2VudCgp IHx8IG1fbGF5b3V0U3RydWN0W3Bvc10uZWZmZWN0aXZlTG9naWNhbFdpZHRoLmlzUGVyY2VudCgp KTsKICAgICAgICAgICAgICAgICAgICAgLy8gfGFsbENvbHNBcmVQZXJjZW50fCBtZWFucyB0aGF0 IGVpdGhlciB0aGUgbG9naWNhbFdpZHRoICpvciogdGhlIGVmZmVjdGl2ZUxvZ2ljYWxXaWR0aCBh cmUgcGVyY2VudHMsIGhhbmRsZSBib3RoIG9mIHRoZW0gaGVyZS4KICAgICAgICAgICAgICAgICAg ICAgZmxvYXQgcGVyY2VudCA9IG1fbGF5b3V0U3RydWN0W3Bvc10ubG9naWNhbFdpZHRoLmlzUGVy Y2VudCgpID8gbV9sYXlvdXRTdHJ1Y3RbcG9zXS5sb2dpY2FsV2lkdGgucGVyY2VudCgpIDogbV9s YXlvdXRTdHJ1Y3RbcG9zXS5lZmZlY3RpdmVMb2dpY2FsV2lkdGgucGVyY2VudCgpOwotICAgICAg ICAgICAgICAgICAgICBtX2xheW91dFN0cnVjdFtwb3NdLmVmZmVjdGl2ZU1pbkxvZ2ljYWxXaWR0 aCA9IG1heChtX2xheW91dFN0cnVjdFtwb3NdLmVmZmVjdGl2ZU1pbkxvZ2ljYWxXaWR0aCwgc3Rh dGljX2Nhc3Q8aW50PihwZXJjZW50ICogY2VsbE1pbkxvZ2ljYWxXaWR0aCAvIHRvdGFsUGVyY2Vu dCkpOwotICAgICAgICAgICAgICAgICAgICBtX2xheW91dFN0cnVjdFtwb3NdLmVmZmVjdGl2ZU1h eExvZ2ljYWxXaWR0aCA9IHBlcmNlbnQgKiBjZWxsTWF4TG9naWNhbFdpZHRoIC8gdG90YWxQZXJj ZW50OworICAgICAgICAgICAgICAgICAgICBpbnQgY29sdW1uTWluTG9naWNhbFdpZHRoID0gc3Rh dGljX2Nhc3Q8aW50PihwZXJjZW50ICogY2VsbE1pbkxvZ2ljYWxXaWR0aCAvIHRvdGFsUGVyY2Vu dCk7CisgICAgICAgICAgICAgICAgICAgIGZsb2F0IGNvbHVtbk1heExvZ2ljYWxXaWR0aCA9IHBl cmNlbnQgKiBjZWxsTWF4TG9naWNhbFdpZHRoIC8gdG90YWxQZXJjZW50OworICAgICAgICAgICAg ICAgICAgICBtX2xheW91dFN0cnVjdFtwb3NdLmVmZmVjdGl2ZU1pbkxvZ2ljYWxXaWR0aCA9IG1h eChtX2xheW91dFN0cnVjdFtwb3NdLmVmZmVjdGl2ZU1pbkxvZ2ljYWxXaWR0aCwgY29sdW1uTWlu TG9naWNhbFdpZHRoKTsKKyAgICAgICAgICAgICAgICAgICAgbV9sYXlvdXRTdHJ1Y3RbcG9zXS5l ZmZlY3RpdmVNYXhMb2dpY2FsV2lkdGggPSBjb2x1bW5NYXhMb2dpY2FsV2lkdGg7CisgICAgICAg ICAgICAgICAgICAgIGFsbG9jYXRlZE1pbkxvZ2ljYWxXaWR0aCArPSBjb2x1bW5NaW5Mb2dpY2Fs V2lkdGg7CisgICAgICAgICAgICAgICAgICAgIGFsbG9jYXRlZE1heExvZ2ljYWxXaWR0aCArPSBj b2x1bW5NYXhMb2dpY2FsV2lkdGg7CiAgICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAg IEFTU0VSVChhbGxvY2F0ZWRNaW5Mb2dpY2FsV2lkdGggPD0gY2VsbE1pbkxvZ2ljYWxXaWR0aCk7 CisgICAgICAgICAgICAgICAgQVNTRVJUKGFsbG9jYXRlZE1heExvZ2ljYWxXaWR0aCA8PSBjZWxs TWF4TG9naWNhbFdpZHRoKTsKKyAgICAgICAgICAgICAgICBjZWxsTWluTG9naWNhbFdpZHRoIC09 IGFsbG9jYXRlZE1pbkxvZ2ljYWxXaWR0aDsKKyAgICAgICAgICAgICAgICBjZWxsTWF4TG9naWNh bFdpZHRoIC09IGFsbG9jYXRlZE1heExvZ2ljYWxXaWR0aDsKICAgICAgICAgICAgIH0gZWxzZSB7 CiAgICAgICAgICAgICAgICAgZmxvYXQgcmVtYWluaW5nTWF4TG9naWNhbFdpZHRoID0gc3Bhbk1h eExvZ2ljYWxXaWR0aDsKICAgICAgICAgICAgICAgICBpbnQgcmVtYWluaW5nTWluTG9naWNhbFdp ZHRoID0gc3Bhbk1pbkxvZ2ljYWxXaWR0aDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwMjBjOTA0Y2RmMmM2MjAwZTI0MzNl Njc3YmVlNDZjZGQ0NTI2MWM0Li41ZTkzNGI4MmRjZjcwZWU1NGIyYzRiMjUxYzk2NGY4ODhjZDA1 NjVmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMTggIEp1bGllbiBDaGFmZnJhaXgg IDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTigxMDIwNDApOiBB dXRvLXRhYmxlIGxheW91dCB3aXRoIHBlcmNlbnQgd2lkdGggZG9lc24ndCBzaHJpbmstdG8tZml0 IGNvbnRlbnQgYSBjZWxsIHdpdGggY29sc3BhbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGZhc3QvdGFibGUvdGQtd2lkdGgtZmlmdHktcGVyY2VudC1y ZWdyZXNzaW9uLWV4cGVjdGVkLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGFibGUvdGQt d2lkdGgtZmlmdHktcGVyY2VudC1yZWdyZXNzaW9uLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA0LTE4 ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IERhdGFHcmlkIHNob3VsZCB1c2UgZXhwbGljaXQgcm9vdCBub2RlCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL3RkLXdpZHRoLWZpZnR5LXBlcmNlbnQtcmVncmVz c2lvbi1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS90ZC13aWR0aC1maWZ0 eS1wZXJjZW50LXJlZ3Jlc3Npb24tZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQpp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41MDI3YjFlMjVk NmUyNWIwZDNkMzJjZjM0MTA2N2NiZDZkYzdkMTNhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC90YWJsZS90ZC13aWR0aC1maWZ0eS1wZXJjZW50LXJlZ3Jlc3Npb24tZXhwZWN0 ZWQuaHRtbApAQCAtMCwwICsxLDIzIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+ Cis8c3R5bGU+CisgICAgdGFibGUKKyAgICB7CisgICAgICAgIGJvcmRlcjpzb2xpZCBibGFjayAx cHg7CisgICAgfQorPC9zdHlsZT4gCis8L2hlYWQ+Cis8Ym9keT4KKzxwPlRlc3QgZm9yIGJ1ZyA8 YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyNjAiPjg0 MjYwPC9hPjogUkVHUkVTU0lPTigxMDIwNDApOiBBdXRvLXRhYmxlIGxheW91dCB3aXRoIHBlcmNl bnQgd2lkdGggZG9lc24ndCBzaHJpbmstdG8tZml0IGNvbnRlbnQgYSBjZWxsIHdpdGggY29sc3Bh bjwvcD4KKzxwPkZvciB0aGlzIHRlc3QgdG8gcGFzcywgdGhlIHRhYmxlIGJlbG93IHNob3VsZCBm aXQgaXRzIGNvbnRlbnQuPC9wPgorPHRhYmxlPgorICAgIDx0cj4KKyAgICAgICAgPHRkPjwvdGQ+ PHRkPjwvdGQ+CisgICAgPC90cj4KKyAgICA8dHI+CisgICAgICAgIDx0ZCBjb2xzcGFuPSIyIj5M b3JlbTwvdGQ+CisgICAgPC90cj4KKzwvdGFibGU+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RhYmxlL3RkLXdpZHRoLWZpZnR5LXBlcmNlbnQtcmVncmVz c2lvbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS90ZC13aWR0aC1maWZ0eS1wZXJjZW50 LXJlZ3Jlc3Npb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zNmMyMDBkMGEzYzBiNTIzNWRiNTAxZDcxYjQ5 YTJhMWViNTFkNGRlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90YWJsZS90 ZC13aWR0aC1maWZ0eS1wZXJjZW50LXJlZ3Jlc3Npb24uaHRtbApAQCAtMCwwICsxLDI3IEBACis8 IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c3R5bGU+CisgICAgdGFibGUKKyAgICB7 CisgICAgICAgIGJvcmRlcjpzb2xpZCBibGFjayAxcHg7CisgICAgfQorICAgIHRkLmZpZnR5UGVy Y2VudAorICAgIHsKKyAgICAgICAgd2lkdGg6IDUwJTsKKyAgICB9Cis8L3N0eWxlPiAKKzwvaGVh ZD4KKzxib2R5PgorPHA+VGVzdCBmb3IgYnVnIDxhIGhyZWY9Imh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NDI2MCI+ODQyNjA8L2E+OiBSRUdSRVNTSU9OKDEwMjA0MCk6 IEF1dG8tdGFibGUgbGF5b3V0IHdpdGggcGVyY2VudCB3aWR0aCBkb2Vzbid0IHNocmluay10by1m aXQgY29udGVudCBhIGNlbGwgd2l0aCBjb2xzcGFuPC9wPgorPHA+Rm9yIHRoaXMgdGVzdCB0byBw YXNzLCB0aGUgdGFibGUgYmVsb3cgc2hvdWxkIGZpdCBpdHMgY29udGVudC48L3A+Cis8dGFibGU+ CisgICAgPHRyPgorICAgICAgICA8dGQgY2xhc3M9ImZpZnR5UGVyY2VudCI+PC90ZD48dGQgY2xh c3M9ImZpZnR5UGVyY2VudCI+PC90ZD4KKyAgICA8L3RyPgorICAgIDx0cj4KKyAgICAgICAgPHRk IGNvbHNwYW49IjIiPkxvcmVtPC90ZD4KKyAgICA8L3RyPgorPC90YWJsZT4KKzwvYm9keT4KKzwv aHRtbD4K