84249 2012-04-18 09:37:55 -0700 Remove m_subclassData from JSArray, move the attribute to subclass as needed 2012-04-18 11:37:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin ggaren mhahnenberg oliver oldest_to_newest 604825 0 benjamin 2012-04-18 09:37:55 -0700 Allocating useless 64bits per JSArray is unfortunately not free. 604834 1 137713 benjamin 2012-04-18 09:47:18 -0700 Created attachment 137713 Patch 604859 2 137713 ggaren 2012-04-18 10:27:04 -0700 Comment on attachment 137713 Patch r=me 604940 3 benjamin 2012-04-18 11:37:12 -0700 Committed r114539: <http://trac.webkit.org/changeset/114539> 137713 2012-04-18 09:47:18 -0700 2012-04-18 10:27:04 -0700 Patch bug-84249-20120418094717.patch text/plain 6486 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZDUwMGM1ODVkYTg0OWVkNzkzNWJhNTQ1MmRlNjkwMzEwYzYzYjcxLi4yOWQwZGUxY2Q5NmY0NjBj OTFmZDIyOTlhNzBhMjk2YjRlYTdmMjhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAxMi0wNC0xOCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmUgbV9zdWJjbGFzc0RhdGEgZnJvbSBKU0FycmF5LCBtb3Zl IHRoZSBhdHRyaWJ1dGUgdG8gc3ViY2xhc3MgYXMgbmVlZGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDI0OQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEpTQXJyYXkncyBtX3N1YmNsYXNzRGF0YSBpcyBv bmx5IHVzZWQgYnkgV2ViQ29yZSdzIFJ1bnRpbWVBcnJheS4gVGhpcyBwYXRjaCBtb3ZlcworICAg ICAgICB0aGUgYXR0cmlidXRlIHRvIFJ1bnRpbWVBcnJheSB0byBhdm9pZCBhbGxvY2F0aW5nIG1l bW9yeSBmb3IgdGhlIHBvaW50ZXIgaW4gdGhlIGNvbW1vbgorICAgICAgICBjYXNlLgorCisgICAg ICAgIFRoaXMgZ2l2ZXMgfjElIGltcHJvdmVtZW50IGluIEpTQXJyYXkgY3JlYXRpb24gbWljcm9i ZW5jaG1hcmsgdGhhbmtzIHRvIGZld2VyIGFsbG9jYXRpb25zCisgICAgICAgIG9mIENvcGllZFNw YWNlLgorCisgICAgICAgICogaml0L0pJVElubGluZU1ldGhvZHMuaDoKKyAgICAgICAgKEpTQzo6 SklUOjplbWl0QWxsb2NhdGVKU0FycmF5KToKKyAgICAgICAgKiBydW50aW1lL0pTQXJyYXkuY3Bw OgorICAgICAgICAoSlNDOjpKU0FycmF5OjpKU0FycmF5KToKKyAgICAgICAgKiBydW50aW1lL0pT QXJyYXkuaDoKKwogMjAxMi0wNC0xNyAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgog CiAgICAgICAgIERGRyBzaG91bGQgbm90IGF0dGVtcHQgdG8gZ2V0IHJhcmUgY2FzZSBjb3VudHMg Zm9yIG9wX21vZCBvbiBBUk0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MGJjOWFkNjZkMjk4NDdmNzM0NDA5ZDA2 NDUxZjI4N2E3NWQ5MTI4Li4zNDAxOWViMTViMmZjMWNjYzYwYzcwZDEzMDZjM2JmODk3YWM3MDQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDQtMTggIEJlbmphbWluIFBvdWxh aW4gIDxicG91bGFpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIG1fc3ViY2xhc3NEYXRh IGZyb20gSlNBcnJheSwgbW92ZSB0aGUgYXR0cmlidXRlIHRvIHN1YmNsYXNzIGFzIG5lZWRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyNDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJyaWRnZS9y dW50aW1lX2FycmF5LmNwcDoKKyAgICAgICAgKEpTQzo6UnVudGltZUFycmF5OjpSdW50aW1lQXJy YXkpOgorICAgICAgICAoSlNDOjpSdW50aW1lQXJyYXk6OmZpbmlzaENyZWF0aW9uKToKKyAgICAg ICAgKiBicmlkZ2UvcnVudGltZV9hcnJheS5oOgorICAgICAgICAoSlNDOjpSdW50aW1lQXJyYXk6 OmdldExlbmd0aCk6CisgICAgICAgIChKU0M6OlJ1bnRpbWVBcnJheTo6Z2V0Q29uY3JldGVBcnJh eSk6CisgICAgICAgIChSdW50aW1lQXJyYXkpOgorCiAyMDEyLTA0LTE4ICBZdXJ5IFNlbWlraGF0 c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERhdGFH cmlkIHNob3VsZCB1c2UgZXhwbGljaXQgcm9vdCBub2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvaml0L0pJVElubGluZU1ldGhvZHMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9qaXQvSklUSW5saW5lTWV0aG9kcy5oCmluZGV4IDk5OGQ1YWMxODc5ODY4ZmZmYmFjMGZmMDhk YWQ3ZDNiNDc0Njk3ZWEuLmYyZDBjZWYxOTNkNjQ4NDFiZjA0NmQ1M2YyZWViYjNjNGJjOWE1ODkg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lTWV0aG9kcy5o CisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUSW5saW5lTWV0aG9kcy5oCkBAIC01 MDMsOCArNTAzLDcgQEAgaW5saW5lIHZvaWQgSklUOjplbWl0QWxsb2NhdGVKU0FycmF5KHVuc2ln bmVkIHZhbHVlc1JlZ2lzdGVyLCB1bnNpZ25lZCBsZW5ndGgsIFIKICAgICBzdG9yZTMyKEltbTMy KGluaXRpYWxMZW5ndGgpLCBBZGRyZXNzKGNlbGxSZXN1bHQsIEpTQXJyYXk6OnZlY3Rvckxlbmd0 aE9mZnNldCgpKSk7CiAgICAgc3RvcmUzMihUcnVzdGVkSW1tMzIoMCksIEFkZHJlc3MoY2VsbFJl c3VsdCwgSlNBcnJheTo6aW5kZXhCaWFzT2Zmc2V0KCkpKTsKIAotICAgIC8vIEluaXRpYWxpemUg dGhlIHN1YmNsYXNzIGRhdGEgYW5kIHRoZSBzcGFyc2UgdmFsdWUgbWFwLgotICAgIHN0b3JlUHRy KFRydXN0ZWRJbW1QdHIoMCksIEFkZHJlc3MoY2VsbFJlc3VsdCwgSlNBcnJheTo6c3ViY2xhc3NE YXRhT2Zmc2V0KCkpKTsKKyAgICAvLyBJbml0aWFsaXplIHRoZSBzcGFyc2UgdmFsdWUgbWFwLgog ICAgIHN0b3JlUHRyKFRydXN0ZWRJbW1QdHIoMCksIEFkZHJlc3MoY2VsbFJlc3VsdCwgSlNBcnJh eTo6c3BhcnNlVmFsdWVNYXBPZmZzZXQoKSkpOwogCiAgICAgICAgIC8vIFN0b3JlIHRoZSB2YWx1 ZXMgd2UgaGF2ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT QXJyYXkuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAKaW5k ZXggYjc0MWQ3M2RhZGE4NmI0YjI4NjAzYjNlMDI1YjE5MWRiMDJkY2ZkZC4uMmE5MTljMzQ2Mzdj NDFlYmY3NDI0MzE3MTY3ZjgyYWFhODljMzVmNiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNBcnJheS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNBcnJheS5jcHAKQEAgLTEzMCw3ICsxMzAsNiBAQCBKU0FycmF5OjpKU0FycmF5KEpT R2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUpCiAgICAgLCBtX2lu ZGV4QmlhcygwKQogICAgICwgbV9zdG9yYWdlKDApCiAgICAgLCBtX3NwYXJzZVZhbHVlTWFwKDAp Ci0gICAgLCBtX3N1YmNsYXNzRGF0YSgwKQogewogfQogCkBAIC0xODEwLDE2ICsxODA5LDYgQEAg dW5zaWduZWQgSlNBcnJheTo6Y29tcGFjdEZvclNvcnRpbmcoSlNHbG9iYWxEYXRhJiBnbG9iYWxE YXRhKQogICAgIHJldHVybiBudW1EZWZpbmVkOwogfQogCi12b2lkKiBKU0FycmF5OjpzdWJjbGFz c0RhdGEoKSBjb25zdAotewotICAgIHJldHVybiBtX3N1YmNsYXNzRGF0YTsKLX0KLQotdm9pZCBK U0FycmF5OjpzZXRTdWJjbGFzc0RhdGEodm9pZCogZCkKLXsKLSAgICBtX3N1YmNsYXNzRGF0YSA9 IGQ7Ci19Ci0KICNpZiBDSEVDS19BUlJBWV9DT05TSVNURU5DWQogCiB2b2lkIEpTQXJyYXk6OmNo ZWNrQ29uc2lzdGVuY3koQ29uc2lzdGVuY3lDaGVja1R5cGUgdHlwZSkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTQXJyYXkuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTQXJyYXkuaAppbmRleCA5OGVlMzJlMzExY2NmNzY0ZTAwMGFlOTVmNjEw NGNkMTlmMjM1NzYyLi43OTEyNTM3YmIzZTcxYjI0NTFmOGU1NmNlMGNkNTA5MGNhMGYyYTA5IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0FycmF5LmgKKysrIGIv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNBcnJheS5oCkBAIC0zMTcsMTAgKzMxNyw4 IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAgIC8vIEZJWE1FOiBNYXliZSBTcGFyc2VBcnJh eVZhbHVlTWFwIHNob3VsZCBiZSBwdXQgaW50byBpdHMgb3duIEpTQ2VsbD8KICAgICAgICAgU3Bh cnNlQXJyYXlWYWx1ZU1hcCogbV9zcGFyc2VWYWx1ZU1hcDsKLSAgICAgICAgdm9pZCogbV9zdWJj bGFzc0RhdGE7IC8vIEEgSlNBcnJheSBzdWJjbGFzcyBjYW4gdXNlIHRoaXMgdG8gZmlsbCB0aGUg dmVjdG9yIGxhemlseS4KIAogICAgICAgICBzdGF0aWMgcHRyZGlmZl90IHNwYXJzZVZhbHVlTWFw T2Zmc2V0KCkgeyByZXR1cm4gT0JKRUNUX09GRlNFVE9GKEpTQXJyYXksIG1fc3BhcnNlVmFsdWVN YXApOyB9Ci0gICAgICAgIHN0YXRpYyBwdHJkaWZmX3Qgc3ViY2xhc3NEYXRhT2Zmc2V0KCkgeyBy ZXR1cm4gT0JKRUNUX09GRlNFVE9GKEpTQXJyYXksIG1fc3ViY2xhc3NEYXRhKTsgfQogICAgICAg ICBzdGF0aWMgcHRyZGlmZl90IGluZGV4Qmlhc09mZnNldCgpIHsgcmV0dXJuIE9CSkVDVF9PRkZT RVRPRihKU0FycmF5LCBtX2luZGV4Qmlhcyk7IH0KICAgICB9OwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9icmlkZ2UvcnVudGltZV9hcnJheS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9icmlk Z2UvcnVudGltZV9hcnJheS5jcHAKaW5kZXggYzE1YzdjYjM5YmE0Nzk1ODEwZWQyNTBlMzM1OWJl YTVlNmUyMmE0Ny4uZjBjNTA4MGY5YzM4NDEyMWE4NjA0NzM5Y2IyMGRiNjkyYWRjOTNhZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYnJpZGdlL3J1bnRpbWVfYXJyYXkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JyaWRnZS9ydW50aW1lX2FycmF5LmNwcApAQCAtMzksNiArMzksNyBAQCBj b25zdCBDbGFzc0luZm8gUnVudGltZUFycmF5OjpzX2luZm8gPSB7ICJSdW50aW1lQXJyYXkiLCAm SlNBcnJheTo6c19pbmZvLCAwLCAwLAogCiBSdW50aW1lQXJyYXk6OlJ1bnRpbWVBcnJheShFeGVj U3RhdGUqIGV4ZWMsIFN0cnVjdHVyZSogc3RydWN0dXJlKQogICAgIDogSlNBcnJheShleGVjLT5n bG9iYWxEYXRhKCksIHN0cnVjdHVyZSkKKyAgICAsIG1fYXJyYXkoMCkKIHsKIH0KIApAQCAtNDYs NyArNDcsNyBAQCB2b2lkIFJ1bnRpbWVBcnJheTo6ZmluaXNoQ3JlYXRpb24oSlNHbG9iYWxEYXRh JiBnbG9iYWxEYXRhLCBCaW5kaW5nczo6QXJyYXkqIGFycgogewogICAgIEJhc2U6OmZpbmlzaENy ZWF0aW9uKGdsb2JhbERhdGEpOwogICAgIEFTU0VSVChpbmhlcml0cygmc19pbmZvKSk7Ci0gICAg c2V0U3ViY2xhc3NEYXRhKGFycmF5KTsKKyAgICBtX2FycmF5ID0gYXJyYXk7CiB9CiAKIFJ1bnRp bWVBcnJheTo6flJ1bnRpbWVBcnJheSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9icmlk Z2UvcnVudGltZV9hcnJheS5oIGIvU291cmNlL1dlYkNvcmUvYnJpZGdlL3J1bnRpbWVfYXJyYXku aAppbmRleCBjN2JlZTUyODJkZjg1ZmRiOTk4MzEzYjM4Y2QxMmFkNDEyOGRjMjYyLi4yZWE1MmI2 OGEyYmUzYzQyOWUyM2ZmNGJkZDdkYWI0ZDZiM2I0ODhlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9icmlkZ2UvcnVudGltZV9hcnJheS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JyaWRnZS9y dW50aW1lX2FycmF5LmgKQEAgLTYwLDkgKzYwLDkgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29s IGRlbGV0ZVByb3BlcnR5KEpTQ2VsbCosIEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXIgJnBy b3BlcnR5TmFtZSk7CiAgICAgc3RhdGljIGJvb2wgZGVsZXRlUHJvcGVydHlCeUluZGV4KEpTQ2Vs bCosIEV4ZWNTdGF0ZSosIHVuc2lnbmVkIHByb3BlcnR5TmFtZSk7CiAgICAgCi0gICAgdW5zaWdu ZWQgZ2V0TGVuZ3RoKCkgY29uc3QgeyByZXR1cm4gZ2V0Q29uY3JldGVBcnJheSgpLT5nZXRMZW5n dGgoKTsgfQorICAgIHVuc2lnbmVkIGdldExlbmd0aCgpIGNvbnN0IHsgcmV0dXJuIG1fYXJyYXkt PmdldExlbmd0aCgpOyB9CiAgICAgCi0gICAgQmluZGluZ3M6OkFycmF5KiBnZXRDb25jcmV0ZUFy cmF5KCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8QmluZGluZ3NBcnJheSo+KHN1YmNsYXNz RGF0YSgpKTsgfQorICAgIEJpbmRpbmdzOjpBcnJheSogZ2V0Q29uY3JldGVBcnJheSgpIGNvbnN0 IHsgcmV0dXJuIG1fYXJyYXk7IH0KIAogICAgIHN0YXRpYyBjb25zdCBDbGFzc0luZm8gc19pbmZv OwogCkBAIC04NSw2ICs4NSw4IEBAIHByaXZhdGU6CiAgICAgUnVudGltZUFycmF5KEV4ZWNTdGF0 ZSosIFN0cnVjdHVyZSopOwogICAgIHN0YXRpYyBKU1ZhbHVlIGxlbmd0aEdldHRlcihFeGVjU3Rh dGUqLCBKU1ZhbHVlLCBjb25zdCBJZGVudGlmaWVyJik7CiAgICAgc3RhdGljIEpTVmFsdWUgaW5k ZXhHZXR0ZXIoRXhlY1N0YXRlKiwgSlNWYWx1ZSwgdW5zaWduZWQpOworCisgICAgQmluZGluZ3NB cnJheSogbV9hcnJheTsKIH07CiAgICAgCiB9IC8vIG5hbWVzcGFjZSBKU0MK