84237 2012-04-18 06:01:14 -0700 [Qt] WheelEventQt.cpp should be deleted 2012-04-18 12:20:16 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 allan.jensen allan.jensen webkit.review.bot oldest_to_newest 604698 0 allan.jensen 2012-04-18 06:01:14 -0700 The file is not compiled in any cases I can see and it duplicates functionality handled in WebEventFactoryQt.cpp [WK2] and WebEventConversion.cpp [WK1] 604702 1 137678 allan.jensen 2012-04-18 06:04:11 -0700 Created attachment 137678 Patch 604941 2 137678 hausmann 2012-04-18 11:37:25 -0700 Comment on attachment 137678 Patch Thanks, I had totally forgotten about this one. Indeed, the intent was to remove it after the move to WebKit. 604982 3 137678 webkit.review.bot 2012-04-18 12:20:12 -0700 Comment on attachment 137678 Patch Clearing flags on attachment: 137678 Committed r114544: <http://trac.webkit.org/changeset/114544> 604983 4 webkit.review.bot 2012-04-18 12:20:16 -0700 All reviewed patches have been landed. Closing bug. 137678 2012-04-18 06:04:11 -0700 2012-04-18 12:20:11 -0700 Patch bug-84237-20120418150419.patch text/plain 4302 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I2MmUzNjcxZGE1NGZi MGQ0MGMzZmMwYzQ1NzNjYzVhMGVjZTEyZC4uYjk5MDdlYzcwNWY2OGVlZWRiODRhODEyMDBmMzU2 MzM3NmE2NDg1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA0LTE4ICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF0gV2hlZWxFdmVudFF0LmNwcCBzaG91bGQgYmUgZGVsZXRlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjM3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9XaGVlbEV2ZW50UXQu Y3BwOiBSZW1vdmVkLgorCiAyMDEyLTA0LTE3ICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxhbGxh bi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIEFzc2VydHMgaW4gWE1MSHR0cFJlcXVlc3RQ cm9ncmVzc0V2ZW50VGhyb3R0bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L1doZWVsRXZlbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9XaGVlbEV2 ZW50UXQuY3BwCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAzYmQwZGEzY2E3Y2U4OTQz YTgzN2I5ZjdiZDc1OTRhMTVjNjAyMmFkLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1doZWVsRXZlbnRRdC5j cHAKKysrIC9kZXYvbnVsbApAQCAtMSw5MyArMCwwIEBACi0vKgotICAgIENvcHlyaWdodCAoQykg MjAwOCBOb2tpYSBDb3Jwb3JhdGlvbiBhbmQvb3IgaXRzIHN1YnNpZGlhcnkoLWllcykKLQotICAg IFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBh bmQvb3IKLSAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBHTlUgTGlicmFyeSBH ZW5lcmFsIFB1YmxpYwotICAgIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3 YXJlIEZvdW5kYXRpb247IGVpdGhlcgotICAgIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3Ig KGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KLQotICAgIFRoaXMgbGlicmFyeSBp cyBkaXN0cmlidXRlZCBpbiB0aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAotICAgIGJ1 dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5 IG9mCi0gICAgTUVSQ0hBTlRBQklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQ T1NFLiAgU2VlIHRoZSBHTlUKLSAgICBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgZm9y IG1vcmUgZGV0YWlscy4KLQotICAgIFlvdSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2Yg dGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljIExpY2Vuc2UKLSAgICBhbG9uZyB3aXRoIHRo aXMgbGlicmFyeTsgc2VlIHRoZSBmaWxlIENPUFlJTkcuTElCLiAgSWYgbm90LCB3cml0ZSB0bwot ICAgIHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVl dCwgRmlmdGggRmxvb3IsCi0gICAgQm9zdG9uLCBNQSAwMjExMC0xMzAxLCBVU0EuCi0qLwotCi0j aW5jbHVkZSAiY29uZmlnLmgiCi0jaW5jbHVkZSAiV2hlZWxFdmVudC5oIgotCi0jaW5jbHVkZSAi UGxhdGZvcm1Nb3VzZUV2ZW50LmgiCi0jaW5jbHVkZSAiUGxhdGZvcm1XaGVlbEV2ZW50LmgiCi0j aW5jbHVkZSAiU2Nyb2xsYmFyLmgiCi0KLSNpbmNsdWRlIDxRR3JhcGhpY3NTY2VuZVdoZWVsRXZl bnQ+Ci0jaW5jbHVkZSA8UVdoZWVsRXZlbnQ+Ci0jaW5jbHVkZSA8cWFwcGxpY2F0aW9uLmg+Ci0j aW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+Ci0KLW5hbWVzcGFjZSBXZWJDb3JlIHsKLQotdm9p ZCBQbGF0Zm9ybVdoZWVsRXZlbnQ6OmFwcGx5RGVsdGEoaW50IGRlbHRhLCBRdDo6T3JpZW50YXRp b24gb3JpZW50YXRpb24pCi17Ci0gICAgLy8gQSBkZWx0YSB0aGF0IGlzIG5vdCBtb2QgMTIwIGlu ZGljYXRlcyBhIGRldmljZSB0aGF0IGlzIHNlbmRpbmcKLSAgICAvLyBmaW5lLXJlc29sdXRpb24g c2Nyb2xsIGV2ZW50cywgc28gdXNlIHRoZSBkZWx0YSBhcyBudW1iZXIgb2Ygd2hlZWwgdGlja3MK LSAgICAvLyBhbmQgbnVtYmVyIG9mIHBpeGVscyB0byBzY3JvbGwuU2VlIGFsc28gd2Via2l0Lm9y Zy9iLzI5NjAxCi0gICAgYm9vbCBmdWxsVGljayA9ICEoZGVsdGEgJSAxMjApOwotCi0gICAgaWYg KG9yaWVudGF0aW9uID09IFF0OjpIb3Jpem9udGFsKSB7Ci0gICAgICAgIG1fZGVsdGFYID0gKGZ1 bGxUaWNrKSA/IGRlbHRhIC8gMTIwLjBmIDogZGVsdGE7Ci0gICAgICAgIG1fZGVsdGFZID0gMDsK LSAgICB9IGVsc2UgewotICAgICAgICBtX2RlbHRhWCA9IDA7Ci0gICAgICAgIG1fZGVsdGFZID0g KGZ1bGxUaWNrKSA/IGRlbHRhIC8gMTIwLjBmIDogZGVsdGE7Ci0gICAgfQotCi0gICAgbV93aGVl bFRpY2tzWCA9IG1fZGVsdGFYOwotICAgIG1fd2hlZWxUaWNrc1kgPSBtX2RlbHRhWTsKLQotI2lm bmRlZiBRVF9OT19XSEVFTEVWRU5UCi0gICAgLy8gVXNlIHRoZSBzYW1lIHNpbmdsZSBzY3JvbGwg c3RlcCBhcyBRVGV4dEVkaXQKLSAgICAvLyAoaW4gUVRleHRFZGl0UHJpdmF0ZTo6aW5pdCBbaCx2 XWJhci0+c2V0U2luZ2xlU3RlcCkKLSAgICBzdGF0aWMgY29uc3QgZmxvYXQgY0RlZmF1bHRRdFNj cm9sbFN0ZXAgPSAyMC5mOwotICAgIG1fZGVsdGFYICo9IChmdWxsVGljaykgPyBRQXBwbGljYXRp b246OndoZWVsU2Nyb2xsTGluZXMoKSAqIGNEZWZhdWx0UXRTY3JvbGxTdGVwIDogMTsKLSAgICBt X2RlbHRhWSAqPSAoZnVsbFRpY2spID8gUUFwcGxpY2F0aW9uOjp3aGVlbFNjcm9sbExpbmVzKCkg KiBjRGVmYXVsdFF0U2Nyb2xsU3RlcCA6IDE7Ci0jZW5kaWYKLX0KLQotUGxhdGZvcm1XaGVlbEV2 ZW50OjpQbGF0Zm9ybVdoZWVsRXZlbnQoUUdyYXBoaWNzU2NlbmVXaGVlbEV2ZW50KiBlKQotI2lm bmRlZiBRVF9OT19XSEVFTEVWRU5UCi0gICAgOiBQbGF0Zm9ybUV2ZW50KFBsYXRmb3JtRXZlbnQ6 OldoZWVsLCBlLT5tb2RpZmllcnMoKSAmIFF0OjpTaGlmdE1vZGlmaWVyLCBlLT5tb2RpZmllcnMo KSAmIFF0OjpDb250cm9sTW9kaWZpZXIsIGUtPm1vZGlmaWVycygpICYgUXQ6OkFsdE1vZGlmaWVy LCBlLT5tb2RpZmllcnMoKSAmIFF0OjpNZXRhTW9kaWZpZXIsIFdURjo6Y3VycmVudFRpbWUoKSkK LSAgICAsIG1fcG9zaXRpb24oZS0+cG9zKCkudG9Qb2ludCgpKQotICAgICwgbV9nbG9iYWxQb3Np dGlvbihlLT5zY3JlZW5Qb3MoKSkKLSAgICAsIG1fZ3JhbnVsYXJpdHkoU2Nyb2xsQnlQaXhlbFdo ZWVsRXZlbnQpCi0gICAgLCBtX2RpcmVjdGlvbkludmVydGVkRnJvbURldmljZShmYWxzZSkKLSNl bmRpZgotewotI2lmbmRlZiBRVF9OT19XSEVFTEVWRU5UCi0gICAgYXBwbHlEZWx0YShlLT5kZWx0 YSgpLCBlLT5vcmllbnRhdGlvbigpKTsKLSNlbHNlCi0gICAgUV9VTlVTRUQoZSk7Ci0jZW5kaWYK LX0KLQotUGxhdGZvcm1XaGVlbEV2ZW50OjpQbGF0Zm9ybVdoZWVsRXZlbnQoUVdoZWVsRXZlbnQq IGUpCi0jaWZuZGVmIFFUX05PX1dIRUVMRVZFTlQKLSAgICA6IFBsYXRmb3JtRXZlbnQoUGxhdGZv cm1FdmVudDo6V2hlZWwsIGUtPm1vZGlmaWVycygpICYgUXQ6OlNoaWZ0TW9kaWZpZXIsIGUtPm1v ZGlmaWVycygpICYgUXQ6OkNvbnRyb2xNb2RpZmllciwgZS0+bW9kaWZpZXJzKCkgJiBRdDo6QWx0 TW9kaWZpZXIsIGUtPm1vZGlmaWVycygpICYgUXQ6Ok1ldGFNb2RpZmllciwgV1RGOjpjdXJyZW50 VGltZSgpKQotICAgICwgbV9wb3NpdGlvbihlLT5wb3MoKSkKLSAgICAsIG1fZ2xvYmFsUG9zaXRp b24oZS0+Z2xvYmFsUG9zKCkpCi0gICAgLCBtX2dyYW51bGFyaXR5KFNjcm9sbEJ5UGl4ZWxXaGVl bEV2ZW50KQotICAgICwgbV9kaXJlY3Rpb25JbnZlcnRlZEZyb21EZXZpY2UoZmFsc2UpCi0jZW5k aWYKLXsKLSNpZm5kZWYgUVRfTk9fV0hFRUxFVkVOVAotICAgIGFwcGx5RGVsdGEoZS0+ZGVsdGEo KSwgZS0+b3JpZW50YXRpb24oKSk7Ci0jZWxzZQotICAgIFFfVU5VU0VEKGUpOwotI2VuZGlmCi19 Ci0KLX0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK