84236 2012-04-18 05:35:23 -0700 [EFL] DRT console messages should contain only the file name part of local URIs 2012-05-06 22:51:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 cdumez cdumez gyuyoung.kim haraken lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 604692 0 cdumez 2012-04-18 05:35:23 -0700 Several test cases are failing because they expect DRT console message to contain only the file name part of local URIs. I identified the following test cases which are failing because of this issue: fast/frames/sandboxed-iframe-close-top-noclose.html fast/frames/sandboxed-iframe-history-denied.html fast/frames/sandboxed-iframe-navigation-parent.html fast/frames/sandboxed-iframe-navigation-targetlink.html fast/frames/sandboxed-iframe-navigation-top-by-name-denied.html fast/frames/sandboxed-iframe-navigation-top-denied.html Their failure diff looks like: --- /home/buildslave-1/webkit-buildslave/efl-linux-debug/build/layout-test-results/fast/frames/sandboxed-iframe-close-top-noclose-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-debug/build/layout-test-results/fast/frames/sandboxed-iframe-close-top-noclose-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL close-top.html. +CONSOLE MESSAGE: Unsafe JavaScript attempt to initiate a navigation change for frame with URL file:///home/buildslave-1/webkit-buildslave/efl-linux-debug/build/LayoutTests/fast/frames/resources/sandboxed-iframe-close-top-does-not-close.html from frame with URL file:///home/buildslave-1/webkit-buildslave/efl-linux-debug/build/LayoutTests/fast/frames/resources/close-top.html. 604696 1 137675 cdumez 2012-04-18 05:42:55 -0700 Created attachment 137675 Patch 604740 2 137675 rakuco 2012-04-18 08:06:16 -0700 Comment on attachment 137675 Patch The patch looks fine. Don't you need to unskip some tests related to this? 604841 3 cdumez 2012-04-18 09:54:12 -0700 No, those are broken tests which are not part of the skip list. 604843 4 rakuco 2012-04-18 10:00:52 -0700 Hmm, I was talking about the section around line 1654 in the skipped list that says "BUG: The whole file path is being shown in the console message instead of only the file name". 604934 5 cdumez 2012-04-18 11:33:58 -0700 Oh sorry, I missed those. I'll make sure they pass and unskip if necessary. Thanks. 605387 6 137843 cdumez 2012-04-18 22:52:51 -0700 Created attachment 137843 Patch Unskip the tests which now pass because of this fix. 605587 7 137843 rakuco 2012-04-19 08:02:47 -0700 Comment on attachment 137843 Patch Looks OK, thanks. 606085 8 137843 haraken 2012-04-19 16:10:09 -0700 Comment on attachment 137843 Patch OK 606175 9 137843 webkit.review.bot 2012-04-19 16:50:55 -0700 Comment on attachment 137843 Patch Clearing flags on attachment: 137843 Committed r114694: <http://trac.webkit.org/changeset/114694> 606176 10 webkit.review.bot 2012-04-19 16:51:00 -0700 All reviewed patches have been landed. Closing bug. 137675 2012-04-18 05:42:55 -0700 2012-04-18 22:52:51 -0700 Patch 84236_console_local_uris.patch text/plain 2420 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNGEy NWYwLi4zODQ5NTA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDQtMTggIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBbRUZMXSBEUlQgY29uc29sZSBt ZXNzYWdlcyBzaG91bGQgY29udGFpbiBvbmx5IHRoZSBmaWxlIG5hbWUgcGFydCBvZiBsb2NhbCBV UklzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDIz NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFByb2Nl c3MgY29uc29sZSBtZXNzYWdlcyBiZWZvcmUgcHJpbnRpbmcgdGhlbSBpbiBFRkwncyBEdW1wUmVu ZGVyVHJlZQorICAgICAgICB0aGVtIHNvIHRoYXQgdGhleSBjb250YWluIG9ubHkgdGhlIGZpbGUg bmFtZSBwYXJ0IG9mIGxvY2FsIFVSSXMuIFRoaXMKKyAgICAgICAgaXMgd2hhdCBpcyBleHBlY3Rl ZCBieSB0ZXN0IGNhc2VzLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5k ZXJUcmVlVmlldy5jcHA6CisgICAgICAgICh1cmxTdWl0YWJsZUZvclRlc3RSZXN1bHQpOgorICAg ICAgICAob25Db25zb2xlTWVzc2FnZSk6CisKIDIwMTItMDQtMTggIE1hcmlvIFNhbmNoZXogUHJh ZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIGF0ay90ZXh0Q2hhbmdl ZE5vdGlmaWNhdGlvbnMgQVBJIHRlc3QgZmFpbHMKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZVZpZXcuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUv ZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAKaW5kZXggYjE2NDAxYS4uMGVkMWJlZSAxMDA2NDQK LS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAKKysr IGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBSZW5kZXJUcmVlVmlldy5jcHAKQEAgLTM1 LDE3ICszNSwzNyBAQAogI2luY2x1ZGUgPEV2YXMuaD4KICNpbmNsdWRlIDxjc3RkaW8+CiAjaW5j bHVkZSA8Y3N0ZGxpYj4KKyNpbmNsdWRlIDx3dGYvTm90Rm91bmQuaD4KKyNpbmNsdWRlIDx3dGYv dGV4dC9DU3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAKIHVzaW5n IG5hbWVzcGFjZSBzdGQ7CiAKIHN0YXRpYyBFd2tfVmlld19TbWFydF9DbGFzcyBnUGFyZW50U21h cnRDbGFzcyA9IEVXS19WSUVXX1NNQVJUX0NMQVNTX0lOSVRfTlVMTDsKIAorc3RhdGljIFdURjo6 U3RyaW5nIHVybFN1aXRhYmxlRm9yVGVzdFJlc3VsdChjb25zdCBXVEY6OlN0cmluZyYgdXJpU3Ry aW5nKQoreworICAgIGlmICh1cmlTdHJpbmcuaXNFbXB0eSgpIHx8ICF1cmlTdHJpbmcuc3RhcnRz V2l0aCgiZmlsZTovLyIpKQorICAgICAgICByZXR1cm4gdXJpU3RyaW5nOworCisgICAgY29uc3Qg c2l6ZV90IGluZGV4ID0gdXJpU3RyaW5nLnJldmVyc2VGaW5kKCcvJyk7CisgICAgcmV0dXJuIChp bmRleCA9PSBXVEY6Om5vdEZvdW5kKSA/IHVyaVN0cmluZyA6IHVyaVN0cmluZy5zdWJzdHJpbmco aW5kZXggKyAxKTsKK30KKwogc3RhdGljIHZvaWQgb25Db25zb2xlTWVzc2FnZShFd2tfVmlld19T bWFydF9EYXRhKiwgY29uc3QgY2hhciogbWVzc2FnZSwgdW5zaWduZWQgaW50IGxpbmVOdW1iZXIs IGNvbnN0IGNoYXIqKQogeworICAgIC8vIFRlc3RzIGV4cGVjdCBvbmx5IHRoZSBmaWxlbmFtZSBw YXJ0IG9mIGxvY2FsIFVSSXMKKyAgICBXVEY6OlN0cmluZyBuZXdNZXNzYWdlID0gbWVzc2FnZTsK KyAgICBpZiAoIW5ld01lc3NhZ2UuaXNFbXB0eSgpKSB7CisgICAgICAgIGNvbnN0IHNpemVfdCBm aWxlUHJvdG9jb2wgPSBuZXdNZXNzYWdlLmZpbmQoImZpbGU6Ly8iKTsKKyAgICAgICAgaWYgKGZp bGVQcm90b2NvbCAhPSBXVEY6Om5vdEZvdW5kKQorICAgICAgICAgICAgbmV3TWVzc2FnZSA9IG5l d01lc3NhZ2UubGVmdChmaWxlUHJvdG9jb2wpICsgdXJsU3VpdGFibGVGb3JUZXN0UmVzdWx0KG5l d01lc3NhZ2Uuc3Vic3RyaW5nKGZpbGVQcm90b2NvbCkpOworICAgIH0KKwogICAgIHByaW50Zigi Q09OU09MRSBNRVNTQUdFOiAiKTsKICAgICBpZiAobGluZU51bWJlcikKICAgICAgICAgcHJpbnRm KCJsaW5lICV1OiAiLCBsaW5lTnVtYmVyKTsKLSAgICBwcmludGYoIiVzXG4iLCBtZXNzYWdlKTsK KyAgICBwcmludGYoIiVzXG4iLCBuZXdNZXNzYWdlLnV0ZjgoKS5kYXRhKCkpOwogfQogCiBzdGF0 aWMgdm9pZCBvbkphdmFTY3JpcHRBbGVydChFd2tfVmlld19TbWFydF9EYXRhKiwgRXZhc19PYmpl Y3QqLCBjb25zdCBjaGFyKiBtZXNzYWdlKQo= 137843 2012-04-18 22:52:51 -0700 2012-04-19 16:50:55 -0700 Patch 84236_console_local_uris.patch text/plain 4399 cdumez ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZmNkYjc4Li4yZTQwMzRiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDQt MTkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAg ICAgICBbRUZMXSBEUlQgY29uc29sZSBtZXNzYWdlcyBzaG91bGQgY29udGFpbiBvbmx5IHRoZSBm aWxlIG5hbWUgcGFydCBvZiBsb2NhbCBVUklzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NDIzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFJlbW92ZSBmcm9tIHRoZSBza2lwIGxpc3QgdGhlIHRlc3RzIHdo aWNoIGV4cGVjdCBvbmx5IHRoZSBmaWxlIG5hbWUKKyAgICAgICAgcGFydCBvZiBsb2NhbCBVUklz IHRvIGJlIGRpc3BsYXllZCBpbiBjb25zb2xlIG1lc3NhZ2VzIG5vdyB0aGF0IGl0IGhhcworICAg ICAgICBiZWVuIGZpeGVkIGluIEVGTCdzIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgICogcGxh dGZvcm0vZWZsL1NraXBwZWQ6CisKIDIwMTItMDQtMTggIFRha2FzaGkgVG95b3NoaW1hICA8dG95 b3NoaW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHVwZGF0ZSBleHBlY3Rh dGlvbnMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC9Ta2lwcGVkIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKaW5kZXggM2FkNTU5MS4uMzgzYmRiNCAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsL1NraXBwZWQKQEAgLTE2NDEsMjAgKzE2NDEsNiBAQCBwcmludGluZy9z aW11bHRhbmVvdXMtcG9zaXRpb24tZmxvYXQtY2hhbmdlLmh0bWwKICMgQlVHOiBzcXVhcmUgYnV0 dG9uIGlzIG5vdCBiZWluZyBkcmF3biBhcyBhIHNxdWFyZQogZmFzdC9jc3Mvc3F1YXJlLWJ1dHRv bi1hcHBlYXJhbmNlLmh0bWwKIAotIyBCVUc6IFRoZSB3aG9sZSBmaWxlIHBhdGggaXMgYmVpbmcg c2hvd24gaW4gdGhlIGNvbnNvbGUgbWVzc2FnZSBpbnN0ZWFkIG9mIG9ubHkgdGhlIGZpbGUgbmFt ZS4KLWh0dHAvdGVzdHMvbWlzYy9pbWFnZS1ibG9ja2VkLXNyYy1jaGFuZ2UuaHRtbAotaHR0cC90 ZXN0cy9taXNjL2ltYWdlLWJsb2NrZWQtc3JjLW5vLWNoYW5nZS5odG1sCi1odHRwL3Rlc3RzL21p c2MvdW5sb2FkYWJsZS1zY3JpcHQuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9mcmFtZS1sb2Fk aW5nLXZpYS1kb2N1bWVudC13cml0ZS5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2FsLUNT Uy1mcm9tLXJlbW90ZS5odG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2FsLUphdmFTY3JpcHQt ZnJvbS1yZW1vdGUuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9sb2NhbC1pRnJhbWUtZnJvbS1y ZW1vdGUuaHRtbAotaHR0cC90ZXN0cy9zZWN1cml0eS9sb2NhbC1pbWFnZS1mcm9tLXJlbW90ZS5o dG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2FsLXZpZGVvLXBvc3Rlci1mcm9tLXJlbW90ZS5o dG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2FsLXZpZGVvLXNvdXJjZS1mcm9tLXJlbW90ZS5o dG1sCi1odHRwL3Rlc3RzL3NlY3VyaXR5L2xvY2FsLXZpZGVvLXNyYy1mcm9tLXJlbW90ZS5odG1s Ci1tZWRpYS9jc3AtYmxvY2tzLXZpZGVvLmh0bWwKLQogIyBCVUc6IE9ubHkgd29ya3MgaWYgLS1n dWkgaXMgcGFzc2VkIChkdWUgdG8gdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24gb2YgUGxhdGZv cm1TY3JlZW5FZmw6OnNjcmVlblJlY3QpLgogZmFzdC9tZWRpYS9pbnZhbGlkLWxlbmd0aHMuaHRt bAogZmFzdC9tZWRpYS9tYXRjaG1lZGl1bS1xdWVyeS1hcGkuaHRtbApkaWZmIC0tZ2l0IGEvVG9v bHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDA0YTI1ZjAuLmFmODMzYTAgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxOCBAQAorMjAxMi0wNC0xOSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpA aW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdIERSVCBjb25zb2xlIG1lc3NhZ2VzIHNob3VsZCBj b250YWluIG9ubHkgdGhlIGZpbGUgbmFtZSBwYXJ0IG9mIGxvY2FsIFVSSXMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjM2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHJvY2VzcyBjb25zb2xlIG1lc3Nh Z2VzIGJlZm9yZSBwcmludGluZyB0aGVtIGluIEVGTCdzIER1bXBSZW5kZXJUcmVlCisgICAgICAg IHRoZW0gc28gdGhhdCB0aGV5IGNvbnRhaW4gb25seSB0aGUgZmlsZSBuYW1lIHBhcnQgb2YgbG9j YWwgVVJJcy4gVGhpcworICAgICAgICBpcyB3aGF0IGlzIGV4cGVjdGVkIGJ5IHRlc3QgY2FzZXMu CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVWaWV3LmNwcDoK KyAgICAgICAgKHVybFN1aXRhYmxlRm9yVGVzdFJlc3VsdCk6CisgICAgICAgIChvbkNvbnNvbGVN ZXNzYWdlKToKKwogMjAxMi0wNC0xOCAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGln YWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gYXRrL3RleHRDaGFuZ2VkTm90aWZpY2F0aW9ucyBB UEkgdGVzdCBmYWlscwpkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1bXBS ZW5kZXJUcmVlVmlldy5jcHAgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRy ZWVWaWV3LmNwcAppbmRleCBiMTY0MDFhLi4wZWQxYmVlIDEwMDY0NAotLS0gYS9Ub29scy9EdW1w UmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVWaWV3LmNwcAorKysgYi9Ub29scy9EdW1wUmVu ZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVWaWV3LmNwcApAQCAtMzUsMTcgKzM1LDM3IEBACiAj aW5jbHVkZSA8RXZhcy5oPgogI2luY2x1ZGUgPGNzdGRpbz4KICNpbmNsdWRlIDxjc3RkbGliPgor I2luY2x1ZGUgPHd0Zi9Ob3RGb3VuZC5oPgorI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4K KyNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogdXNpbmcgbmFtZXNwYWNlIHN0ZDsK IAogc3RhdGljIEV3a19WaWV3X1NtYXJ0X0NsYXNzIGdQYXJlbnRTbWFydENsYXNzID0gRVdLX1ZJ RVdfU01BUlRfQ0xBU1NfSU5JVF9OVUxMOwogCitzdGF0aWMgV1RGOjpTdHJpbmcgdXJsU3VpdGFi bGVGb3JUZXN0UmVzdWx0KGNvbnN0IFdURjo6U3RyaW5nJiB1cmlTdHJpbmcpCit7CisgICAgaWYg KHVyaVN0cmluZy5pc0VtcHR5KCkgfHwgIXVyaVN0cmluZy5zdGFydHNXaXRoKCJmaWxlOi8vIikp CisgICAgICAgIHJldHVybiB1cmlTdHJpbmc7CisKKyAgICBjb25zdCBzaXplX3QgaW5kZXggPSB1 cmlTdHJpbmcucmV2ZXJzZUZpbmQoJy8nKTsKKyAgICByZXR1cm4gKGluZGV4ID09IFdURjo6bm90 Rm91bmQpID8gdXJpU3RyaW5nIDogdXJpU3RyaW5nLnN1YnN0cmluZyhpbmRleCArIDEpOworfQor CiBzdGF0aWMgdm9pZCBvbkNvbnNvbGVNZXNzYWdlKEV3a19WaWV3X1NtYXJ0X0RhdGEqLCBjb25z dCBjaGFyKiBtZXNzYWdlLCB1bnNpZ25lZCBpbnQgbGluZU51bWJlciwgY29uc3QgY2hhciopCiB7 CisgICAgLy8gVGVzdHMgZXhwZWN0IG9ubHkgdGhlIGZpbGVuYW1lIHBhcnQgb2YgbG9jYWwgVVJJ cworICAgIFdURjo6U3RyaW5nIG5ld01lc3NhZ2UgPSBtZXNzYWdlOworICAgIGlmICghbmV3TWVz c2FnZS5pc0VtcHR5KCkpIHsKKyAgICAgICAgY29uc3Qgc2l6ZV90IGZpbGVQcm90b2NvbCA9IG5l d01lc3NhZ2UuZmluZCgiZmlsZTovLyIpOworICAgICAgICBpZiAoZmlsZVByb3RvY29sICE9IFdU Rjo6bm90Rm91bmQpCisgICAgICAgICAgICBuZXdNZXNzYWdlID0gbmV3TWVzc2FnZS5sZWZ0KGZp bGVQcm90b2NvbCkgKyB1cmxTdWl0YWJsZUZvclRlc3RSZXN1bHQobmV3TWVzc2FnZS5zdWJzdHJp bmcoZmlsZVByb3RvY29sKSk7CisgICAgfQorCiAgICAgcHJpbnRmKCJDT05TT0xFIE1FU1NBR0U6 ICIpOwogICAgIGlmIChsaW5lTnVtYmVyKQogICAgICAgICBwcmludGYoImxpbmUgJXU6ICIsIGxp bmVOdW1iZXIpOwotICAgIHByaW50ZigiJXNcbiIsIG1lc3NhZ2UpOworICAgIHByaW50ZigiJXNc biIsIG5ld01lc3NhZ2UudXRmOCgpLmRhdGEoKSk7CiB9CiAKIHN0YXRpYyB2b2lkIG9uSmF2YVNj cmlwdEFsZXJ0KEV3a19WaWV3X1NtYXJ0X0RhdGEqLCBFdmFzX09iamVjdCosIGNvbnN0IGNoYXIq IG1lc3NhZ2UpCg==