84229 2012-04-18 00:26:42 -0700 [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE 2012-04-18 09:14:23 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 d-r tmpsantos dbates gyuyoung.kim lucas.de.marchi mxie naginenis paroga rakuco rwlbuis tmpsantos tonikitoo webkit.review.bot oldest_to_newest 604619 0 d-r 2012-04-18 00:26:42 -0700 Build 203 [1] on the debug and build 35578 on the release buildbot included important changes from bug 84052 and bug 83281. However, they did not trigger rebuilds of the required objects, leading to an increase in failure rates by about 140 cases. So, from svn revision 114416 to 114420, the buildsystem failed to trigger the appropriate rebuild. This needs to be fixed urgently. [1] http://build.webkit.org/builders/EFL%20Linux%20Debug/builds/203 [2] http://build.webkit.org/builders/EFL%20Linux%20Release/builds/35578 604626 1 d-r 2012-04-18 01:00:41 -0700 --cmakearg="-DCMAKE_VERBOSE_MAKEFILE=ON" as an argument to build-webkit --efl might be helpful. 604632 2 naginenis 2012-04-18 01:26:31 -0700 Looks like EFl buildbots are triggering rebuilds of changes only when we force a clean build. 604683 3 naginenis 2012-04-18 05:09:53 -0700 The root cause of this issue is ONLY_BUILD_JAVASCRIPTCORE is always ON after running run-javascriptcore-tests(value is stored in CMakeCache.txt) and the following check in CMakeLists.txt ignores building other modules when this option is ON. OPTION(ONLY_BUILD_JAVASCRIPTCORE "only build JavaScriptCore") IF (ONLY_BUILD_JAVASCRIPTCORE) SET(ENABLE_WEBCORE OFF) SET(ENABLE_WEBKIT OFF) SET(ENABLE_WEBKIT2 OFF) SET(ENABLE_TOOLS OFF) ENDIF () To fix the issue we should set this option OFF when we run build-webkit. 604695 4 137674 tmpsantos 2012-04-18 05:41:13 -0700 Created attachment 137674 Patch fixing buildsystem. 604701 5 137677 tmpsantos 2012-04-18 06:03:45 -0700 Created attachment 137677 Same patch, better changelog. 604707 6 137677 rakuco 2012-04-18 06:45:45 -0700 Comment on attachment 137677 Same patch, better changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review > Tools/Scripts/build-jsc:73 > + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess. 604788 7 137677 rwlbuis 2012-04-18 08:55:28 -0700 Comment on attachment 137677 Same patch, better changelog. View in context: https://bugs.webkit.org/attachment.cgi?id=137677&action=review >> Tools/Scripts/build-jsc:73 >> + buildCMakeProjectOrExit(0, cmakeBasedPortName(), undef, "jsc", cmakeBasedPortArguments()); # This call only returns if nothing wrong happened > > As we were discussing on IRC, this will break if JSC_EXECUTABLE_NAME is set to something else in Options${PORT}.cmake. Adding a note in a comment before this line should be enough for now, I guess. Why not use JSC_EXECUTABLE_NAME in the first place instead of hardcoding jsc? 604792 8 137677 rwlbuis 2012-04-18 09:07:54 -0700 Comment on attachment 137677 Same patch, better changelog. Looks good. 604796 9 137677 webkit.review.bot 2012-04-18 09:14:18 -0700 Comment on attachment 137677 Same patch, better changelog. Clearing flags on attachment: 137677 Committed r114508: <http://trac.webkit.org/changeset/114508> 604797 10 webkit.review.bot 2012-04-18 09:14:23 -0700 All reviewed patches have been landed. Closing bug. 137674 2012-04-18 05:41:13 -0700 2012-04-18 06:03:45 -0700 Patch fixing buildsystem. build_jsc_target.patch text/plain 2822 tmpsantos ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggYzY3YmI2 OS4uOTBmZjAzYSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50 eHQKQEAgLTE5LDE0ICsxOSw2IEBAIEVORElGICgpCiAKIFNFVChFTkFCTEVfVE9PTFMgT04pCiAK LU9QVElPTihPTkxZX0JVSUxEX0pBVkFTQ1JJUFRDT1JFICJvbmx5IGJ1aWxkIEphdmFTY3JpcHRD b3JlIikKLUlGIChPTkxZX0JVSUxEX0pBVkFTQ1JJUFRDT1JFKQotICAgIFNFVChFTkFCTEVfV0VC Q09SRSBPRkYpCi0gICAgU0VUKEVOQUJMRV9XRUJLSVQgT0ZGKQotICAgIFNFVChFTkFCTEVfV0VC S0lUMiBPRkYpCi0gICAgU0VUKEVOQUJMRV9UT09MUyBPRkYpCi1FTkRJRiAoKQotCiBTRVQoV1RG X0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV1RGIikKIFNFVChKQVZBU0NSSVBUQ09S RV9ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL0phdmFTY3JpcHRDb3JlIikKIFNFVChX RUJDT1JFX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViQ29yZSIpCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggODljYjExNzUuLjIwMzQ5NTYgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0w NC0xOCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4K KworICAgICAgICBbQ01ha2VdIFVzZSBqc2MgdGFyZ2V0IGluc3RlYWQgb2YgT05MWV9CVUlMRF9K QVZBU0NSSVBUQ09SRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODQyMjkKKworICAgICAgICBDTWFrZSBjYWNoZXMgT05MWV9CVUlMRF9KQVZBU0NSSVBU Q09SRSBhbmQgd2lsbCByZXVzZSBmb3IgZnVydGVyIGJ1aWxkcywKKyAgICAgICAgZ2l2aW5nIHVz IHdyb25nIHJlc3VsdHMgd2hlbiBjYWxsaW5nIGJ1aWxkLXdlYmtpdCBhZnRlciBidWlsZC1qc2Mu CisKKyAgICAgICAgSW5zdGVhZCBvZiB0cnlpbmcgdG8gZW11bGF0ZSBhIGJ1aWxkIHRhcmdldCB1 c2luZyBjb21tYW5kIGxpbmUgb3B0aW9ucywKKyAgICAgICAganVzdCBidWlsZCB0aGUgZXhpc3Rp bmcganNjIHRhcmdldCBkaXJlY3RseS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA0LTE3ICBZb25nIExp ICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxMDU0NTMpOiBDcmFzaCB3 aGVuIGhhbmRsaW5nIHRvdWNoIGV2ZW50cwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIv VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGNmOGExYjMuLjI2MWY2MGYgMTAwNjQ0Ci0tLSBhL1Rvb2xz L0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0w NC0xOCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4K KworICAgICAgICBbQ01ha2VdIFVzZSBqc2MgdGFyZ2V0IGluc3RlYWQgb2YgT05MWV9CVUlMRF9K QVZBU0NSSVBUQ09SRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODQyMjkKKworICAgICAgICBDTWFrZSBjYWNoZXMgT05MWV9CVUlMRF9KQVZBU0NSSVBU Q09SRSBhbmQgd2lsbCByZXVzZSBmb3IgZnVydGVyIGJ1aWxkcywKKyAgICAgICAgZ2l2aW5nIHVz IHdyb25nIHJlc3VsdHMgd2hlbiBjYWxsaW5nIGJ1aWxkLXdlYmtpdCBhZnRlciBidWlsZC1qc2Mu CisKKyAgICAgICAgSW5zdGVhZCBvZiB0cnlpbmcgdG8gZW11bGF0ZSBhIGJ1aWxkIHRhcmdldCB1 c2luZyBjb21tYW5kIGxpbmUgb3B0aW9ucywKKyAgICAgICAganVzdCBidWlsZCB0aGUgZXhpc3Rp bmcganNjIHRhcmdldCBkaXJlY3RseS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorCiAyMDEyLTA0LTE3ICBKYWNr eSBKaWFuZyAgPHpoYWppYW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFZpZXdw b3J0IG1ldGF0YWcgZG9lc24ndCBkaXNhYmxlIGRvdWJsZS10YXAgem9vbQpkaWZmIC0tZ2l0IGEv VG9vbHMvU2NyaXB0cy9idWlsZC1qc2MgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwppbmRleCAx NDQ3YmJhLi40MThmMjJiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYworKysg Yi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAtNzAsNyArNzAsNyBAQCBpZiAoaXNRdCgpKSB7 CiAgICAgbXkgJHJlc3VsdCA9IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJH Vik7CiAgICAgZXhpdCBleGl0U3RhdHVzKCRyZXN1bHQpOwogfSBlbHNpZiAoY21ha2VCYXNlZFBv cnROYW1lKCkpIHsKLSAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgwLCBjbWFrZUJhc2VkUG9y dE5hbWUoKSwgdW5kZWYsIHVuZGVmLCAoIi1ET05MWV9CVUlMRF9KQVZBU0NSSVBUQ09SRT0xIiwg Y21ha2VCYXNlZFBvcnRBcmd1bWVudHMoKSkpOyAjIFRoaXMgY2FsbCBvbmx5IHJldHVybnMgaWYg bm90aGluZyB3cm9uZyBoYXBwZW5lZAorICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KDAsIGNt YWtlQmFzZWRQb3J0TmFtZSgpLCB1bmRlZiwgImpzYyIsIGNtYWtlQmFzZWRQb3J0QXJndW1lbnRz KCkpOyAjIFRoaXMgY2FsbCBvbmx5IHJldHVybnMgaWYgbm90aGluZyB3cm9uZyBoYXBwZW5lZAog ICAgIGV4aXQgZXhpdFN0YXR1cygwKTsKIH0KIAo= 137677 2012-04-18 06:03:45 -0700 2012-04-18 09:14:18 -0700 Same patch, better changelog. build_jsc_target.patch text/plain 2816 tmpsantos ZGlmZiAtLWdpdCBhL0NNYWtlTGlzdHMudHh0IGIvQ01ha2VMaXN0cy50eHQKaW5kZXggYzY3YmI2 OS4uOTBmZjAzYSAxMDA2NDQKLS0tIGEvQ01ha2VMaXN0cy50eHQKKysrIGIvQ01ha2VMaXN0cy50 eHQKQEAgLTE5LDE0ICsxOSw2IEBAIEVORElGICgpCiAKIFNFVChFTkFCTEVfVE9PTFMgT04pCiAK LU9QVElPTihPTkxZX0JVSUxEX0pBVkFTQ1JJUFRDT1JFICJvbmx5IGJ1aWxkIEphdmFTY3JpcHRD b3JlIikKLUlGIChPTkxZX0JVSUxEX0pBVkFTQ1JJUFRDT1JFKQotICAgIFNFVChFTkFCTEVfV0VC Q09SRSBPRkYpCi0gICAgU0VUKEVOQUJMRV9XRUJLSVQgT0ZGKQotICAgIFNFVChFTkFCTEVfV0VC S0lUMiBPRkYpCi0gICAgU0VUKEVOQUJMRV9UT09MUyBPRkYpCi1FTkRJRiAoKQotCiBTRVQoV1RG X0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV1RGIikKIFNFVChKQVZBU0NSSVBUQ09S RV9ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL0phdmFTY3JpcHRDb3JlIikKIFNFVChX RUJDT1JFX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViQ29yZSIpCmRpZmYgLS1n aXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggODljYjExNzUuLmQxOGNiYTUgMTAwNjQ0 Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0w NC0xOCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4K KworICAgICAgICBbQ01ha2VdIFVzZSBqc2MgdGFyZ2V0IGluc3RlYWQgb2YgT05MWV9CVUlMRF9K QVZBU0NSSVBUQ09SRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODQyMjkKKworICAgICAgICBDTWFrZSBjYWNoZXMgT05MWV9CVUlMRF9KQVZBU0NSSVBU Q09SRT0xIGFuZCB3aWxsIHJldXNlIHRoZSBzZXR0aW5nIGZvcgorICAgICAgICBzdWJzZXF1ZW50 IGJ1aWxkcywgc3RvcHBpbmcgV2ViQ29yZSBmcm9tIGJlaW5nIGJ1aWx0IGV2ZXIgYWdhaW4uCisK KyAgICAgICAgSW5zdGVhZCBvZiB0cnlpbmcgdG8gZW11bGF0ZSBhIGJ1aWxkIHRhcmdldCB1c2lu ZyBjb21tYW5kIGxpbmUgb3B0aW9ucywKKyAgICAgICAganVzdCBidWlsZCB0aGUgZXhpc3Rpbmcg anNjIHRhcmdldCBkaXJlY3RseS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0OgorCiAyMDEyLTA0LTE3ICBZb25nIExpICA8 eW9saUByaW0uY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIxMDU0NTMpOiBDcmFzaCB3aGVu IGhhbmRsaW5nIHRvdWNoIGV2ZW50cwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9v bHMvQ2hhbmdlTG9nCmluZGV4IGNmOGExYjMuLjc5MjlmYTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL0No YW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wNC0x OCAgVGhpYWdvIE1hcmNvcyBQLiBTYW50b3MgIDx0aGlhZ28uc2FudG9zQGludGVsLmNvbT4KKwor ICAgICAgICBbQ01ha2VdIFVzZSBqc2MgdGFyZ2V0IGluc3RlYWQgb2YgT05MWV9CVUlMRF9KQVZB U0NSSVBUQ09SRQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODQyMjkKKworICAgICAgICBDTWFrZSBjYWNoZXMgT05MWV9CVUlMRF9KQVZBU0NSSVBUQ09S RT0xIGFuZCB3aWxsIHJldXNlIHRoZSBzZXR0aW5nIGZvcgorICAgICAgICBzdWJzZXF1ZW50IGJ1 aWxkcywgc3RvcHBpbmcgV2ViQ29yZSBmcm9tIGJlaW5nIGJ1aWx0IGV2ZXIgYWdhaW4uCisKKyAg ICAgICAgSW5zdGVhZCBvZiB0cnlpbmcgdG8gZW11bGF0ZSBhIGJ1aWxkIHRhcmdldCB1c2luZyBj b21tYW5kIGxpbmUgb3B0aW9ucywKKyAgICAgICAganVzdCBidWlsZCB0aGUgZXhpc3RpbmcganNj IHRhcmdldCBkaXJlY3RseS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtanNjOgorCiAyMDEyLTA0LTE3ICBKYWNreSBKaWFu ZyAgPHpoYWppYW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFZpZXdwb3J0IG1l dGF0YWcgZG9lc24ndCBkaXNhYmxlIGRvdWJsZS10YXAgem9vbQpkaWZmIC0tZ2l0IGEvVG9vbHMv U2NyaXB0cy9idWlsZC1qc2MgYi9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYwppbmRleCAxNDQ3YmJh Li40MThmMjJiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL2J1aWxkLWpzYworKysgYi9Ub29s cy9TY3JpcHRzL2J1aWxkLWpzYwpAQCAtNzAsNyArNzAsNyBAQCBpZiAoaXNRdCgpKSB7CiAgICAg bXkgJHJlc3VsdCA9IGJ1aWxkUU1ha2VQcm9qZWN0cyhcQHByb2plY3RzLCAwLCBAQVJHVik7CiAg ICAgZXhpdCBleGl0U3RhdHVzKCRyZXN1bHQpOwogfSBlbHNpZiAoY21ha2VCYXNlZFBvcnROYW1l KCkpIHsKLSAgICBidWlsZENNYWtlUHJvamVjdE9yRXhpdCgwLCBjbWFrZUJhc2VkUG9ydE5hbWUo KSwgdW5kZWYsIHVuZGVmLCAoIi1ET05MWV9CVUlMRF9KQVZBU0NSSVBUQ09SRT0xIiwgY21ha2VC YXNlZFBvcnRBcmd1bWVudHMoKSkpOyAjIFRoaXMgY2FsbCBvbmx5IHJldHVybnMgaWYgbm90aGlu ZyB3cm9uZyBoYXBwZW5lZAorICAgIGJ1aWxkQ01ha2VQcm9qZWN0T3JFeGl0KDAsIGNtYWtlQmFz ZWRQb3J0TmFtZSgpLCB1bmRlZiwgImpzYyIsIGNtYWtlQmFzZWRQb3J0QXJndW1lbnRzKCkpOyAj IFRoaXMgY2FsbCBvbmx5IHJldHVybnMgaWYgbm90aGluZyB3cm9uZyBoYXBwZW5lZAogICAgIGV4 aXQgZXhpdFN0YXR1cygwKTsKIH0KIAo=