84215 2012-04-17 17:14:22 -0700 [Chromium] Solid color shader should use premultiplied alpha. 2012-04-18 13:35:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84197 1 reveman reveman cc-bugs jamesr piman webkit.review.bot oldest_to_newest 604502 0 reveman 2012-04-17 17:14:22 -0700 This is mostly for consistency. Textures are expected to have premultiplied alpha so I don't think there's a good reason not to expect that in the solid color shader as well. Also faster not to compute the color per-pixel even though I doubt that matters. 604525 1 137642 reveman 2012-04-17 17:48:22 -0700 Created attachment 137642 Patch 604526 2 piman 2012-04-17 17:52:01 -0700 LGTM 604921 3 137642 enne 2012-04-18 11:23:42 -0700 Comment on attachment 137642 Patch Sounds good. R=me. 605041 4 137642 webkit.review.bot 2012-04-18 13:35:00 -0700 Comment on attachment 137642 Patch Clearing flags on attachment: 137642 Committed r114552: <http://trac.webkit.org/changeset/114552> 605042 5 webkit.review.bot 2012-04-18 13:35:04 -0700 All reviewed patches have been landed. Closing bug. 137642 2012-04-17 17:48:22 -0700 2012-04-18 13:35:00 -0700 Patch bug-84215-20120417204821.patch text/plain 3645 reveman U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0Mzc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2I2MmUzNjcxZGE1NGZi MGQ0MGMzZmMwYzQ1NzNjYzVhMGVjZTEyZC4uZjM3ZjMxYzZiZjE1OTQ4MWYzYjc0YzIxYWEwMTYy MDA0ZmE2MTFmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTE3ICBEYXZp ZCBSZXZlbWFuICA8cmV2ZW1hbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBT b2xpZCBjb2xvciBzaGFkZXIgc2hvdWxkIHVzZSBwcmVtdWx0aXBsaWVkIGFscGhhLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyMTUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGb3IgZWZmaWNpZW5jeSBh bmQgY29uc2lzdGVuY3ksIGV4cGVjdCBwcmVtdWx0aXBsaWVkIGFscGhhIGluCisgICAgICAgIHNv bGlkIGNvbG9yIHNoYWRlci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRl cmVyQ2hyb21pdW06OmRyYXdEZWJ1Z0JvcmRlclF1YWQpOgorICAgICAgICAoV2ViQ29yZTo6TGF5 ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3U29saWRDb2xvclF1YWQpOgorICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2Nocm9taXVtL1NoYWRlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkZyYWdtZW50U2hhZGVyQ29sb3I6OmdldFNoYWRlclN0cmluZyk6CisKIDIwMTItMDQtMTcg IEFsbGFuIFNhbmRmZWxkIEplbnNlbiAgPGFsbGFuLmplbnNlbkBub2tpYS5jb20+CiAKICAgICAg ICAgQXNzZXJ0cyBpbiBYTUxIdHRwUmVxdWVzdFByb2dyZXNzRXZlbnRUaHJvdHRsZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5k ZXJlckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9t aXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAKaW5kZXggMGQwNjYzMzI5MGEyYjRkN2RiODNl NDE5OWMxMWFjMDg4OTFlYzk5NC4uMzBiNDRiNzQ2MjMyOGExYmU4MjdiMDkzN2E5ZjY5NjhmYWIx ZmE4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCkBAIC01MjksNyAr NTI5LDEwIEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3RGVidWdCb3JkZXJRdWFk KGNvbnN0IENDRGVidWdCb3JkZXJEcmF3UXVhZCogcXVhCiAgICAgTGF5ZXJSZW5kZXJlckNocm9t aXVtOjp0b0dMTWF0cml4KCZnbE1hdHJpeFswXSwgcHJvamVjdGlvbk1hdHJpeCgpICogcmVuZGVy TWF0cml4KTsKICAgICBHTEMoY29udGV4dCgpLCBjb250ZXh0KCktPnVuaWZvcm1NYXRyaXg0ZnYo cHJvZ3JhbS0+dmVydGV4U2hhZGVyKCkubWF0cml4TG9jYXRpb24oKSwgMSwgZmFsc2UsICZnbE1h dHJpeFswXSkpOwogCi0gICAgR0xDKGNvbnRleHQoKSwgY29udGV4dCgpLT51bmlmb3JtNGYocHJv Z3JhbS0+ZnJhZ21lbnRTaGFkZXIoKS5jb2xvckxvY2F0aW9uKCksIHF1YWQtPmNvbG9yKCkucmVk KCkgLyAyNTUuMCwgcXVhZC0+Y29sb3IoKS5ncmVlbigpIC8gMjU1LjAsIHF1YWQtPmNvbG9yKCku Ymx1ZSgpIC8gMjU1LjAsIHF1YWQtPmNvbG9yKCkuYWxwaGEoKSAvIDI1NS4wKSk7CisgICAgY29u c3QgQ29sb3ImIGNvbG9yID0gcXVhZC0+Y29sb3IoKTsKKyAgICBmbG9hdCBhbHBoYSA9IGNvbG9y LmFscGhhKCkgLyAyNTUuMDsKKworICAgIEdMQyhjb250ZXh0KCksIGNvbnRleHQoKS0+dW5pZm9y bTRmKHByb2dyYW0tPmZyYWdtZW50U2hhZGVyKCkuY29sb3JMb2NhdGlvbigpLCAoY29sb3IucmVk KCkgLyAyNTUuMCkgKiBhbHBoYSwgKGNvbG9yLmdyZWVuKCkgLyAyNTUuMCkgKiBhbHBoYSwgKGNv bG9yLmJsdWUoKSAvIDI1NS4wKSAqIGFscGhhLCBhbHBoYSkpOwogCiAgICAgR0xDKGNvbnRleHQo KSwgY29udGV4dCgpLT5saW5lV2lkdGgocXVhZC0+d2lkdGgoKSkpOwogCkBAIC02MTgsOCArNjIx LDkgQEAgdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdTb2xpZENvbG9yUXVhZChjb25z dCBDQ1NvbGlkQ29sb3JEcmF3UXVhZCogcXVhZCkKICAgICB0aWxlVHJhbnNmb3JtLnRyYW5zbGF0 ZSh0aWxlUmVjdC54KCkgKyB0aWxlUmVjdC53aWR0aCgpIC8gMi4wLCB0aWxlUmVjdC55KCkgKyB0 aWxlUmVjdC5oZWlnaHQoKSAvIDIuMCk7CiAKICAgICBjb25zdCBDb2xvciYgY29sb3IgPSBxdWFk LT5jb2xvcigpOworICAgIGZsb2F0IGFscGhhID0gY29sb3IuYWxwaGEoKSAvIDI1NS4wOwogCi0g ICAgR0xDKGNvbnRleHQoKSwgY29udGV4dCgpLT51bmlmb3JtNGYoc29saWRDb2xvclByb2dyYW0t PmZyYWdtZW50U2hhZGVyKCkuY29sb3JMb2NhdGlvbigpLCBjb2xvci5yZWQoKSAvIDI1NS4wLCBj b2xvci5ncmVlbigpIC8gMjU1LjAsIGNvbG9yLmJsdWUoKSAvIDI1NS4wLCBjb2xvci5hbHBoYSgp IC8gMjU1LjApKTsKKyAgICBHTEMoY29udGV4dCgpLCBjb250ZXh0KCktPnVuaWZvcm00Zihzb2xp ZENvbG9yUHJvZ3JhbS0+ZnJhZ21lbnRTaGFkZXIoKS5jb2xvckxvY2F0aW9uKCksIChjb2xvci5y ZWQoKSAvIDI1NS4wKSAqIGFscGhhLCAoY29sb3IuZ3JlZW4oKSAvIDI1NS4wKSAqIGFscGhhLCAo Y29sb3IuYmx1ZSgpIC8gMjU1LjApICogYWxwaGEsIGFscGhhKSk7CiAKICAgICBmbG9hdCBvcGFj aXR5ID0gcXVhZC0+b3BhY2l0eSgpOwogICAgIGRyYXdUZXh0dXJlZFF1YWQodGlsZVRyYW5zZm9y bSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVt L1NoYWRlckNocm9taXVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL1NoYWRlckNocm9taXVtLmNwcAppbmRleCAxNjIzNzc1YzgyZjYxYzhhNDY2NTUyY2Nj NjlhYzQwNTc2NThmNTRlLi44ZmEyNWM0M2MwOWViOTgwOTU5YjczZTMyODUyNThiZDM1Zjk4NDY0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9T aGFkZXJDaHJvbWl1bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vU2hhZGVyQ2hyb21pdW0uY3BwCkBAIC03MjAsNyArNzIwLDcgQEAgU3RyaW5nIEZy YWdtZW50U2hhZGVyQ29sb3I6OmdldFNoYWRlclN0cmluZygpIGNvbnN0CiAgICAgICAgIHVuaWZv cm0gdmVjNCBjb2xvcjsKICAgICAgICAgdm9pZCBtYWluKCkKICAgICAgICAgewotICAgICAgICAg ICAgZ2xfRnJhZ0NvbG9yID0gdmVjNChjb2xvci54eXogKiBjb2xvci53LCBjb2xvci53KTsKKyAg ICAgICAgICAgIGdsX0ZyYWdDb2xvciA9IGNvbG9yOwogICAgICAgICB9CiAgICAgKTsKIH0K