<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>84213</bug_id>
          
          <creation_ts>2012-04-17 16:48:45 -0700</creation_ts>
          <short_desc>build-webkit: make ninja work with chromium linux</short_desc>
          <delta_ts>2012-04-17 17:59:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dirk Pranke">dpranke</reporter>
          <assigned_to name="Dirk Pranke">dpranke</assigned_to>
          <cc>eric</cc>
    
    <cc>ojan</cc>
    
    <cc>thakis</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>604482</commentid>
    <comment_count>0</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-04-17 16:48:45 -0700</bug_when>
    <thetext>build-webkit: make ninja work with chromium linux</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604483</commentid>
    <comment_count>1</comment_count>
      <attachid>137637</attachid>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-04-17 16:49:38 -0700</bug_when>
    <thetext>Created attachment 137637
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604486</commentid>
    <comment_count>2</comment_count>
      <attachid>137637</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-04-17 16:56:33 -0700</bug_when>
    <thetext>Comment on attachment 137637
Patch

You&apos;re blowing my mind.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604509</commentid>
    <comment_count>3</comment_count>
      <attachid>137637</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-17 17:29:40 -0700</bug_when>
    <thetext>Comment on attachment 137637
Patch

Clearing flags on attachment: 137637

Committed r114469: &lt;http://trac.webkit.org/changeset/114469&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604510</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-04-17 17:29:45 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604524</commentid>
    <comment_count>5</comment_count>
    <who name="Nico Weber">thakis</who>
    <bug_when>2012-04-17 17:43:52 -0700</bug_when>
    <thetext>omg did I write that? :-D

Thanks for fixing, let me know how it goes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>604536</commentid>
    <comment_count>6</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-04-17 17:59:47 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; omg did I write that? :-D
&gt; 
&gt; Thanks for fixing, let me know how it goes.

Seems to work fine.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>137637</attachid>
            <date>2012-04-17 16:49:38 -0700</date>
            <delta_ts>2012-04-17 17:29:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-84213-20120417164937.patch</filename>
            <type>text/plain</type>
            <size>1664</size>
            <attacher name="Dirk Pranke">dpranke</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NDY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzMxNzM2NWI3ZjBkZDhlZTdmZTE0OWQxMmQ4MDNmYzU5
ZWY1OWQzZi4uYzA3ZGZmNThkNTkyMDljYWE0NjE2ZjVkMWJiOGE5ODg5MmExMGQ5NCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2
IEBACisyMDEyLTA0LTE3ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg
ICAgICAgIGJ1aWxkLXdlYmtpdDogbWFrZSBuaW5qYSB3b3JrIHdpdGggY2hyb21pdW0gbGludXgK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjEzCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHR5cG9z
IHNvIHRoYXQgYnVpbGQtd2Via2l0IHdpbGwgdXNlIG5pbmphIHRvCisgICAgICAgIGJ1aWxkIGNo
cm9taXVtIGlmIGEgYnVpbGQubmluamEgZmlsZSBleGlzdHMgYW5kIGlzIHVwLXRvLWRhdGUuCisK
KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChkZXRlcm1pbmVJc0No
cm9taXVtTmluamEpOgorCiAyMDEyLTA0LTE3ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5v
cmc+CiAKICAgICAgICAgQWRkIGNhY2hpbmcgdG8gdGhlIGZsYWtpbmVzcyBkYXNoYm9hcmQganNv
biBmaWxlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMv
U2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDgxMjEzNTczZDcxNGM1NTRiMWI4Njc5MzMwNTMz
ODI4NjFiOTNjZmYuLmIxZTI1MTI3OGZhYzA1MzMwMmYzNDg4YmE1MWJkNGRiNTE3ZmQzZTQgMTAw
NzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRz
L3dlYmtpdGRpcnMucG0KQEAgLTExNTYsNyArMTE1Niw3IEBAIHN1YiBkZXRlcm1pbmVJc0Nocm9t
aXVtTmluamEoKQogCiAgICAgbXkgJGhhc1VwVG9EYXRlTmluamFidWlsZCA9IDA7CiAgICAgaWYg
KC1lICJvdXQvJGNvbmZpZy9idWlsZC5uaW5qYSIpIHsKLSAgICAgICAgbXkgJHN0YXROaW5qYSA9
IHN0YXQoIm91dC8kY29uZmlnL2J1aWxkLm5pbmphIik7CisgICAgICAgIG15ICRzdGF0TmluamEg
PSBzdGF0KCJvdXQvJGNvbmZpZy9idWlsZC5uaW5qYSIpLT5tdGltZTsKIAogICAgICAgICBteSAk
c3RhdFhjb2RlID0gMDsKICAgICAgICAgaWYgKC1lICdTb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dl
YktpdC54Y29kZXByb2onKSB7CkBAIC0xMTY1LDcgKzExNjUsNyBAQCBzdWIgZGV0ZXJtaW5lSXND
aHJvbWl1bU5pbmphKCkKIAogICAgICAgICBteSAkc3RhdE1ha2UgPSAwOwogICAgICAgICBpZiAo
LWUgJ01ha2VmaWxlLmNocm9taXVtJykgewotICAgICAgICAgICRzdGF0WGNvZGUgPSBzdGF0KCdN
YWtlZmlsZS5jaHJvbWl1bScpLT5tdGltZTsKKyAgICAgICAgICAkc3RhdE1ha2UgPSBzdGF0KCdN
YWtlZmlsZS5jaHJvbWl1bScpLT5tdGltZTsKICAgICAgICAgfQogCiAgICAgICAgICRoYXNVcFRv
RGF0ZU5pbmphYnVpbGQgPSAkc3RhdE5pbmphID4gJHN0YXRYY29kZSAmJiAkc3RhdE5pbmphID4g
JHN0YXRNYWtlOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>