84203 2012-04-17 15:34:49 -0700 Layout Test svg/transforms/transform-origin-css-property.xhtml is failing 2012-05-22 14:16:23 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 scheib schenney fmalita giles_joplin krit schenney zimmermann oldest_to_newest 604406 0 scheib 2012-04-17 15:34:49 -0700 The following layout ref test is failing on Chromium all platforms. svg/transforms/transform-origin-css-property.xhtml See: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=svg%2Ftransforms%2Ftransform-origin-css-property.xhtml Looks like an anti-aliasing or a small horizontal offset issue. Test was introduced in https://bugs.webkit.org/show_bug.cgi?id=79068 and not modified since. Note, Chromium has pixel test variations checked in --- not intended for a ref test. http://trac.webkit.org/changeset/114416 Should be all ref-test or all pixel baselines, right? 604728 1 schenney 2012-04-18 07:55:56 -0700 Committed r114503: <http://trac.webkit.org/changeset/114503> 604731 2 schenney 2012-04-18 07:57:27 -0700 Indeed, this test has a ref test and there should be no image baselines. I have removed the image baselines but left the expectation for failure. It may be a problem with the ref test result that requires further investigation. 604888 3 schenney 2012-04-18 10:56:33 -0700 Definitely a problem with the ref-test not matching. The test renders multiple svg rectangles rotated by 90 degrees with different transform-origin points, specified using different forms. e.g. ["50% 50%", "center 50%", "50% center", "center", "center center", [15, 15]] All of the rects in a set should appear right on top of each other. The ref-test just uses a single div with the % spec. My suspicion is that (15,15) is not the same as (50%,50%) when all is said and done. As this test is testing that SVG supports the property, I propose fixing it by changing the ref to print multiple divs using the same values as the test. I'll get a patch up. 604906 4 krit 2012-04-18 11:11:20 -0700 (In reply to comment #3) > Definitely a problem with the ref-test not matching. The test renders multiple svg rectangles rotated by 90 degrees with different transform-origin points, specified using different forms. e.g. > > ["50% 50%", "center 50%", "50% center", "center", "center center", [15, 15]] > > All of the rects in a set should appear right on top of each other. > > The ref-test just uses a single div with the % spec. > > My suspicion is that (15,15) is not the same as (50%,50%) when all is said and done. > > As this test is testing that SVG supports the property, I propose fixing it by changing the ref to print multiple divs using the same values as the test. > > I'll get a patch up. The idea of ref tests is that they are platform independent. If the test is failing on chromium, it should get onto the skip list and needs investigation. If it turns out that the test is wrong, the test should be changed. Don't create platform dependent ref files. 604935 5 137730 schenney 2012-04-18 11:35:54 -0700 Created attachment 137730 Patch 604942 6 schenney 2012-04-18 11:37:39 -0700 I have modified the ref-test to draw more divs, hopefully reproducing the behavior of the SVG rects. Review at will, but let's wait until the EWS bots get through it before we commit anything. I'm not sure it will behave on the build machines the same way it behaves locally. 604948 7 krit 2012-04-18 11:41:28 -0700 (In reply to comment #6) > I have modified the ref-test to draw more divs, hopefully reproducing the behavior of the SVG rects. Review at will, but let's wait until the EWS bots get through it before we commit anything. I'm not sure it will behave on the build machines the same way it behaves locally. Maybe I misunderstand what th problem is. Why do you draw more rects? It seems like you change the ref file to be a test itself. Which is not preferred either. 604957 8 schenney 2012-04-18 11:48:50 -0700 The issue is that apparently ["50% 50%", "center 50%", "50% center", "center", "center center", [15, 15]] are not all pixel equivalent when applied as transform-origin for rotate(90deg). That seems to be an issue in the code for parsing and applying "center" and "50% center". My reasoning applied to this patch is that we are testing whether or not SVG respects the transform-origin property. We are not testing that the various origin specifications (e.g. 50% vs. center) produce identical results. So I think it's OK to modify the test in this way. If we do care that all these transform-origin specs are identical, I suggest a different ref-test that uses fixed SVG rectangles in exactly the place we expect the transformed rect to be. But my guess is that it would be even harder to get platform agnostic results. Interestingly, apparently the CSS div does not respect [15,15] as an origin. Is that spec or a bug? 606624 9 137730 schenney 2012-04-20 09:16:04 -0700 Comment on attachment 137730 Patch Clearing flags on attachment: 137730 Committed r114752: <http://trac.webkit.org/changeset/114752> 606625 10 schenney 2012-04-20 09:16:09 -0700 All reviewed patches have been landed. Closing bug. 630744 11 fmalita 2012-05-22 14:16:23 -0700 *** Bug 83059 has been marked as a duplicate of this bug. *** 137730 2012-04-18 11:35:54 -0700 2012-04-20 09:16:04 -0700 Patch bug-84203-20120418143553.patch text/plain 3817 schenney SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDExNDUzNykKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTE4ICBTdGVwaGVuIENoZW5uZXkg IDxzY2hlbm5leUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgTGF5b3V0IFRlc3Qgc3ZnL3RyYW5z Zm9ybXMvdHJhbnNmb3JtLW9yaWdpbi1jc3MtcHJvcGVydHkueGh0bWwgaXMgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQyMDMKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3QgY29t cGFyZXMgQ1NTIGRpdidzIG4gYSByZWYtdGVzdCB3aXRoIGEgc2luZ2xlIHNwZWMgZm9yIHRyYW5z Zm9ybS1vcmlnaW4KKyAgICAgICAgdG8gU1ZHIHJlY3RzIHdpdGggbXVsdGlwZSBzcGVjcyBmb3Ig dHJhbnNmb3JtLW9yaWdpbiB0aGF0IGFyZSBzdXBwb3NlZAorICAgICAgICB0byBhbGwgYmUgZXF1 aXZhbGVudCwgc3VjaCBhcyBbNTAlLDUwJV0gYW5kIFtjZW50ZXIsIGNlbnRlcl0uIEl0IGZhaWxz CisgICAgICAgIGR1ZSB0byBvbmUtcGl4ZWwgZGlmZmVyZW5jZXMgb24gQ2hyb21pdW0uCisKKyAg ICAgICAgVGhpcyBjaGFuZ2UgcmVuZGVycyBhcyBtYW55IGRpdnMgaW4gdGhlIHJlZi10ZXN0IGFz IFNWRyByZWN0cyBpbiB0aGUKKyAgICAgICAgdGVzdCwgYW5kIGVuZHMgdXAgd2l0aCB0aGUgc2Ft ZSByZXN1bHQuIEl0IHNlZW1zIGxpa2VseSB0aGF0IG9uZSBvZgorICAgICAgICB0aGUgc2V2ZXJh bCBzcGVjcyB0aGF0IGFyZSB1c2VkIGlzIGNvbXB1dGVkIHNsaWdodGx5IGRpZmZlcmVudGx5Cisg ICAgICAgIChtYXliZSA1MCUgaXMgbm90IHRoZSBzYW1lIGFzIGNlbnRlcikuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQ6CisgICAgICAgICogc3Zn L3RyYW5zZm9ybXMvdHJhbnNmb3JtLW9yaWdpbi1jc3MtcHJvcGVydHktZXhwZWN0ZWQueGh0bWw6 CisKIDIwMTItMDQtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIEdUSyB0ZXN0X2V4cGVjdGF0aW9ucyB1cGRhdGUuCkluZGV4 OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlv bnMudHh0CShyZXZpc2lvbiAxMTQ1MzApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1 bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEyODUsOSArMTI4NSw2 IEBAIEJVR1dLODM3MTcgTEVPUEFSRCA6IHN2Zy9jdXN0b20vZm9yZWlnbi0KIAogQlVHV0s4Mzg3 NSBMSU5VWCA6IHN2Zy90ZXh0L2ZvbnQtc2l6ZS1iZWxvdy1wb2ludC1maXZlLnN2ZyA9IFBBU1Mg VEVYVAogCi0vLyBUaGUgcmVmIHRlc3QgaXMgZmFpbGluZz8gVmVyeSBvZGQgaWYgc28uCi1CVUdX Szg0MjAzIDogc3ZnL3RyYW5zZm9ybXMvdHJhbnNmb3JtLW9yaWdpbi1jc3MtcHJvcGVydHkueGh0 bWwgPSBJTUFHRQotCiAvLyBJdCBpcyB2ZXJ5IGhhcmQgdG8gc2VlIHdoeSBzb21lIG9mIHRoZXNl IGFyZSBmYWlsaW5nLiBUaGUgZGlmZiBtdXN0IGJlIHRpbnkgaW4gc29tZSBjYXNlcy4KIC8vIE90 aGVyIGZhaWwgaW50ZXJtaXR0ZW50bHkgaW4gYSB3YXkgdGhhdCBpcyBvZGQgLSBjbGlwcGluZyBh bmQgbWFza2luZyBzaG91bGQgYmUgc3RhYmxlLgogLy8gSXQgaXMgcHJvYmFibHkgYSB0ZXN0IGRl c2lnbiBmbGF3LgpJbmRleDogTGF5b3V0VGVzdHMvc3ZnL3RyYW5zZm9ybXMvdHJhbnNmb3JtLW9y aWdpbi1jc3MtcHJvcGVydHktZXhwZWN0ZWQueGh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvc3ZnL3RyYW5zZm9ybXMvdHJhbnNmb3JtLW9yaWdpbi1jc3MtcHJvcGVydHktZXhwZWN0ZWQu eGh0bWwJKHJldmlzaW9uIDExNDUzMCkKKysrIExheW91dFRlc3RzL3N2Zy90cmFuc2Zvcm1zL3Ry YW5zZm9ybS1vcmlnaW4tY3NzLXByb3BlcnR5LWV4cGVjdGVkLnhodG1sCSh3b3JraW5nIGNvcHkp CkBAIC0yMiwyMiArMjIsMjIgQEAKICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZGl2 Um9vdCIpLmFwcGVuZENoaWxkKGRpdik7CiAgICAgfQogCi0gICAgdmFyIHRyYW5zZm9ybU9yaWdp bnMgPSBbCi0gICAgICAgICAiNTAlIDUwJSIsCi0gICAgICAgICAiMCUgMCUiLAotICAgICAgICAg IjAlIDUwJSIsCi0gICAgICAgICAiMTAwJSAwJSIsCi0gICAgICAgICAiMCUgNTAlIiwKLSAgICAg ICAgICIxMDAlIDUwJSIsCi0gICAgICAgICAiMCUgMTAwJSIsCi0gICAgICAgICAiNTAlIDEwMCUi LAotICAgICAgICAgIjEwMCUgMTAwJSIsCisgICAgdmFyIGVxdWl2YWxlbnRUcmFuc2Zvcm1Pcmln aW5zID0gWworICAgICAgICAgWyI1MCUgNTAlIiwgImNlbnRlciA1MCUiLCAiNTAlIGNlbnRlciIs ICJjZW50ZXIiLCAiY2VudGVyIGNlbnRlciJdLAorICAgICAgICAgWyIwJSAwJSIsICJsZWZ0IDAl IiwgIjAlIHRvcCIsICJsZWZ0IHRvcCIsICJ0b3AgbGVmdCJdLAorICAgICAgICAgWyIwJSA1MCUi LCAibGVmdCA1MCUiLCAiMCUgY2VudGVyIiwgImxlZnQiLCAibGVmdCBjZW50ZXIiLCAiY2VudGVy IGxlZnQiXSwKKyAgICAgICAgIFsiMTAwJSAwJSIsICJyaWdodCAwJSIsICIxMDAlIHRvcCIsICJy aWdodCB0b3AiLCAidG9wIHJpZ2h0Il0sCisgICAgICAgICBbIjAlIDUwJSIsICJsZWZ0IDUwJSIs ICIwJSBjZW50ZXIiLCAibGVmdCBjZW50ZXIiLCAiY2VudGVyIGxlZnQiXSwKKyAgICAgICAgIFsi MTAwJSA1MCUiLCAicmlnaHQgNTAlIiwgIjEwMCUgY2VudGVyIiwgInJpZ2h0IGNlbnRlciIsICJj ZW50ZXIgcmlnaHQiXSwKKyAgICAgICAgIFsiMCUgMTAwJSIsICJsZWZ0IDEwMCUiLCAiMCUgYm90 dG9tIiwgImxlZnQgYm90dG9tIiwgImxlZnQgYm90dG9tIl0sCisgICAgICAgICBbIjUwJSAxMDAl IiwgImNlbnRlciAxMDAlIiwgIjUwJSBib3R0b20iLCAiYm90dG9tIiwgImNlbnRlciBib3R0b20i LCAiYm90dG9tIGNlbnRlciJdLAorICAgICAgICAgWyIxMDAlIDEwMCUiLCAicmlnaHQgMTAwJSIs ICIxMDAlIGJvdHRvbSIsICJyaWdodCBib3R0b20iLCAiYm90dG9tIHJpZ2h0Il0KICAgICAgXTsK IAotICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRyYW5zZm9ybU9yaWdpbnMubGVuZ3RoOyBpKysp ICB7CisgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZXF1aXZhbGVudFRyYW5zZm9ybU9yaWdpbnMu bGVuZ3RoOyBpKyspICB7CiAgICAgICAgICB2YXIgeCA9IDYwICsgKGkgJSAgNCkgKiA2MDsKICAg ICAgICAgIHZhciB5ID0gNjAgKyBNYXRoLmZsb29yKGkgLyA0KSAqIDYwOwotICAgICAgICAgYWRk VHJhbnNmb3JtT3JpZ2luRGl2KHgsIHksIHRyYW5zZm9ybU9yaWdpbnNbaV0pOworICAgICAgICAg ZXF1aXZhbGVudFRyYW5zZm9ybU9yaWdpbnNbaV0ubWFwKCBmdW5jdGlvbihzKSB7IGFkZFRyYW5z Zm9ybU9yaWdpbkRpdih4LCB5LCBzKTsgfSApOwogICAgICB9CiAKICAgXV0+PC9zY3JpcHQ+Cg==