84200 2012-04-17 15:06:27 -0700 It should be possible to create an inheritorID for the global this object without crashing 2012-04-17 16:04:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 fpizlo webkit-unassigned webkit.review.bot oldest_to_newest 604385 0 fpizlo 2012-04-17 15:06:27 -0700 The global this object has a structure that has a null global object. That makes sense since there is no one global object that the structure could be associated with. But what doesn't make sense is that this leads to the inheritorID structure created for objects that have the global this object as their prototype also having a null global object, which then results in hilarity and badness when any operation is performed on those objects that expects to be able to query the global object via the structure. 604386 1 fpizlo 2012-04-17 15:06:35 -0700 <rdar://problem/11251082> 604388 2 137615 fpizlo 2012-04-17 15:08:15 -0700 Created attachment 137615 the patch 604390 3 137616 fpizlo 2012-04-17 15:10:52 -0700 Created attachment 137616 the patch 604394 4 webkit.review.bot 2012-04-17 15:14:23 -0700 Attachment 137616 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/runtime/JSGlobalThis.h:68: The parameter name "globalData" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/JSGlobalThis.h:68: The parameter name "globalObject" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style. 604416 5 137616 buildbot 2012-04-17 15:43:02 -0700 Comment on attachment 137616 the patch Attachment 137616 did not pass win-ews (win): Output: http://queues.webkit.org/results/12415987 604433 6 fpizlo 2012-04-17 16:02:11 -0700 Landed in http://trac.webkit.org/changeset/114457 604438 7 fpizlo 2012-04-17 16:04:06 -0700 Windows build fix: http://trac.webkit.org/changeset/114459 137615 2012-04-17 15:08:15 -0700 2012-04-17 15:10:52 -0700 the patch globalthis_patch_1.diff text/plain 6358 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0NDQwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDEyLTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNyZWF0ZSBhbiBpbmhlcml0b3JJRCBmb3IgdGhlIGds b2JhbCB0aGlzIG9iamVjdCB3aXRob3V0IGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDIwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTEyNTEwODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBydW50aW1lL0pTR2xvYmFsVGhpcy5jcHA6CisgICAgICAgIChKU0M6OkpTR2xvYmFsVGhp czo6c2V0VW53cmFwcGVkT2JqZWN0KToKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsVGhpcy5o OgorICAgICAgICAoSlNDOjpKU0dsb2JhbFRoaXM6OmNyZWF0ZSk6CisgICAgICAgIChKU0M6OkpT R2xvYmFsVGhpczo6dW53cmFwcGVkT2JqZWN0KToKKyAgICAgICAgKEpTR2xvYmFsVGhpcyk6Cisg ICAgICAgICogcnVudGltZS9KU09iamVjdC5jcHA6CisgICAgICAgIChKU0M6OkpTT2JqZWN0Ojpj cmVhdGVJbmhlcml0b3JJRCk6CisgICAgICAgICogcnVudGltZS9KU09iamVjdC5oOgorICAgICAg ICAoSlNPYmplY3QpOgorICAgICAgICAoSlNDOjpKU09iamVjdDo6cmVzZXRJbmhlcml0b3JJRCk6 CisKIDIwMTItMDQtMTcgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAg ICBERkcgYW5kIExMSW50IHNob3VsZCBub3QgY2xvYmJlciB0aGUgZnJhbWUgcG9pbnRlciBvbiBB Uk12NwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxUaGlzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbFRo aXMuY3BwCShyZXZpc2lvbiAxMTQ0MTIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9KU0dsb2JhbFRoaXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCw5ICs0OCwxMiBAQCB2b2lk IEpTR2xvYmFsVGhpczo6dmlzaXRDaGlsZHJlbihKU0NlbGwqCiAgICAgICAgIHZpc2l0b3IuYXBw ZW5kKCZ0aGlzT2JqZWN0LT5tX3Vud3JhcHBlZE9iamVjdCk7CiB9CiAKLUpTR2xvYmFsT2JqZWN0 KiBKU0dsb2JhbFRoaXM6OnVud3JhcHBlZE9iamVjdCgpCit2b2lkIEpTR2xvYmFsVGhpczo6c2V0 VW53cmFwcGVkT2JqZWN0KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgSlNHbG9iYWxPYmplY3Qq IGdsb2JhbE9iamVjdCkKIHsKLSAgICByZXR1cm4gbV91bndyYXBwZWRPYmplY3QuZ2V0KCk7Cisg ICAgQVNTRVJUX0FSRyhnbG9iYWxPYmplY3QsIGdsb2JhbE9iamVjdCk7CisgICAgbV91bndyYXBw ZWRPYmplY3Quc2V0KGdsb2JhbERhdGEsIHRoaXMsIGdsb2JhbE9iamVjdCk7CisgICAgc2V0UHJv dG90eXBlKGdsb2JhbERhdGEsIGdsb2JhbE9iamVjdC0+cHJvdG90eXBlKCkpOworICAgIHJlc2V0 SW5oZXJpdG9ySUQoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbFRoaXMuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbFRoaXMuaAkocmV2aXNpb24gMTE0NDEyKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxUaGlzLmgJKHdvcmtpbmcg Y29weSkKQEAgLTM2LDYgKzM2LDcgQEAgcHVibGljOgogCiAgICAgc3RhdGljIEpTR2xvYmFsVGhp cyogY3JlYXRlKEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUp CiAgICAgeworICAgICAgICBBU1NFUlQoc3RydWN0dXJlLT5nbG9iYWxPYmplY3QoKSk7CiAgICAg ICAgIEpTR2xvYmFsVGhpcyogZ2xvYmFsVGhpcyA9IG5ldyAoTm90TnVsbCwgYWxsb2NhdGVDZWxs PEpTR2xvYmFsVGhpcz4oZ2xvYmFsRGF0YS5oZWFwKSkgSlNHbG9iYWxUaGlzKGdsb2JhbERhdGEs IHN0cnVjdHVyZSk7CiAgICAgICAgIGdsb2JhbFRoaXMtPmZpbmlzaENyZWF0aW9uKGdsb2JhbERh dGEpOwogICAgICAgICByZXR1cm4gZ2xvYmFsVGhpczsKQEAgLTQ4LDcgKzQ5LDcgQEAgcHVibGlj OgogCiAgICAgc3RhdGljIEpTX0VYUE9SVERBVEEgY29uc3QgSlNDOjpDbGFzc0luZm8gc19pbmZv OwogCi0gICAgSlNHbG9iYWxPYmplY3QqIHVud3JhcHBlZE9iamVjdCgpOworICAgIEpTR2xvYmFs T2JqZWN0KiB1bndyYXBwZWRPYmplY3QoKSBjb25zdCB7IHJldHVybiBtX3Vud3JhcHBlZE9iamVj dC5nZXQoKTsgfQogCiBwcm90ZWN0ZWQ6CiAgICAgSlNHbG9iYWxUaGlzKEpTR2xvYmFsRGF0YSYg Z2xvYmFsRGF0YSwgU3RydWN0dXJlKiBzdHJ1Y3R1cmUpCkBAIC02NSw2ICs2Niw5IEBAIHByb3Rl Y3RlZDoKIAogICAgIEpTX0VYUE9SVF9QUklWQVRFIHN0YXRpYyB2b2lkIHZpc2l0Q2hpbGRyZW4o SlNDZWxsKiwgU2xvdFZpc2l0b3ImKTsKIAorICAgIEpTX0VYUE9SVF9QUklWQVRFIHZvaWQgc2V0 VW53cmFwcGVkT2JqZWN0KEpTR2xvYmFsRGF0YSYgZ2xvYmFsRGF0YSwgSlNHbG9iYWxPYmplY3Qq IGdsb2JhbE9iamVjdCk7CisgICAgCitwcml2YXRlOgogICAgIFdyaXRlQmFycmllcjxKU0dsb2Jh bE9iamVjdD4gbV91bndyYXBwZWRPYmplY3Q7CiB9OwogCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9KU09iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCShyZXZpc2lvbiAxMTQ0MTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU0 MSw3ICs1NDEsMTMgQEAgTkVWRVJfSU5MSU5FIHZvaWQgSlNPYmplY3Q6OmZpbGxHZXR0ZXJQcgog CiBTdHJ1Y3R1cmUqIEpTT2JqZWN0OjpjcmVhdGVJbmhlcml0b3JJRChKU0dsb2JhbERhdGEmIGds b2JhbERhdGEpCiB7Ci0gICAgbV9pbmhlcml0b3JJRC5zZXQoZ2xvYmFsRGF0YSwgdGhpcywgY3Jl YXRlRW1wdHlPYmplY3RTdHJ1Y3R1cmUoZ2xvYmFsRGF0YSwgc3RydWN0dXJlKCktPmdsb2JhbE9i amVjdCgpLCB0aGlzKSk7CisgICAgSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdDsKKyAgICBp ZiAoaXNHbG9iYWxUaGlzKCkpCisgICAgICAgIGdsb2JhbE9iamVjdCA9IHN0YXRpY19jYXN0PEpT R2xvYmFsVGhpcyo+KHRoaXMpLT51bndyYXBwZWRPYmplY3QoKTsKKyAgICBlbHNlCisgICAgICAg IGdsb2JhbE9iamVjdCA9IHN0cnVjdHVyZSgpLT5nbG9iYWxPYmplY3QoKTsKKyAgICBBU1NFUlQo Z2xvYmFsT2JqZWN0KTsKKyAgICBtX2luaGVyaXRvcklELnNldChnbG9iYWxEYXRhLCB0aGlzLCBj cmVhdGVFbXB0eU9iamVjdFN0cnVjdHVyZShnbG9iYWxEYXRhLCBnbG9iYWxPYmplY3QsIHRoaXMp KTsKICAgICBBU1NFUlQobV9pbmhlcml0b3JJRC0+aXNFbXB0eSgpKTsKICAgICByZXR1cm4gbV9p bmhlcml0b3JJRC5nZXQoKTsKIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0pTT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv SlNPYmplY3QuaAkocmV2aXNpb24gMTE0NDEyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtMjY0LDYgKzI2NCwxMSBAQCBuYW1l c3BhY2UgSlNDIHsKICAgICAgICAgLy8gVG8gaW5zdGFudGlhdGUgb2JqZWN0cyB5b3UgbGlrZWx5 IHdhbnQgSlNGaW5hbE9iamVjdCwgYmVsb3cuCiAgICAgICAgIC8vIFRvIGNyZWF0ZSBkZXJpdmVk IHR5cGVzIHlvdSBsaWtlbHkgd2FudCBKU05vbkZpbmFsT2JqZWN0LCBiZWxvdy4KICAgICAgICAg SlNPYmplY3QoSlNHbG9iYWxEYXRhJiwgU3RydWN0dXJlKiwgUHJvcGVydHlTdG9yYWdlIGlubGlu ZVN0b3JhZ2UpOworICAgICAgICAKKyAgICAgICAgdm9pZCByZXNldEluaGVyaXRvcklEKCkKKyAg ICAgICAgeworICAgICAgICAgICAgbV9pbmhlcml0b3JJRC5jbGVhcigpOworICAgICAgICB9CiAK ICAgICBwcml2YXRlOgogICAgICAgICBmcmllbmQgY2xhc3MgTExJbnRPZmZzZXRzRXh0cmFjdG9y OwpJbmRleDogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0NDQwKQorKysgU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMTcgIEZpbGlw IFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBJdCBzaG91bGQgYmUgcG9zc2li bGUgdG8gY3JlYXRlIGFuIGluaGVyaXRvcklEIGZvciB0aGUgZ2xvYmFsIHRoaXMgb2JqZWN0IHdp dGhvdXQgY3Jhc2hpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTg0MjAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xMTI1MTA4Mj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGJl Y2F1c2UgdGhlIGNpcmN1bXN0YW5jZXMgbmVjZXNzYXJ5IHRvIG1ha2UgdGhpcyBoYXBwZW4gYXJl IHJhdGhlciBoYWlyeS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTRE9NV2luZG93U2hlbGwu aDoKKyAgICAgICAgKFdlYkNvcmU6OkpTRE9NV2luZG93U2hlbGw6OndpbmRvdyk6CisgICAgICAg IChXZWJDb3JlOjpKU0RPTVdpbmRvd1NoZWxsOjpzZXRXaW5kb3cpOgorCiAyMDEyLTA0LTE3ICBL ZW50YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbVjhdIFBhc3Mg SXNvbGF0ZSB0byB0b1Y4U2xvdygpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RPTVdpbmRvd1NoZWxsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNET01XaW5kb3dTaGVsbC5oCShyZXZpc2lvbiAxMTQ0MTIpCisrKyBTb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd1NoZWxsLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzLDEy ICs0MywxMSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIEpTRE9NV2luZG93U2hlbGwo UGFzc1JlZlB0cjxET01XaW5kb3c+LCBKU0M6OlN0cnVjdHVyZSosIERPTVdyYXBwZXJXb3JsZCop OwogICAgICAgICBzdGF0aWMgdm9pZCBkZXN0cm95KEpTQ2VsbCopOwogCi0gICAgICAgIEpTRE9N V2luZG93KiB3aW5kb3coKSBjb25zdCB7IHJldHVybiBKU0M6OmpzQ2FzdDxKU0RPTVdpbmRvdyo+ KG1fdW53cmFwcGVkT2JqZWN0LmdldCgpKTsgfQorICAgICAgICBKU0RPTVdpbmRvdyogd2luZG93 KCkgY29uc3QgeyByZXR1cm4gSlNDOjpqc0Nhc3Q8SlNET01XaW5kb3cqPih1bndyYXBwZWRPYmpl Y3QoKSk7IH0KICAgICAgICAgdm9pZCBzZXRXaW5kb3coSlNDOjpKU0dsb2JhbERhdGEmIGdsb2Jh bERhdGEsIEpTRE9NV2luZG93KiB3aW5kb3cpCiAgICAgICAgIHsKICAgICAgICAgICAgIEFTU0VS VF9BUkcod2luZG93LCB3aW5kb3cpOwotICAgICAgICAgICAgbV91bndyYXBwZWRPYmplY3Quc2V0 KGdsb2JhbERhdGEsIHRoaXMsIHdpbmRvdyk7Ci0gICAgICAgICAgICBzZXRQcm90b3R5cGUoZ2xv YmFsRGF0YSwgd2luZG93LT5wcm90b3R5cGUoKSk7CisgICAgICAgICAgICBzZXRVbndyYXBwZWRP YmplY3QoZ2xvYmFsRGF0YSwgd2luZG93KTsKICAgICAgICAgfQogICAgICAgICB2b2lkIHNldFdp bmRvdyhQYXNzUmVmUHRyPERPTVdpbmRvdz4pOwogCg== 137616 2012-04-17 15:10:52 -0700 2012-04-17 15:43:02 -0700 the patch globalthis_patch_2.diff text/plain 5951 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0NDQwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDEyLTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg SXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNyZWF0ZSBhbiBpbmhlcml0b3JJRCBmb3IgdGhlIGds b2JhbCB0aGlzIG9iamVjdCB3aXRob3V0IGNyYXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDIwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MTEyNTEwODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBydW50aW1lL0pTR2xvYmFsVGhpcy5jcHA6CisgICAgICAgIChKU0M6OkpTR2xvYmFsVGhp czo6c2V0VW53cmFwcGVkT2JqZWN0KToKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsVGhpcy5o OgorICAgICAgICAoSlNDOjpKU0dsb2JhbFRoaXM6OnVud3JhcHBlZE9iamVjdCk6CisgICAgICAg IChKU0dsb2JhbFRoaXMpOgorICAgICAgICAqIHJ1bnRpbWUvSlNPYmplY3QuY3BwOgorICAgICAg ICAoSlNDOjpKU09iamVjdDo6Y3JlYXRlSW5oZXJpdG9ySUQpOgorICAgICAgICAqIHJ1bnRpbWUv SlNPYmplY3QuaDoKKyAgICAgICAgKEpTT2JqZWN0KToKKyAgICAgICAgKEpTQzo6SlNPYmplY3Q6 OnJlc2V0SW5oZXJpdG9ySUQpOgorCiAyMDEyLTA0LTE3ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0Bh cHBsZS5jb20+CiAKICAgICAgICAgREZHIGFuZCBMTEludCBzaG91bGQgbm90IGNsb2JiZXIgdGhl IGZyYW1lIHBvaW50ZXIgb24gQVJNdjcKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTR2xvYmFsVGhpcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvSlNHbG9iYWxUaGlzLmNwcAkocmV2aXNpb24gMTE0NDEyKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxUaGlzLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDgsOSArNDgsMTIgQEAgdm9pZCBKU0dsb2JhbFRoaXM6OnZpc2l0Q2hpbGRyZW4oSlNDZWxsKgog ICAgICAgICB2aXNpdG9yLmFwcGVuZCgmdGhpc09iamVjdC0+bV91bndyYXBwZWRPYmplY3QpOwog fQogCi1KU0dsb2JhbE9iamVjdCogSlNHbG9iYWxUaGlzOjp1bndyYXBwZWRPYmplY3QoKQordm9p ZCBKU0dsb2JhbFRoaXM6OnNldFVud3JhcHBlZE9iamVjdChKU0dsb2JhbERhdGEmIGdsb2JhbERh dGEsIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCiB7Ci0gICAgcmV0dXJuIG1fdW53cmFw cGVkT2JqZWN0LmdldCgpOworICAgIEFTU0VSVF9BUkcoZ2xvYmFsT2JqZWN0LCBnbG9iYWxPYmpl Y3QpOworICAgIG1fdW53cmFwcGVkT2JqZWN0LnNldChnbG9iYWxEYXRhLCB0aGlzLCBnbG9iYWxP YmplY3QpOworICAgIHNldFByb3RvdHlwZShnbG9iYWxEYXRhLCBnbG9iYWxPYmplY3QtPnByb3Rv dHlwZSgpKTsKKyAgICByZXNldEluaGVyaXRvcklEKCk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIEpT QwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxUaGlzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxUaGlzLmgJ KHJldmlzaW9uIDExNDQxMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xv YmFsVGhpcy5oCSh3b3JraW5nIGNvcHkpCkBAIC00OCw3ICs0OCw3IEBAIHB1YmxpYzoKIAogICAg IHN0YXRpYyBKU19FWFBPUlREQVRBIGNvbnN0IEpTQzo6Q2xhc3NJbmZvIHNfaW5mbzsKIAotICAg IEpTR2xvYmFsT2JqZWN0KiB1bndyYXBwZWRPYmplY3QoKTsKKyAgICBKU0dsb2JhbE9iamVjdCog dW53cmFwcGVkT2JqZWN0KCkgY29uc3QgeyByZXR1cm4gbV91bndyYXBwZWRPYmplY3QuZ2V0KCk7 IH0KIAogcHJvdGVjdGVkOgogICAgIEpTR2xvYmFsVGhpcyhKU0dsb2JhbERhdGEmIGdsb2JhbERh dGEsIFN0cnVjdHVyZSogc3RydWN0dXJlKQpAQCAtNjUsNiArNjUsOSBAQCBwcm90ZWN0ZWQ6CiAK ICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgdm9pZCB2aXNpdENoaWxkcmVuKEpTQ2VsbCos IFNsb3RWaXNpdG9yJik7CiAKKyAgICBKU19FWFBPUlRfUFJJVkFURSB2b2lkIHNldFVud3JhcHBl ZE9iamVjdChKU0dsb2JhbERhdGEmIGdsb2JhbERhdGEsIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxP YmplY3QpOworICAgIAorcHJpdmF0ZToKICAgICBXcml0ZUJhcnJpZXI8SlNHbG9iYWxPYmplY3Q+ IG1fdW53cmFwcGVkT2JqZWN0OwogfTsKIApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvSlNPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0pTT2JqZWN0LmNwcAkocmV2aXNpb24gMTE0NDEyKQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NDEsNyArNTQx LDEzIEBAIE5FVkVSX0lOTElORSB2b2lkIEpTT2JqZWN0OjpmaWxsR2V0dGVyUHIKIAogU3RydWN0 dXJlKiBKU09iamVjdDo6Y3JlYXRlSW5oZXJpdG9ySUQoSlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRh KQogewotICAgIG1faW5oZXJpdG9ySUQuc2V0KGdsb2JhbERhdGEsIHRoaXMsIGNyZWF0ZUVtcHR5 T2JqZWN0U3RydWN0dXJlKGdsb2JhbERhdGEsIHN0cnVjdHVyZSgpLT5nbG9iYWxPYmplY3QoKSwg dGhpcykpOworICAgIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3Q7CisgICAgaWYgKGlzR2xv YmFsVGhpcygpKQorICAgICAgICBnbG9iYWxPYmplY3QgPSBzdGF0aWNfY2FzdDxKU0dsb2JhbFRo aXMqPih0aGlzKS0+dW53cmFwcGVkT2JqZWN0KCk7CisgICAgZWxzZQorICAgICAgICBnbG9iYWxP YmplY3QgPSBzdHJ1Y3R1cmUoKS0+Z2xvYmFsT2JqZWN0KCk7CisgICAgQVNTRVJUKGdsb2JhbE9i amVjdCk7CisgICAgbV9pbmhlcml0b3JJRC5zZXQoZ2xvYmFsRGF0YSwgdGhpcywgY3JlYXRlRW1w dHlPYmplY3RTdHJ1Y3R1cmUoZ2xvYmFsRGF0YSwgZ2xvYmFsT2JqZWN0LCB0aGlzKSk7CiAgICAg QVNTRVJUKG1faW5oZXJpdG9ySUQtPmlzRW1wdHkoKSk7CiAgICAgcmV0dXJuIG1faW5oZXJpdG9y SUQuZ2V0KCk7CiB9CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVj dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0 LmgJKHJldmlzaW9uIDExNDQxMikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pT T2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTI2NCw2ICsyNjQsMTEgQEAgbmFtZXNwYWNlIEpT QyB7CiAgICAgICAgIC8vIFRvIGluc3RhbnRpYXRlIG9iamVjdHMgeW91IGxpa2VseSB3YW50IEpT RmluYWxPYmplY3QsIGJlbG93LgogICAgICAgICAvLyBUbyBjcmVhdGUgZGVyaXZlZCB0eXBlcyB5 b3UgbGlrZWx5IHdhbnQgSlNOb25GaW5hbE9iamVjdCwgYmVsb3cuCiAgICAgICAgIEpTT2JqZWN0 KEpTR2xvYmFsRGF0YSYsIFN0cnVjdHVyZSosIFByb3BlcnR5U3RvcmFnZSBpbmxpbmVTdG9yYWdl KTsKKyAgICAgICAgCisgICAgICAgIHZvaWQgcmVzZXRJbmhlcml0b3JJRCgpCisgICAgICAgIHsK KyAgICAgICAgICAgIG1faW5oZXJpdG9ySUQuY2xlYXIoKTsKKyAgICAgICAgfQogCiAgICAgcHJp dmF0ZToKICAgICAgICAgZnJpZW5kIGNsYXNzIExMSW50T2Zmc2V0c0V4dHJhY3RvcjsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDExNDQ0MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTE3ICBGaWxpcCBQaXpsbyAg PGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAgSXQgc2hvdWxkIGJlIHBvc3NpYmxlIHRvIGNy ZWF0ZSBhbiBpbmhlcml0b3JJRCBmb3IgdGhlIGdsb2JhbCB0aGlzIG9iamVjdCB3aXRob3V0IGNy YXNoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04 NDIwMAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTEyNTEwODI+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBiZWNhdXNlIHRo ZSBjaXJjdW1zdGFuY2VzIG5lY2Vzc2FyeSB0byBtYWtlIHRoaXMgaGFwcGVuIGFyZSByYXRoZXIg aGFpcnkuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd1NoZWxsLmg6CisgICAg ICAgIChXZWJDb3JlOjpKU0RPTVdpbmRvd1NoZWxsOjp3aW5kb3cpOgorICAgICAgICAoV2ViQ29y ZTo6SlNET01XaW5kb3dTaGVsbDo6c2V0V2luZG93KToKKwogMjAxMi0wNC0xNyAgS2VudGFybyBI YXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4XSBQYXNzIElzb2xhdGUg dG8gdG9WOFNsb3coKQpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01XaW5k b3dTaGVsbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9N V2luZG93U2hlbGwuaAkocmV2aXNpb24gMTE0NDEyKQorKysgU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvanMvSlNET01XaW5kb3dTaGVsbC5oCSh3b3JraW5nIGNvcHkpCkBAIC00MywxMiArNDMsMTEg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBKU0RPTVdpbmRvd1NoZWxsKFBhc3NSZWZQ dHI8RE9NV2luZG93PiwgSlNDOjpTdHJ1Y3R1cmUqLCBET01XcmFwcGVyV29ybGQqKTsKICAgICAg ICAgc3RhdGljIHZvaWQgZGVzdHJveShKU0NlbGwqKTsKIAotICAgICAgICBKU0RPTVdpbmRvdyog d2luZG93KCkgY29uc3QgeyByZXR1cm4gSlNDOjpqc0Nhc3Q8SlNET01XaW5kb3cqPihtX3Vud3Jh cHBlZE9iamVjdC5nZXQoKSk7IH0KKyAgICAgICAgSlNET01XaW5kb3cqIHdpbmRvdygpIGNvbnN0 IHsgcmV0dXJuIEpTQzo6anNDYXN0PEpTRE9NV2luZG93Kj4odW53cmFwcGVkT2JqZWN0KCkpOyB9 CiAgICAgICAgIHZvaWQgc2V0V2luZG93KEpTQzo6SlNHbG9iYWxEYXRhJiBnbG9iYWxEYXRhLCBK U0RPTVdpbmRvdyogd2luZG93KQogICAgICAgICB7CiAgICAgICAgICAgICBBU1NFUlRfQVJHKHdp bmRvdywgd2luZG93KTsKLSAgICAgICAgICAgIG1fdW53cmFwcGVkT2JqZWN0LnNldChnbG9iYWxE YXRhLCB0aGlzLCB3aW5kb3cpOwotICAgICAgICAgICAgc2V0UHJvdG90eXBlKGdsb2JhbERhdGEs IHdpbmRvdy0+cHJvdG90eXBlKCkpOworICAgICAgICAgICAgc2V0VW53cmFwcGVkT2JqZWN0KGds b2JhbERhdGEsIHdpbmRvdyk7CiAgICAgICAgIH0KICAgICAgICAgdm9pZCBzZXRXaW5kb3coUGFz c1JlZlB0cjxET01XaW5kb3c+KTsKIAo=