84199 2012-04-17 15:04:15 -0700 [BlackBerry] Viewport metatag doesn't disable double-tap zoom 2012-04-17 23:39:56 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jkjiang jkjiang rwlbuis staikos tonikitoo webkit.review.bot zimmermann oldest_to_newest 604381 0 jkjiang 2012-04-17 15:04:15 -0700 With the following viewport meta-tag, you can still double-tap zoom the page: <meta name="viewport" content="user-scalable=no, target-density-dpi=device-dpi, width=device-width"> 604595 1 137654 jkjiang 2012-04-17 22:28:51 -0700 Created attachment 137654 Patch 604611 2 137654 webkit.review.bot 2012-04-17 23:39:52 -0700 Comment on attachment 137654 Patch Clearing flags on attachment: 137654 Committed r114488: <http://trac.webkit.org/changeset/114488> 604612 3 webkit.review.bot 2012-04-17 23:39:56 -0700 All reviewed patches have been landed. Closing bug. 137654 2012-04-17 22:28:51 -0700 2012-04-17 23:39:52 -0700 Patch bug-84199-20120418012850.patch text/plain 4936 jkjiang U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBhNmZiMjE2MTE3MTcyMjU5YmUxZDg4ZjRmMWJmYzlmYmNjYzEyYTU4Li4zYWRhOTAxZmNi ZjU0ZTk4N2Y5NGI5YTgwYTg4YWFhZjVkMmZlZTQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wNC0xNyAgSmFja3kgSmlhbmcgIDx6aGFqaWFu Z0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBWaWV3cG9ydCBtZXRhdGFnIGRvZXNu J3QgZGlzYWJsZSBkb3VibGUtdGFwIHpvb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg0MTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUFI6IDE0ODI3OQorICAgICAgICBXaGVuIHdlIHNldCAidXNlci1z Y2FsYWJsZT1ubyIgaW4gdmlld3BvcnQgbWV0YS10YWcgYW5kIGNoYW5nZSBhbnkKKyAgICAgICAg b3RoZXIgV2ViU2V0dGluZ3MsIHRoZSBXZWJQYWdlIGNhbiB0dXJuIHRvIGJlIHNjYWxhYmxlLgor ICAgICAgICBUaGlzIGlzIGEgcmVncmVzc2lvbiBvZiB0aGUgY2hhbmdlIG1hc3Rlcl8zMi9TSEE6 ZmEwZjhlZTkuIEluIHRoYXQKKyAgICAgICAgY2hhbmdlLCB3ZSB1c2VkIHNldFVzZXJTY2FsYWJs ZSh3ZWJTZXR0aW5ncy0+aXNVc2VyU2NhbGFibGUoKSkKKyAgICAgICAgaW4gV2ViUGFnZVByaXZh dGU6OmRpZENoYW5nZVNldHRpbmdzIHdoaWNoIHdhcyBpbmNvcnJlY3QgZm9yIG5vbi1EUlQKKyAg ICAgICAgY2FzZSwgYXMgd2ViU2V0dGluZ3MtPmlzVXNlclNjYWxhYmxlKCkgd291bGQgYWx3YXlz IHJldHVybiB0cnVlIGJ5CisgICAgICAgIGRlZmF1bHQuCisgICAgICAgIENyZWF0ZSBhIG5ldyBB UEkgV2ViUGFnZTo6c2V0VXNlclNjYWxhYmxlIHdoaWNoIHdpbGwgYmUgdXNlZCBpbgorICAgICAg ICBEdW1wUmVuZGVyVHJlZS5jcHAuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAg ICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2U6OnNldFVzZXJTY2FsYWJsZSk6CisgICAg ICAgIChXZWJLaXQpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpXZWJQYWdlUHJpdmF0 ZTo6ZGlkQ2hhbmdlU2V0dGluZ3MpOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTIt MDQtMTcgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tC ZXJyeV0gUGF0dGVybiBtYXRjaGluZyBzaG91bGQgYmUgYXBwbGllZCB0byBudW1iZXJzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAppbmRleCA2MzA5ZjlkZDNkYjMyZjFi Y2NiNTJhNzFiNDYwNTlmMWZjNTRhMzFlLi4zMGE3MTBiYjAxNjNjODk1N2NjNzA3ZjdhM2ViYzAz ZWUwNDlkNmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKQEAg LTE1NzUsNiArMTU3NSwxMSBAQCBib29sIFdlYlBhZ2U6OmlzVXNlclNjYWxhYmxlKCkgY29uc3QK ICAgICByZXR1cm4gZC0+aXNVc2VyU2NhbGFibGUoKTsKIH0KIAordm9pZCBXZWJQYWdlOjpzZXRV c2VyU2NhbGFibGUoYm9vbCB1c2VyU2NhbGFibGUpCit7CisgICAgZC0+c2V0VXNlclNjYWxhYmxl KHVzZXJTY2FsYWJsZSk7Cit9CisKIGRvdWJsZSBXZWJQYWdlOjpjdXJyZW50U2NhbGUoKSBjb25z dAogewogICAgIHJldHVybiBkLT5jdXJyZW50U2NhbGUoKTsKQEAgLTU2ODgsOSArNTY5Myw2IEBA IHZvaWQgV2ViUGFnZVByaXZhdGU6OmRpZENoYW5nZVNldHRpbmdzKFdlYlNldHRpbmdzKiB3ZWJT ZXR0aW5ncykKICAgICBjb3JlU2V0dGluZ3MtPnNldERvd25sb2FkYWJsZUJpbmFyeUZvbnRzRW5h YmxlZCh3ZWJTZXR0aW5ncy0+ZG93bmxvYWRhYmxlQmluYXJ5Rm9udHNFbmFibGVkKCkpOwogICAg IGNvcmVTZXR0aW5ncy0+c2V0U3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKG1fd2ViU2V0dGluZ3Mt PmlzU3BhdGlhbE5hdmlnYXRpb25FbmFibGVkKCkpOwogCi0gICAgLy8gVXNlclNjYWxhYmxlIHNo b3VsZCBiZSByZXNldCBieSBuZXcgc2V0dGluZ3MuCi0gICAgc2V0VXNlclNjYWxhYmxlKHdlYlNl dHRpbmdzLT5pc1VzZXJTY2FsYWJsZSgpKTsKLQogICAgIFdlYlN0cmluZyBzdHlsZXNoZWV0VVJM ID0gd2ViU2V0dGluZ3MtPnVzZXJTdHlsZVNoZWV0U3RyaW5nKCk7CiAgICAgaWYgKHN0eWxlc2hl ZXRVUkwuaXNFbXB0eSgpKQogICAgICAgICBzdHlsZXNoZWV0VVJMID0gd2ViU2V0dGluZ3MtPnVz ZXJTdHlsZVNoZWV0TG9jYXRpb24oKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5oIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdl LmgKaW5kZXggNzZjMzg2MzYxZDI0ZWZjYzhhOTFiMTQ0OWJlOTYwNTFmNzUxN2RjYi4uMTVkYzE3 MzFiNjFkNWExYTFkODEwYmRiOTdiNGFiMmFlNmZhNzA3ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L0FwaS9XZWJQYWdlLmgKQEAgLTE3NCw2ICsxNzQsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBw aW5jaFpvb21BYm91dFBvaW50KGRvdWJsZSBzY2FsZSwgaW50IHgsIGludCB5KTsKIAogICAgIGJv b2wgaXNVc2VyU2NhbGFibGUoKSBjb25zdDsKKyAgICB2b2lkIHNldFVzZXJTY2FsYWJsZShib29s KTsKICAgICBkb3VibGUgY3VycmVudFNjYWxlKCkgY29uc3Q7CiAgICAgZG91YmxlIGluaXRpYWxT Y2FsZSgpIGNvbnN0OwogICAgIGRvdWJsZSB6b29tVG9GaXRTY2FsZSgpIGNvbnN0OwpkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGZkZTg0YzZhOTBi MzRlNjZkNTY3NDJkMTQxMTU0N2VmN2U5ZDU3ZjMuLjczODg1ZmM5NTY1NWZjZTMyZTdkOTk3MGE2 YmVhYmQwMTJhMjYxZjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNC0xNyAgSmFja3kgSmlhbmcgIDx6aGFq aWFuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBWaWV3cG9ydCBtZXRhdGFnIGRv ZXNuJ3QgZGlzYWJsZSBkb3VibGUtdGFwIHpvb20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTk5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmV2ZXJ0IGEgcGFydCBvZiB0aGUgY2hhbmdlIG1hc3Rlcl8z Mi9TSEE6ZmEwZjhlZTkgYW5kIHVzZQorICAgICAgICBXZWJQYWdlOjpzZXRVc2VyU2NhbGFibGUg aW5zdGVhZC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRl clRyZWUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpEdW1wUmVuZGVyVHJlZTo6 cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcpOgorCiAyMDEyLTA0LTE3ICBEaXJr IFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGJ1aWxkLXdlYmtpdDog bWFrZSBuaW5qYSB3b3JrIHdpdGggY2hyb21pdW0gbGludXgKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1 bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvRHVtcFJlbmRlclRyZWUuY3BwIGIvVG9vbHMvRHVtcFJl bmRlclRyZWUvYmxhY2tiZXJyeS9EdW1wUmVuZGVyVHJlZS5jcHAKaW5kZXggNDFiOTkyMGMyYjdk ZTlkYmQwZmJiNDlmOTUzMTE0N2NkNTE2NDk4Ny4uYjU5ZDJmYzM1NzdiY2VhNTZkMjg0M2E5OWVm ZGUwM2QyNjgyMjRiMiAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJy eS9EdW1wUmVuZGVyVHJlZS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJy eS9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTI1OCw3ICsyNTgsNiBAQCB2b2lkIER1bXBSZW5kZXJU cmVlOjpyZXNldFRvQ29uc2lzdGVudFN0YXRlQmVmb3JlVGVzdGluZygpCiAgICAgc2V0dGluZ3Mt PnNldEZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoZmFsc2UpOwogICAgIHNldHRpbmdzLT5zZXRNYXhp bXVtUGFnZXNJbkNhY2hlKDApOwogICAgIHNldHRpbmdzLT5zZXRQbHVnaW5zRW5hYmxlZCh0cnVl KTsKLSAgICBzZXR0aW5ncy0+c2V0VXNlclNjYWxhYmxlKHRydWUpOwogICAgIC8vIEFwcGx5IG5l dyBzZXR0aW5ncyB0byBjdXJyZW50IHBhZ2UsIHNlZSBtb3JlIGluIHRoZSBkZXN0cnVjdG9yIG9m IFdlYlNldHRpbmdzVHJhbnNhY3Rpb24uCiAgICAgV2ViU2V0dGluZ3NUcmFuc2FjdGlvbiB3ZWJT ZXR0aW5nVHJhbnNhY3Rpb24oc2V0dGluZ3MpOwogCkBAIC0yNjksNiArMjY4LDcgQEAgdm9pZCBE dW1wUmVuZGVyVHJlZTo6cmVzZXRUb0NvbnNpc3RlbnRTdGF0ZUJlZm9yZVRlc3RpbmcoKQogCiAg ICAgbV9wYWdlLT5zZXRWaXJ0dWFsVmlld3BvcnRTaXplKDgwMCwgNjAwKTsKICAgICBtX3BhZ2Ut PnJlc2V0VmlydHVhbFZpZXdwb3J0T25Db21taXR0ZWQoZmFsc2UpOworICAgIG1fcGFnZS0+c2V0 VXNlclNjYWxhYmxlKHRydWUpOwogICAgIG1fcGFnZS0+c2V0SmF2YVNjcmlwdENhbkFjY2Vzc0Ns aXBib2FyZCh0cnVlKTsKIAogICAgIGlmIChXZWJDb3JlOjpQYWdlKiBwYWdlID0gRHVtcFJlbmRl clRyZWVTdXBwb3J0Ojpjb3JlUGFnZShtX3BhZ2UpKSB7Cg==