84194 2012-04-17 14:34:45 -0700 REGRESSION(r112155): Children style not always recalculated in CSS animations 2012-06-07 21:38:51 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED InRadar, Regression P1 Normal --- 1 loic.yhuel webkit-unassigned dino igor.oliveira marc.hoyois robarnold simon.fraser oldest_to_newest 604349 0 137607 loic.yhuel 2012-04-17 14:34:45 -0700 Created attachment 137607 blinking text animation The attached blink animation no longer works since https://bugs.webkit.org/show_bug.cgi?id=79389 has landed. There are paints, but the text is always black. In Element::recalcStyle, when the text color should be changed to white : - styleChangeType() is SyntheticStyleChange, the animated style (color: white) is set on the Element in setRenderStyle(newStyle) - currentStyle and newStyle are the same (color: black), so ch is NoChange - After r112155, change is no more set to Force, so Text::recalcTextStyle is called with NoChange as argument, the style of the text is not changed, so the text color remains black. 604365 1 ap 2012-04-17 14:49:08 -0700 <rdar://problem/11267408> 630544 2 ap 2012-05-22 10:55:51 -0700 Rob, would you be willing to investigate this regression? 631047 3 robarnold 2012-05-22 18:32:53 -0700 Yes, I should have investigated sooner. Unfortunately it'll probably be 2 weeks before I can really dig into this (vacation + needing to unblock a bunch of people at FB). It looks like Loïc did some nice investigation; my current plan is to see if forcing recalcuation when the new style has inheritable properties (ideally if they changed / are used) will work. 634185 4 dino 2012-05-25 12:34:37 -0700 We're getting multiple reports of this breaking various things. I'm going to revert the change from https://bugs.webkit.org/show_bug.cgi?id=79389 634213 5 dino 2012-05-25 13:03:48 -0700 Reverted in http://trac.webkit.org/changeset/118553 634222 6 dino 2012-05-25 13:08:41 -0700 Reverting fixed the attached testcase. 644306 7 marc.hoyois 2012-06-07 21:38:51 -0700 *** Bug 84371 has been marked as a duplicate of this bug. *** 137607 2012-04-17 14:34:45 -0700 2012-04-17 14:34:45 -0700 blinking text animation blink.html text/html 423 loic.yhuel PGh0bWw+CiAgICA8aGVhZD4KICAgICAgICA8c3R5bGUgdHlwZT0idGV4dC9jc3MiPgogICAgICAg ICAgICBALXdlYmtpdC1rZXlmcmFtZXMgYmxpbmsgewogICAgICAgICAgICAgICAgMCUgICB7IGNv bG9yOiBibGFjazsgfQogICAgICAgICAgICAgICAgNTAlICB7IGNvbG9yOiB3aGl0ZTsgfQogICAg ICAgICAgICAgICAgMTAwJSB7IGNvbG9yOiBibGFjazsgfQogICAgICAgICAgICB9CgogICAgICAg ICAgICAjYmxpbmsgewogICAgICAgICAgICAgICAgLXdlYmtpdC1hbmltYXRpb246IGJsaW5rIDFz IHN0ZXAtZW5kIGluZmluaXRlOwogICAgICAgICAgICB9CiAgICAgICAgPC9zdHlsZT4KICAgIDwv aGVhZD4KICAgIDxib2R5PgogICAgICAgIDxzcGFuIGlkPWJsaW5rPkJsaW5raW5nIHRleHQ8L3Nw YW4+CiAgICA8L2JvZHk+CjwvaHRtbD4K