84191 2012-04-17 13:54:10 -0700 GraphicsContextCG's roundToDevicePixels should round even when there's no transform 2012-04-18 13:05:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60318 1 leviw leviw darin eae eric jchaffraix mitz simon.fraser webkit.review.bot oldest_to_newest 604316 0 leviw 2012-04-17 13:54:10 -0700 Currently, if there's no transform on the graphics context, the CG implementation of GraphicsContext::roundToDevicePixels returns the rect passed in instead of rounding. This breaks text underlines when sub-pixel layout is enabled. 604332 1 137601 leviw 2012-04-17 14:20:30 -0700 Created attachment 137601 Patch 604496 2 137601 eric 2012-04-17 17:04:33 -0700 Comment on attachment 137601 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137601&action=review Wouldn't rect.round() do the same thing? Or do we call it roundedIntRect(rect)? In either case, I would be surprised if the float -> int -> float conversion would matter, and would save adding a couple lines of code. > Source/WebCore/ChangeLog:11 > + end up being more than on3e pixel wide. This adds a static inline rounding method and uses it for on3e 604913 3 137728 leviw 2012-04-18 11:15:28 -0700 Created attachment 137728 Patch 604963 4 137728 eric 2012-04-18 11:54:33 -0700 Comment on attachment 137728 Patch LGTM. 604964 5 137728 leviw 2012-04-18 11:55:53 -0700 Comment on attachment 137728 Patch Thanks Eric :) 605017 6 137728 webkit.review.bot 2012-04-18 13:05:27 -0700 Comment on attachment 137728 Patch Clearing flags on attachment: 137728 Committed r114548: <http://trac.webkit.org/changeset/114548> 605018 7 webkit.review.bot 2012-04-18 13:05:32 -0700 All reviewed patches have been landed. Closing bug. 137601 2012-04-17 14:20:30 -0700 2012-04-18 11:15:21 -0700 Patch bug-84191-20120417142028.patch text/plain 2668 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDQzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTE3ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBHcmFwaGljc0NvbnRleHRD RydzIHJvdW5kVG9EZXZpY2VQaXhlbHMgc2hvdWxkIHJvdW5kIGV2ZW4gd2hlbiB0aGVyZSdzIG5v IHRyYW5zZm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODQxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIHBhaW50aW5nIHdpdGggdGhlIGlkZW50aWZ5IHRyYW5zZm9ybSwgdGhlIHJvdW5kVG9E ZXZpY2VQaXhlbHMgZnVuY3Rpb24gaW4gR3JhcGhpY3NDb250ZXh0Q0cKKyAgICAgICAgZG9lcyBh biBlYXJseSByZXR1cm4gdGhhdCBzaW1wbHkgcmV0dXJucyB0aGUgRmxvYXRSZWN0IHRoYXQgd2Fz IHBhc3NlZCBpbi4gVGhpcyBwcm92ZWQgdG8gYmUgYQorICAgICAgICBwcm9ibGVtIGluIHN1Yi1w aXhlbCBsYXlvdXQsIGFzIHdlIHdvdWxkbid0IGFkanVzdCB0aGUgcGFpbnQgcmVjdCBmb3IgdGV4 dCB1bmRlcmxpbmUsIGFuZCBpdCBjb3VsZAorICAgICAgICBlbmQgdXAgYmVpbmcgbW9yZSB0aGFu IG9uM2UgcGl4ZWwgd2lkZS4gVGhpcyBhZGRzIGEgc3RhdGljIGlubGluZSByb3VuZGluZyBtZXRo b2QgYW5kIHVzZXMgaXQgZm9yCisgICAgICAgIHRoZSBzaW1wbGUgc2hvcnQtY2lyY3VpdCBjYXNl LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yIGJlZm9yZSBz d2l0Y2hpbmcgdG8gc3ViLXBpeGVsIGxheW91dC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJvdW5kZWRG bG9hdFJlY3QpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpHcmFwaGlj c0NvbnRleHQ6OnJvdW5kVG9EZXZpY2VQaXhlbHMpOgorCiAyMDEyLTA0LTE3ICBFbWlsIEEgRWts dW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSb2xsb3V0IHIxMTQ0MDQgYXMgaXQg YnJva2UgYSBjb3VwbGUgb2YgY2hyb21pdW0gYnVpbGRzLgpJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNw cAkocmV2aXNpb24gMTE0Mzk0KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvR3JhcGhpY3NDb250ZXh0Q0cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAyLDYgKzEzMDIs MTEgQEAgQWZmaW5lVHJhbnNmb3JtIEdyYXBoaWNzQ29udGV4dDo6Z2V0Q1RNKAogICAgIHJldHVy biBBZmZpbmVUcmFuc2Zvcm0oQ0dDb250ZXh0R2V0Q1RNKHBsYXRmb3JtQ29udGV4dCgpKSk7CiB9 CiAKK3N0YXRpYyBpbmxpbmUgRmxvYXRSZWN0IHJvdW5kZWRGbG9hdFJlY3QoY29uc3QgRmxvYXRS ZWN0JiByZWN0KQoreworICAgIHJldHVybiBGbG9hdFJlY3QobHJvdW5kZihyZWN0LngoKSksIGxy b3VuZGYocmVjdC55KCkpLCBscm91bmRmKHJlY3Qud2lkdGgoKSksIGxyb3VuZGYocmVjdC5oZWln aHQoKSkpOworfQorCiBGbG9hdFJlY3QgR3JhcGhpY3NDb250ZXh0Ojpyb3VuZFRvRGV2aWNlUGl4 ZWxzKGNvbnN0IEZsb2F0UmVjdCYgcmVjdCwgUm91bmRpbmdNb2RlIHJvdW5kaW5nTW9kZSkKIHsK ICNpZiBQTEFURk9STShDSFJPTUlVTSkKQEAgLTEzMTMsMTIgKzEzMTgsMTIgQEAgRmxvYXRSZWN0 IEdyYXBoaWNzQ29udGV4dDo6cm91bmRUb0RldmljZQogICAgIC8vIHdlIGdldCB0aGUgYWZmaW5l IHRyYW5zZm9ybSBtYXRyaXggYW5kIGV4dHJhY3QgdGhlIHNjYWxlLgogCiAgICAgaWYgKG1fZGF0 YS0+bV91c2VyVG9EZXZpY2VUcmFuc2Zvcm1Lbm93blRvQmVJZGVudGl0eSkKLSAgICAgICAgcmV0 dXJuIHJlY3Q7CisgICAgICAgIHJldHVybiByb3VuZGVkRmxvYXRSZWN0KHJlY3QpOwogCiAgICAg Q0dBZmZpbmVUcmFuc2Zvcm0gZGV2aWNlTWF0cml4ID0gQ0dDb250ZXh0R2V0VXNlclNwYWNlVG9E ZXZpY2VTcGFjZVRyYW5zZm9ybShwbGF0Zm9ybUNvbnRleHQoKSk7CiAgICAgaWYgKENHQWZmaW5l VHJhbnNmb3JtSXNJZGVudGl0eShkZXZpY2VNYXRyaXgpKSB7CiAgICAgICAgIG1fZGF0YS0+bV91 c2VyVG9EZXZpY2VUcmFuc2Zvcm1Lbm93blRvQmVJZGVudGl0eSA9IHRydWU7Ci0gICAgICAgIHJl dHVybiByZWN0OworICAgICAgICByZXR1cm4gcm91bmRlZEZsb2F0UmVjdChyZWN0KTsKICAgICB9 CiAKICAgICBmbG9hdCBkZXZpY2VTY2FsZVggPSBzcXJ0ZihkZXZpY2VNYXRyaXguYSAqIGRldmlj ZU1hdHJpeC5hICsgZGV2aWNlTWF0cml4LmIgKiBkZXZpY2VNYXRyaXguYik7Cg== 137728 2012-04-18 11:15:28 -0700 2012-04-18 13:05:27 -0700 Patch bug-84191-20120418111527.patch text/plain 3571 leviw SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTE4ICBMZXZpIFdl aW50cmF1YiAgPGxldml3QGNocm9taXVtLm9yZz4KKworICAgICAgICBHcmFwaGljc0NvbnRleHRD RydzIHJvdW5kVG9EZXZpY2VQaXhlbHMgc2hvdWxkIHJvdW5kIGV2ZW4gd2hlbiB0aGVyZSdzIG5v IHRyYW5zZm9ybQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9ODQxOTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaGVuIHBhaW50aW5nIHdpdGggdGhlIGlkZW50aWZ5IHRyYW5zZm9ybSwgdGhlIHJvdW5kVG9E ZXZpY2VQaXhlbHMgZnVuY3Rpb24gaW4gR3JhcGhpY3NDb250ZXh0Q0cKKyAgICAgICAgZG9lcyBh biBlYXJseSByZXR1cm4gdGhhdCBzaW1wbHkgcmV0dXJucyB0aGUgRmxvYXRSZWN0IHRoYXQgd2Fz IHBhc3NlZCBpbi4gVGhpcyBwcm92ZWQgdG8gYmUgYQorICAgICAgICBwcm9ibGVtIGluIHN1Yi1w aXhlbCBsYXlvdXQsIGFzIHdlIHdvdWxkbid0IGFkanVzdCB0aGUgcGFpbnQgcmVjdCBmb3IgdGV4 dCB1bmRlcmxpbmUsIGFuZCBpdCBjb3VsZAorICAgICAgICBlbmQgdXAgYmVpbmcgbW9yZSB0aGFu IG9uZSBwaXhlbCB3aWRlLiBBZGRpbmcgYSByb3VuZGVkSW50UmVjdCBtZXRob2Qgb24gRmxvYXRS ZWN0IGZvciB0aGUgc2ltcGxlCisgICAgICAgIHNob3J0LWNpcmN1aXQgY2FzZS4KKworICAgICAg ICBObyBuZXcgdGVzdHMuIE5vIGNoYW5nZSBpbiBiZWhhdmlvciBiZWZvcmUgc3dpdGNoaW5nIHRv IHN1Yi1waXhlbCBsYXlvdXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJl Y3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6cm91bmRlZEludFJlY3QpOgorICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5oOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29u dGV4dDo6cm91bmRUb0RldmljZVBpeGVscyk6CisKIDIwMTItMDQtMTggIExldmkgV2VpbnRyYXVi ICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENvbnZlcnQgU2hhZG93RGF0YSBhbmQg RHJvcFNoYWRvd0ZpbHRlck9wZXJhdGlvbiB0byB1c2UgSW50UG9pbnQKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0Zsb2F0UmVjdC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAkocmV2aXNpb24gMTE0 NTIwKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRSZWN0LmNwcAko d29ya2luZyBjb3B5KQpAQCAtMjM2LDYgKzIzNiwxMSBAQCBJbnRSZWN0IGVuY2xvc2VkSW50UmVj dChjb25zdCBGbG9hdFJlY3QmCiAgICAgcmV0dXJuIEludFJlY3QoeCwgeSwgd2lkdGgsIGhlaWdo dCk7CiB9CiAKK0ludFJlY3Qgcm91bmRlZEludFJlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQor eworICAgIHJldHVybiBJbnRSZWN0KHJvdW5kZWRJbnRQb2ludChyZWN0LmxvY2F0aW9uKCkpLCBy b3VuZGVkSW50U2l6ZShyZWN0LnNpemUoKSkpOworfQorCiBGbG9hdFJlY3QgbWFwUmVjdChjb25z dCBGbG9hdFJlY3QmIHIsIGNvbnN0IEZsb2F0UmVjdCYgc3JjUmVjdCwgY29uc3QgRmxvYXRSZWN0 JiBkZXN0UmVjdCkKIHsKICAgICBpZiAoc3JjUmVjdC53aWR0aCgpID09IDAgfHwgc3JjUmVjdC5o ZWlnaHQoKSA9PSAwKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvRmxv YXRSZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv RmxvYXRSZWN0LmgJKHJldmlzaW9uIDExNDUyMCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0Zsb2F0UmVjdC5oCSh3b3JraW5nIGNvcHkpCkBAIC0yODgsNiArMjg4LDggQEAg SW50UmVjdCBlbmNsb3NpbmdJbnRSZWN0KGNvbnN0IEZsb2F0UmVjdAogLy8gUmV0dXJucyBhIHZh bGlkIEludFJlY3QgY29udGFpbmVkIHdpdGhpbiB0aGUgZ2l2ZW4gRmxvYXRSZWN0LgogSW50UmVj dCBlbmNsb3NlZEludFJlY3QoY29uc3QgRmxvYXRSZWN0Jik7CiAKK0ludFJlY3Qgcm91bmRlZElu dFJlY3QoY29uc3QgRmxvYXRSZWN0Jik7CisKIC8vIE1hcCByZWN0IHIgZnJvbSBzcmNSZWN0IHRv IGFuIGVxdWl2YWxlbnQgcmVjdCBpbiBkZXN0UmVjdC4KIEZsb2F0UmVjdCBtYXBSZWN0KGNvbnN0 IEZsb2F0UmVjdCYgciwgY29uc3QgRmxvYXRSZWN0JiBzcmNSZWN0LCBjb25zdCBGbG9hdFJlY3Qm IGRlc3RSZWN0KTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cv R3JhcGhpY3NDb250ZXh0Q0cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NnL0dyYXBoaWNzQ29udGV4dENHLmNwcAkocmV2aXNpb24gMTE0NTIwKQor KysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250ZXh0Q0cu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzEzLDEyICsxMzEzLDEyIEBAIEZsb2F0UmVjdCBHcmFw aGljc0NvbnRleHQ6OnJvdW5kVG9EZXZpY2UKICAgICAvLyB3ZSBnZXQgdGhlIGFmZmluZSB0cmFu c2Zvcm0gbWF0cml4IGFuZCBleHRyYWN0IHRoZSBzY2FsZS4KIAogICAgIGlmIChtX2RhdGEtPm1f dXNlclRvRGV2aWNlVHJhbnNmb3JtS25vd25Ub0JlSWRlbnRpdHkpCi0gICAgICAgIHJldHVybiBy ZWN0OworICAgICAgICByZXR1cm4gcm91bmRlZEludFJlY3QocmVjdCk7CiAKICAgICBDR0FmZmlu ZVRyYW5zZm9ybSBkZXZpY2VNYXRyaXggPSBDR0NvbnRleHRHZXRVc2VyU3BhY2VUb0RldmljZVNw YWNlVHJhbnNmb3JtKHBsYXRmb3JtQ29udGV4dCgpKTsKICAgICBpZiAoQ0dBZmZpbmVUcmFuc2Zv cm1Jc0lkZW50aXR5KGRldmljZU1hdHJpeCkpIHsKICAgICAgICAgbV9kYXRhLT5tX3VzZXJUb0Rl dmljZVRyYW5zZm9ybUtub3duVG9CZUlkZW50aXR5ID0gdHJ1ZTsKLSAgICAgICAgcmV0dXJuIHJl Y3Q7CisgICAgICAgIHJldHVybiByb3VuZGVkSW50UmVjdChyZWN0KTsKICAgICB9CiAKICAgICBm bG9hdCBkZXZpY2VTY2FsZVggPSBzcXJ0ZihkZXZpY2VNYXRyaXguYSAqIGRldmljZU1hdHJpeC5h ICsgZGV2aWNlTWF0cml4LmIgKiBkZXZpY2VNYXRyaXguYik7Cg==