84178 2012-04-17 11:56:28 -0700 Relax ScrollView::adjustScrollPositionWithinRange in case constrainsScrollingToContentEdge is false 2012-04-20 12:33:13 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 73144 1 tonikitoo tonikitoo andersca kenneth manyoso simon.fraser oldest_to_newest 604201 0 tonikitoo 2012-04-17 11:56:28 -0700 Right now, when a port has delegatesScrolling set to FALSE, and constrainsScrollingToContentEdge set to FALSE (i.e. it accepts overscrolled position), calling ScrollView::setScrollPosition with an overscrolled position still gets the position clamped to the content size edges. We could relax ::adjustScrollPositionWithinRange in that sense. 604203 1 tonikitoo 2012-04-17 11:56:44 -0700 *** Bug 84176 has been marked as a duplicate of this bug. *** 604208 2 andersca 2012-04-17 11:58:45 -0700 I think doing so would break a lot of assumptions inside WebCore. I tried doing something like this in ScrollView::updateScrollbars and it did not work well. 604230 3 tonikitoo 2012-04-17 12:12:06 -0700 (In reply to comment #2) > I think doing so would break a lot of assumptions inside WebCore. I tried doing something like this in ScrollView::updateScrollbars and it did not work well. Would you remember what kind of assumptions? We run with this since a while without problems... If we do not have such a "relaxation" if user over scrolls a webpage, say to (0, -20) webcore would be tracking a scroll position of (0, 0). 604238 4 tonikitoo 2012-04-17 12:20:47 -0700 Note that ScrollView::setScrollOffset does something similar already: 340 void ScrollView::setScrollOffset(const IntPoint& offset) 341 { 342 int horizontalOffset = offset.x(); 343 int verticalOffset = offset.y(); 344 if (constrainsScrollingToContentEdge()) { 345 horizontalOffset = max(min(horizontalOffset, contentsWidth() - visibleWidth()), 0); 346 verticalOffset = max(min(verticalOffset, contentsHeight() - visibleHeight()), 0); 347 } .... 604240 5 137582 tonikitoo 2012-04-17 12:23:42 -0700 Created attachment 137582 (wrong patch, please ignore) patch Patch for discussion. Call sites of ScrollView::adjustScrollPositionWithinRange from ::setScrollPosition and ::updateScrollbars. 604824 6 137708 tonikitoo 2012-04-18 09:37:38 -0700 Created attachment 137708 (committed r114770, r=atreat) patch - the right patch this time 606354 7 tonikitoo 2012-04-19 22:15:31 -0700 <tonikitoo> andersca, sir, would you have some minutes to talk about? https://bugs.webkit.org/show_bug.cgi?id=84178 <tonikitoo> (shame we can not talk in person during the summit :( ) <andersca> tonikitoo: yes, I think I was wrong about my assumption <andersca> tonikitoo: if you have a Mac you can test if it breaks things by going to a page with a vertical scrollbar, scroll to the bottom <andersca> tonikitoo: then hit command-f to show the find banner and escape to hide it <tonikitoo> scrollview::setscrollposition calls it I think <andersca> tonikitoo: and make sure that the behavior is the same even with your patch ... <tonikitoo> andersca, just to let you know: I got it tested on a safari build with and without the patch, and behaviour looks the same <andersca> tonikitoo: excellent 606754 8 137708 manyoso 2012-04-20 11:43:33 -0700 Comment on attachment 137708 (committed r114770, r=atreat) patch - the right patch this time lgtm and tested against mac port with no regression so r+ 606809 9 137708 tonikitoo 2012-04-20 12:32:40 -0700 Comment on attachment 137708 (committed r114770, r=atreat) patch - the right patch this time Committed http://trac.webkit.org/changeset/114770 137582 2012-04-17 12:23:42 -0700 2012-04-18 09:39:02 -0700 (wrong patch, please ignore) patch 0001-2012-04-16-Antonio-Gomes-agomes-rim.com.patch text/plain 4232 tonikitoo RnJvbSA4ODAwYWQ4NjA3YTYxY2FmM2YzZDFhN2ZjODI5MTU3OWFkOGE5NTczIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog TW9uLCAxNiBBcHIgMjAxMiAxNDoyMToxNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQt MTYgIEFudG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KCiAgICAgICAgU2NyZWVuIHNoaWZ0 IGRvd24gd2hlbiBWS0Igc2hvd3MgYnkgY2xpY2tpbmcgaW4gYSBpbnB1dCBib3ggTUtTXzM2MDEz NzEKICAgICAgICBQUiAjMTQ5ODQ2CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgoKICAgICAgICBBZnRlciBzd2l0Y2hpbmcgZnJvbSBTY3JvbGxWaWV3OjpjYW5PdmVyc2Nyb2xs IHRvIFNjcm9sbFZpZXc6OmNvbnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlCiAgICAgICAg d2UgaGFkIGEgbGVzcyByZXN0cmljdCBjb2RlIHBhdGggYWxsb3dpbmcvZGlzYWxsb3dpbmcgb3Zl cnNjcm9sbGluZy4gVGhhdCBjYXVzZWQKICAgICAgICBzb21lIHdlYnBhZ2VzIGxpa2UgZ29vZ2xl LmNvbSB0byBnZXQgc3R1ZmYgb24gb3ZlcnNjcm9sbCB3aGVuIGFkanVzdGluZyB0aGUgc2Nyb2xs CiAgICAgICAgcG9zaXRpb24gdG8gZW5zdXJlIHRoZSBmb2N1c2VkIGlucHV0IGZpZWxkIGlzIHZp c2libGUuCgogICAgICAgIFBhdGNoIHJlc3RyaWN0cyB0aGUgd2F5IHdlIGFsbG93IG92ZXJzY3Jv bGxpbmcgdG8gdGhlIGJvdHRvbSwgd2hlcmUgdGhlIHZpcnR1YWwKICAgICAgICBrZXlib2FyZCBw b3BzIHVwIGZyb20sIGNsYW1waW5nIGl0IHRvIDAsIDAgaWYgaXQgdHJpZXMgdG8KICAgICAgICBv dmVyc2Nyb2xsIHVwd2FyZHMsIGFuZCB0byBtYXhpbXVtIHNjcm9sbCBwb3NpdGlvbiBpZiBpdCBv dmVyc2Nyb2xscwogICAgICAgIGRvd253YXJkcy4KCiAgICAgICAgSW50ZXJuYWxseSByZXZpZXdl ZCBieSBNaWtlIEZlbnRvbi4KICAgICAgICBQUiAjMTQ5ODQ2CgogICAgICAgICogV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwOgogICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0 SGFuZGxlcjo6ZW5zdXJlRm9jdXNUZXh0RWxlbWVudFZpc2libGUpOgotLS0KIFNvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAyMyArKysrKysrKysr KysrKysrKysrKwogLi4uL2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw ICAgICAgfCAgIDExICsrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDg5ZDEx ZTMuLjEyYTAyNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2 IEBACisyMDEyLTA0LTE2ICBBbnRvbmlvIEdvbWVzICA8YWdvbWVzQHJpbS5jb20+CisKKyAgICAg ICAgU2NyZWVuIHNoaWZ0IGRvd24gd2hlbiBWS0Igc2hvd3MgYnkgY2xpY2tpbmcgaW4gYSBpbnB1 dCBib3ggTUtTXzM2MDEzNzEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTg0MDU3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWZ0ZXIgc3dpdGNoaW5nIGZyb20gU2Nyb2xsVmlldzo6Y2FuT3ZlcnNjcm9sbCB0 byBTY3JvbGxWaWV3Ojpjb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250ZW50RWRnZQorICAgICAgICB3 ZSBoYWQgYSBsZXNzIHJlc3RyaWN0IGNvZGUgcGF0aCBhbGxvd2luZy9kaXNhbGxvd2luZyBvdmVy c2Nyb2xsaW5nLiBUaGF0IGNhdXNlZAorICAgICAgICBzb21lIHdlYnBhZ2VzIGxpa2UgZ29vZ2xl LmNvbSB0byBnZXQgc3R1ZmYgb24gb3ZlcnNjcm9sbCB3aGVuIGFkanVzdGluZyB0aGUgc2Nyb2xs CisgICAgICAgIHBvc2l0aW9uIHRvIGVuc3VyZSB0aGUgZm9jdXNlZCBpbnB1dCBmaWVsZCBpcyB2 aXNpYmxlLgorCisgICAgICAgIFBhdGNoIHJlc3RyaWN0cyB0aGUgd2F5IHdlIGFsbG93IG92ZXJz Y3JvbGxpbmcgdG8gdGhlIGJvdHRvbSwgd2hlcmUgdGhlIHZpcnR1YWwKKyAgICAgICAga2V5Ym9h cmQgcG9wcyB1cCBmcm9tLCBjbGFtcGluZyBpdCB0byAwLCAwIGlmIGl0IHRyaWVzIHRvCisgICAg ICAgIG92ZXJzY3JvbGwgdXB3YXJkcywgYW5kIHRvIG1heGltdW0gc2Nyb2xsIHBvc2l0aW9uIGlm IGl0IG92ZXJzY3JvbGxzCisgICAgICAgIGRvd253YXJkcy4KKworICAgICAgICBQUiAjMTQ5ODQ2 CisgICAgICAgIEludGVybmFsbHkgcmV2aWV3ZWQgYnkgTWlrZSBGZW50b24uCisKKyAgICAgICAg KiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OklucHV0SGFuZGxlcjo6ZW5zdXJlRm9jdXNUZXh0RWxlbWVudFZpc2libGUpOgorCiAy MDEyLTA0LTE2ICBZb25neGluIERhaSAgPHlvZGFpQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNr QmVycnldIEluY3JlYXNlIHBhZGRpbmcgZm9yIHRleHQgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKaW5k ZXggYzZjODQ3Mi4uMGI5ZTAyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC02MzQsNyArNjM0LDE2IEBA IHZvaWQgSW5wdXRIYW5kbGVyOjplbnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZShDYXJldFNj cm9sbFR5cGUgc2Nyb2xsVHlwZSkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaG9yaXpvbnRhbFNjcm9sbEFsaWdubWVudCwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdmVydGljYWxTY3JvbGxBbGlnbm1lbnQpOwogCi0gICAgICAgICAgICBtYWluRnJh bWVWaWV3LT5zZXRTY3JvbGxQb3NpdGlvbihyZXZlYWxSZWN0LmxvY2F0aW9uKCkpOworICAgICAg ICAgICAgbWFpbkZyYW1lVmlldy0+c2V0Q29uc3RyYWluc1Njcm9sbGluZ1RvQ29udGVudEVkZ2Uo ZmFsc2UpOworICAgICAgICAgICAgLy8gSW4gb3JkZXIgdG8gYWRqdXN0IHRoZSBzY3JvbGwgcG9z aXRpb24gdG8gZW5zdXJlIHRoZSBmb2N1c2VkIGlucHV0IGZpZWxkIGlzIHZpc2libGUsCisgICAg ICAgICAgICAvLyB3ZSBhbGxvdyBvdmVyc2Nyb2xsaW5nLiBIb3dldmVyIHRoaXMgb3ZlcnNjcm9s bCBoYXMgdG8gYmUgc3RyaWN0bHkgYWxsb3dlZCB0b3dhcmRzIHRoZQorICAgICAgICAgICAgLy8g Ym90dG9tIG9mIHRoZSBwYWdlIG9uIHRoZSB5IGF4aXMgb25seSwgd2hlcmUgdGhlIHZpcnR1YWwg a2V5Ym9hcmQgcG9wcyB1cCBmcm9tLgorICAgICAgICAgICAgV2ViQ29yZTo6SW50UG9pbnQgc2Ny b2xsTG9jYXRpb24gPSByZXZlYWxSZWN0LmxvY2F0aW9uKCk7CisgICAgICAgICAgICBzY3JvbGxM b2NhdGlvbi5jbGFtcE5lZ2F0aXZlVG9aZXJvKCk7CisgICAgICAgICAgICBXZWJDb3JlOjpJbnRQ b2ludCBtYXhpbXVtU2Nyb2xsUG9zaXRpb24gPSBXZWJDb3JlOjpJbnRQb2ludChtYWluRnJhbWVW aWV3LT5jb250ZW50c1dpZHRoKCkgLSBhY3R1YWxTY3JlZW5SZWN0LndpZHRoKCksIG1haW5GcmFt ZVZpZXctPmNvbnRlbnRzSGVpZ2h0KCkgLSBhY3R1YWxTY3JlZW5SZWN0LmhlaWdodCgpKTsKKyAg ICAgICAgICAgIHNjcm9sbExvY2F0aW9uID0gc2Nyb2xsTG9jYXRpb24uc2hydW5rVG8obWF4aW11 bVNjcm9sbFBvc2l0aW9uKTsKKyAgICAgICAgICAgIG1haW5GcmFtZVZpZXctPnNldFNjcm9sbFBv c2l0aW9uKHNjcm9sbExvY2F0aW9uKTsKKyAgICAgICAgICAgIG1haW5GcmFtZVZpZXctPnNldENv bnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlKHRydWUpOwogICAgICAgICB9CiAgICAgfQog Ci0tIAoxLjcuNS40Cgo= 137708 2012-04-18 09:37:38 -0700 2012-04-20 12:32:40 -0700 (committed r114770, r=atreat) patch - the right patch this time 0001-Relax-ScrollView-adjustScrollPositionWithinRange-in-.patch text/plain 2983 tonikitoo RnJvbSA0ZTI0OWExNjA3ZGNjODgyYzM3YjBhOWI1MDY2ZTBlZjkxNDJkN2JhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDxhZ29tZXNAcmltLmNvbT4KRGF0ZTog VHVlLCAxNyBBcHIgMjAxMiAxNToyMjoyMCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIFJlbGF4IFNj cm9sbFZpZXc6OmFkanVzdFNjcm9sbFBvc2l0aW9uV2l0aGluUmFuZ2UgaW4gY2FzZQogY29uc3Ry YWluc1Njcm9sbGluZ1RvQ29udGVudEVkZ2UgaXMgZmFsc2UKIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3OAoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuClBh dGNoIGJ5IEFudG9uaW8gR29tZXMgPGFnb21lc0ByaW0uY29tPgoKTm8gbmV3IHRlc3RzIHNpbmNl IGl0IGlzIG5vdCBlYXNpbHkgdGVzdGFibGUuCgpXaGVuIGEgcG9ydCBoYXMgYm90aCBkZWxlZ2F0 ZXNTY3JvbGxpbmcgYW5kIGNvbnN0cmFpbnNTY3JvbGxpbmdUb0NvbnRlbnRFZGdlIHNldCB0byBG QUxTRQooaS5lLiBpdCBhY2NlcHRzIG92ZXJzY3JvbGxlZCBwb3NpdGlvbiksIGNhbGxpbmcgU2Ny b2xsVmlldzo6c2V0U2Nyb2xsUG9zaXRpb24gd2l0aCBhbiBvdmVyc2Nyb2xsZWQKcG9zaXRpb24g c3RpbGwgZ2V0cyB0aGUgcG9zaXRpb24gY2xhbXBlZCB0byB0aGUgY29udGVudCBzaXplIGVkZ2Vz LgoKUGF0Y2ggcmVsYXhlcyA6OmFkanVzdFNjcm9sbFBvc2l0aW9uV2l0aGluUmFuZ2UgaW4gdGhh dCBzZW5zZSBpbiBvcmRlciB0byB0cmFjayB0aGUgYWN0dWFsIHNjcm9sbApwb3NpdGlvbi4KCk5v dGU6IFNjcm9sbFZpZXc6OnNldFNjcm9sbE9mZnNldCBhbHJlYWR5IGRvZXMgc29tZXRoaW5nIHNp bWlsYXIuCgoqIHBsYXRmb3JtL1Njcm9sbFZpZXcuY3BwOgooV2ViQ29yZTo6U2Nyb2xsVmlldzo6 YWRqdXN0U2Nyb2xsUG9zaXRpb25XaXRoaW5SYW5nZSk6Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nICAgICAgICAgICAgICAgfCAgIDIxICsrKysrKysrKysrKysrKysrKysrKwogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vU2Nyb2xsVmlldy5jcHAgfCAgICAzICsrKwogMiBmaWxlcyBjaGFu Z2VkLCAyNCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0Mzlm MjA5Li4xNDc2OWRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTItMDQtMTcgIEFu dG9uaW8gR29tZXMgIDxhZ29tZXNAcmltLmNvbT4KKworICAgICAgICBSZWxheCBTY3JvbGxWaWV3 OjphZGp1c3RTY3JvbGxQb3NpdGlvbldpdGhpblJhbmdlIGluIGNhc2UgY29uc3RyYWluc1Njcm9s bGluZ1RvQ29udGVudEVkZ2UgaXMgZmFsc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTg0MTc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGl0IGlzIG5vdCBlYXNpbHkgdGVz dGFibGUuCisKKyAgICAgICAgV2hlbiBhIHBvcnQgaGFzIGJvdGggZGVsZWdhdGVzU2Nyb2xsaW5n IGFuZCBjb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250ZW50RWRnZSBzZXQgdG8gRkFMU0UKKyAgICAg ICAgKGkuZS4gaXQgYWNjZXB0cyBvdmVyc2Nyb2xsZWQgcG9zaXRpb24pLCBjYWxsaW5nIFNjcm9s bFZpZXc6OnNldFNjcm9sbFBvc2l0aW9uIHdpdGggYW4gb3ZlcnNjcm9sbGVkCisgICAgICAgIHBv c2l0aW9uIHN0aWxsIGdldHMgdGhlIHBvc2l0aW9uIGNsYW1wZWQgdG8gdGhlIGNvbnRlbnQgc2l6 ZSBlZGdlcy4KKworICAgICAgICBQYXRjaCByZWxheGVzIDo6YWRqdXN0U2Nyb2xsUG9zaXRpb25X aXRoaW5SYW5nZSBpbiB0aGF0IHNlbnNlIGluIG9yZGVyIHRvIHRyYWNrIHRoZSBhY3R1YWwgc2Ny b2xsCisgICAgICAgIHBvc2l0aW9uLgorCisgICAgICAgIE5vdGU6IFNjcm9sbFZpZXc6OnNldFNj cm9sbE9mZnNldCBhbHJlYWR5IGRvZXMgc29tZXRoaW5nIHNpbWlsYXIuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9TY3JvbGxWaWV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbFZpZXc6OmFk anVzdFNjcm9sbFBvc2l0aW9uV2l0aGluUmFuZ2UpOgorCiAyMDEyLTA0LTE3ICBKb2huIEJhdW1h biAgPGpiYXVtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gRW5zdXJlIFJh dGVMaW1pdGVyIHdhaXRzIGZvciBTd2FwYnVmZmVycyBjb21wbGV0aW9uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9TY3JvbGxWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL1Njcm9sbFZpZXcuY3BwCmluZGV4IGM0YjczNDcuLjFkY2M2ZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL1Njcm9sbFZpZXcuY3BwCkBAIC0zMTksNiArMzE5LDkgQEAgSW50UG9pbnQg U2Nyb2xsVmlldzo6bWluaW11bVNjcm9sbFBvc2l0aW9uKCkgY29uc3QKIAogSW50UG9pbnQgU2Ny b2xsVmlldzo6YWRqdXN0U2Nyb2xsUG9zaXRpb25XaXRoaW5SYW5nZShjb25zdCBJbnRQb2ludCYg c2Nyb2xsUG9pbnQpIGNvbnN0CiB7CisgICAgaWYgKCFjb25zdHJhaW5zU2Nyb2xsaW5nVG9Db250 ZW50RWRnZSgpKQorICAgICAgICByZXR1cm4gc2Nyb2xsUG9pbnQ7CisKICAgICBJbnRQb2ludCBu ZXdTY3JvbGxQb3NpdGlvbiA9IHNjcm9sbFBvaW50LnNocnVua1RvKG1heGltdW1TY3JvbGxQb3Np dGlvbigpKTsKICAgICBuZXdTY3JvbGxQb3NpdGlvbiA9IG5ld1Njcm9sbFBvc2l0aW9uLmV4cGFu ZGVkVG8obWluaW11bVNjcm9sbFBvc2l0aW9uKCkpOwogICAgIHJldHVybiBuZXdTY3JvbGxQb3Np dGlvbjsKLS0gCjEuNy41LjQKCg==