84177 2012-04-17 11:55:49 -0700 Lion Production Test failing with error: "Failed to stop httpd: pid file still exists" 2012-04-20 12:34:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/builders/Lion%20Release%20%28Tests%29/builds/7667/steps/layout-test/logs/stdio P2 Normal --- 1 jer.noble jer.noble abarth dpranke ojan rniwa webkit.review.bot oldest_to_newest 604200 0 jer.noble 2012-04-17 11:55:49 -0700 run_webkit_tests is failing with the following stack trace: Traceback (most recent call last): File "/Volumes/Data/slave/lion-intel-release-tests/build/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 459, in <module> sys.exit(main()) ...snip... raise http_server_base.ServerError('Failed to stop %s: pid file still exists' % self._name) webkitpy.layout_tests.servers.http_server_base.ServerError: Failed to stop httpd: pid file still exists Failed to execute Tools/Scripts/new-run-webkit-tests at ./Tools/Scripts/run-webkit-tests line 122. 604263 1 137586 rniwa 2012-04-17 12:59:31 -0700 Created attachment 137586 Try to remove apache's pid file in the case it's stale 604266 2 jer.noble 2012-04-17 13:03:02 -0700 Looks like it might be a hardware problem. Rebooted the offending bot. <http://build.webkit.org/buildslaves/apple-xserve-10> 604282 3 137586 dpranke 2012-04-17 13:20:44 -0700 Comment on attachment 137586 Try to remove apache's pid file in the case it's stale See the comment right after this ... you can't assume apache has exited until the pid file is removed. If you delete the pid file too early, you may attempt to restart the server while the previous server is still running, and fail. You should only delete the pid file is the pid is gone. You should probably reuse the log in http_server.py, which checks for the running process. 604284 4 137586 rniwa 2012-04-17 13:22:15 -0700 Comment on attachment 137586 Try to remove apache's pid file in the case it's stale (In reply to comment #3) > (From update of attachment 137586 [details]) > See the comment right after this ... you can't assume apache has exited until the pid file is removed. If you delete the pid file too early, you may attempt to restart the server while the previous server is still running, and fail. You should only delete the pid file is the pid is gone. > > You should probably reuse the log in http_server.py, which checks for the running process. Okay, please make those changes then. I don't understand this code and don't have a time for it. 605029 5 137753 jer.noble 2012-04-18 13:17:24 -0700 Created attachment 137753 Patch 605040 6 137753 dpranke 2012-04-18 13:34:52 -0700 Comment on attachment 137753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137753&action=review > Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py:144 > + # If apache was forcefully killed, the pid file will not have been deleted, so check At the beginning of this routine, (before we call self._run(self._stop_cmd), we should check to see if the server is running ... in the context of the problem we're seeing, we know that self._pid is set to the pid we care about (see start() in http_server_base.py:78). So, I would rewrite the whole routine as something like: def _stop_running_server(self): if self._pid and not self._executive.check_running_pid(pid): self._filesystem.remove(self._pid_file) return retval, err = self._run(self.stop_cmd) if retval or len(err): raise http_server_base.ServerError('Failed to stop %s: %s' % (self._name, err)) # For some reason ... ... In this case you'll raise an error if you can't delete the pidfile, but I think that's probably good. 605047 7 137757 jer.noble 2012-04-18 13:43:06 -0700 Created attachment 137757 Patch Updated with dpranke's rewrite. 605051 8 137757 dpranke 2012-04-18 13:44:43 -0700 Comment on attachment 137757 Patch r+ if you add a "return" after line 143 so that we don't execute the rest of the function. 605111 9 rniwa 2012-04-18 14:47:23 -0700 Thanks for the fix! 606810 10 jer.noble 2012-04-20 12:34:33 -0700 Committed r114555: <http://trac.webkit.org/changeset/114555> 137586 2012-04-17 12:59:31 -0700 2012-04-17 13:22:15 -0700 Try to remove apache's pid file in the case it's stale bug-84177-20120417125930.patch text/plain 1760 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNDQwNCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTA0LTE3ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIExpb24gUHJvZHVjdGlvbiBUZXN0IGZhaWxpbmcgd2l0aCBlcnJvcjogIkZhaWxl ZCB0byBzdG9wIGh0dHBkOiBwaWQgZmlsZSBzdGlsbCBleGlzdHMiCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyeSB0byBkZWxldGUgdGhlIHBpZCBmaWxl IGxlZnQgYnkgQXBhY2hlIGluIHRoZSBjYXNlIGl0IHdhcyBraWxsZWQgZm9yY2VmdWxseS4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0 dHBfc2VydmVyLnB5OgorICAgICAgICAoTGF5b3V0VGVzdEFwYWNoZUh0dHBkLl9zdG9wX3J1bm5p bmdfc2VydmVyKToKKwogMjAxMi0wNC0xNyAgTmFuZG9yIEh1c3prYSAgPGhuYW5kb3JAaW5mLnUt c3plZ2VkLmh1PgogCiAgICAgICAgIFtRdF0gSlNDIGJ1aWxkIHNob3VsZCBoYW5kbGUgLS1uby13 ZWJraXQyIG9wdGlvbiB0byBhdm9pZCB1bndhbnRlZCBjbGVhbi1idWlsZHMKSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2VydmVy LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Nl cnZlcnMvYXBhY2hlX2h0dHBfc2VydmVyLnB5CShyZXZpc2lvbiAxMTQyMTQpCisrKyBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9zZXJ2ZXJzL2FwYWNoZV9odHRwX3NlcnZlci5w eQkod29ya2luZyBjb3B5KQpAQCAtMTQxLDYgKzE0MSwxMyBAQCBjbGFzcyBMYXlvdXRUZXN0QXBh Y2hlSHR0cGQoaHR0cF9zZXJ2ZXJfCiAgICAgICAgIGlmIHJldHZhbCBvciBsZW4oZXJyKToKICAg ICAgICAgICAgIHJhaXNlIGh0dHBfc2VydmVyX2Jhc2UuU2VydmVyRXJyb3IoJ0ZhaWxlZCB0byBz dG9wICVzOiAlcycgJSAoc2VsZi5fbmFtZSwgZXJyKSkKIAorICAgICAgICAjIE9wdGltaXN0aWNh bGx5IGRlbGV0ZSB0aGUgcGlkIGZpbGUgaW4gdGhlIGNhc2UgQXBhY2hlIGhhZCBiZWVuIGZvcmNl ZnVsbHkga2lsbGVkIGFuZCBsZWZ0IHBpZCBmaWxlLgorICAgICAgICB0cnk6CisgICAgICAgICAg ICBpZiBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhzZWxmLl9waWRfZmlsZSk6CisgICAgICAgICAg ICAgICAgc2VsZi5fZmlsZXN5c3RlbS5yZW1vdmUoc2VsZi5fcGlkX2ZpbGUpCisgICAgICAgIGV4 Y2VwdDoKKyAgICAgICAgICAgIHBhc3MKKwogICAgICAgICAjIEZvciBzb21lIHJlYXNvbiBhcGFj aGUgaXNuJ3QgZ3VhcmFudGVlZCB0byBoYXZlIGFjdHVhbGx5IHN0b3BwZWQgYWZ0ZXIKICAgICAg ICAgIyB0aGUgc3RvcCBjb21tYW5kIHJldHVybnMsIHNvIHdlIHdhaXQgYSBsaXR0bGUgd2hpbGUg bG9uZ2VyIGZvciB0aGUKICAgICAgICAgIyBwaWQgZmlsZSB0byBiZSByZW1vdmVkLgo= 137753 2012-04-18 13:17:24 -0700 2012-04-18 13:43:02 -0700 Patch bug-84177-20120418131723.patch text/plain 2084 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWY1MTQxODlkOTU3MGZhNjk3YzgwNTJmOGZlNjMyYjZi MWY2NTNlZS4uODg3YjU0YzhmZjE1OWZkNTExZDg0ZGViYzk0YzllZDA2YWJiOWFiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIExpb24gUHJvZHVjdGlvbiBUZXN0IGZhaWxpbmcgd2l0aCBlcnJvcjogIkZhaWxlZCB0byBz dG9wIGh0dHBkOiBwaWQgZmlsZSBzdGlsbCBleGlzdHMiCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyeSB0byBkZWxldGUgdGhlIHBpZCBmaWxlIGxlZnQg YnkgQXBhY2hlIGluIHRoZSBjYXNlIGl0IHdhcyBraWxsZWQgZm9yY2VmdWxseS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2Vy dmVyLnB5OgorICAgICAgICAoTGF5b3V0VGVzdEFwYWNoZUh0dHBkLl9zdG9wX3J1bm5pbmdfc2Vy dmVyKToKKwogMjAxMi0wNC0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNDUwNi4KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hl X2h0dHBfc2VydmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2Vy dmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKaW5kZXggYTA5YWEzMzQ1OTEyZGQ2NjRkZjlhOTAw NzEwZWI3ZTEwY2VjYWJkYS4uZmYyNzEzOGExNDAwNGYzMDgzNjA1NDZiYzAzZTQ2MWI0MjExNTli YSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVy cy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKQEAgLTE0MSw2ICsxNDEsMTYg QEAgY2xhc3MgTGF5b3V0VGVzdEFwYWNoZUh0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZl ckJhc2UpOgogICAgICAgICBpZiByZXR2YWwgb3IgbGVuKGVycik6CiAgICAgICAgICAgICByYWlz ZSBodHRwX3NlcnZlcl9iYXNlLlNlcnZlckVycm9yKCdGYWlsZWQgdG8gc3RvcCAlczogJXMnICUg KHNlbGYuX25hbWUsIGVycikpCiAKKyAgICAgICAgIyBJZiBhcGFjaGUgd2FzIGZvcmNlZnVsbHkg a2lsbGVkLCB0aGUgcGlkIGZpbGUgd2lsbCBub3QgaGF2ZSBiZWVuIGRlbGV0ZWQsIHNvIGNoZWNr CisgICAgICAgICMgdGhhdCB0aGUgcHJvY2VzcyBzcGVjaWZpZWQgYnkgdGhlIHBpZF9maWxlIG5v IGxvbmdlciBleGlzdHMgYmVmb3JlIGRlbGV0aW5nIHRoZSBmaWxlLgorICAgICAgICB0cnk6Cisg ICAgICAgICAgICBpZiBzZWxmLl9maWxlc3lzdGVtLmV4aXN0cyhzZWxmLl9waWRfZmlsZSk6Cisg ICAgICAgICAgICAgICAgcGlkID0gaW50KHNlbGYuX2ZpbGVzeXN0ZW0ucmVhZF90ZXh0X2ZpbGUo c2VsZi5fcGlkX2ZpbGUpKQorICAgICAgICAgICAgICAgIGlmIG5vdCBzZWxmLl9leGVjdXRpdmUu Y2hlY2tfcnVubmluZ19waWQocGlkKToKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5fZmlsZXN5 c3RlbS5yZW1vdmUoc2VsZi5fcGlkX2ZpbGUpCisgICAgICAgIGV4Y2VwdDoKKyAgICAgICAgICAg IHBhc3MKKwogICAgICAgICAjIEZvciBzb21lIHJlYXNvbiBhcGFjaGUgaXNuJ3QgZ3VhcmFudGVl ZCB0byBoYXZlIGFjdHVhbGx5IHN0b3BwZWQgYWZ0ZXIKICAgICAgICAgIyB0aGUgc3RvcCBjb21t YW5kIHJldHVybnMsIHNvIHdlIHdhaXQgYSBsaXR0bGUgd2hpbGUgbG9uZ2VyIGZvciB0aGUKICAg ICAgICAgIyBwaWQgZmlsZSB0byBiZSByZW1vdmVkLgo= 137757 2012-04-18 13:43:06 -0700 2012-04-18 13:44:43 -0700 Patch bug-84177-20120418134305.patch text/plain 1866 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWY1MTQxODlkOTU3MGZhNjk3YzgwNTJmOGZlNjMyYjZi MWY2NTNlZS4uODg3YjU0YzhmZjE1OWZkNTExZDg0ZGViYzk0YzllZDA2YWJiOWFiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAg ICAgIExpb24gUHJvZHVjdGlvbiBUZXN0IGZhaWxpbmcgd2l0aCBlcnJvcjogIkZhaWxlZCB0byBz dG9wIGh0dHBkOiBwaWQgZmlsZSBzdGlsbCBleGlzdHMiCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFRyeSB0byBkZWxldGUgdGhlIHBpZCBmaWxlIGxlZnQg YnkgQXBhY2hlIGluIHRoZSBjYXNlIGl0IHdhcyBraWxsZWQgZm9yY2VmdWxseS4KKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hlX2h0dHBfc2Vy dmVyLnB5OgorICAgICAgICAoTGF5b3V0VGVzdEFwYWNoZUh0dHBkLl9zdG9wX3J1bm5pbmdfc2Vy dmVyKToKKwogMjAxMi0wNC0xOCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFp bC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjExNDUwNi4KZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3NlcnZlcnMvYXBhY2hl X2h0dHBfc2VydmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2Vy dmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKaW5kZXggYTA5YWEzMzQ1OTEyZGQ2NjRkZjlhOTAw NzEwZWI3ZTEwY2VjYWJkYS4uY2UwOTllYzM1YjE1YmQ0NzBkYmU1YWNhNTAwOGJjYzVjMWE5ZDJj MCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvc2VydmVy cy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvc2VydmVycy9hcGFjaGVfaHR0cF9zZXJ2ZXIucHkKQEAgLTEzNyw2ICsxMzcsMTEg QEAgY2xhc3MgTGF5b3V0VGVzdEFwYWNoZUh0dHBkKGh0dHBfc2VydmVyX2Jhc2UuSHR0cFNlcnZl ckJhc2UpOgogICAgICAgICByZXR1cm4gaW50KHNlbGYuX2ZpbGVzeXN0ZW0ucmVhZF90ZXh0X2Zp bGUoc2VsZi5fcGlkX2ZpbGUpKQogCiAgICAgZGVmIF9zdG9wX3J1bm5pbmdfc2VydmVyKHNlbGYp OgorICAgICAgICAjIElmIGFwYWNoZSB3YXMgZm9yY2VmdWxseSBraWxsZWQsIHRoZSBwaWQgZmls ZSB3aWxsIG5vdCBoYXZlIGJlZW4gZGVsZXRlZCwgc28gY2hlY2sKKyAgICAgICAgIyB0aGF0IHRo ZSBwcm9jZXNzIHNwZWNpZmllZCBieSB0aGUgcGlkX2ZpbGUgbm8gbG9uZ2VyIGV4aXN0cyBiZWZv cmUgZGVsZXRpbmcgdGhlIGZpbGUuCisgICAgICAgIGlmIHNlbGYuX3BpZCBhbmQgbm90IHNlbGYu X2V4ZWN1dGl2ZS5jaGVja19ydW5uaW5nX3BpZChzZWxmLl9waWQpOgorICAgICAgICAgICAgc2Vs Zi5fZmlsZXN5c3RlbS5yZW1vdmUoc2VsZi5fcGlkX2ZpbGUpCisKICAgICAgICAgcmV0dmFsLCBl cnIgPSBzZWxmLl9ydW4oc2VsZi5fc3RvcF9jbWQpCiAgICAgICAgIGlmIHJldHZhbCBvciBsZW4o ZXJyKToKICAgICAgICAgICAgIHJhaXNlIGh0dHBfc2VydmVyX2Jhc2UuU2VydmVyRXJyb3IoJ0Zh aWxlZCB0byBzdG9wICVzOiAlcycgJSAoc2VsZi5fbmFtZSwgZXJyKSkK