84171 2012-04-17 11:21:37 -0700 WebCore::EventTarget::addEventListener crash 2012-04-24 07:49:59 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 fmalita fmalita ap webkit.review.bot zimmermann oldest_to_newest 604168 0 137564 fmalita 2012-04-17 11:21:37 -0700 Created attachment 137564 Crash repro. [2134:2134:166495129177:ERROR:process_util_posix.cc(143)] Received signal 11 base::debug::StackTrace::StackTrace() [0x7fc4ae32ea9e] base::(anonymous namespace)::StackDumpSignalHandler() [0x7fc4ae38d549] 0x7fc4a2c15af0 WebCore::Node::addEventListener() [0x7fc4a973e06f] WebCore::SVGTRefElement::buildPendingResource() [0x7fc4a9ad54d0] WebCore::SVGTRefElement::insertedIntoDocument() [0x7fc4a9ad5587] WebCore::notifyChildInserted() [0x7fc4a969dbd4] WebCore::updateTreeAfterInsertion() [0x7fc4a969e62a] WebCore::ContainerNode::appendChild() [0x7fc4a969c139] WebCore::SVGUseElement::buildShadowTree() [0x7fc4a9aea930] WebCore::SVGUseElement::buildShadowAndInstanceTree() [0x7fc4a9ae9c99] WebCore::SVGUseElement::buildPendingResource() [0x7fc4a9ae9873] WebCore::SVGUseElement::finishParsingChildren() [0x7fc4a9aebefc] WebCore::XMLDocumentParser::endElementNs() [0x7fc4aa3dbeea] WebCore::endElementNsHandler() [0x7fc4aa3dce87] xmlParseTryOrFinish [0x7fc4aa5e136b] xmlParseChunk [0x7fc4aa5e387f] WebCore::XMLDocumentParser::doWrite() [0x7fc4aa3db105] WebCore::XMLDocumentParser::append() [0x7fc4aa3d7bd6] WebCore::DecodedDataDocumentParser::appendBytes() [0x7fc4a96a6884] WebCore::DocumentWriter::addData() [0x7fc4aa275c60] Chromium bug: http://code.google.com/p/chromium/issues/detail?id=123465 Most likely introduced in http://trac.webkit.org/changeset/108082 605112 1 ap 2012-04-18 14:47:46 -0700 ASSERTION FAILED: (*it)->shadowTreeElement() OpenSource/Source/WebCore/dom/Node.cpp(2482) : virtual bool WebCore::Node::addEventListener(const WTF::AtomicString &, PassRefPtr<WebCore::EventListener>, bool) 1 0x105397b58 WebCore::SVGTRefElement::buildPendingResource() 2 0x105397c70 WebCore::SVGTRefElement::insertedInto(WebCore::Node*) 3 0x103f7f009 WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument(WebCore::Node*) 4 0x103f7cae2 WebCore::ChildNodeInsertionNotifier::notify(WebCore::Node*) 5 0x103f792c7 _ZN7WebCoreL24updateTreeAfterInsertionEPNS_13ContainerNodeEPNS_4NodeEb 6 0x103f78d6d WebCore::ContainerNode::appendChild(WTF::PassRefPtr<WebCore::Node>, int&, bool) 7 0x10539c17c WebCore::SVGUseElement::buildShadowTree(WebCore::SVGElement*, WebCore::SVGElementInstance*) 8 0x10539bb15 WebCore::SVGUseElement::buildShadowAndInstanceTree(WebCore::SVGElement*) 9 0x10539b6b9 WebCore::SVGUseElement::buildPendingResource() 10 0x10539e2a2 WebCore::SVGUseElement::finishParsingChildren() 608056 2 fmalita 2012-04-23 15:11:12 -0700 I believe I got to the bottom of this. SVGUseElement::buildShadowAndInstanceTree(): m_targetElementInstance = SVGElementInstance::create(this, this, target); ... buildShadowTree(target, m_targetElementInstance.get()); ... associateInstancesWithShadowTreeElements(shadowTreeRootElement->firstChild(), m_targetElementInstance.get()); ... transferEventListenersToShadowTree(m_targetElementInstance.get()); ... BuildShadowTree() triggers SVGTRefElement::buildPendingResource() for the shadow <tref> node, which in turn attempts to install event handlers on the target node (same <tref> in this example). The problem is that Node::addEventListener() asserts that each element instance must have an associated shadow tree entry - but buildShadowAndInstanceTree() only sets up the instance<->shadow pointers later (associateInstancesWithShadowTreeElements). We can prevent this by skipping event handler activation for shadow tree tref's in SVGTRefElement::buildPendingResource(), as buildShadowAndInstanceTree() copies the active handlers anyway (transferEventListenersToShadowTree). 608133 3 138446 fmalita 2012-04-23 15:56:01 -0700 Created attachment 138446 Patch 608557 4 138446 zimmermann 2012-04-24 05:00:28 -0700 Comment on attachment 138446 Patch Looks great, r=me in case cr-linux EWS turns green. 608606 5 138549 fmalita 2012-04-24 06:40:26 -0700 Created attachment 138549 Patch for landing 608658 6 138549 webkit.review.bot 2012-04-24 07:49:54 -0700 Comment on attachment 138549 Patch for landing Clearing flags on attachment: 138549 Committed r115053: <http://trac.webkit.org/changeset/115053> 608659 7 webkit.review.bot 2012-04-24 07:49:59 -0700 All reviewed patches have been landed. Closing bug. 137564 2012-04-17 11:21:37 -0700 2012-04-17 11:21:37 -0700 Crash repro. test.svg image/svg+xml 155 fmalita PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4gIAo8dHJlZiB4bGluazpocmVmPSIjdHJlZiIgaWQ9 InRyZWYiLz4KPHVzZSB4bGluazpocmVmPSIjdHJlZiIvPgo8L3N2Zz4= 138446 2012-04-23 15:56:01 -0700 2012-04-24 06:40:21 -0700 Patch bug-84171-20120423185559.patch text/plain 4361 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyNjZmY2Q1NjA1NzAx NjMwN2U2OWU4NDk5YjAyZmE0ZjMwOTY3OS4uMmMzOGFjMzQ3NTI3NTk4MTkzNzhmMGJkZjk0MGMy MTFkYWZjNDk5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTIzICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViQ29yZTo6RXZl bnRUYXJnZXQ6OmFkZEV2ZW50TGlzdGVuZXIgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogc3ZnL2N1c3RvbS91c2UtdHJlZi1jcmFzaC5z dmcKKworICAgICAgICBBZGRpbmcgdHJlZiB0YXJnZXQgZXZlbnQgbGlzdGVuZXJzIHdoaWxlIGJ1 aWxkaW5nIHRoZSBzaGFkb3cgdHJlZSBpcworICAgICAgICBwcm9ibGVtYXRpYywgYmVjYXVzZSBT VkdVc2VFbGVtZW50OjpidWlsZFNoYWRvd0FuZEluc3RhbmNlVHJlZSgpIG9ubHkKKyAgICAgICAg c2V0cyB0aGUgZWxlbWVudCBpbnN0YW5jZTwtPnNoYWRvdyBlbGVtZW50IGFzc29jaWF0aW9uIGF0 IGEgbGF0ZXIgdGltZS4KKworICAgICAgICBGb3J0dW5hdGVseSwgYnVpbGRTaGFkb3dBbmRJbnN0 YW5jZVRyZWUoKSBhbHNvIHByb3BhZ2F0ZXMgdGhlIGV2ZW50CisgICAgICAgIGhhbmRsZXJzICh0 cmFuc2ZlckV2ZW50TGlzdGVuZXJzVG9TaGFkb3dUcmVlKSAtIHNvIHdlIGNhbiBzaW1wbHkgc2tp cAorICAgICAgICB0aGVtIGluIFNWR1RSZWZFbGVtZW50OjpidWlsZFBlbmRpbmdSZXNvdXJjZSgp IGZvciBzaGFkb3cgZWxlbWVudHMuCisKKyAgICAgICAgKiBzdmcvU1ZHVFJlZkVsZW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U1ZHVFJlZkVsZW1lbnQ6OmJ1aWxkUGVuZGluZ1Jlc291cmNl KToKKwogMjAxMi0wNC0yMyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4K IAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBpbXByb3ZlIHRoZSB3YXkgaGVhcCBzbmFwc2hvdCBk aWZmIGlzIGNhbGN1bGF0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUUmVm RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVFJlZkVsZW1lbnQuY3BwCmluZGV4 IDg2YTczN2M3YTAxYjQ5M2Q3ZjM3M2NhMmQwM2VmNWIzN2RmZWFjMmMuLjE0MDI0Y2VhNTczOWM0 OGExYzEyMjE0ZThhNjlhMjY5NjZkZTRjNmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2 Zy9TVkdUUmVmRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVt ZW50LmNwcApAQCAtMjgxLDkgKzI4MSwxNSBAQCB2b2lkIFNWR1RSZWZFbGVtZW50OjpidWlsZFBl bmRpbmdSZXNvdXJjZSgpCiAKICAgICB1cGRhdGVSZWZlcmVuY2VkVGV4dCgpOwogCi0gICAgbV9l dmVudExpc3RlbmVyID0gVGFyZ2V0TGlzdGVuZXI6OmNyZWF0ZSh0aGlzLCBpZCk7Ci0gICAgdGFy Z2V0LT5hZGRFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5ET01TdWJ0cmVlTW9kaWZpZWRFdmVu dCwgbV9ldmVudExpc3RlbmVyLmdldCgpLCBmYWxzZSk7Ci0gICAgdGFyZ2V0LT5hZGRFdmVudExp c3RlbmVyKGV2ZW50TmFtZXMoKS5ET01Ob2RlUmVtb3ZlZEZyb21Eb2N1bWVudEV2ZW50LCBtX2V2 ZW50TGlzdGVuZXIuZ2V0KCksIGZhbHNlKTsKKyAgICAvLyBEb24ndCBzZXQgdXAgZXZlbnQgbGlz dGVuZXJzIGlmIHRoaXMgaXMgYSBzaGFkb3cgdHJlZSBub2RlLgorICAgIC8vIFNWR1VzZUVsZW1l bnQ6OnRyYW5zZmVyRXZlbnRMaXN0ZW5lcnNUb1NoYWRvd1RyZWUoKSBoYW5kbGVzIHRoaXMgdGFz aywgYW5kIGFkZEV2ZW50TGlzdGVuZXIoKQorICAgIC8vIGV4cGVjdHMgZXZlcnkgZWxlbWVudCBp bnN0YW5jZSB0byBoYXZlIGFuIGFzc29jaWF0ZWQgc2hhZG93IHRyZWUgZWxlbWVudCAtIHdoaWNo IGlzIG5vdCB0aGUKKyAgICAvLyBjYXNlIHdoZW4gd2UgbGFuZCBoZXJlIGZyb20gU1ZHVXNlRWxl bWVudDo6YnVpbGRTaGFkb3dUcmVlKCkuCisgICAgaWYgKCFpc0luU2hhZG93VHJlZSgpKSB7Cisg ICAgICAgIG1fZXZlbnRMaXN0ZW5lciA9IFRhcmdldExpc3RlbmVyOjpjcmVhdGUodGhpcywgaWQp OworICAgICAgICB0YXJnZXQtPmFkZEV2ZW50TGlzdGVuZXIoZXZlbnROYW1lcygpLkRPTVN1YnRy ZWVNb2RpZmllZEV2ZW50LCBtX2V2ZW50TGlzdGVuZXIuZ2V0KCksIGZhbHNlKTsKKyAgICAgICAg dGFyZ2V0LT5hZGRFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5ET01Ob2RlUmVtb3ZlZEZyb21E b2N1bWVudEV2ZW50LCBtX2V2ZW50TGlzdGVuZXIuZ2V0KCksIGZhbHNlKTsKKyAgICB9CiB9CiAK IE5vZGU6Okluc2VydGlvbk5vdGlmaWNhdGlvblJlcXVlc3QgU1ZHVFJlZkVsZW1lbnQ6Omluc2Vy dGVkSW50byhOb2RlKiByb290UGFyZW50KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGIyZTgxMDRjNTI3MGI2NDY4ZTIwNTU2 MjQ5OTNjNGRlMjQ1MDYyODUuLmM0OGE3YmJlNzBkODM3NjQyM2FjM2ZlODgyYjlmNzYxODk1ODMw ZmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wNC0yMyAgRmxvcmluIE1hbGl0YSAgPGZt YWxpdGFAZ29vZ2xlLmNvbT4KKworICAgICAgICBXZWJDb3JlOjpFdmVudFRhcmdldDo6YWRkRXZl bnRMaXN0ZW5lciBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQxNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIHN2Zy9jdXN0b20vdXNlLXRyZWYtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4K KyAgICAgICAgKiBzdmcvY3VzdG9tL3VzZS10cmVmLWNyYXNoLnN2ZzogQWRkZWQuCisKIDIwMTIt MDQtMjMgIE1pa2hhaWwgTmFnYW5vdiAgPG1uYWdhbm92QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbQ2hyb21pdW1dIFVucmV2aWV3ZWQgdGVzdCBleHBlY3RhdGlvbnMgdXBkYXRlLgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtdHJlZi1jcmFzaC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS10cmVmLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4yOWVlM2MzZTg4MzJmMDhlZTg2MTlmNmM1OTM4NjFkNTFjZmFmYWRjCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtdHJlZi1jcmFzaC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSBAQAorUEFTUyAobm90IGNyYXNoaW5nKSAtLSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQxNzEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L3N2Zy9jdXN0b20vdXNlLXRyZWYtY3Jhc2guc3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS91 c2UtdHJlZi1jcmFzaC5zdmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGNiNzU4YzE3ZTI3MWQ4ODUwMmMzYmNkMDMx ZTQwMzhjMjU4N2M5MgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20v dXNlLXRyZWYtY3Jhc2guc3ZnCkBAIC0wLDAgKzEsMTQgQEAKKzw/eG1sIHZlcnNpb249IjEuMCIg ZW5jb2Rpbmc9IlVURi04Ij8+Cis8c3ZnIHhtbG5zOnN2Zz0iaHR0cDovL3d3dy53My5vcmcvMjAw MC9zdmciIAorICAgICB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIAorICAgICB4 bWxuczp4bGluaz0iaHR0cDovL3d3dy53My5vcmcvMTk5OS94bGluayI+CisKKyAgPHRyZWYgeGxp bms6aHJlZj0iI3RyZWYiIGlkPSJ0cmVmIi8+CisgIDx1c2UgeGxpbms6aHJlZj0iI3RyZWYiLz4K KyAgPHRleHQ+UEFTUyAobm90IGNyYXNoaW5nKSAtLSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODQxNzE8L3RleHQ+CisKKyAgPHNjcmlwdD4KKyAgICBpZiAod2luZG93 LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFz VGV4dCgpOworICA8L3NjcmlwdD4KKzwvc3ZnPgo= 138549 2012-04-24 06:40:26 -0700 2012-04-24 07:49:54 -0700 Patch for landing bug-84171-20120424094024.patch text/plain 4369 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0ODk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWIyNjZmY2Q1NjA1NzAx NjMwN2U2OWU4NDk5YjAyZmE0ZjMwOTY3OS4uOTY4MGJiNmM5Y2ZkYjA2ZDI0ZTdhMjA3MjhhNWQ1 N2NjOWMwYjUwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA0LTIzICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViQ29yZTo6RXZl bnRUYXJnZXQ6OmFkZEV2ZW50TGlzdGVuZXIgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTmlr b2xhcyBaaW1tZXJtYW5uLgorCisgICAgICAgIFRlc3Q6IHN2Zy9jdXN0b20vdXNlLXRyZWYtY3Jh c2guc3ZnCisKKyAgICAgICAgQWRkaW5nIHRyZWYgdGFyZ2V0IGV2ZW50IGxpc3RlbmVycyB3aGls ZSBidWlsZGluZyB0aGUgc2hhZG93IHRyZWUgaXMKKyAgICAgICAgcHJvYmxlbWF0aWMsIGJlY2F1 c2UgU1ZHVXNlRWxlbWVudDo6YnVpbGRTaGFkb3dBbmRJbnN0YW5jZVRyZWUoKSBvbmx5CisgICAg ICAgIHNldHMgdGhlIGVsZW1lbnQgaW5zdGFuY2U8LT5zaGFkb3cgZWxlbWVudCBhc3NvY2lhdGlv biBhdCBhIGxhdGVyIHRpbWUuCisKKyAgICAgICAgRm9ydHVuYXRlbHksIGJ1aWxkU2hhZG93QW5k SW5zdGFuY2VUcmVlKCkgYWxzbyBwcm9wYWdhdGVzIHRoZSBldmVudAorICAgICAgICBoYW5kbGVy cyAodHJhbnNmZXJFdmVudExpc3RlbmVyc1RvU2hhZG93VHJlZSkgLSBzbyB3ZSBjYW4gc2ltcGx5 IHNraXAKKyAgICAgICAgdGhlbSBpbiBTVkdUUmVmRWxlbWVudDo6YnVpbGRQZW5kaW5nUmVzb3Vy Y2UoKSBmb3Igc2hhZG93IGVsZW1lbnRzLgorCisgICAgICAgICogc3ZnL1NWR1RSZWZFbGVtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1RSZWZFbGVtZW50OjpidWlsZFBlbmRpbmdSZXNv dXJjZSk6CisKIDIwMTItMDQtMjMgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogaW1wcm92ZSB0aGUgd2F5IGhlYXAgc25hcHNo b3QgZGlmZiBpcyBjYWxjdWxhdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZH VFJlZkVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1RSZWZFbGVtZW50LmNwcApp bmRleCA4NmE3MzdjN2EwMWI0OTNkN2YzNzNjYTJkMDNlZjViMzdkZmVhYzJjLi4xNDAyNGNlYTU3 MzljNDhhMWMxMjIxNGU4YTY5YTI2OTY2ZGU0YzZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHVFJlZkVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdUUmVm RWxlbWVudC5jcHAKQEAgLTI4MSw5ICsyODEsMTUgQEAgdm9pZCBTVkdUUmVmRWxlbWVudDo6YnVp bGRQZW5kaW5nUmVzb3VyY2UoKQogCiAgICAgdXBkYXRlUmVmZXJlbmNlZFRleHQoKTsKIAotICAg IG1fZXZlbnRMaXN0ZW5lciA9IFRhcmdldExpc3RlbmVyOjpjcmVhdGUodGhpcywgaWQpOwotICAg IHRhcmdldC0+YWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuRE9NU3VidHJlZU1vZGlmaWVk RXZlbnQsIG1fZXZlbnRMaXN0ZW5lci5nZXQoKSwgZmFsc2UpOwotICAgIHRhcmdldC0+YWRkRXZl bnRMaXN0ZW5lcihldmVudE5hbWVzKCkuRE9NTm9kZVJlbW92ZWRGcm9tRG9jdW1lbnRFdmVudCwg bV9ldmVudExpc3RlbmVyLmdldCgpLCBmYWxzZSk7CisgICAgLy8gRG9uJ3Qgc2V0IHVwIGV2ZW50 IGxpc3RlbmVycyBpZiB0aGlzIGlzIGEgc2hhZG93IHRyZWUgbm9kZS4KKyAgICAvLyBTVkdVc2VF bGVtZW50Ojp0cmFuc2ZlckV2ZW50TGlzdGVuZXJzVG9TaGFkb3dUcmVlKCkgaGFuZGxlcyB0aGlz IHRhc2ssIGFuZCBhZGRFdmVudExpc3RlbmVyKCkKKyAgICAvLyBleHBlY3RzIGV2ZXJ5IGVsZW1l bnQgaW5zdGFuY2UgdG8gaGF2ZSBhbiBhc3NvY2lhdGVkIHNoYWRvdyB0cmVlIGVsZW1lbnQgLSB3 aGljaCBpcyBub3QgdGhlCisgICAgLy8gY2FzZSB3aGVuIHdlIGxhbmQgaGVyZSBmcm9tIFNWR1Vz ZUVsZW1lbnQ6OmJ1aWxkU2hhZG93VHJlZSgpLgorICAgIGlmICghaXNJblNoYWRvd1RyZWUoKSkg eworICAgICAgICBtX2V2ZW50TGlzdGVuZXIgPSBUYXJnZXRMaXN0ZW5lcjo6Y3JlYXRlKHRoaXMs IGlkKTsKKyAgICAgICAgdGFyZ2V0LT5hZGRFdmVudExpc3RlbmVyKGV2ZW50TmFtZXMoKS5ET01T dWJ0cmVlTW9kaWZpZWRFdmVudCwgbV9ldmVudExpc3RlbmVyLmdldCgpLCBmYWxzZSk7CisgICAg ICAgIHRhcmdldC0+YWRkRXZlbnRMaXN0ZW5lcihldmVudE5hbWVzKCkuRE9NTm9kZVJlbW92ZWRG cm9tRG9jdW1lbnRFdmVudCwgbV9ldmVudExpc3RlbmVyLmdldCgpLCBmYWxzZSk7CisgICAgfQog fQogCiBOb2RlOjpJbnNlcnRpb25Ob3RpZmljYXRpb25SZXF1ZXN0IFNWR1RSZWZFbGVtZW50Ojpp bnNlcnRlZEludG8oTm9kZSogcm9vdFBhcmVudCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0No YW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiMmU4MTA0YzUyNzBiNjQ2OGUy MDU1NjI0OTkzYzRkZTI0NTA2Mjg1Li5hODQwY2I4MWI0ZjMyYTA1OTYzNjlkMmRmMGFkNzI0YWI4 NTM4YTFiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDQtMjMgIEZsb3JpbiBNYWxpdGEg IDxmbWFsaXRhQGdvb2dsZS5jb20+CisKKyAgICAgICAgV2ViQ29yZTo6RXZlbnRUYXJnZXQ6OmFk ZEV2ZW50TGlzdGVuZXIgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTmlrb2xhcyBaaW1tZXJt YW5uLgorCisgICAgICAgICogc3ZnL2N1c3RvbS91c2UtdHJlZi1jcmFzaC1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIHN2Zy9jdXN0b20vdXNlLXRyZWYtY3Jhc2guc3ZnOiBBZGRlZC4K KwogMjAxMi0wNC0yMyAgTWlraGFpbCBOYWdhbm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZCB0ZXN0IGV4cGVjdGF0aW9ucyB1cGRhdGUu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS10cmVmLWNyYXNoLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vdXNlLXRyZWYtY3Jhc2gtZXhwZWN0ZWQu dHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjI5ZWUzYzNlODgzMmYwOGVlODYxOWY2YzU5Mzg2MWQ1MWNmYWZhZGMK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL3VzZS10cmVmLWNyYXNo LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTIChub3QgY3Jhc2hpbmcpIC0tIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3MQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvc3ZnL2N1c3RvbS91c2UtdHJlZi1jcmFzaC5zdmcgYi9MYXlvdXRUZXN0cy9zdmcv Y3VzdG9tL3VzZS10cmVmLWNyYXNoLnN2ZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kY2I3NThjMTdlMjcxZDg4NTAy YzNiY2QwMzFlNDAzOGMyNTg3YzkyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvc3Zn L2N1c3RvbS91c2UtdHJlZi1jcmFzaC5zdmcKQEAgLTAsMCArMSwxNCBAQAorPD94bWwgdmVyc2lv bj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4KKzxzdmcgeG1sbnM6c3ZnPSJodHRwOi8vd3d3Lncz Lm9yZy8yMDAwL3N2ZyIgCisgICAgIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIg CisgICAgIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIj4KKworICA8 dHJlZiB4bGluazpocmVmPSIjdHJlZiIgaWQ9InRyZWYiLz4KKyAgPHVzZSB4bGluazpocmVmPSIj dHJlZiIvPgorICA8dGV4dD5QQVNTIChub3QgY3Jhc2hpbmcpIC0tIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDE3MTwvdGV4dD4KKworICA8c2NyaXB0PgorICAgIGlm ICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICBsYXlvdXRUZXN0Q29udHJvbGxl ci5kdW1wQXNUZXh0KCk7CisgIDwvc2NyaXB0PgorPC9zdmc+Cg==