8417 2006-04-15 17:58:17 -0700 make-css-file-arrays.pl hangs when run on Linux 2006-04-16 20:07:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC Linux RESOLVED FIXED P2 Normal --- 1 kevino darin bugs-webkit oldest_to_newest 39390 0 kevino 2006-04-15 17:58:17 -0700 When WebCore/DerivedSources.make is run on Linux (tested on FC4), WebCore/css/make-css-file-arrays.pl hangs. Patch is attached. (tested on FC4, OS X 10.4.6 Intel and WinXP SP2/Cygwin) 39391 1 7736 kevino 2006-04-15 17:59:14 -0700 Created attachment 7736 patch for DerivedSources.make that fixes the hang. 39397 2 eric 2006-04-15 18:28:12 -0700 Be sure to mark your patch for review. Also, I think we've generally used #include <assert.h> instead of <cassert> 39450 3 7736 darin 2006-04-16 19:26:38 -0700 Comment on attachment 7736 patch for DerivedSources.make that fixes the hang. A few comments: First, this is not a patch for DerivedSources.make! Second, patches should include change log comments. Third, include in RenderArena.cpp should be <assert.h>, not <cassert>, to match usage in the rest of the project. But I think all of these are minor and it's good to just land this, so I will do it as soon as possible. r=me 7736 2006-04-15 17:59:14 -0700 2006-04-16 19:26:38 -0700 patch for DerivedSources.make that fixes the hang. make-css-file-arrays.patch text/plain 816 kevino SW5kZXg6IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckFyZW5hLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJBcmVuYS5jcHAJKHJldmlzaW9uIDEzODc3KQorKysgV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQXJlbmEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICsz Niw3IEBACiAKICNpbmNsdWRlIDxzdHJpbmcuaD4KICNpbmNsdWRlIDxzdGRsaWIuaD4KKyNpbmNs dWRlIDxjYXNzZXJ0PgogCiAjaW5jbHVkZSAiUmVuZGVyQXJlbmEuaCIKIApJbmRleDogV2ViQ29y ZS9jc3MvbWFrZS1jc3MtZmlsZS1hcnJheXMucGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9jc3Mv bWFrZS1jc3MtZmlsZS1hcnJheXMucGwJKHJldmlzaW9uIDEzODc3KQorKysgV2ViQ29yZS9jc3Mv bWFrZS1jc3MtZmlsZS1hcnJheXMucGwJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAg Zm9yIG15ICRpbiAoQEFSR1YpIHsKICAgICBteSAkbmFtZSA9ICQxOwogCiAgICAgIyBTbHVycCBp biB0aGUgQ1NTIGZpbGUuCi0gICAgb3BlbiBJTiwgIi18IiwgIi91c3IvYmluL2NwcCIsICItUCIs ICRpbiwgIi0iIG9yIGRpZTsKKyAgICBvcGVuIElOLCAiLXwiLCAiL3Vzci9iaW4vY3BwIiwgIi1Q IiwgJGluIG9yIGRpZTsKICAgICBteSAkdGV4dDsgeyBsb2NhbCAkLzsgJHRleHQgPSA8SU4+OyB9 CiAgICAgY2xvc2UgSU47CiAK