84169 2012-04-17 11:06:22 -0700 [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP 2012-04-19 15:13:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84170 84342 1 tmpsantos tmpsantos gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 604157 0 tmpsantos 2012-04-17 11:06:22 -0700 DRT is creating all the databases inside ~/.webkit. This is causing unreliable/flaky tests results (specially when running tests in parallel). 605816 1 137960 tmpsantos 2012-04-19 13:17:48 -0700 Created attachment 137960 add DUMPRENDERTREE_TEMP support to EFL's DRT 605858 2 137960 rakuco 2012-04-19 14:02:02 -0700 Comment on attachment 137960 add DUMPRENDERTREE_TEMP support to EFL's DRT While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that? 605872 3 137960 eric 2012-04-19 14:13:31 -0700 Comment on attachment 137960 add DUMPRENDERTREE_TEMP support to EFL's DRT Icky String-concat api. 605894 4 tmpsantos 2012-04-19 14:23:34 -0700 (In reply to comment #2) > (From update of attachment 137960 [details]) > While the change does make the port behave more similarly to other ports, I'd be glad if you could share more details about the problems you were experiencing -- were multiple tests writing to the same locations or something like that? When running database tests, they will all create databases at ~/.webkit/. Some tests might be testing concurrency, quota, stress and all sort of things. It generates some random results and timeouts if many tests are running in parallel (and some fail due to other tests leftovers). After this patch, they will go to a private temporary folder like /tmp/DumpRenderTree-ABCDE/Databases/ which is cleaned up later. Not to mention that DRT might potentially screw up the developer environment since ~/.webkit is the default for EWK (imagine if you are working on a browser as well). :) 605983 5 137960 webkit.review.bot 2012-04-19 15:12:57 -0700 Comment on attachment 137960 add DUMPRENDERTREE_TEMP support to EFL's DRT Clearing flags on attachment: 137960 Committed r114682: <http://trac.webkit.org/changeset/114682> 605984 6 webkit.review.bot 2012-04-19 15:13:02 -0700 All reviewed patches have been landed. Closing bug. 137960 2012-04-19 13:17:48 -0700 2012-04-19 15:12:57 -0700 add DUMPRENDERTREE_TEMP support to EFL's DRT drt_storage_folder.patch text/plain 1576 tmpsantos ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBhNDll NzNjLi42NzUzYTQwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMTkgIFRoaWFnbyBNYXJjb3MgUC4gU2Fu dG9zICA8dGhpYWdvLnNhbnRvc0BpbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW0RSVF0gU2hv dWxkIGNyZWF0ZSBvZmZsaW5lIHN0b3JhZ2UgaW5zaWRlIERVTVBSRU5ERVJUUkVFX1RFTVAKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTY5CisKKyAg ICAgICAgQWxsIGRhdGFiYXNlcyB3ZXJlIGJlaW5nIGNyZWF0ZWQgaW5zaWRlIH4vLndlYmtpdCB3 aGljaCB3YXMgY2F1c2luZworICAgICAgICBmbGFreSB0ZXN0cyB3aGVuIHJ1bm5pbmcgbXVsdGlw bGUgdGVzdHMgaW4gcGFyYWxsZWwsIHNwZWNpYWxseSB0aW1lb3V0cworICAgICAgICBkdWUgdG8g Y29uY3VycmVuY3kuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwOgorICAg ICAgICAoRHVtcFJlbmRlclRyZWVDaHJvbWU6OmluaXRpYWxpemUpOgorCiAyMDEyLTA0LTE5ICBE b21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0BsaW51eC5pbnRlbC5jb20+CiAK ICAgICAgICAgW0dUS10gMyBmYXN0LyBsYXlvdXQgdGVzdHMgZmFpbGluZyBhZnRlciB1cGdyYWRp bmcgbGlic291cCB0byAyLjM3LjkyCmRpZmYgLS1naXQgYS9Ub29scy9EdW1wUmVuZGVyVHJlZS9l ZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvZWZsL0R1 bXBSZW5kZXJUcmVlQ2hyb21lLmNwcAppbmRleCAyNTBlY2VjLi4zMTExM2M0IDEwMDY0NAotLS0g YS9Ub29scy9EdW1wUmVuZGVyVHJlZS9lZmwvRHVtcFJlbmRlclRyZWVDaHJvbWUuY3BwCisrKyBi L1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2VmbC9EdW1wUmVuZGVyVHJlZUNocm9tZS5jcHAKQEAgLTE0 MSw2ICsxNDEsMTUgQEAgYm9vbCBEdW1wUmVuZGVyVHJlZUNocm9tZTo6aW5pdGlhbGl6ZSgpCiAK ICAgICBtX21haW5GcmFtZSA9IGV3a192aWV3X2ZyYW1lX21haW5fZ2V0KG1fbWFpblZpZXcpOwog CisgICAgY2hhciogZHJ0VGVtcCA9IGdldGVudigiRFVNUFJFTkRFUlRSRUVfVEVNUCIpOworICAg IGlmIChkcnRUZW1wKSB7CisgICAgICAgIGNoYXIgcGF0aFsyMDQ4XTsKKyAgICAgICAgZWluYV9z dHJfam9pbihwYXRoLCBzaXplb2YocGF0aCksICcvJywgZHJ0VGVtcCwgIkxvY2FsU3RvcmFnZSIp OworICAgICAgICBld2tfc2V0dGluZ3NfbG9jYWxfc3RvcmFnZV9wYXRoX3NldChwYXRoKTsKKyAg ICAgICAgZWluYV9zdHJfam9pbihwYXRoLCBzaXplb2YocGF0aCksICcvJywgZHJ0VGVtcCwgIkRh dGFiYXNlcyIpOworICAgICAgICBld2tfc2V0dGluZ3Nfd2ViX2RhdGFiYXNlX3BhdGhfc2V0KHBh dGgpOworICAgIH0KKwogICAgIHJldHVybiB0cnVlOwogfQogCg==