84162 2012-04-17 10:26:19 -0700 media-exit-fullscreen-button (and related enums) is unnecessary and should be removed. 2023-10-12 12:50:23 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 84515 1 jer.noble jer.noble ahmad.saleem792 destra eric.carlson jer.noble webkit.review.bot oldest_to_newest 604121 0 jer.noble 2012-04-17 10:26:19 -0700 media-exit-fullscreen-button (and related enums) is unnecessary and should be removed. 604123 1 jer.noble 2012-04-17 10:28:19 -0700 That keyword was added in http://trac.webkit.org/changeset/111041 for (bug #70437). The state of the full screen button does not need to be reflected in CSS. 604231 2 137580 jer.noble 2012-04-17 12:12:22 -0700 Created attachment 137580 Patch 606926 3 137580 webkit.review.bot 2012-04-20 14:45:29 -0700 Comment on attachment 137580 Patch Rejecting attachment 137580 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: y/autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 113] No route to host> Full output: http://queues.webkit.org/results/12476285 606966 4 jer.noble 2012-04-20 15:34:14 -0700 Committed r114789: <http://trac.webkit.org/changeset/114789> 607082 5 jer.noble 2012-04-20 17:14:15 -0700 Rolled out commit in r114804. Committed r114804: <http://trac.webkit.org/changeset/114804> 607083 6 jer.noble 2012-04-20 17:14:39 -0700 Reopening after rollout. 1984674 7 ahmad.saleem792 2023-10-12 12:50:23 -0700 I didn't manage to find anything with this 'media-exit-fullscreen-button' except some tests in CSSOM and 'js' file for Developer Tools. I think we don't have these anymore and we can close this bug. CCing - Eric, Dana and Jer Noble. 137580 2012-04-17 12:12:22 -0700 2013-01-04 11:29:37 -0800 Patch bug-84162-20120417121221.patch text/plain 5519 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzU0N2NkNjBmMmZjMTI2 Njc0NTYxMDQ5ZWEzMmUwOWZiOWI5OGYwYy4uZTZjYzI2ZmYzZWY4ZDYwMjExNGYxM2ZjNDAyOWRj OTk0NTcwMDQ2NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTE3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIG1lZGlhLWV4aXQtZnVsbHNj cmVlbi1idXR0b24gKGFuZCByZWxhdGVkIGVudW1zKSBpcyB1bm5lY2Vzc2FyeSBhbmQgc2hvdWxk IGJlIHJlbW92ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD04NDE2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0czsgbm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkgc28gY292ZXJlZCBi eSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICBSZW1vdmUgdGhlIG1lZGlhLWV4aXQtZnVsbHNj cmVlbi1idXR0b24ga2V5d29yZCwgYW5kIHJlbmFtZSBtZWRpYS1lbnRlci1mdWxsc2NyZWVuLWJ1 dHRvbiB0bworICAgICAgICBtZWRpYS1mdWxsc2NyZWVuLWJ1dHRvbi4KKworICAgICAgICAqIGNz cy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmg6CisgICAgICAgIChXZWJDb3JlOjpDU1NQcmlt aXRpdmVWYWx1ZTo6Q1NTUHJpbWl0aXZlVmFsdWUpOgorICAgICAgICAqIGNzcy9DU1NWYWx1ZUtl eXdvcmRzLmluOgorICAgICAgICAqIGNzcy9tZWRpYUNvbnRyb2xzLmNzczoKKyAgICAgICAgKGF1 ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLWZ1bGxzY3JlZW4tYnV0dG9uLCB2aWRlbzo6LXdl YmtpdC1tZWRpYS1jb250cm9scy1mdWxsc2NyZWVuLWJ1dHRvbik6CisgICAgICAgICogcGxhdGZv cm0vVGhlbWVUeXBlcy5oOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZTo6cGFpbnQpOgorCiAyMDEyLTA0LTE2ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIEhUTUw1IFZpZGVvIEZ1bGwg U2NyZWVuIGJ1dHRvbiBicm9rZW4gKGxvb2tzIGxpa2Ugd2hpdGUgc3F1YXJlKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgKaW5kZXggYTMwNWYxOGI3 NDkyNTE4MTkzODQ3M2UwYTc5Y2VkMjk1ODkxOTgyZC4uMzM5MDBiNzA5YzZkOGYwYmZmMTdkNjM5 ZGNlY2E4YWYxYTRkMTg5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1ByaW1p dGl2ZVZhbHVlTWFwcGluZ3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZl VmFsdWVNYXBwaW5ncy5oCkBAIC0zNzEsMTEgKzM3MSw4IEBAIHRlbXBsYXRlPD4gaW5saW5lIENT U1ByaW1pdGl2ZVZhbHVlOjpDU1NQcmltaXRpdmVWYWx1ZShDb250cm9sUGFydCBlKQogICAgICAg ICBjYXNlIExpc3RJdGVtUGFydDoKICAgICAgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1 ZUxpc3RpdGVtOwogICAgICAgICAgICAgYnJlYWs7Ci0gICAgICAgIGNhc2UgTWVkaWFFbnRlckZ1 bGxzY3JlZW5CdXR0b25QYXJ0OgotICAgICAgICAgICAgbV92YWx1ZS5pZGVudCA9IENTU1ZhbHVl TWVkaWFFbnRlckZ1bGxzY3JlZW5CdXR0b247Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAg Y2FzZSBNZWRpYUV4aXRGdWxsc2NyZWVuQnV0dG9uUGFydDoKLSAgICAgICAgICAgIG1fdmFsdWUu aWRlbnQgPSBDU1NWYWx1ZU1lZGlhRXhpdEZ1bGxzY3JlZW5CdXR0b247CisgICAgICAgIGNhc2Ug TWVkaWFGdWxsc2NyZWVuQnV0dG9uUGFydDoKKyAgICAgICAgICAgIG1fdmFsdWUuaWRlbnQgPSBD U1NWYWx1ZU1lZGlhRnVsbHNjcmVlbkJ1dHRvbjsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICBjYXNlIE1lZGlhUGxheUJ1dHRvblBhcnQ6CiAgICAgICAgICAgICBtX3ZhbHVlLmlkZW50ID0g Q1NTVmFsdWVNZWRpYVBsYXlCdXR0b247CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv Q1NTVmFsdWVLZXl3b3Jkcy5pbiBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRz LmluCmluZGV4IDY0ODI4MTI0M2RmYWUwZWIwZDMxYTBmNjJmOGFkMmQxOGUwNjgzYWMuLmMzMWEz YTdjZTFjZDczMjM4MGE1YzJlZDdiODhlMTM0ZTAwODQ1ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NWYWx1ZUtleXdvcmRzLmluCkBAIC02MjIsOCArNjIyLDcgQEAgaW5uZXItc3Bpbi1idXR0b24K IC13ZWJraXQtaW5wdXQtc3BlZWNoLWJ1dHRvbgogbGlzdGJveAogbGlzdGl0ZW0KLW1lZGlhLWVu dGVyLWZ1bGxzY3JlZW4tYnV0dG9uCi1tZWRpYS1leGl0LWZ1bGxzY3JlZW4tYnV0dG9uCittZWRp YS1mdWxsc2NyZWVuLWJ1dHRvbgogbWVkaWEtZnVsbHNjcmVlbi12b2x1bWUtc2xpZGVyCiBtZWRp YS1mdWxsc2NyZWVuLXZvbHVtZS1zbGlkZXItdGh1bWIKIG1lZGlhLW11dGUtYnV0dG9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvbWVkaWFDb250cm9scy5jc3MgYi9Tb3VyY2UvV2Vi Q29yZS9jc3MvbWVkaWFDb250cm9scy5jc3MKaW5kZXggM2ZiN2U4OTY2YjdlODVkZGM1ZTJlODZi MmY3YzU1YzQ2NjZkOGNlMy4uYjgxMzMyZmM3NjEzYTI1OWY5N2U2MTFkNDc5M2Y0YTQyMWQ2MDQ2 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL21lZGlhQ29udHJvbHMuY3NzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2Nzcy9tZWRpYUNvbnRyb2xzLmNzcwpAQCAtMTUwLDcgKzE1MCw3IEBA IGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRyb2xzLXNlZWstZm9yd2FyZC1idXR0b24sIHZpZGVv Ojotd2Via2l0LW1lZGlhLWNvbnRyb2xzCiB9CiAKIGF1ZGlvOjotd2Via2l0LW1lZGlhLWNvbnRy b2xzLWZ1bGxzY3JlZW4tYnV0dG9uLCB2aWRlbzo6LXdlYmtpdC1tZWRpYS1jb250cm9scy1mdWxs c2NyZWVuLWJ1dHRvbiB7Ci0gICAgLXdlYmtpdC1hcHBlYXJhbmNlOiBtZWRpYS1lbnRlci1mdWxs c2NyZWVuLWJ1dHRvbjsKKyAgICAtd2Via2l0LWFwcGVhcmFuY2U6IG1lZGlhLWZ1bGxzY3JlZW4t YnV0dG9uOwogICAgIGRpc3BsYXk6IC13ZWJraXQtYm94OwogICAgIHdpZHRoOiAxNnB4OwogICAg IGhlaWdodDogMTZweDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RoZW1l VHlwZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RoZW1lVHlwZXMuaAppbmRleCAxMjA4 YTlhMmVlNTY2MzA4ZGNiMjRiZDIyMzhlMDdmZDRlMDA1NjY4Li5lYTUwZDM1YzhmNmViMDQ2ZTRj Nzk5NjFkODM2YjJjNTkwMGM0ODUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9UaGVtZVR5cGVzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVGhlbWVUeXBlcy5o CkBAIC00OCw3ICs0OCw3IEBAIHR5cGVkZWYgdW5zaWduZWQgQ29udHJvbFN0YXRlczsKIGVudW0g Q29udHJvbFBhcnQgewogICAgIE5vQ29udHJvbFBhcnQsIENoZWNrYm94UGFydCwgUmFkaW9QYXJ0 LCBQdXNoQnV0dG9uUGFydCwgU3F1YXJlQnV0dG9uUGFydCwgQnV0dG9uUGFydCwKICAgICBCdXR0 b25CZXZlbFBhcnQsIERlZmF1bHRCdXR0b25QYXJ0LCBJbm5lclNwaW5CdXR0b25QYXJ0LCBJbnB1 dFNwZWVjaEJ1dHRvblBhcnQsIExpc3Rib3hQYXJ0LCBMaXN0SXRlbVBhcnQsCi0gICAgTWVkaWFF bnRlckZ1bGxzY3JlZW5CdXR0b25QYXJ0LCBNZWRpYUV4aXRGdWxsc2NyZWVuQnV0dG9uUGFydCwg TWVkaWFGdWxsU2NyZWVuVm9sdW1lU2xpZGVyUGFydCwgTWVkaWFGdWxsU2NyZWVuVm9sdW1lU2xp ZGVyVGh1bWJQYXJ0LCBNZWRpYU11dGVCdXR0b25QYXJ0LCBNZWRpYVBsYXlCdXR0b25QYXJ0LCBN ZWRpYVNlZWtCYWNrQnV0dG9uUGFydCwgCisgICAgTWVkaWFGdWxsc2NyZWVuQnV0dG9uUGFydCwg TWVkaWFGdWxsU2NyZWVuVm9sdW1lU2xpZGVyUGFydCwgTWVkaWFGdWxsU2NyZWVuVm9sdW1lU2xp ZGVyVGh1bWJQYXJ0LCBNZWRpYU11dGVCdXR0b25QYXJ0LCBNZWRpYVBsYXlCdXR0b25QYXJ0LCBN ZWRpYVNlZWtCYWNrQnV0dG9uUGFydCwgCiAgICAgTWVkaWFTZWVrRm9yd2FyZEJ1dHRvblBhcnQs IE1lZGlhUmV3aW5kQnV0dG9uUGFydCwgTWVkaWFSZXR1cm5Ub1JlYWx0aW1lQnV0dG9uUGFydCwg TWVkaWFUb2dnbGVDbG9zZWRDYXB0aW9uc0J1dHRvblBhcnQsCiAgICAgTWVkaWFTbGlkZXJQYXJ0 LCBNZWRpYVNsaWRlclRodW1iUGFydCwgTWVkaWFWb2x1bWVTbGlkZXJDb250YWluZXJQYXJ0LCBN ZWRpYVZvbHVtZVNsaWRlclBhcnQsIE1lZGlhVm9sdW1lU2xpZGVyVGh1bWJQYXJ0LAogICAgIE1l ZGlhVm9sdW1lU2xpZGVyTXV0ZUJ1dHRvblBhcnQsIE1lZGlhQ29udHJvbHNCYWNrZ3JvdW5kUGFy dCwgTWVkaWFDb250cm9sc0Z1bGxzY3JlZW5CYWNrZ3JvdW5kUGFydCwgTWVkaWFDdXJyZW50VGlt ZVBhcnQsIE1lZGlhVGltZVJlbWFpbmluZ1BhcnQsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lLmNwcAppbmRleCBmMWJjMWZhMjU4OTU4NWViOGY3OWI5MGMwYzczYWY0YjJlZTM2 OTBlLi4wYzVkMWM5MTI3MGQzNGNiOTIxODg1MGIxYWEzM2VhY2YzNDA5YTFkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5jcHAKQEAgLTMwOCw4ICszMDgsNyBAQCBib29s IFJlbmRlclRoZW1lOjpwYWludChSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFBhaW50SW5mbyYgcGFp bnRJbmZvLCBjb25zdCBJbnRSZQogICAgICAgICBjYXNlIFNsaWRlclRodW1iSG9yaXpvbnRhbFBh cnQ6CiAgICAgICAgIGNhc2UgU2xpZGVyVGh1bWJWZXJ0aWNhbFBhcnQ6CiAgICAgICAgICAgICBy ZXR1cm4gcGFpbnRTbGlkZXJUaHVtYihvLCBwYWludEluZm8sIHIpOwotICAgICAgICBjYXNlIE1l ZGlhRW50ZXJGdWxsc2NyZWVuQnV0dG9uUGFydDoKLSAgICAgICAgY2FzZSBNZWRpYUV4aXRGdWxs c2NyZWVuQnV0dG9uUGFydDoKKyAgICAgICAgY2FzZSBNZWRpYUZ1bGxzY3JlZW5CdXR0b25QYXJ0 OgogICAgICAgICAgICAgcmV0dXJuIHBhaW50TWVkaWFGdWxsc2NyZWVuQnV0dG9uKG8sIHBhaW50 SW5mbywgcik7CiAgICAgICAgIGNhc2UgTWVkaWFQbGF5QnV0dG9uUGFydDoKICAgICAgICAgICAg IHJldHVybiBwYWludE1lZGlhUGxheUJ1dHRvbihvLCBwYWludEluZm8sIHIpOwo=