84152 2012-04-17 07:37:22 -0700 [BlackBerry] Pattern matching should be applied to numbers 2012-04-17 08:20:55 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 604009 0 mifenton 2012-04-17 07:37:22 -0700 Pattern matching should be added for number strings and treated a numeric input. 604012 1 137535 mifenton 2012-04-17 07:41:43 -0700 Created attachment 137535 Patch 604030 2 137535 webkit.review.bot 2012-04-17 08:20:51 -0700 Comment on attachment 137535 Patch Clearing flags on attachment: 137535 Committed r114380: <http://trac.webkit.org/changeset/114380> 604031 3 webkit.review.bot 2012-04-17 08:20:55 -0700 All reviewed patches have been landed. Closing bug. 137535 2012-04-17 07:41:43 -0700 2012-04-17 08:20:51 -0700 Patch 0001-2012-04-16-Mike-Fenton-mifenton-rim.com.patch text/plain 6534 mifenton RnJvbSAzNDRkYmEzNzMwODRkNjJjNGNmZGYzMDEzZmJmZDg1MWY3NzdmZDNkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog TW9uLCAxNiBBcHIgMjAxMiAxMjozMTo1OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDQt MTYgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUFIgMTQ4OTA2LgoK ICAgICAgICBBZGQgcGF0dGVybiBtYXRjaGluZyBmb3IgbnVtYmVyIGJhc2VkIG9uIFswLTldIHRv IHRyaWdnZXIKICAgICAgICBpbnB1dCBoZWxwIG1hdGNoaW5nIG51bWJlciBmaWVsZHMuCgogICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoKICAgICAgICAqIFdlYktpdFN1cHBvcnQv RE9NU3VwcG9ydC5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RE9NU3VwcG9ydDo6 ZWxlbWVudFBhdHRlcm5JbmRpY2F0ZXNOdW1iZXIpOgogICAgICAgIChET01TdXBwb3J0KToKICAg ICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0OjplbGVtZW50UGF0dGVybkluZGlj YXRlc0hleGFkZWNpbWFsKToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0 OjplbGVtZW50UGF0dGVybk1hdGNoZXMpOgogICAgICAgICogV2ViS2l0U3VwcG9ydC9ET01TdXBw b3J0Lmg6CiAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CiAgICAgICAg KEJsYWNrQmVycnk6OldlYktpdDo6Y29udmVydElucHV0VHlwZSk6Ci0tLQogU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDIxICsrKysrKysrKysr KysrCiAuLi4vV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcCB8 ICAgMzAgKysrKysrKysrKysrKy0tLS0tLQogLi4uL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1 cHBvcnQvRE9NU3VwcG9ydC5oICAgfCAgICAyICsKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBv cnQvSW5wdXRIYW5kbGVyLmNwcCAgICAgIHwgICAgMiArCiA0IGZpbGVzIGNoYW5nZWQsIDQ1IGlu c2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9n CmluZGV4IDg3ZmUyNjEuLmE2ZmIyMTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpA QCAtMSwzICsxLDI0IEBACisyMDEyLTA0LTE3ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5j b20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFBhdHRlcm4gbWF0Y2hpbmcgc2hvdWxkIGJlIGFw cGxpZWQgdG8gbnVtYmVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODQxNTIKKworICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgorCisg ICAgICAgIFBSIDE0ODkwNi4KKworICAgICAgICBBZGQgcGF0dGVybiBtYXRjaGluZyBmb3IgbnVt YmVyIGJhc2VkIG9uIFswLTldIHRvIHRyaWdnZXIKKyAgICAgICAgaW5wdXQgaGVscCBtYXRjaGlu ZyBudW1iZXIgZmllbGRzLgorCisgICAgICAgICogV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNw cDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6RE9NU3VwcG9ydDo6ZWxlbWVudFBhdHRl cm5JbmRpY2F0ZXNOdW1iZXIpOgorICAgICAgICAoRE9NU3VwcG9ydCk6CisgICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OkRPTVN1cHBvcnQ6OmVsZW1lbnRQYXR0ZXJuSW5kaWNhdGVzSGV4YWRl Y2ltYWwpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpET01TdXBwb3J0OjplbGVtZW50 UGF0dGVybk1hdGNoZXMpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5oOgor ICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNr QmVycnk6OldlYktpdDo6Y29udmVydElucHV0VHlwZSk6CisKIDIwMTItMDQtMTcgIEdlb3JnZSBT dGFpa29zICA8c3RhaWtvc0B3ZWJraXQub3JnPgogCiAgICAgICAgIEV4cG9ydCB0aGUgaW5pdGlh bGl6YXRpb24gZnVuY3Rpb24gc28gaXQgY2FuIGJlIGNhbGxlZCBlYXJsaWVyLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcApp bmRleCA5ODYzOGEwLi44OWM5ODg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9ET01TdXBwb3J0LmNwcApAQCAtMzk0LDM1ICszOTQsNDUgQEAg Ym9vbCBlbGVtZW50SWRPck5hbWVJbmRpY2F0ZXNOb0F1dG9jb21wbGV0ZShjb25zdCBFbGVtZW50 KiBlbGVtZW50KQogICAgIHJldHVybiBmYWxzZTsKIH0KIAorYm9vbCBlbGVtZW50UGF0dGVybklu ZGljYXRlc051bWJlcihjb25zdCBIVE1MSW5wdXRFbGVtZW50KiBpbnB1dEVsZW1lbnQpCit7Cisg ICAgcmV0dXJuIGVsZW1lbnRQYXR0ZXJuTWF0Y2hlcygiWzAtOV0iLCBpbnB1dEVsZW1lbnQpOwor fQorCiBib29sIGVsZW1lbnRQYXR0ZXJuSW5kaWNhdGVzSGV4YWRlY2ltYWwoY29uc3QgSFRNTElu cHV0RWxlbWVudCogaW5wdXRFbGVtZW50KQogewotICAgIGlmICghaW5wdXRFbGVtZW50KQorICAg IHJldHVybiBlbGVtZW50UGF0dGVybk1hdGNoZXMoIlswLTlhLWZBLUZdIiwgaW5wdXRFbGVtZW50 KTsKK30KKworYm9vbCBlbGVtZW50UGF0dGVybk1hdGNoZXMoY29uc3QgY2hhciogcGF0dGVybiwg Y29uc3QgSFRNTElucHV0RWxlbWVudCogaW5wdXRFbGVtZW50KQoreworICAgIFdURjo6U3RyaW5n IHBhdHRlcm5TdHJpbmcocGF0dGVybik7CisgICAgaWYgKCFpbnB1dEVsZW1lbnQgfHwgcGF0dGVy blN0cmluZy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChpbnB1 dEVsZW1lbnQtPmZhc3RIYXNBdHRyaWJ1dGUoSFRNTE5hbWVzOjpwYXR0ZXJuQXR0cikpIHsKLSAg ICAgICAgQXRvbWljU3RyaW5nIHBhdHRlcm5BdHRyaWJ1dGUgPSBpbnB1dEVsZW1lbnQtPmZhc3RH ZXRBdHRyaWJ1dGUoSFRNTE5hbWVzOjpwYXR0ZXJuQXR0cik7Ci0gICAgICAgIGlmIChwYXR0ZXJu QXR0cmlidXRlLnN0YXJ0c1dpdGgoIlswLTlhLWZBLUZdIikpIHsKKyAgICAgICAgV1RGOjpTdHJp bmcgcGF0dGVybkF0dHJpYnV0ZSA9IGlucHV0RWxlbWVudC0+ZmFzdEdldEF0dHJpYnV0ZShIVE1M TmFtZXM6OnBhdHRlcm5BdHRyKTsKKyAgICAgICAgaWYgKHBhdHRlcm5BdHRyaWJ1dGUuc3RhcnRz V2l0aChwYXR0ZXJuU3RyaW5nKSkgewogICAgICAgICAgICAgLy8gVGhlIHBhdHRlcm4gaXMgZm9y IGhleGFkZWNpbWFsLCBtYWtlIHN1cmUgbm90aGluZyBlbHNlIGlzIHBlcm1pdHRlZC4KIAogICAg ICAgICAgICAgLy8gQ2hlY2sgaWYgaXQgd2FzIGFuIGV4YWN0IG1hdGNoLgotICAgICAgICAgICAg aWYgKHBhdHRlcm5BdHRyaWJ1dGUubGVuZ3RoKCkgPT0gMTEpCisgICAgICAgICAgICBpZiAocGF0 dGVybkF0dHJpYnV0ZS5sZW5ndGgoKSA9PSBwYXR0ZXJuU3RyaW5nLmxlbmd0aCgpKQogICAgICAg ICAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgICAgICAgICAvLyBDaGVjayBmb3IgKgotICAg ICAgICAgICAgaWYgKHBhdHRlcm5BdHRyaWJ1dGUubGVuZ3RoKCkgPT0gMTIgJiYgcGF0dGVybkF0 dHJpYnV0ZVsxMV0gPT0gJyonKQorICAgICAgICAgICAgaWYgKHBhdHRlcm5BdHRyaWJ1dGUubGVu Z3RoKCkgPT0gcGF0dGVyblN0cmluZy5sZW5ndGgoKSArIDEgJiYgcGF0dGVybkF0dHJpYnV0ZVtw YXR0ZXJuU3RyaW5nLmxlbmd0aCgpXSA9PSAnKicpCiAgICAgICAgICAgICAgICAgcmV0dXJuIHRy dWU7CiAKICAgICAgICAgICAgIC8vIElzIHRoZSByZWdleCBzcGVjaWZ5aW5nIGEgY2hhcmFjdGVy IGNvdW50PwotICAgICAgICAgICAgaWYgKHBhdHRlcm5BdHRyaWJ1dGVbMTFdICE9ICd7JyB8fCAh cGF0dGVybkF0dHJpYnV0ZS5lbmRzV2l0aCgifSIpKQorICAgICAgICAgICAgaWYgKHBhdHRlcm5B dHRyaWJ1dGVbcGF0dGVyblN0cmluZy5sZW5ndGgoKV0gIT0gJ3snIHx8ICFwYXR0ZXJuQXR0cmli dXRlLmVuZHNXaXRoKCJ9IikpCiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAg ICAgICAgICBpbnQgY291bnQgPSAwOwogICAgICAgICAgICAgLy8gTWFrZSBzdXJlIHRoZSBudW1i ZXIgaW4gdGhlIHJlZ2V4IGlzIGFjdHVhbGx5IGEgbnVtYmVyLgotICAgICAgICAgICAgaWYgKChz c2NhbmYocGF0dGVybkF0dHJpYnV0ZS5zdHJpbmcoKS5sYXRpbjEoKS5kYXRhKCksICJbMC05YS1m QS1GXXslZH1cMCIsICZjb3VudCkgPT0gMSkgJiYgY291bnQgPiAwKQotICAgICAgICAgICAgICAg IHJldHVybiB0cnVlOworICAgICAgICAgICAgdW5zaWduZWQgY291bnQgPSAwOworICAgICAgICAg ICAgcGF0dGVyblN0cmluZyA9IHBhdHRlcm5TdHJpbmcgKyAieyVkfSI7CisgICAgICAgICAgICBy ZXR1cm4gKHNzY2FuZihwYXR0ZXJuQXR0cmlidXRlLmxhdGluMSgpLmRhdGEoKSwgcGF0dGVyblN0 cmluZy5sYXRpbjEoKS5kYXRhKCkgKyAnXDAnLCAmY291bnQpID09IDEpICYmIGNvdW50ID4gMDsK ICAgICAgICAgfQogICAgIH0KLQogICAgIHJldHVybiBmYWxzZTsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5oIGIvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvRE9NU3VwcG9ydC5oCmluZGV4IDZm NjY5OGYuLjM4Njk5ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0RPTVN1cHBvcnQuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2Vi S2l0U3VwcG9ydC9ET01TdXBwb3J0LmgKQEAgLTc4LDYgKzc4LDggQEAgYm9vbCBpc1Bvc2l0aW9u SW5Ob2RlKFdlYkNvcmU6Ok5vZGUqLCBjb25zdCBXZWJDb3JlOjpQb3NpdGlvbiYpOwogYm9vbCBl bGVtZW50SWRPck5hbWVJbmRpY2F0ZXNOb0F1dG9jb21wbGV0ZShjb25zdCBXZWJDb3JlOjpFbGVt ZW50Kik7CiBib29sIGVsZW1lbnRJZE9yTmFtZUluZGljYXRlc0VtYWlsKGNvbnN0IFdlYkNvcmU6 OkhUTUxJbnB1dEVsZW1lbnQqKTsKIGJvb2wgZWxlbWVudElkT3JOYW1lSW5kaWNhdGVzVXJsKGNv bnN0IFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQqKTsKK2Jvb2wgZWxlbWVudFBhdHRlcm5NYXRj aGVzKGNvbnN0IGNoYXIqLCBjb25zdCBXZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Kik7Citib29s IGVsZW1lbnRQYXR0ZXJuSW5kaWNhdGVzTnVtYmVyKGNvbnN0IFdlYkNvcmU6OkhUTUxJbnB1dEVs ZW1lbnQqKTsKIGJvb2wgZWxlbWVudFBhdHRlcm5JbmRpY2F0ZXNIZXhhZGVjaW1hbChjb25zdCBX ZWJDb3JlOjpIVE1MSW5wdXRFbGVtZW50Kik7CiAKIFdlYkNvcmU6OkludFBvaW50IGNvbnZlcnRQ b2ludFRvRnJhbWUoY29uc3QgV2ViQ29yZTo6RnJhbWUqIHNvdXJjZUZyYW1lLCBjb25zdCBXZWJD b3JlOjpGcmFtZSogdGFyZ2V0RnJhbWUsIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBzb3VyY2VQ b2ludCwgY29uc3QgYm9vbCBjbGFtcFRvVGFyZ2V0RnJhbWUgPSBmYWxzZSk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw IGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNw cAppbmRleCAwYjllMDI1Li4wOTE1Y2Q5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTE1OCw2ICsxNTgs OCBAQCBzdGF0aWMgQmxhY2tCZXJyeUlucHV0VHlwZSBjb252ZXJ0SW5wdXRUeXBlKGNvbnN0IEhU TUxJbnB1dEVsZW1lbnQqIGlucHV0RWxlbWVudAogICAgICAgICByZXR1cm4gSW5wdXRUeXBlRW1h aWw7CiAgICAgaWYgKERPTVN1cHBvcnQ6OmVsZW1lbnRJZE9yTmFtZUluZGljYXRlc1VybChpbnB1 dEVsZW1lbnQpKQogICAgICAgICByZXR1cm4gSW5wdXRUeXBlVVJMOworICAgIGlmIChET01TdXBw b3J0OjplbGVtZW50UGF0dGVybkluZGljYXRlc051bWJlcihpbnB1dEVsZW1lbnQpKQorICAgICAg ICByZXR1cm4gSW5wdXRUeXBlTnVtYmVyOwogICAgIGlmIChET01TdXBwb3J0OjplbGVtZW50UGF0 dGVybkluZGljYXRlc0hleGFkZWNpbWFsKGlucHV0RWxlbWVudCkpCiAgICAgICAgIHJldHVybiBJ bnB1dFR5cGVIZXhhZGVjaW1hbDsKIAotLSAKMS43LjUuNAoK