84149 2012-04-17 06:42:27 -0700 [GTK] Enable back double buffering on WebKitWebView to fix flickering 2012-04-22 18:03:40 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 carlosg webkit-unassigned carlosg cgarcia gustavo mrobinson webkit.review.bot zan oldest_to_newest 603987 0 carlosg 2012-04-17 06:42:27 -0700 WebKitWebView disables GTK+ double buffering as it already has its own backing store, as worthwhile as it is, it unfortunately brings in other side effects in how non-double-buffered widgets are rendered, from the docs of gdk_window_flush(): "For Gtk widgets that don't use double buffering this will be called automatically before sending the expose event" This means that all drawing commands up to the WebKitWebView parent GdkWindow are flushed to the X server before rendering the view itself, this may translate into flickering of the parent window background. GTK+ unfortunately has no means to let WebKit claim ownership on the backing buffer, nor to hand a surface to act as the backing buffer for a widget, so this has to be enabled back so all contents are composited before getting to the front store. I'm going to attach a patch to remove the gtk_widget_set_double_buffered() call from wk1, as for wk2 the flickering is reportedly non visible, but I think the same issue may lie there, just better hidden. 603989 1 137530 carlosg 2012-04-17 06:47:04 -0700 Created attachment 137530 Patch, enable back GTK+ double buffering to fix flickering 603991 2 137530 webkit.review.bot 2012-04-17 06:47:47 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering Rejecting attachment 137530 from review queue. carlosg@gnome.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. 603992 3 137530 webkit.review.bot 2012-04-17 06:48:29 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering Rejecting attachment 137530 from commit-queue. carlosg@gnome.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 603995 4 137530 carlosg 2012-04-17 06:51:43 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering Ehrm... unused to bugzilla review stuff, sorry :), setting to '?' now 604015 5 137530 cgarcia 2012-04-17 07:44:59 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering It's ok for me as long as this doesn't have a huge impact in performance, since the flickering effect is quite annoying. 604061 6 137530 mrobinson 2012-04-17 09:04:34 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering Thanks for spending the time to fix this! 604068 7 137530 webkit.review.bot 2012-04-17 09:12:40 -0700 Comment on attachment 137530 Patch, enable back GTK+ double buffering to fix flickering Clearing flags on attachment: 137530 Committed r114385: <http://trac.webkit.org/changeset/114385> 604069 8 webkit.review.bot 2012-04-17 09:12:44 -0700 All reviewed patches have been landed. Closing bug. 607411 9 mrobinson 2012-04-22 18:03:40 -0700 *** Bug 80747 has been marked as a duplicate of this bug. *** 137530 2012-04-17 06:47:04 -0700 2012-04-17 09:12:40 -0700 Patch, enable back GTK+ double buffering to fix flickering patch-84149 text/plain 2075 carlosg ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv Z3RrL0NoYW5nZUxvZwppbmRleCAxYzlmNTAyLi4wN2Y2OWJmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L2d0ay9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjYgQEAKKzIwMTItMDQtMTcgIENhcmxvcyBHYXJuYWNobyAgPGNhcmxvc0BsYW5l ZG8uY29tPgorCisgICAgICAgIFtHVEtdIEVuYWJsZSBiYWNrIGRvdWJsZSBidWZmZXJpbmcgb24g V2ViS2l0V2ViVmlldyB0byBmaXggZmxpY2tlcmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQxNDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBEZXNwaXRlIGhhdmluZyBXZWJLaXRXZWJWaWV3IGl0cyBv d24gYmFja2luZyBidWZmZXIsIGNhbGxpbmcKKyAgICAgICAgZ3RrX3dpZGdldF9zZXRfZG91Ymxl X2J1ZmZlcmVkKC4uLixGQUxTRSkgbWF5IHN0aWxsIHBvc2Ugc2lkZQorICAgICAgICBlZmZlY3Rz LCBzdWNoIGFzIGVuc3VyaW5nIHRoYXQgYWxsIGRyYXdpbmcgb3BlcmF0aW9ucyBhcmUgCisgICAg ICAgIGZsdXNoZWQgdG8gdGhlIFggc2VydmVyIGJlZm9yZSByZW5kZXJpbmcgYSBub24tZG91Ymxl IGJ1ZmZlcmVkCisgICAgICAgIHdpZGdldCwgd2hpY2ggbWF5IHRyYW5zbGF0ZSBpbnRvIGZsaWNr ZXJpbmcgb2YgdGhlIHBhcmVudCAKKyAgICAgICAgR2RrV2luZG93IGJlZm9yZSB0aGUgV2ViS2l0 V2ViVmlldyBpdHNlbGYgaXMgcmVuZGVyZWQuIAorCisgICAgICAgIEVuYWJsaW5nIGJhY2sgZG91 YmxlIGJ1ZmZlcmluZyBzb2x2ZXMgdGhpcyBhcyBhbGwgY29udGVudHMgYXJlIAorICAgICAgICBm aXJzdCBjb21wb3NpdGVkIHRvZ2V0aGVyIGJlZm9yZSBnZXR0aW5nIHRvIHRoZSBmcm9udCBidWZm ZXIsCisgICAgICAgIGJ1dCBlZmZlY3RpdmVseSBhY3RzIGFzIDNyZCBidWZmZXIuIFRoaXMgaXMg c29ydCBvZiB1bmF2b2lkYWJsZQorICAgICAgICB1bmxlc3MgR1RLKyBnYWlucyBhICJsZXQgbWUg dGFrZSBvd25lcnNoaXAgb2YgdGhlIGJhY2tpbmcgYnVmZmVyCisgICAgICAgIGZvciB0aGlzIHdp ZGdldCIsIHdoaWNoIGN1cnJlbnRseSBsYWNrcy4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcDoKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19pbml0KTogUmVtb3ZlIGNhbGwg dG8gZ3RrX3dpZGdldF9zZXRfZG91YmxlX2J1ZmZlcmVkKC4uLiwgRkFMU0UpCisKIDIwMTItMDQt MDYgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIEFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIGlzIGJyb2tlbiBhZnRlciByZWNlbnQgVGV4dHVy ZU1hcHBlciByZW9yZ2FuaXphdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dl YmtpdC93ZWJraXR3ZWJ2aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJ2aWV3LmNwcAppbmRleCA3YWQ2M2U1Li41NTgyMDkyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCkBAIC0zNjIyLDcgKzM2MjIsNiBAQCBzdGF0aWMgdm9p ZCB3ZWJraXRfd2ViX3ZpZXdfaW5pdChXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3KQogICAgIHByaXYt PnZpZXdwb3J0QXR0cmlidXRlcy0+cHJpdi0+d2ViVmlldyA9IHdlYlZpZXc7CiAKICAgICBndGtf d2lkZ2V0X3NldF9jYW5fZm9jdXMoR1RLX1dJREdFVCh3ZWJWaWV3KSwgVFJVRSk7Ci0gICAgZ3Rr X3dpZGdldF9zZXRfZG91YmxlX2J1ZmZlcmVkKEdUS19XSURHRVQod2ViVmlldyksIEZBTFNFKTsK IAogICAgIHByaXYtPm1haW5GcmFtZSA9IFdFQktJVF9XRUJfRlJBTUUod2Via2l0X3dlYl9mcmFt ZV9uZXcod2ViVmlldykpOwogICAgIHByaXYtPmxhc3RQb3B1cFhQb3NpdGlvbiA9IHByaXYtPmxh c3RQb3B1cFlQb3NpdGlvbiA9IC0xOwo=