84140 2012-04-17 03:13:09 -0700 Script make_names.pl should generate consistent .h & .cpp files 2012-04-17 10:12:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 vivekgalatage vivekgalatage abarth bweinstein darin ddkilzer haraken rniwa webkit.review.bot oldest_to_newest 603911 0 vivekgalatage 2012-04-17 03:13:09 -0700 Source/WebCore/dom/make_names.pl should generate the .h & .cpp file in consistent manner. Currently while generating the HTMLNames.cpp (same is applicable to all such *Names.cpp files) when the line for the namespace URI is written, a newline is not added. Hence the "// Tags" statement is put after the define for namespace URI. Also the additional ';' after the DEFINE_GLOBALS is not required as this will be added by the macro expansion. 603913 1 vivekgalatage 2012-04-17 03:15:31 -0700 Done all the necessary fixes in the make_names.pl and uploading the patch now. 603926 2 137512 vivekgalatage 2012-04-17 04:19:44 -0700 Created attachment 137512 Patch 604110 3 137512 webkit.review.bot 2012-04-17 10:12:36 -0700 Comment on attachment 137512 Patch Clearing flags on attachment: 137512 Committed r114391: <http://trac.webkit.org/changeset/114391> 604111 4 webkit.review.bot 2012-04-17 10:12:42 -0700 All reviewed patches have been landed. Closing bug. 137512 2012-04-17 04:19:44 -0700 2012-04-17 10:12:36 -0700 Patch bug-84140-20120417164957.patch text/plain 2347 vivekgalatage SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDM2MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTE3ICBWaXZlayBH YWxhdGFnZSAgPHZpdmVrZ2FsYXRhZ2VAZ21haWwuY29tPgorCisgICAgICAgIFNjcmlwdCBtYWtl X25hbWVzLnBsIHNob3VsZCBnZW5lcmF0ZSBjb25zaXN0ZW50IC5oICYgLmNwcCBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQxNDAKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhIG5ld2xp bmUgY2hhcmFjdGVyIGFuZCByZW1vdmVkICc7JyBhZnRlciB0aGUgREVGSU5FX0dMT0JBTAorCisg ICAgICAgIE5vIHRlc3QgY2FzZXMgcmVxdWlyZWQgZm9yIHRoaXMgY2hhbmdlLgorCisgICAgICAg ICogZG9tL21ha2VfbmFtZXMucGw6CisgICAgICAgIChwcmludE5hbWVzQ3BwRmlsZSk6CisKIDIw MTItMDQtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIElu dHJvZHVjZSBhbiBpbnRlcm5hbCBmZWF0dXJlIGZvciBhIGZpeGVkIHBsYWNlaG9sZGVyCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9kb20vbWFrZV9uYW1lcy5wbAkocmV2aXNpb24gMTE0MzMzKQorKysgU291cmNlL1dl YkNvcmUvZG9tL21ha2VfbmFtZXMucGwJKHdvcmtpbmcgY29weSkKQEAgLTYyMiwxMiArNjIyLDEy IEBAIHN1YiBwcmludE5hbWVzQ3BwRmlsZQogICAgIAogICAgIG15ICRsb3dlck5hbWVzcGFjZSA9 IGxjKCRwYXJhbWV0ZXJze25hbWVzcGFjZVByZWZpeH0pOwogCi0gICAgcHJpbnQgRiAiREVGSU5F X0dMT0JBTChBdG9taWNTdHJpbmcsICR7bG93ZXJOYW1lc3BhY2V9TmFtZXNwYWNlVVJJLCBcIiRw YXJhbWV0ZXJze25hbWVzcGFjZVVSSX1cIikiOworICAgIHByaW50IEYgIkRFRklORV9HTE9CQUwo QXRvbWljU3RyaW5nLCAke2xvd2VyTmFtZXNwYWNlfU5hbWVzcGFjZVVSSSwgXCIkcGFyYW1ldGVy c3tuYW1lc3BhY2VVUkl9XCIpXG5cbiI7CiAKICAgICBpZiAoa2V5cyAlYWxsVGFncykgewogICAg ICAgICBwcmludCBGICIvLyBUYWdzXG4iOwogICAgICAgICBmb3IgbXkgJG5hbWUgKHNvcnQga2V5 cyAlYWxsVGFncykgewotICAgICAgICAgICAgcHJpbnQgRiAiREVGSU5FX0dMT0JBTChRdWFsaWZp ZWROYW1lLCAiLCAkbmFtZSwgIlRhZywgbnVsbEF0b20sIFwiJG5hbWVcIiwgJHtsb3dlck5hbWVz cGFjZX1OYW1lc3BhY2VVUkkpO1xuIjsKKyAgICAgICAgICAgIHByaW50IEYgIkRFRklORV9HTE9C QUwoUXVhbGlmaWVkTmFtZSwgIiwgJG5hbWUsICJUYWcsIG51bGxBdG9tLCBcIiRuYW1lXCIsICR7 bG93ZXJOYW1lc3BhY2V9TmFtZXNwYWNlVVJJKVxuIjsKICAgICAgICAgfQogICAgICAgICAKICAg ICAgICAgcHJpbnQgRiAiXG5cbldlYkNvcmU6OlF1YWxpZmllZE5hbWUqKiBnZXQkcGFyYW1ldGVy c3tuYW1lc3BhY2V9VGFncyhzaXplX3QqIHNpemUpXG4iOwpAQCAtNjQ0LDcgKzY0NCw3IEBAIHN1 YiBwcmludE5hbWVzQ3BwRmlsZQogICAgIGlmIChrZXlzICVhbGxBdHRycykgewogICAgICAgICBw cmludCBGICJcbi8vIEF0dHJpYnV0ZXNcbiI7CiAgICAgICAgIGZvciBteSAkbmFtZSAoc29ydCBr ZXlzICVhbGxBdHRycykgewotICAgICAgICAgICAgcHJpbnQgRiAiREVGSU5FX0dMT0JBTChRdWFs aWZpZWROYW1lLCAiLCAkbmFtZSwgIkF0dHIsIG51bGxBdG9tLCBcIiRuYW1lXCIsICR7bG93ZXJO YW1lc3BhY2V9TmFtZXNwYWNlVVJJKTtcbiI7CisgICAgICAgICAgICBwcmludCBGICJERUZJTkVf R0xPQkFMKFF1YWxpZmllZE5hbWUsICIsICRuYW1lLCAiQXR0ciwgbnVsbEF0b20sIFwiJG5hbWVc IiwgJHtsb3dlck5hbWVzcGFjZX1OYW1lc3BhY2VVUkkpXG4iOwogICAgICAgICB9CiAgICAgICAg IHByaW50IEYgIlxuXG5XZWJDb3JlOjpRdWFsaWZpZWROYW1lKiogZ2V0JHBhcmFtZXRlcnN7bmFt ZXNwYWNlfUF0dHJzKHNpemVfdCogc2l6ZSlcbiI7CiAgICAgICAgIHByaW50IEYgIntcbiAgICBz dGF0aWMgV2ViQ29yZTo6UXVhbGlmaWVkTmFtZSogJHBhcmFtZXRlcnN7bmFtZXNwYWNlfUF0dHJb XSA9IHtcbiI7Cg==