84136 2012-04-17 02:24:43 -0700 [EFL][WK2] Fix build break when non-cross platform CONTEXT_MENUS are enabled 2012-04-23 08:06:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 mpakulavelrutka webkit-unassigned g.czajkowski gyuyoung.kim lucas.de.marchi webkit.review.bot oldest_to_newest 603887 0 mpakulavelrutka 2012-04-17 02:24:43 -0700 In EFL WebKit2 when ENABLE_CONTEXT_MENUS is set true and CROSS_PLATFORM_CONTEXT_MENUS are set false, there is a build break caused by mismatch between contextMenuItemVector declaration which uses PlatformMenuDescription (defined as Vector<ContexMenuItem and definition which uses const Vector<ContextMenuItem>*. This fixed the build break by adding const to EFL PlatformMenuDesciption. 603919 1 mpakulavelrutka 2012-04-17 03:46:23 -0700 EFL WebKit2 has CONTEXT_MENUS disabled so this patch currently does not blocks the build. 603924 2 137510 mpakulavelrutka 2012-04-17 04:09:48 -0700 Created attachment 137510 adds const to EFL PlatformMenuDescription 603946 3 g.czajkowski 2012-04-17 05:25:05 -0700 LGTM. 607693 4 137510 webkit.review.bot 2012-04-23 08:05:59 -0700 Comment on attachment 137510 adds const to EFL PlatformMenuDescription Clearing flags on attachment: 137510 Committed r114902: <http://trac.webkit.org/changeset/114902> 607694 5 webkit.review.bot 2012-04-23 08:06:04 -0700 All reviewed patches have been landed. Closing bug. 137510 2012-04-17 04:09:48 -0700 2012-04-23 08:05:59 -0700 adds const to EFL PlatformMenuDescription patch.diff text/plain 1458 mpakulavelrutka ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNmUzOTZmLi5kOTc3YmMwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDQtMTcgIE1pY2hhxYIgUGFrdcWCYSB2ZWwgUnV0a2EgIDxtLnBha3VsYUBzYW1z dW5nLmNvbT4KKyAgICAgICAgW0VGTF1bV0syXSBGaXggYnVpbGQgYnJlYWsgd2hlbiBub24tY3Jv c3MgcGxhdGZvcm0gQ09OVEVYVF9NRU5VUyBhcmUgZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MTM2CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgd2FzIGEgbWlzbWF0Y2ggYmV0d2Vl biBjb250ZXh0TWVudUl0ZW1WZWN0b3IgZGVjbGFyYXRpb24gYW5kIGRlZmluaXRpb24uCisgICAg ICAgIEZpeGVkIGJ5IGNoYW5naW5nIFBsYXRmb3JtTWVudURlc2NyaXB0aW9uIGZvciBFRkwgcG9y dCBieSBhZGRpbmcgYSBjb25zdCBtb2RpZmllci4KKworICAgICAgICBObyBuZXcgdGVzdHMgcmVx dWlyZWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9QbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbi5oOgor ICAgICAgICAoV2ViQ29yZSk6IEFkZGVkIGNvbnN0IG1vZGlmaWVyIHRvIFBsYXRmb3JtTWVudURl c2NyaXB0aW9uIGRlZmluaXRpb24uCisKIDIwMTItMDQtMTcgIEtlbnQgVGFtdXJhICA8dGtlbnRA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIEludHJvZHVjZSBhbiBpbnRlcm5hbCBmZWF0dXJlIGZv ciBhIGZpeGVkIHBsYWNlaG9sZGVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9QbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbi5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vUGxh dGZvcm1NZW51RGVzY3JpcHRpb24uaAppbmRleCA0NTlkMGE1Li43ODE5NmFkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9QbGF0Zm9ybU1lbnVEZXNjcmlwdGlvbi5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtTWVudURlc2NyaXB0aW9uLmgKQEAgLTUy LDcgKzUyLDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgIHR5cGVkZWYgd3hNZW51KiBQbGF0 Zm9ybU1lbnVEZXNjcmlwdGlvbjsKICNlbGlmIFBMQVRGT1JNKEVGTCkKICAgICBjbGFzcyBDb250 ZXh0TWVudUl0ZW07Ci0gICAgdHlwZWRlZiBWZWN0b3I8Q29udGV4dE1lbnVJdGVtPiogUGxhdGZv cm1NZW51RGVzY3JpcHRpb247CisgICAgdHlwZWRlZiBjb25zdCBWZWN0b3I8Q29udGV4dE1lbnVJ dGVtPiogUGxhdGZvcm1NZW51RGVzY3JpcHRpb247CiAjZWxzZQogICAgIHR5cGVkZWYgdm9pZCog UGxhdGZvcm1NZW51RGVzY3JpcHRpb247CiAjZW5kaWYK