84134 2012-04-17 02:10:12 -0700 [BlackBerry] Export globalInitialize() 2012-04-17 02:48:35 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos staikos tonikitoo webkit.review.bot oldest_to_newest 603872 0 137492 staikos 2012-04-17 02:10:12 -0700 Created attachment 137492 patch to fix it globalInitialize() should have been exported and was not. Do it. 603873 1 webkit.review.bot 2012-04-17 02:12:22 -0700 Attachment 137492 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BlackBerryGlo..." exit_code: 1 Source/WebKit/blackberry/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 603883 2 137498 staikos 2012-04-17 02:20:03 -0700 Created attachment 137498 patch to fix it 603898 3 137498 zimmermann 2012-04-17 02:37:19 -0700 Comment on attachment 137498 patch to fix it r=me! 603903 4 137498 webkit.review.bot 2012-04-17 02:48:31 -0700 Comment on attachment 137498 patch to fix it Clearing flags on attachment: 137498 Committed r114361: <http://trac.webkit.org/changeset/114361> 603904 5 webkit.review.bot 2012-04-17 02:48:35 -0700 All reviewed patches have been landed. Closing bug. 137492 2012-04-17 02:10:12 -0700 2012-04-17 02:20:03 -0700 patch to fix it globalinit.patch text/plain 1111 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTE0MzYwKQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDEyLTA0LTE3ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBFeHBvcnQgdGhlIGluaXRpYWxpemF0aW9uIGZ1bmN0aW9uIHNvIGl0IGNh biBiZSBjYWxsZWQgZWFybGllci4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIEFwaS9CbGFja0JlcnJ5R2xvYmFsLmg6IGV4cG9ydCBnbG9iYWxJbml0 aWFsaXplKCkKKyAgICAgICAgKFdlYktpdCk6CisKIDIwMTItMDQtMTYgIEFudG9uaW8gR29tZXMg IDxhZ29tZXNAcmltLmNvbT4KIAogICAgICAgICBTY3JlZW4gc2hpZnQgZG93biB3aGVuIFZLQiBz aG93cyBieSBjbGlja2luZyBpbiBhIGlucHV0IGJveCBNS1NfMzYwMTM3MQpJbmRleDogU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CbGFja0JlcnJ5R2xvYmFsLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CbGFja0JlcnJ5R2xvYmFsLmgJKHJldmlzaW9u IDExNDM1OSkKKysrIFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmxhY2tCZXJyeUdsb2Jh bC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewog CiBjbGFzcyBXZWJTdHJpbmc7CiAKLXZvaWQgZ2xvYmFsSW5pdGlhbGl6ZSgpOworQkxBQ0tCRVJS WV9FWFBPUlQgdm9pZCBnbG9iYWxJbml0aWFsaXplKCk7CiB2b2lkIGNvbGxlY3RKYXZhc2NyaXB0 R2FyYmFnZU5vdygpOwogdm9pZCBjbGVhckNvb2tpZUNhY2hlKCk7CiBCTEFDS0JFUlJZX0VYUE9S VCB2b2lkIGNsZWFyTWVtb3J5Q2FjaGVzKCk7Cg== 137498 2012-04-17 02:20:03 -0700 2012-04-17 02:48:31 -0700 patch to fix it globalinit.patch text/plain 1166 staikos SW5kZXg6IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkocmV2aXNpb24gMTE0MzYwKQorKysg U291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTA0LTE3ICBHZW9yZ2UgU3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9y Zz4KKworICAgICAgICBFeHBvcnQgdGhlIGluaXRpYWxpemF0aW9uIGZ1bmN0aW9uIHNvIGl0IGNh biBiZSBjYWxsZWQgZWFybGllci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0MTM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBBcGkvQmxhY2tCZXJyeUdsb2JhbC5oOiBleHBvcnQgZ2xvYmFsSW5pdGlh bGl6ZSgpCisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA0LTE2ICBBbnRvbmlvIEdvbWVzICA8 YWdvbWVzQHJpbS5jb20+CiAKICAgICAgICAgU2NyZWVuIHNoaWZ0IGRvd24gd2hlbiBWS0Igc2hv d3MgYnkgY2xpY2tpbmcgaW4gYSBpbnB1dCBib3ggTUtTXzM2MDEzNzEKSW5kZXg6IFNvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmxhY2tCZXJyeUdsb2JhbC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmxhY2tCZXJyeUdsb2JhbC5oCShyZXZpc2lvbiAx MTQzNTkpCisrKyBTb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JsYWNrQmVycnlHbG9iYWwu aAkod29ya2luZyBjb3B5KQpAQCAtMzAsNyArMzAsNyBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIAog Y2xhc3MgV2ViU3RyaW5nOwogCi12b2lkIGdsb2JhbEluaXRpYWxpemUoKTsKK0JMQUNLQkVSUllf RVhQT1JUIHZvaWQgZ2xvYmFsSW5pdGlhbGl6ZSgpOwogdm9pZCBjb2xsZWN0SmF2YXNjcmlwdEdh cmJhZ2VOb3coKTsKIHZvaWQgY2xlYXJDb29raWVDYWNoZSgpOwogQkxBQ0tCRVJSWV9FWFBPUlQg dm9pZCBjbGVhck1lbW9yeUNhY2hlcygpOwo=