84131 2012-04-17 01:24:28 -0700 Dromaeo/cssquery-prototype.html, cssquery-jquery.html, cssquery-dojo.html are very slow 2012-09-20 20:08:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 93185 P2 Normal --- 1 rniwa morrita eric kling koivisto mjs morrita ojan tony oldest_to_newest 603857 0 rniwa 2012-04-17 01:24:28 -0700 All of these tests are taking well over 2 minutes each to run on Chromium Mac bots: http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Perf%29/builds/1616 181.695680 Dromaeo/cssquery-prototype.html 181.681818 Dromaeo/cssquery-jquery.html 172.595614 Dromaeo/dromaeo-object-regexp.html 166.828389 Dromaeo/cssquery-dojo.html 162.882592 Parser/tiny-innerHTML.html 158.915446 Dromaeo/jslib-modify-jquery.html 603867 1 137490 morrita 2012-04-17 01:56:03 -0700 Created attachment 137490 Patch 603870 2 morrita 2012-04-17 02:05:35 -0700 The patch illustrates a naive fix. But I'm not sure whether this is the right direction. Slow tests are slow because they contain many small tests, not because they have a few large tests. My feeling is that it's better to just skip less relevant ones. For example, it might be OK just to cover cssquery-jquery.html for "cssquery" family because the world is dominated by jquery not prototype. We also able to skip dromaeo-* since these are almost pure-JS which will be (roughly) covered by SunSpider. 623075 3 tony 2012-05-14 10:17:54 -0700 To summarize, those 6 tests take over 17 minutes right now. This change converts the number of runs from 5 to 2, which should bring the running time for these tests to under 7 minutes. It seems worth trying. We can watch the graphs to see how stable the times are. If the times are consistent across runs, then the extra runs probably aren't necessary. 623136 4 rniwa 2012-05-14 11:19:07 -0700 (In reply to comment #3) > To summarize, those 6 tests take over 17 minutes right now. This change converts the number of runs from 5 to 2, which should bring the running time for these tests to under 7 minutes. We should probably omit reporting stdev, min, max, median in that case because sample size of 5 doesn't give us a meaningful statistics. 623138 5 rniwa 2012-05-14 11:19:28 -0700 I mean the sample size of "2". 725102 6 rniwa 2012-09-20 20:08:42 -0700 *** This bug has been marked as a duplicate of bug 93185 *** 137490 2012-04-17 01:56:03 -0700 2012-04-17 01:56:03 -0700 Patch bug-84131-20120417175601.patch text/plain 3879 morrita U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MzM2CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0Ryb21hZW8vY3NzcXVlcnktZG9qby5odG1sIGIvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL2Nz c3F1ZXJ5LWRvam8uaHRtbAppbmRleCAxNWY1MzdjZDkxNmIzZTJmODFjZjI5NTUxNDVkYjM5NWUz YWFlNjBlLi5jZjZlYzZlYTBjYTk0ZmE3ZDc0YmYyNzgzOTc3Mjc4NzE1N2I4NGRiIDEwMDY0NAot LS0gYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vY3NzcXVlcnktZG9qby5odG1sCisrKyBiL1Bl cmZvcm1hbmNlVGVzdHMvRHJvbWFlby9jc3NxdWVyeS1kb2pvLmh0bWwKQEAgLTYsNyArNiw3IEBA CiA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIuanMiPjwvc2NyaXB0PgogPHNj cmlwdD4KICQoZG9jdW1lbnQpLnJlYWR5KGZ1bmN0aW9uKCkgewotICAgIERSVC5zZXR1cCgiY3Nz cXVlcnktZG9qbyIpOworICAgIERSVC5zZXR1cCgiY3NzcXVlcnktZG9qbyIsIERSVC5udW1UZXN0 c0ZvclNsb3dzKTsKIH0pOwogPC9zY3JpcHQ+CiA8L2hlYWQ+CmRpZmYgLS1naXQgYS9QZXJmb3Jt YW5jZVRlc3RzL0Ryb21hZW8vY3NzcXVlcnktanF1ZXJ5Lmh0bWwgYi9QZXJmb3JtYW5jZVRlc3Rz L0Ryb21hZW8vY3NzcXVlcnktanF1ZXJ5Lmh0bWwKaW5kZXggOTY0ZjVlOGIzYjEwYzUxNzg0YzQ5 N2QzMmQzMGM2ZTYwNzQ5YWQ3OC4uMWNmYWY1NDk3YTZjMmNkZTNhNTNhNTYxNWY4ODQwZDQ2ZDRm ZGMwMCAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL2Nzc3F1ZXJ5LWpxdWVy eS5odG1sCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvRHJvbWFlby9jc3NxdWVyeS1qcXVlcnkuaHRt bApAQCAtNiw3ICs2LDcgQEAKIDxzY3JpcHQgc3JjPSJyZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5q cyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgogJChkb2N1bWVudCkucmVhZHkoZnVuY3Rpb24oKSB7Ci0g ICAgRFJULnNldHVwKCJjc3NxdWVyeS1qcXVlcnkiKTsKKyAgICBEUlQuc2V0dXAoImNzc3F1ZXJ5 LWpxdWVyeSIsIERSVC5udW1UZXN0c0ZvclNsb3dzKTsKIH0pOwogPC9zY3JpcHQ+CiA8L2hlYWQ+ CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vY3NzcXVlcnktcHJvdG90eXBl Lmh0bWwgYi9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vY3NzcXVlcnktcHJvdG90eXBlLmh0bWwK aW5kZXggNjdhNTk1MWVjNTlhNDllMzUzNDhmMmQ2YWZlMGRjODUzM2FmZjY0Ny4uMmVmOWU2MDZh OGEzYzhlOTFkYTA4Njk2Mzc5NDhiYTVlMDk5ODY1MyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VU ZXN0cy9Ecm9tYWVvL2Nzc3F1ZXJ5LXByb3RvdHlwZS5odG1sCisrKyBiL1BlcmZvcm1hbmNlVGVz dHMvRHJvbWFlby9jc3NxdWVyeS1wcm90b3R5cGUuaHRtbApAQCAtNiw3ICs2LDcgQEAKIDxzY3Jp cHQgc3JjPSJyZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0Pgog JChkb2N1bWVudCkucmVhZHkoZnVuY3Rpb24oKSB7Ci0gICAgRFJULnNldHVwKCJjc3NxdWVyeS1w cm90b3R5cGUiKTsKKyAgICBEUlQuc2V0dXAoImNzc3F1ZXJ5LXByb3RvdHlwZSIsIERSVC5udW1U ZXN0c0ZvclNsb3dzKTsKIH0pOwogPC9zY3JpcHQ+CiA8L2hlYWQ+CmRpZmYgLS1naXQgYS9QZXJm b3JtYW5jZVRlc3RzL0Ryb21hZW8vZHJvbWFlby1vYmplY3QtcmVnZXhwLmh0bWwgYi9QZXJmb3Jt YW5jZVRlc3RzL0Ryb21hZW8vZHJvbWFlby1vYmplY3QtcmVnZXhwLmh0bWwKaW5kZXggZmM3NmVi YzA2MWZkOGIxZTZlM2UxMTU0N2U1NTFlZDY0MWMwODRhOC4uZmQyN2M0YzNhOWYwM2M2MWNlNmZh OGM1YWIwZjZhYjJmMTQyZjZjZSAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVv L2Ryb21hZW8tb2JqZWN0LXJlZ2V4cC5odG1sCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvRHJvbWFl by9kcm9tYWVvLW9iamVjdC1yZWdleHAuaHRtbApAQCAtNiw3ICs2LDcgQEAKIDxzY3JpcHQgc3Jj PSJyZXNvdXJjZXMvZHJvbWFlb3J1bm5lci5qcyI+PC9zY3JpcHQ+CiA8c2NyaXB0PgogJChkb2N1 bWVudCkucmVhZHkoZnVuY3Rpb24oKSB7Ci0gICAgRFJULnNldHVwKCJkcm9tYWVvLW9iamVjdC1y ZWdleHAiKTsKKyAgICBEUlQuc2V0dXAoImRyb21hZW8tb2JqZWN0LXJlZ2V4cCIsIERSVC5udW1U ZXN0c0ZvclNsb3dzKTsKIH0pOwogPC9zY3JpcHQ+CiA8L2hlYWQ+CmRpZmYgLS1naXQgYS9QZXJm b3JtYW5jZVRlc3RzL0Ryb21hZW8vanNsaWItbW9kaWZ5LWpxdWVyeS5odG1sIGIvUGVyZm9ybWFu Y2VUZXN0cy9Ecm9tYWVvL2pzbGliLW1vZGlmeS1qcXVlcnkuaHRtbAppbmRleCA2ZTNjOGQ1YWQz MzA1OTQxYWRmN2FiODI4YmQ5NGQ3YTk2NmQxMTA0Li4xOWMxNDU2OWFhZmRjOWRkOGFjMjEzMTZj MmI5Y2UwNTExODZmNDJjIDEwMDY0NAotLS0gYS9QZXJmb3JtYW5jZVRlc3RzL0Ryb21hZW8vanNs aWItbW9kaWZ5LWpxdWVyeS5odG1sCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvRHJvbWFlby9qc2xp Yi1tb2RpZnktanF1ZXJ5Lmh0bWwKQEAgLTYsNyArNiw3IEBACiA8c2NyaXB0IHNyYz0icmVzb3Vy Y2VzL2Ryb21hZW9ydW5uZXIuanMiPjwvc2NyaXB0PgogPHNjcmlwdD4KICQoZG9jdW1lbnQpLnJl YWR5KGZ1bmN0aW9uKCkgewotICAgIERSVC5zZXR1cCgianNsaWItbW9kaWZ5LWpxdWVyeSIpOwor ICAgIERSVC5zZXR1cCgianNsaWItbW9kaWZ5LWpxdWVyeSIsIERSVC5udW1UZXN0c0ZvclNsb3dz KTsKIH0pOwogPC9zY3JpcHQ+CiA8L2hlYWQ+CmRpZmYgLS1naXQgYS9QZXJmb3JtYW5jZVRlc3Rz L0Ryb21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIuanMgYi9QZXJmb3JtYW5jZVRlc3RzL0Ry b21hZW8vcmVzb3VyY2VzL2Ryb21hZW9ydW5uZXIuanMKaW5kZXggYzg5YWM3MWU3ZjQ5NmQ3NTY5 MmE0ZWRlNTE0NGNmZGQzNmNiNzc5OC4uZjZhZjczNWM3NTEwZjI3MjM0ODAwZWU0OWI3ZWM1NDlk OWUzNjY3YyAxMDA2NDQKLS0tIGEvUGVyZm9ybWFuY2VUZXN0cy9Ecm9tYWVvL3Jlc291cmNlcy9k cm9tYWVvcnVubmVyLmpzCisrKyBiL1BlcmZvcm1hbmNlVGVzdHMvRHJvbWFlby9yZXNvdXJjZXMv ZHJvbWFlb3J1bm5lci5qcwpAQCAtMSw2ICsxLDcgQEAKIChmdW5jdGlvbigpewogICAgICB2YXIg RFJUICA9IHsKICAgICAgICAgIGJhc2VVUkw6ICIuL3Jlc291cmNlcy9kcm9tYWVvL3dlYi9pbmRl eC5odG1sIiwKKyAgICAgICAgIG51bVRlc3RzRm9yU2xvd3M6IDIsCiAKICAgICAgICAgIGNvbXB1 dGVTY29yZXM6IGZ1bmN0aW9uIChyZXN1bHRzKSB7CiAgICAgICAgICAgICAgdmFyIG1lYW4gPSAw LCBtaW4gPSAwLCBtYXggPSAwLCBzdGRldiA9IDAsIHZhcnN1bSA9IDA7CkBAIC0yMyw5ICsyNCwx MCBAQAogICAgICAgICAgICAgIH07CiAgICAgICAgICB9LAogCi0gICAgICAgICBzZXR1cDogZnVu Y3Rpb24odGVzdE5hbWUpIHsKKyAgICAgICAgIHNldHVwOiBmdW5jdGlvbih0ZXN0TmFtZSwgb3B0 X251bVRlc3RzKSB7CisgICAgICAgICAgICAgdmFyIG51bVRlc3RzID0gb3B0X251bVRlc3RzIHx8 IDU7CiAgICAgICAgICAgICAgdmFyIGlmcmFtZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImlm cmFtZSIpOwotICAgICAgICAgICAgIHZhciB1cmwgPSBEUlQuYmFzZVVSTCArICI/IiArIHRlc3RO YW1lOworICAgICAgICAgICAgIHZhciB1cmwgPSBEUlQuYmFzZVVSTCArICI/IiArIHRlc3ROYW1l ICsgIiZudW1UZXN0cz0iICsgbnVtVGVzdHMudG9TdHJpbmcoKTsKICAgICAgICAgICAgICBpZnJh bWUuc2V0QXR0cmlidXRlKCJzcmMiLCB1cmwpOwogICAgICAgICAgICAgIGRvY3VtZW50LmJvZHku YXBwZW5kQ2hpbGQoaWZyYW1lKTsKICAgICAgICAgICAgICBpZnJhbWUuYWRkRXZlbnRMaXN0ZW5l cigK