84111 2012-04-16 18:22:23 -0700 -webkit-mask-box-image does not draw when layer tree flattening is enabled 2012-04-17 14:32:51 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aestes aestes hyatt mitz sam simon.fraser oldest_to_newest 603659 0 aestes 2012-04-16 18:22:23 -0700 -webkit-mask-box-image does not draw when layer tree flattening is enabled 603664 1 137451 aestes 2012-04-16 18:25:27 -0700 Created attachment 137451 Patch 603665 2 aestes 2012-04-16 18:25:52 -0700 <rdar://problem/10950075> 604339 3 137451 simon.fraser 2012-04-17 14:28:03 -0700 Comment on attachment 137451 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137451&action=review > Source/WebCore/rendering/InlineFlowBox.cpp:1292 > + bool flattenCompositingLayers = !renderer()->view()->frameView() || renderer()->view()->frameView()->paintBehavior() & PaintBehaviorFlattenCompositingLayers; I think it would be cleaner to pass this down via PaintInfo, but that would be a larger change. 604346 4 aestes 2012-04-17 14:32:51 -0700 Committed r114433: <http://trac.webkit.org/changeset/114433> 137451 2012-04-16 18:25:27 -0700 2012-04-17 14:28:03 -0700 Patch bug-84111-20120416182526.patch text/plain 3272 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MzMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzcwNTA4NzY5OGZkNTE1 ZTUxMTRjNzE5ODI5NmZhZjgyZDlkYmE2Yi4uZmU4ZjBkZjkzZTJjY2Q2NjUyMDdmZWU5M2RmMjli ZWYyYjc1OTVlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTE2ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICAtd2Via2l0LW1hc2stYm94LWlt YWdlIGRvZXMgbm90IGRyYXcgd2hlbiBsYXllciB0cmVlIGZsYXR0ZW5pbmcgaXMgZW5hYmxlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQxMTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVz dHMgc2luY2UgdGFraW5nIHBpeGVsIHRlc3QgcmVzdWx0cyB3aXRoCisgICAgICAgIFBhaW50QmVo YXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnMgc2V0IGlzIG5vdCBjdXJyZW50bHkgc3VwcG9y dGVkLgorICAgICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 MTEwPiB0cmFja3MgZml4aW5nIHRoaXMuCisKKyAgICAgICAgV2hlbiBwYWludGluZyBtYXNrIGlt YWdlcywgd2Ugc2hvdWxkIHRha2UgdGhlIG5vbi1jb21wb3NpdGVkIHBhdGggaWYKKyAgICAgICAg bGF5ZXJzIGFyZSBiZWluZyBmbGF0dGVuZWQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSW5saW5l Rmxvd0JveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbmxpbmVGbG93Qm94OjpwYWludE1hc2sp OgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3guY3BwOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyQm94OjpwYWludE1hc2tJbWFnZXMpOgorCiAyMDEyLTA0LTE2ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTE0Mjg1LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lu bGluZUZsb3dCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZUZsb3dCb3gu Y3BwCmluZGV4IDRhOWJjMWI4MWIxMDI4ZTMzYmZjYzA2OTNhYzA0NWM1YzIzODI5ZWMuLmU2ODM4 ZWU0MjU3ZDYzY2VlZTcxZmQ1ZjBhNmJlOWJhMjE1ZDViMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9JbmxpbmVGbG93Qm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvSW5saW5lRmxvd0JveC5jcHAKQEAgLTEyODksOCArMTI4OSw5IEBAIHZvaWQgSW5s aW5lRmxvd0JveDo6cGFpbnRNYXNrKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQ b2ludCYgcGFpbnRPZmZzCiAgICAgLy8gRmlndXJlIG91dCBpZiB3ZSBuZWVkIHRvIHB1c2ggYSB0 cmFuc3BhcmVuY3kgbGF5ZXIgdG8gcmVuZGVyIG91ciBtYXNrLgogICAgIGJvb2wgcHVzaFRyYW5z cGFyZW5jeUxheWVyID0gZmFsc2U7CiAgICAgYm9vbCBjb21wb3NpdGVkTWFzayA9IHJlbmRlcmVy KCktPmhhc0xheWVyKCkgJiYgYm94TW9kZWxPYmplY3QoKS0+bGF5ZXIoKS0+aGFzQ29tcG9zaXRl ZE1hc2soKTsKKyAgICBib29sIGZsYXR0ZW5Db21wb3NpdGluZ0xheWVycyA9ICFyZW5kZXJlcigp LT52aWV3KCktPmZyYW1lVmlldygpIHx8IHJlbmRlcmVyKCktPnZpZXcoKS0+ZnJhbWVWaWV3KCkt PnBhaW50QmVoYXZpb3IoKSAmIFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdMYXllcnM7 CiAgICAgQ29tcG9zaXRlT3BlcmF0b3IgY29tcG9zaXRlT3AgPSBDb21wb3NpdGVTb3VyY2VPdmVy OwotICAgIGlmICghY29tcG9zaXRlZE1hc2spIHsKKyAgICBpZiAoIWNvbXBvc2l0ZWRNYXNrIHx8 IGZsYXR0ZW5Db21wb3NpdGluZ0xheWVycykgewogICAgICAgICBpZiAoKG1hc2tCb3hJbWFnZSAm JiByZW5kZXJlcigpLT5zdHlsZSgpLT5tYXNrTGF5ZXJzKCktPmhhc0ltYWdlKCkpIHx8IHJlbmRl cmVyKCktPnN0eWxlKCktPm1hc2tMYXllcnMoKS0+bmV4dCgpKQogICAgICAgICAgICAgcHVzaFRy YW5zcGFyZW5jeUxheWVyID0gdHJ1ZTsKICAgICAgICAgCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCb3guY3BwCmluZGV4IGIwZmE4NjVmNzU2YTQ4ZDU1ZDY4ZTM2MjA2MzMyMDc1ZGFmOTlm MzkuLmZmYzQ3MGYyNjg5MzA1YWY3NTQ3NzZiYTU4ZTc3ODEzODUzNTI4NjQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCkBAIC0xMDUxLDExICsxMDUxLDEyIEBAIHZvaWQg UmVuZGVyQm94OjpwYWludE1hc2tJbWFnZXMoY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNv bnN0IExheW91dFJlY3QmIHBhCiAgICAgLy8gRmlndXJlIG91dCBpZiB3ZSBuZWVkIHRvIHB1c2gg YSB0cmFuc3BhcmVuY3kgbGF5ZXIgdG8gcmVuZGVyIG91ciBtYXNrLgogICAgIGJvb2wgcHVzaFRy YW5zcGFyZW5jeUxheWVyID0gZmFsc2U7CiAgICAgYm9vbCBjb21wb3NpdGVkTWFzayA9IGhhc0xh eWVyKCkgJiYgbGF5ZXIoKS0+aGFzQ29tcG9zaXRlZE1hc2soKTsKKyAgICBib29sIGZsYXR0ZW5D b21wb3NpdGluZ0xheWVycyA9ICF2aWV3KCktPmZyYW1lVmlldygpIHx8IHZpZXcoKS0+ZnJhbWVW aWV3KCktPnBhaW50QmVoYXZpb3IoKSAmIFBhaW50QmVoYXZpb3JGbGF0dGVuQ29tcG9zaXRpbmdM YXllcnM7CiAgICAgQ29tcG9zaXRlT3BlcmF0b3IgY29tcG9zaXRlT3AgPSBDb21wb3NpdGVTb3Vy Y2VPdmVyOwogCiAgICAgYm9vbCBhbGxNYXNrSW1hZ2VzTG9hZGVkID0gdHJ1ZTsKICAgICAKLSAg ICBpZiAoIWNvbXBvc2l0ZWRNYXNrKSB7CisgICAgaWYgKCFjb21wb3NpdGVkTWFzayB8fCBmbGF0 dGVuQ29tcG9zaXRpbmdMYXllcnMpIHsKICAgICAgICAgcHVzaFRyYW5zcGFyZW5jeUxheWVyID0g dHJ1ZTsKICAgICAgICAgU3R5bGVJbWFnZSogbWFza0JveEltYWdlID0gc3R5bGUoKS0+bWFza0Jv eEltYWdlKCkuaW1hZ2UoKTsKICAgICAgICAgY29uc3QgRmlsbExheWVyKiBtYXNrTGF5ZXJzID0g c3R5bGUoKS0+bWFza0xheWVycygpOwo=