84100 2012-04-16 17:00:13 -0700 Remove unused variable CachedResourceLoader::m_loadFinishing 2012-04-16 17:48:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 japhet japhet ap koivisto webkit.review.bot oldest_to_newest 603579 0 japhet 2012-04-16 17:00:13 -0700 Specifically, it's always false. 603581 1 137432 japhet 2012-04-16 17:03:06 -0700 Created attachment 137432 patch 603620 2 137432 ap 2012-04-16 17:37:58 -0700 Comment on attachment 137432 patch Oh well. 603631 3 137432 webkit.review.bot 2012-04-16 17:47:50 -0700 Comment on attachment 137432 patch Clearing flags on attachment: 137432 Committed r114328: <http://trac.webkit.org/changeset/114328> 603632 4 webkit.review.bot 2012-04-16 17:48:00 -0700 All reviewed patches have been landed. Closing bug. 137432 2012-04-16 17:03:06 -0700 2012-04-16 17:47:49 -0700 patch loadFinishing.txt text/plain 3089 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDMyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE2ICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCB2YXJp YWJsZSBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6bV9sb2FkRmluaXNoaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDEwMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgcmVtb3Zpbmcg ZGVhZCBjb2RlLgorCisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhY2hlZFJlc291cmNlTG9hZGVyOjpDYWNoZWRSZXNv dXJjZUxvYWRlcik6CisgICAgICAgIChXZWJDb3JlOjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6bG9h ZERvbmUpOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVkUmVzb3VyY2VMb2FkZXI6OmRlY3JlbWVu dFJlcXVlc3RDb3VudCk6CisgICAgICAgICogbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9h ZGVyLmg6CisgICAgICAgIChDYWNoZWRSZXNvdXJjZUxvYWRlcik6CisgICAgICAgIChXZWJDb3Jl OjpDYWNoZWRSZXNvdXJjZUxvYWRlcjo6cmVxdWVzdENvdW50KToKKwogMjAxMi0wNC0xNiAgRXJp ayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtWOF0gRG9uJ3QgZGVs ZXRlIHRoZSBwZXIgY29udGV4dCBkYXRhIHVudGlsIHRoZSBWOElzb2xhdGVkQ29udGV4dCBpcyBk ZWxldGVkCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2VM b2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNo ZWRSZXNvdXJjZUxvYWRlci5jcHAJKHJldmlzaW9uIDExNDI4NykKKysrIFNvdXJjZS9XZWJDb3Jl L2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTExNyw3ICsxMTcsNiBAQAogICAgICwgbV9yZXF1ZXN0Q291bnQoMCkKICAgICAsIG1fZ2FyYmFn ZUNvbGxlY3REb2N1bWVudFJlc291cmNlc1RpbWVyKHRoaXMsICZDYWNoZWRSZXNvdXJjZUxvYWRl cjo6Z2FyYmFnZUNvbGxlY3REb2N1bWVudFJlc291cmNlc1RpbWVyRmlyZWQpCiAgICAgLCBtX2F1 dG9Mb2FkSW1hZ2VzKHRydWUpCi0gICAgLCBtX2xvYWRGaW5pc2hpbmcoZmFsc2UpCiAgICAgLCBt X2FsbG93U3RhbGVSZXNvdXJjZXMoZmFsc2UpCiB7CiB9CkBAIC02ODEsOCArNjgwLDYgQEAKIAog dm9pZCBDYWNoZWRSZXNvdXJjZUxvYWRlcjo6bG9hZERvbmUoKQogewotICAgIG1fbG9hZEZpbmlz aGluZyA9IGZhbHNlOwotCiAgICAgUmVmUHRyPERvY3VtZW50PiBwcm90ZWN0KG1fZG9jdW1lbnQp OwogICAgIGlmIChmcmFtZSgpKQogICAgICAgICBmcmFtZSgpLT5sb2FkZXIoKS0+bG9hZERvbmUo KTsKQEAgLTc0NywxMyArNzQ0LDYgQEAKICAgICAtLW1fcmVxdWVzdENvdW50OwogICAgIEFTU0VS VChtX3JlcXVlc3RDb3VudCA+IC0xKTsKIH0KLQotaW50IENhY2hlZFJlc291cmNlTG9hZGVyOjpy ZXF1ZXN0Q291bnQoKQotewotICAgIGlmIChtX2xvYWRGaW5pc2hpbmcpCi0gICAgICAgICByZXR1 cm4gbV9yZXF1ZXN0Q291bnQgKyAxOwotICAgIHJldHVybiBtX3JlcXVlc3RDb3VudDsKLX0KICAg ICAKIHZvaWQgQ2FjaGVkUmVzb3VyY2VMb2FkZXI6OnByZWxvYWQoQ2FjaGVkUmVzb3VyY2U6OlR5 cGUgdHlwZSwgUmVzb3VyY2VSZXF1ZXN0JiByZXF1ZXN0LCBjb25zdCBTdHJpbmcmIGNoYXJzZXQs IGJvb2wgcmVmZXJlbmNlZEZyb21Cb2R5KQogewpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVy L2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlTG9hZGVyLmgJKHJldmlzaW9uIDExNDI4NykK KysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZUxvYWRlci5oCSh3 b3JraW5nIGNvcHkpCkBAIC0xMDQsMTMgKzEwNCwxMSBAQAogICAgIERvY3VtZW50KiBkb2N1bWVu dCgpIGNvbnN0IHsgcmV0dXJuIG1fZG9jdW1lbnQ7IH0KIAogICAgIHZvaWQgcmVtb3ZlQ2FjaGVk UmVzb3VyY2UoQ2FjaGVkUmVzb3VyY2UqKSBjb25zdDsKLQotICAgIHZvaWQgbG9hZEZpbmlzaGlu ZygpIHsgbV9sb2FkRmluaXNoaW5nID0gdHJ1ZTsgfQogICAgIHZvaWQgbG9hZERvbmUoKTsKICAg ICAKICAgICB2b2lkIGluY3JlbWVudFJlcXVlc3RDb3VudChjb25zdCBDYWNoZWRSZXNvdXJjZSop OwogICAgIHZvaWQgZGVjcmVtZW50UmVxdWVzdENvdW50KGNvbnN0IENhY2hlZFJlc291cmNlKik7 Ci0gICAgaW50IHJlcXVlc3RDb3VudCgpOworICAgIGludCByZXF1ZXN0Q291bnQoKSBjb25zdCB7 IHJldHVybiBtX3JlcXVlc3RDb3VudDsgfQogCiAgICAgYm9vbCBpc1ByZWxvYWRlZChjb25zdCBT dHJpbmcmIHVybFN0cmluZykgY29uc3Q7CiAgICAgdm9pZCBjbGVhclByZWxvYWRzKCk7CkBAIC0x NTEsOSArMTQ5LDggQEAKIAogICAgIFRpbWVyPENhY2hlZFJlc291cmNlTG9hZGVyPiBtX2dhcmJh Z2VDb2xsZWN0RG9jdW1lbnRSZXNvdXJjZXNUaW1lcjsKIAotICAgIC8vMjkgYml0cyBsZWZ0Cisg ICAgLy8gMzAgYml0cyBsZWZ0CiAgICAgYm9vbCBtX2F1dG9Mb2FkSW1hZ2VzIDogMTsKLSAgICBi b29sIG1fbG9hZEZpbmlzaGluZyA6IDE7CiAgICAgYm9vbCBtX2FsbG93U3RhbGVSZXNvdXJjZXMg OiAxOwogfTsKIAo=