84095 2012-04-16 16:22:36 -0700 Only depend on xrender if x11 is being used 2013-02-19 09:03:28 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://trac.macports.org/ticket/34086 EasyFix P2 Normal --- 0 jeremyhu webkit-unassigned chkang514 jeremyhu michael.duwei mrobinson webkit.review.bot zan oldest_to_newest 603540 0 jeremyhu 2012-04-16 16:22:36 -0700 http://trac.macports.org/ticket/34086 configure.ac contains: # check for XRender under Linux/Unix. Some linkers require explicit # linkage (like GNU Gold), so we cannot rely on GTK+ pulling XRender if test "$os_win32" = "no"; then PKG_CHECK_MODULES([XRENDER], [xrender]) AC_SUBST([XRENDER_CFLAGS]) AC_SUBST([XRENDER_LIBS]) fi But that logic is incorrect. You should be checking for xrender based on target (x11), not OS. This incorrectly results in xrender being pulled in for the quartz target, and it incorrectly prevents xrender from being pulled in on the win/x11 target. 605632 1 jeremyhu 2012-04-19 09:39:25 -0700 Here is a patch: https://trac.macports.org/raw-attachment/ticket/34086/xrender-check.patch --- configure.orig 2012-04-18 17:55:13.000000000 -0500 +++ configure 2012-04-18 17:56:11.000000000 -0500 @@ -22086,7 +22086,7 @@ # check for XRender under Linux/Unix. Some linkers require explicit # linkage (like GNU Gold), so we cannot rely on GTK+ pulling XRender -if test "$os_win32" = "no"; then +if test "$with_target" = "x11"; then pkg_failed=no { $as_echo "$as_me:${as_lineno-$LINENO}: checking for XRENDER" >&5 748440 2 170103 chkang514 2012-10-23 03:03:13 -0700 Created attachment 170103 I made a simple patch for this bug. 748689 3 jeremyhu 2012-10-23 08:57:55 -0700 That's exactly the same patch that I provided in the link in the previous comment... 749137 4 chkang514 2012-10-23 17:12:41 -0700 I appreciate for your guide. Is there anything i missed? > That's exactly the same patch that I provided in the link in the previous comment... 752981 5 jeremyhu 2012-10-28 13:37:57 -0700 (In reply to comment #4) > I appreciate for your guide. > Is there anything i missed? > > That's exactly the same patch that I provided in the link in the previous comment... No, I'm saying that's exactly what I had already, so: Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> Tested-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com> Sorry, I'm not familiar with the commit process within webkit and have just been filing bugs. If it should've been sent to a list or made an attachment, please let me know for next time. 835885 6 170103 benjamin 2013-02-18 18:36:59 -0800 Comment on attachment 170103 I made a simple patch for this bug. This looks out of date, the patch does not apply. 835914 7 jeremyhu 2013-02-18 20:19:18 -0800 It's a trivial 1-line patch. Surely you can rebase it. 836018 8 jeremyhu 2013-02-18 23:27:16 -0800 And it applies fine to 1.11.5 836085 9 zan 2013-02-19 00:34:45 -0800 The configuration system used by the Autotools build was reworked recently. The change should now fit in here: http://trac.webkit.org/browser/trunk/Source/autotools/FindDependencies.m4 836091 10 189013 chkang514 2013-02-19 00:48:06 -0800 Created attachment 189013 Patch 836459 11 189013 webkit.review.bot 2013-02-19 09:03:24 -0800 Comment on attachment 189013 Patch Clearing flags on attachment: 189013 Committed r143344: <http://trac.webkit.org/changeset/143344> 836460 12 webkit.review.bot 2013-02-19 09:03:28 -0800 All reviewed patches have been landed. Closing bug. 170103 2012-10-23 03:03:13 -0700 2013-02-19 00:48:01 -0800 I made a simple patch for this bug. 0001-Only-depend-on-xrender-if-x11-is-being-used.patch text/plain 1803 chkang514 RnJvbSBhMTNjMjQxZWYxZTk1ZWZmODhlZmIwNzNkZDQ3N2MwMTc4ODU0ZWJhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBDaGFuZ2h1biBLYW5nIDx0ZW1vb2NoaW5AY29tcGFueTEwMC5u ZXQ+CkRhdGU6IEZyaSwgMTkgT2N0IDIwMTIgMjE6NTQ6MzQgKzA5MDAKU3ViamVjdDogW1BBVENI XSBPbmx5IGRlcGVuZCBvbiB4cmVuZGVyIGlmIHgxMSBpcyBiZWluZyB1c2VkCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQwOTUKClJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgoKWHJlbmRlciBzaG91bGQgYmUgY2hlY2tlZCBiYXNlZCBvbiB0YXJnZXQgKHgxMSks IG5vdCBPUy4KVGhpcyBpbmNvcnJlY3RseSByZXN1bHRzIGluIHhyZW5kZXIgYmVpbmcgcHVsbGVk IGluIGZvciB0aGUgcXVhcnR6IHRhcmdldCwKYW5kIGl0IGluY29ycmVjdGx5IHByZXZlbnRzIHhy ZW5kZXIgZnJvbSBiZWluZyBwdWxsZWQgaW4gb24gdGhlIHdpbi94MTEgdGFyZ2V0LgoKKiBjb25m aWd1cmUuYWM6Ci0tLQogQ2hhbmdlTG9nICAgIHwgICAxMyArKysrKysrKysrKysrCiBjb25maWd1 cmUuYWMgfCAgICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggM2IzZWQy Mi4uZDYwMWY5ZiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTEwLTE5ICBDaGFuZ2h1biBLYW5nICA8dGVtb29jaGluQGNvbXBhbnkx MDAubmV0PgorCisgICAgICAgIE9ubHkgZGVwZW5kIG9uIHhyZW5kZXIgaWYgeDExIGlzIGJlaW5n IHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0 MDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgWHJl bmRlciBzaG91bGQgYmUgY2hlY2tlZCBiYXNlZCBvbiB0YXJnZXQgKHgxMSksIG5vdCBPUy4KKyAg ICAgICAgVGhpcyBpbmNvcnJlY3RseSByZXN1bHRzIGluIHhyZW5kZXIgYmVpbmcgcHVsbGVkIGlu IGZvciB0aGUgcXVhcnR6IHRhcmdldCwKKyAgICAgICAgYW5kIGl0IGluY29ycmVjdGx5IHByZXZl bnRzIHhyZW5kZXIgZnJvbSBiZWluZyBwdWxsZWQgaW4gb24gdGhlIHdpbi94MTEgdGFyZ2V0Lgor CisgICAgICAgICogY29uZmlndXJlLmFjOgorCiAyMDEyLTEwLTE4ICBMYXN6bG8gR29tYm9zICA8 bC5nb21ib3NAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gQnVpbGRmaXggaWYgTmV0c2Nh cGUgcGx1Z2luIHN1cHBvcnQgaXMgZGlzYWJsZWQKZGlmZiAtLWdpdCBhL2NvbmZpZ3VyZS5hYyBi L2NvbmZpZ3VyZS5hYwppbmRleCAzNzY2M2UyLi42Zjg5MTI1IDEwMDY0NAotLS0gYS9jb25maWd1 cmUuYWMKKysrIGIvY29uZmlndXJlLmFjCkBAIC05ODgsNyArOTg4LDcgQEAgZmkKIAogIyBjaGVj ayBmb3IgWFJlbmRlciB1bmRlciBMaW51eC9Vbml4LiBTb21lIGxpbmtlcnMgcmVxdWlyZSBleHBs aWNpdAogIyBsaW5rYWdlIChsaWtlIEdOVSBHb2xkKSwgc28gd2UgY2Fubm90IHJlbHkgb24gR1RL KyBwdWxsaW5nIFhSZW5kZXIKLWlmIHRlc3QgIiRvc193aW4zMiIgPSAibm8iOyB0aGVuCitpZiB0 ZXN0ICIkd2l0aF90YXJnZXQiID0gIngxMSI7IHRoZW4KICAgIFBLR19DSEVDS19NT0RVTEVTKFtY UkVOREVSXSwgW3hyZW5kZXJdKQogICAgQUNfU1VCU1QoW1hSRU5ERVJfQ0ZMQUdTXSkKICAgIEFD X1NVQlNUKFtYUkVOREVSX0xJQlNdKQotLSAKMS43LjkuNQoK 189013 2013-02-19 00:48:06 -0800 2013-02-19 09:03:24 -0800 Patch bug-84095-20130219004428.patch text/plain 1174 chkang514 U3VidmVyc2lvbiBSZXZpc2lvbjogMTQzMzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L0ZpbmREZXBlbmRlbmNpZXMubTQgYi9Tb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMu bTQKaW5kZXggMGRjYjQ2MjYzMzdiMDNhN2Q3OTdmNzE5MzNiZTM4ODIzMDA3MGQ1MC4uZDZkZGRm MWNjNjYzMzdlZjA3MmU2YzBjOTBhZDdlMDliN2FlNDNhNSAxMDA2NDQKLS0tIGEvU291cmNlL2F1 dG90b29scy9GaW5kRGVwZW5kZW5jaWVzLm00CisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvRmluZERl cGVuZGVuY2llcy5tNApAQCAtNDA0LDcgKzQwNCw3IEBAIGZpCiAKICMgQ2hlY2sgZm9yIFhSZW5k ZXIgdW5kZXIgTGludXgvVW5peC4gU29tZSBsaW5rZXJzIHJlcXVpcmUgZXhwbGljaXQgbGlua2Fn ZSAobGlrZSBHTlUgR29sZCksCiAjIHNvIHdlIGNhbm5vdCByZWx5IG9uIEdUSysgcHVsbGluZyBY UmVuZGVyLgotaWYgdGVzdCAiJG9zX3dpbjMyIiA9ICJubyI7IHRoZW4KK2lmIHRlc3QgIiR3aXRo X3RhcmdldCIgPSAieDExIjsgdGhlbgogICAgIFBLR19DSEVDS19NT0RVTEVTKFtYUkVOREVSXSwg W3hyZW5kZXJdKQogICAgIEFDX1NVQlNUKFtYUkVOREVSX0NGTEFHU10pCiAgICAgQUNfU1VCU1Qo W1hSRU5ERVJfTElCU10pCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXgg OTJkZjA5NTM2ZjY1MGNjOTAxOGRkNTk1NjllMzQ1YmMxODc5YmNmOS4uNTEzMTI5ZTIxNzgxODRl ZWY3OGFmMTk0YjhjODQzYzBlYWQ3MmU4NSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0No YW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEzLTAyLTE5ICBDaGFuZ2h1biBLYW5nICA8dGVt b29jaGluQGNvbXBhbnkxMDAubmV0PgorCisgICAgICAgIE9ubHkgZGVwZW5kIG9uIHhyZW5kZXIg aWYgeDExIGlzIGJlaW5nIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTg0MDk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL0ZpbmREZXBlbmRlbmNpZXMubTQ6CisKIDIw MTMtMDItMTggIENoYW5nU2VvayBPaCAgPHNoaXZhbWlkb3dAZ21haWwuY29tPgogCiAgICAgICAg IFtHVEtdIEZpeCBuaXRzIGZvciBjb25maWd1cmF0aW9uCg==