84068 2012-04-16 13:27:31 -0700 Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot 2012-04-17 00:18:49 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa abarth eric lforschler tony wsiegrist oldest_to_newest 603383 0 rniwa 2012-04-16 13:27:31 -0700 Chromium Win Perf fails to create WebKitBuild directory because mkdir on Windows doesn't support -p option. Since the download step automatically creates WebKitBuild directory now, this step is completely redundant. 603393 1 137394 rniwa 2012-04-16 13:40:36 -0700 Created attachment 137394 Fixes the failure 603399 2 137394 eric 2012-04-16 13:50:51 -0700 Comment on attachment 137394 Fixes the failure I assume this step was only used by the perf bot. 603401 3 eric 2012-04-16 13:51:12 -0700 You are aware we have unit tests for master.cfg, rght? 603411 4 rniwa 2012-04-16 13:59:52 -0700 (In reply to comment #2) > (From update of attachment 137394 [details]) > I assume this step was only used by the perf bot. It's also used by testers but it's redundant there as well since download-built-product makes WebKitBuild directory as I explained in the change log. (In reply to comment #3) > You are aware we have unit tests for master.cfg, rght? Oh, I didn't know that. Did someone add it recently? I don't think a unit test is helpful for this file though. 603417 5 eric 2012-04-16 14:03:40 -0700 I added it long ago. :) It's of some use. it doesn't cover everything by far. 603427 6 rniwa 2012-04-16 14:14:10 -0700 (In reply to comment #5) > I added it long ago. :) It's of some use. it doesn't cover everything by far. I guess we can test whether config.json loads, etc... but we can't really test whether the code change we made is correct or not by unit tests there because most of master.cfg just calls out to other scripts. 603837 7 rniwa 2012-04-17 00:18:49 -0700 Committed r114353: <http://trac.webkit.org/changeset/114353> 137394 2012-04-16 13:40:36 -0700 2012-04-16 13:50:51 -0700 Fixes the failure bug-84068-20120416134035.patch text/plain 2578 rniwa SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDExNDI5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTA0LTE2ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJlbW92ZSBDcmVhdGVXZWJLaXRCdWlsZERpcmVjdG9yeSBzdGVwIHRvIGZpeCBD aHJvbWl1bSBXaW5kb3dzIFBlcmYgYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD04NDA2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJlbW92ZSBDcmVhdGVXZWJLaXRCdWlsZERpcmVjdG9yeSBmcm9tIG1h c3Rlci5jZmcgc2luY2UgZG93bmxvYWQtYnVpbHQtcHJvZHVjdAorICAgICAgICBhdXRvbWF0aWNh bGx5IGNyZWF0ZXMgdGhlIGJ1aWxkIGRpcmVjdG9yeSBpZiBuZWVkZWQuCisKKyAgICAgICAgKiBC dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAg ICAgICAoRG93bmxvYWRBbmRQZXJmVGVzdEZhY3RvcnkuX19pbml0X18pOgorICAgICAgICAoRG93 bmxvYWRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5Ll9faW5pdF9fKToKKwogMjAxMi0wNC0xNiAg VmluY2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZGluZyBD b250cmlidXRvcnMgQnJpYW4gU2Fsb21vbiBhbmQgVG9tIEh1ZHNvbiB0byBjb21taXR0ZXJzLnB5 LgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lvbiAxMTQyMTQpCisrKyBUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNDQsMTUgKzI0NCw2IEBAIGNsYXNzIERvd25sb2FkQnVpbHRQcm9kdWN0 KHNoZWxsLlNoZWxsQ28KICAgICBmbHVua09uRmFpbHVyZSA9IFRydWUKIAogCi1jbGFzcyBDcmVh dGVXZWJLaXRCdWlsZERpcmVjdG9yeShzaGVsbC5TaGVsbENvbW1hbmQpOgotICAgIGNvbW1hbmQg PSBbIm1rZGlyIiwgIi1wIiwgIldlYktpdEJ1aWxkIl0KLSAgICBuYW1lID0gImNyZWF0ZS13ZWJr aXRidWlsZC1kaXIiCi0gICAgZGVzY3JpcHRpb24gPSBbImNyZWF0aW5nIFdlYktpdEJ1aWxkIGRp cmVjdG9yeSJdCi0gICAgZGVzY3JpcHRpb25Eb25lID0gWyJjcmVhdGVkIFdlYktpdEJ1aWxkIGRp cmVjdG9yeSJdCi0gICAgaGFsdE9uRmFpbHVyZSA9IFRydWUKLSAgICBmbHVua09uRmFpbHVyZSA9 IFRydWUKLQotCiBjbGFzcyBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKHNoZWxsLlRlc3QpOgogICAg IG5hbWUgPSAianNjb3JlLXRlc3QiCiAgICAgZGVzY3JpcHRpb24gPSBbImpzY29yZS10ZXN0cyBy dW5uaW5nIl0KQEAgLTgyNyw3ICs4MTgsNiBAQCBjbGFzcyBCdWlsZEFuZFBlcmZUZXN0V2ViS2l0 MkZhY3RvcnkoRmFjCiBjbGFzcyBEb3dubG9hZEFuZFBlcmZUZXN0RmFjdG9yeShGYWN0b3J5KToK ICAgICBkZWYgX19pbml0X18oc2VsZiwgcGxhdGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVj dHVyZXMsICoqa3dhcmdzKToKICAgICAgICAgRmFjdG9yeS5fX2luaXRfXyhzZWxmLCBwbGF0Zm9y bSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgRmFsc2UsICoqa3dhcmdzKQotICAgICAg ICBzZWxmLmFkZFN0ZXAoQ3JlYXRlV2ViS2l0QnVpbGREaXJlY3RvcnkpCiAgICAgICAgIHNlbGYu YWRkU3RlcChEb3dubG9hZEJ1aWx0UHJvZHVjdCkKICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJh Y3RCdWlsdFByb2R1Y3QpCiAgICAgICAgIHNlbGYuYWRkU3RlcChSdW5BbmRVcGxvYWRQZXJmVGVz dHMpCkBAIC04MzUsNyArODI1LDYgQEAgY2xhc3MgRG93bmxvYWRBbmRQZXJmVGVzdEZhY3Rvcnko RmFjdG9yeQogY2xhc3MgRG93bmxvYWRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5KEZhY3Rvcnkp OgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0 ZWN0dXJlcywgKiprd2FyZ3MpOgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRm b3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgKiprd2FyZ3MpCi0gICAg ICAgIHNlbGYuYWRkU3RlcChDcmVhdGVXZWJLaXRCdWlsZERpcmVjdG9yeSkKICAgICAgICAgc2Vs Zi5hZGRTdGVwKERvd25sb2FkQnVpbHRQcm9kdWN0KQogICAgICAgICBzZWxmLmFkZFN0ZXAoRXh0 cmFjdEJ1aWx0UHJvZHVjdCkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFuZFVwbG9hZFBlcmZU ZXN0c1dlYktpdDIpCg==