84022 2012-04-16 05:05:02 -0700 [CG] ImageBuffer: check getPremultipliedImageData() error return 2012-04-18 23:22:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon eric mitz webkit.review.bot oldest_to_newest 603057 0 noel.gordon 2012-04-16 05:05:02 -0700 [CG] ImageBufffer: check getPremultipliedImageData() error return 603060 1 137321 noel.gordon 2012-04-16 05:06:57 -0700 Created attachment 137321 Patch 603066 2 noel.gordon 2012-04-16 05:18:15 -0700 Reopening to attach new patch. 603067 3 137327 noel.gordon 2012-04-16 05:18:20 -0700 Created attachment 137327 Patch 603423 4 137327 eric 2012-04-16 14:07:58 -0700 Comment on attachment 137327 Patch So does this mean we now pass more of that test? I'm surprised not to see any expectation changes? 604623 5 noel.gordon 2012-04-18 00:55:06 -0700 No change in behavior test-wise: we still pass canvas/philip/tests/toDataURL.jpeg.alpha.html, which covers this area of the code. 604627 6 137327 webkit.review.bot 2012-04-18 01:06:02 -0700 Comment on attachment 137327 Patch Clearing flags on attachment: 137327 Committed r114491: <http://trac.webkit.org/changeset/114491> 604628 7 webkit.review.bot 2012-04-18 01:06:07 -0700 All reviewed patches have been landed. Closing bug. 605369 8 noel.gordon 2012-04-18 22:13:55 -0700 Oh and did we noticed that loop stuffing 255 into the alpha channel. The encoder is so fast that iterating over pixels to reformat them becomes a significant factor in overall encoding time. Surely the CG jpeg encoder can be told to ignore the alpha channel. Investigating ... 605403 9 noel.gordon 2012-04-18 23:22:08 -0700 Filed bug 84319. 137321 2012-04-16 05:06:57 -0700 2012-04-16 05:18:07 -0700 Patch bug-84022-20120416220656.patch text/plain 3049 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM3MjE3NWFmZGEyMzkx ZDIwMTcyMGI5ZGEzMDU4NDllMjMwNjQyOC4uYzk2Y2Y1ZTRjYjcyMWZhYzU3ZTI0MTNiNjZmOTRh MzcwYmU1YTMxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE2ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbQ0ddIEltYWdlQnVm ZmZlcjogY2hlY2sgZ2V0UHJlbXVsdGlwbGllZEltYWdlRGF0YSgpIGVycm9yIHJldHVybgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQwMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbWFnZUJ1ZmZlcjo6 Z2V0UHJlbXVsdGlwbGllZEltYWdlRGF0YSgpIGNhbiBmYWlsOyB0b0RhdGFVUkwoKSBzaG91bGQg Y2hlY2sgZm9yIGEKKyAgICAgICAgZmFpbHVyZSByZXR1cm4sIGFuZCByZXR1cm4gImRhdGE6LCIg aWYgc28uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRvRGF0 YVVSTCB0ZXN0cywgaW4gcGFydGljdWxhcjoKKyAgICAgICAgICBjYW52YXMvcGhpbGlwL3Rlc3Rz L3RvRGF0YVVSTC5qcGVnLmFscGhhLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L2NnL0ltYWdlQnVmZmVyQ0cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnRv RGF0YVVSTCk6IFJlbmFtZSB8YXJyfCB2YXJpYWJsZSB0byBwcmVtdWx0aXBsaWVkRGF0YSBhbmQK KyAgICAgICAgcmV0dXJuICJkYXRhOiwiIGlmIHByZW11bHRpcGxpZWREYXRhIGlzIGVtcHR5LiBD bGVhbiB1cCB3aGl0ZXNwYWNlIGFuZCBhIGNvbW1lbnQuCisKIDIwMTItMDQtMTYgIEphc29uIExp dSAgPGphc29uLmxpdUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnld IE1pc3NpbmcgcmVhZHlTdGF0ZSAyIHdoZW4gYSBYTUxIdHRwUmVxdWVzdCBjYWxscyB4bWxodHRw Lm9wZW4oIkhFQUQiLCJub3RFeGlzdC5odG1sIix0cnVlKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyQ0cuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKaW5kZXggNmVmMzc0 Zjk2MGJhYjIwN2NiYTk5MGVhYTQwOTMwYmY4YzliY2M2Mi4uNzUyYWM0ZDFmYjAzOTk4N2U1YmFi ZDE1NDE5Y2JlYzAxN2E2ZTAwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAKQEAgLTQzNiwyMyArNDM2LDI1IEBAIHN0 YXRpYyBTdHJpbmcgQ0dJbWFnZVRvRGF0YVVSTChDR0ltYWdlUmVmIGltYWdlLCBjb25zdCBTdHJp bmcmIG1pbWVUeXBlLCBjb25zdCBkCiBTdHJpbmcgSW1hZ2VCdWZmZXI6OnRvRGF0YVVSTChjb25z dCBTdHJpbmcmIG1pbWVUeXBlLCBjb25zdCBkb3VibGUqIHF1YWxpdHksIENvb3JkaW5hdGVTeXN0 ZW0pIGNvbnN0CiB7CiAgICAgQVNTRVJUKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1h Z2VNSU1FVHlwZUZvckVuY29kaW5nKG1pbWVUeXBlKSk7Ci0gICAgUmV0YWluUHRyPENHSW1hZ2VS ZWY+IGltYWdlOworCiAgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiB1dGkgPSB1dGlGcm9tTUlN RVR5cGUobWltZVR5cGUpOwogICAgIEFTU0VSVCh1dGkpOwotICAgIFJlZlB0cjxCeXRlQXJyYXk+ IGFycjsKKworICAgIFJlZlB0cjxCeXRlQXJyYXk+IHByZW11bHRpcGxpZWREYXRhOworICAgIFJl dGFpblB0cjxDR0ltYWdlUmVmPiBpbWFnZTsKIAogICAgIGlmIChDRkVxdWFsKHV0aS5nZXQoKSwg anBlZ1VUSSgpKSkgewogICAgICAgICAvLyBKUEVHcyBkb24ndCBoYXZlIGFuIGFscGhhIGNoYW5u ZWwsIHNvIHdlIGhhdmUgdG8gbWFudWFsbHkgY29tcG9zaXRlIG9uIHRvcCBvZiBibGFjay4KLSAg ICAgICAgYXJyID0gZ2V0UHJlbXVsdGlwbGllZEltYWdlRGF0YShJbnRSZWN0KEludFBvaW50KDAs IDApLCBsb2dpY2FsU2l6ZSgpKSk7CisgICAgICAgIHByZW11bHRpcGxpZWREYXRhID0gZ2V0UHJl bXVsdGlwbGllZEltYWdlRGF0YShJbnRSZWN0KEludFBvaW50KDAsIDApLCBsb2dpY2FsU2l6ZSgp KSk7CisgICAgICAgIGlmICghcHJlbXVsdGlwbGllZERhdGEpCisgICAgICAgICAgICByZXR1cm4g ImRhdGE6LCI7CiAKLSAgICAgICAgdW5zaWduZWQgY2hhciAqZGF0YSA9IGFyci0+ZGF0YSgpOwor ICAgICAgICB1bnNpZ25lZCBjaGFyICpkYXRhID0gcHJlbXVsdGlwbGllZERhdGEtPmRhdGEoKTsK ICAgICAgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBsb2dpY2FsU2l6ZSgpLndpZHRoKCkgKiBsb2dp Y2FsU2l6ZSgpLmhlaWdodCgpOyBpKyspCi0gICAgICAgICAgICBkYXRhW2kgKiA0ICsgM10gPSAy NTU7IC8vIFRoZSBpbWFnZSBpcyBhbHJlYWR5IHByZW11bHRpcGxpZWQsIHNvIHdlIGp1c3QgbmVl ZCB0byBtYWtlIGl0IG9wYXF1ZS4KKyAgICAgICAgICAgIGRhdGFbaSAqIDQgKyAzXSA9IDI1NTsg Ly8gVGhlIGRhdGEgaXMgcHJlbXVsdGlwbGllZCwgd2UganVzdCBuZWVkIHRvIG1ha2UgaXQgb3Bh cXVlLgogCiAgICAgICAgIFJldGFpblB0cjxDR0RhdGFQcm92aWRlclJlZj4gZGF0YVByb3ZpZGVy OwotICAgIAogICAgICAgICBkYXRhUHJvdmlkZXIuYWRvcHRDRihDR0RhdGFQcm92aWRlckNyZWF0 ZVdpdGhEYXRhKDAsIGRhdGEsIDQgKiBsb2dpY2FsU2l6ZSgpLndpZHRoKCkgKiBsb2dpY2FsU2l6 ZSgpLmhlaWdodCgpLCAwKSk7Ci0gICAgCiAgICAgICAgIGlmICghZGF0YVByb3ZpZGVyKQogICAg ICAgICAgICAgcmV0dXJuICJkYXRhOiwiOwogCg== 137327 2012-04-16 05:18:20 -0700 2012-04-18 01:06:02 -0700 Patch bug-84022-20120416221818.patch text/plain 3048 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGM3MjE3NWFmZGEyMzkx ZDIwMTcyMGI5ZGEzMDU4NDllMjMwNjQyOC4uOWY3NzM3ZGZlNGQ4YmFhYTQ1NGUxOGE3OGM0ODAy NjA4ZmIxOGE4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA0LTE2ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbQ0ddIEltYWdlQnVm ZmVyOiBjaGVjayBnZXRQcmVtdWx0aXBsaWVkSW1hZ2VEYXRhKCkgZXJyb3IgcmV0dXJuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NDAyMgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltYWdlQnVmZmVyOjpn ZXRQcmVtdWx0aXBsaWVkSW1hZ2VEYXRhKCkgY2FuIGZhaWwuIHRvRGF0YVVSTCgpIHNob3VsZCBj aGVjayBmb3IgYQorICAgICAgICBmYWlsdXJlIHJldHVybiwgYW5kIHJldHVybiAiZGF0YTosIiBp ZiBzby4KKworICAgICAgICBObyBuZXcgdGVzdHMuIENvdmVyZWQgYnkgZXhpc3RpbmcgdG9EYXRh VVJMIHRlc3RzLCBpbiBwYXJ0aWN1bGFyOgorICAgICAgICAgIGNhbnZhcy9waGlsaXAvdGVzdHMv dG9EYXRhVVJMLmpwZWcuYWxwaGEuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2cvSW1hZ2VCdWZmZXJDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZUJ1ZmZlcjo6dG9E YXRhVVJMKTogUmVuYW1lIHxhcnJ8IHZhcmlhYmxlIHRvIHByZW11bHRpcGxpZWREYXRhIGFuZAor ICAgICAgICByZXR1cm4gImRhdGE6LCIgaWYgcHJlbXVsdGlwbGllZERhdGEgaXMgZW1wdHkuIENs ZWFuIHVwIHdoaXRlc3BhY2UgYW5kIGEgY29tbWVudC4KKwogMjAxMi0wNC0xNiAgSmFzb24gTGl1 ICA8amFzb24ubGl1QHRvcmNobW9iaWxlLmNvbS5jbj4KIAogICAgICAgICBbQmxhY2tCZXJyeV0g TWlzc2luZyByZWFkeVN0YXRlIDIgd2hlbiBhIFhNTEh0dHBSZXF1ZXN0IGNhbGxzIHhtbGh0dHAu b3BlbigiSEVBRCIsIm5vdEV4aXN0Lmh0bWwiLHRydWUpLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvSW1hZ2VCdWZmZXJDRy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAppbmRleCA2ZWYzNzRm OTYwYmFiMjA3Y2JhOTkwZWFhNDA5MzBiZjhjOWJjYzYyLi43NTJhYzRkMWZiMDM5OTg3ZTViYWJk MTU0MTljYmVjMDE3YTZlMDA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9jZy9JbWFnZUJ1ZmZlckNHLmNwcApAQCAtNDM2LDIzICs0MzYsMjUgQEAgc3Rh dGljIFN0cmluZyBDR0ltYWdlVG9EYXRhVVJMKENHSW1hZ2VSZWYgaW1hZ2UsIGNvbnN0IFN0cmlu ZyYgbWltZVR5cGUsIGNvbnN0IGQKIFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0 IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IGRvdWJsZSogcXVhbGl0eSwgQ29vcmRpbmF0ZVN5c3Rl bSkgY29uc3QKIHsKICAgICBBU1NFUlQoTUlNRVR5cGVSZWdpc3RyeTo6aXNTdXBwb3J0ZWRJbWFn ZU1JTUVUeXBlRm9yRW5jb2RpbmcobWltZVR5cGUpKTsKLSAgICBSZXRhaW5QdHI8Q0dJbWFnZVJl Zj4gaW1hZ2U7CisKICAgICBSZXRhaW5QdHI8Q0ZTdHJpbmdSZWY+IHV0aSA9IHV0aUZyb21NSU1F VHlwZShtaW1lVHlwZSk7CiAgICAgQVNTRVJUKHV0aSk7Ci0gICAgUmVmUHRyPEJ5dGVBcnJheT4g YXJyOworCisgICAgUmVmUHRyPEJ5dGVBcnJheT4gcHJlbXVsdGlwbGllZERhdGE7CisgICAgUmV0 YWluUHRyPENHSW1hZ2VSZWY+IGltYWdlOwogCiAgICAgaWYgKENGRXF1YWwodXRpLmdldCgpLCBq cGVnVVRJKCkpKSB7CiAgICAgICAgIC8vIEpQRUdzIGRvbid0IGhhdmUgYW4gYWxwaGEgY2hhbm5l bCwgc28gd2UgaGF2ZSB0byBtYW51YWxseSBjb21wb3NpdGUgb24gdG9wIG9mIGJsYWNrLgotICAg ICAgICBhcnIgPSBnZXRQcmVtdWx0aXBsaWVkSW1hZ2VEYXRhKEludFJlY3QoSW50UG9pbnQoMCwg MCksIGxvZ2ljYWxTaXplKCkpKTsKKyAgICAgICAgcHJlbXVsdGlwbGllZERhdGEgPSBnZXRQcmVt dWx0aXBsaWVkSW1hZ2VEYXRhKEludFJlY3QoSW50UG9pbnQoMCwgMCksIGxvZ2ljYWxTaXplKCkp KTsKKyAgICAgICAgaWYgKCFwcmVtdWx0aXBsaWVkRGF0YSkKKyAgICAgICAgICAgIHJldHVybiAi ZGF0YTosIjsKIAotICAgICAgICB1bnNpZ25lZCBjaGFyICpkYXRhID0gYXJyLT5kYXRhKCk7Cisg ICAgICAgIHVuc2lnbmVkIGNoYXIgKmRhdGEgPSBwcmVtdWx0aXBsaWVkRGF0YS0+ZGF0YSgpOwog ICAgICAgICBmb3IgKGludCBpID0gMDsgaSA8IGxvZ2ljYWxTaXplKCkud2lkdGgoKSAqIGxvZ2lj YWxTaXplKCkuaGVpZ2h0KCk7IGkrKykKLSAgICAgICAgICAgIGRhdGFbaSAqIDQgKyAzXSA9IDI1 NTsgLy8gVGhlIGltYWdlIGlzIGFscmVhZHkgcHJlbXVsdGlwbGllZCwgc28gd2UganVzdCBuZWVk IHRvIG1ha2UgaXQgb3BhcXVlLgorICAgICAgICAgICAgZGF0YVtpICogNCArIDNdID0gMjU1OyAv LyBUaGUgZGF0YSBpcyBwcmVtdWx0aXBsaWVkLCB3ZSBqdXN0IG5lZWQgdG8gbWFrZSBpdCBvcGFx dWUuCiAKICAgICAgICAgUmV0YWluUHRyPENHRGF0YVByb3ZpZGVyUmVmPiBkYXRhUHJvdmlkZXI7 Ci0gICAgCiAgICAgICAgIGRhdGFQcm92aWRlci5hZG9wdENGKENHRGF0YVByb3ZpZGVyQ3JlYXRl V2l0aERhdGEoMCwgZGF0YSwgNCAqIGxvZ2ljYWxTaXplKCkud2lkdGgoKSAqIGxvZ2ljYWxTaXpl KCkuaGVpZ2h0KCksIDApKTsKLSAgICAKICAgICAgICAgaWYgKCFkYXRhUHJvdmlkZXIpCiAgICAg ICAgICAgICByZXR1cm4gImRhdGE6LCI7CiAK