84010 2012-04-16 00:21:49 -0700 [GTK] atk/textChangedNotifications API test fails 2012-04-19 15:56:50 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned jiapu.mail mario morrita mrobinson oldest_to_newest 602942 0 pnormand 2012-04-16 00:21:49 -0700 First failing build is http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/22284 I suspect http://trac.webkit.org/changeset/114220 might be culprit. I'll skip this test for now. 603140 1 137346 mario 2012-04-16 07:32:45 -0700 Created attachment 137346 Patch proposal It is segfaulting in WebCore::Editor, at Source/WebCore/editing/Editor.cpp:920. See the snippet: bool Editor::insertTextWithoutSendingTextEvent(const String& text, bool selectInsertedText, TextEvent* triggeringEvent) { [...] if (selection.isContentEditable()) { if (Node* selectionStart = selection.start().deprecatedNode()) { RefPtr<Document> document = selectionStart->document(); // Insert the text if (triggeringEvent->isDictation()) <--- SEGV here, triggeringEvent might be NULL (see check in line below, in the else branch) DictationCommand::insertText(document.get(), text, triggeringEvent->dictationAlternatives(), selection); else { TypingCommand::Options options = 0; if (selectInsertedText) options |= TypingCommand::SelectInsertedText; if (autocorrectionWasApplied) options |= TypingCommand::RetainAutocorrectionIndicator; TypingCommand::insertText(document.get(), text, selection, options, triggeringEvent && triggeringEvent->isComposition() ? TypingCommand::TextCompositionConfirm : TypingCommand::TextCompositionNone); } [...] } So, the attached patch would fix the issue. 603168 2 mrobinson 2012-04-16 08:21:31 -0700 Is Dictation a new feature? I'm surprised it isn't behind a compile-time flag. 603661 3 jiapu.mail 2012-04-16 18:23:22 -0700 (In reply to comment #2) > Is Dictation a new feature? I'm surprised it isn't behind a compile-time flag. Currently this is used only by OS X. I can certainly put it behind compile time flag, if that's desirable. 604122 4 jiapu.mail 2012-04-17 10:26:49 -0700 It seems http://trac.webkit.org/changeset/114311 has already fixed this. 604130 5 mrobinson 2012-04-17 10:34:17 -0700 We just need to unskip the test now. 604620 6 mario 2012-04-18 00:37:49 -0700 Committed r114490: <http://trac.webkit.org/changeset/114490> 606054 7 137346 eric 2012-04-19 15:56:50 -0700 Comment on attachment 137346 Patch proposal Cleared review? from attachment 137346 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 137346 2012-04-16 07:32:45 -0700 2012-04-19 15:56:50 -0700 Patch proposal 0001-2012-04-16-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 3800 mario RnJvbSA5M2YwYzA4Mjg1MWVhYmYyNGE0Y2JiNDMxYWU0ZjY3NjViODY4ZDU3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBNb24sIDE2IEFwciAyMDEyIDE2OjMxOjE5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wNC0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdIGF0ay90ZXh0Q2hhbmdlZE5vdGlmaWNhdGlvbnMgQVBJIHRlc3QgZmFp bHMKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQwMTAK CiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIEFkZCBtaXNzaW5n IG51bGwtY2hlY2sgaW4gV2ViQ29yZTo6RWRpdG9yLgoKICAgICAgICAqIGVkaXRpbmcvRWRpdG9y LmNwcDoKICAgICAgICAoV2ViQ29yZTo6RWRpdG9yOjppbnNlcnRUZXh0V2l0aG91dFNlbmRpbmdU ZXh0RXZlbnQpOiBBZGQgbWlzc2luZwogICAgICAgIG51bGwtY2hlY2sgZm9yIHRyaWdlcmluZ0V2 ZW50IHdoZW4gY2hlY2tpbmcgaWYgaXNEaWN0YXRpb24oKS4KCjIwMTItMDQtMTYgIE1hcmlvIFNh bmNoZXogUHJhZGEgIDxtc2FuY2hlekBpZ2FsaWEuY29tPgoKICAgICAgICBbR1RLXSBhdGsvdGV4 dENoYW5nZWROb3RpZmljYXRpb25zIEFQSSB0ZXN0IGZhaWxzCiAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MDEwCgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICAqIFNjcmlwdHMvcnVuLWd0ay10ZXN0czoKICAgICAgICAo VGVzdFJ1bm5lcik6IFVuc2tpcCBwYXNzaW5nIHRlc3QgaW4gdGVzdGF0ay4KLS0tCiBTb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFNvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcCB8ICAgIDIgKy0KIFRvb2xzL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICB8ICAgMTAgKysrKysrKysrKwogVG9vbHMvU2NyaXB0cy9ydW4tZ3RrLXRl c3RzICAgICAgIHwgICAgNCAtLS0tCiA0IGZpbGVzIGNoYW5nZWQsIDI0IGluc2VydGlvbnMoKyks IDUgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGRjNzIxNzUuLjM3YmY5ZjMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wNC0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1z YW5jaGV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gYXRrL3RleHRDaGFuZ2VkTm90aWZp Y2F0aW9ucyBBUEkgdGVzdCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9ODQwMTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBZGQgbWlzc2luZyBudWxsLWNoZWNrIGluIFdlYkNvcmU6OkVkaXRvci4K KworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVkaXRv cjo6aW5zZXJ0VGV4dFdpdGhvdXRTZW5kaW5nVGV4dEV2ZW50KTogQWRkIG1pc3NpbmcKKyAgICAg ICAgbnVsbC1jaGVjayBmb3IgdHJpZ2VyaW5nRXZlbnQgd2hlbiBjaGVja2luZyBpZiBpc0RpY3Rh dGlvbigpLgorCiAyMDEyLTA0LTE2ICBKYXNvbiBMaXUgIDxqYXNvbi5saXVAdG9yY2htb2JpbGUu Y29tLmNuPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBNaXNzaW5nIHJlYWR5U3RhdGUgMiB3aGVu IGEgWE1MSHR0cFJlcXVlc3QgY2FsbHMgeG1saHR0cC5vcGVuKCJIRUFEIiwibm90RXhpc3QuaHRt bCIsdHJ1ZSkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0VkaXRvci5jcHAKaW5kZXggMjI4ODRmYS4uMjk0ZWI5 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9FZGl0b3IuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2VkaXRpbmcvRWRpdG9yLmNwcApAQCAtOTE2LDcgKzkxNiw3IEBAIGJvb2wg RWRpdG9yOjppbnNlcnRUZXh0V2l0aG91dFNlbmRpbmdUZXh0RXZlbnQoY29uc3QgU3RyaW5nJiB0 ZXh0LCBib29sIHNlbGVjdEluCiAgICAgICAgICAgICBSZWZQdHI8RG9jdW1lbnQ+IGRvY3VtZW50 ID0gc2VsZWN0aW9uU3RhcnQtPmRvY3VtZW50KCk7CiAKICAgICAgICAgICAgIC8vIEluc2VydCB0 aGUgdGV4dAotICAgICAgICAgICAgaWYgKHRyaWdnZXJpbmdFdmVudC0+aXNEaWN0YXRpb24oKSkK KyAgICAgICAgICAgIGlmICh0cmlnZ2VyaW5nRXZlbnQgJiYgdHJpZ2dlcmluZ0V2ZW50LT5pc0Rp Y3RhdGlvbigpKQogICAgICAgICAgICAgICAgIERpY3RhdGlvbkNvbW1hbmQ6Omluc2VydFRleHQo ZG9jdW1lbnQuZ2V0KCksIHRleHQsIHRyaWdnZXJpbmdFdmVudC0+ZGljdGF0aW9uQWx0ZXJuYXRp dmVzKCksIHNlbGVjdGlvbik7CiAgICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgICBU eXBpbmdDb21tYW5kOjpPcHRpb25zIG9wdGlvbnMgPSAwOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hh bmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDIxMjZjNTUuLjc0ZTA4NjkgMTAwNjQ0Ci0t LSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBA QAorMjAxMi0wNC0xNiAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gYXRrL3RleHRDaGFuZ2VkTm90aWZpY2F0aW9ucyBBUEkgdGVzdCBm YWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODQw MTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNj cmlwdHMvcnVuLWd0ay10ZXN0czoKKyAgICAgICAgKFRlc3RSdW5uZXIpOiBVbnNraXAgcGFzc2lu ZyB0ZXN0IGluIHRlc3RhdGsuCisKIDIwMTItMDQtMTYgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9y bWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIEdUSyBnYXJkZW5pbmcuCmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1ndGstdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1 bi1ndGstdGVzdHMKaW5kZXggNjI2NWVjMC4uNzc3Njc4OCAxMDA3NTUKLS0tIGEvVG9vbHMvU2Ny aXB0cy9ydW4tZ3RrLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWd0ay10ZXN0cwpAQCAt NzEsMTAgKzcxLDYgQEAgY2xhc3MgVGVzdFJ1bm5lcjoKICAgICAgICAgICAgICAgICAgICAgIlRl c3QgaXMgZmxha3kgaW4gR1RLIExpbnV4IDMyLWJpdCBSZWxlYXNlIGJvdCIsCiAgICAgICAgICAg ICAgICAgICAgIDgyODY4LAogICAgICAgICAgICAgICAgICAgICBbIi93ZWJraXQyL1dlYktpdFdl YlZpZXcvcmVzb3VyY2VzIl0pLAotICAgICAgICBTa2lwcGVkVGVzdCgidW5pdHRlc3RzL3Rlc3Rh dGsiLAotICAgICAgICAgICAgICAgICAgICAiRmFpbHMgb24gYWxsIEdUSyBib3RzIiwKLSAgICAg ICAgICAgICAgICAgICAgODQwMTAsCi0gICAgICAgICAgICAgICAgICAgIFsiL3dlYmtpdC9hdGsv dGV4dENoYW5nZWROb3RpZmljYXRpb25zIl0pLAogICAgIF0KIAogICAgIGRlZiBfX2luaXRfXyhz ZWxmLCBvcHRpb25zLCB0ZXN0cz1bXSk6Ci0tIAoxLjcuNy42Cgo=