84003 2012-04-15 18:03:40 -0700 Align JSC/V8 bindings canvas.toDataURL() code flows 2012-04-15 20:54:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon eric sam webkit.review.bot oldest_to_newest 602832 0 noel.gordon 2012-04-15 18:03:40 -0700 Align JSC/V8 bindings canvas.toDataURL() code flows 602833 1 137258 noel.gordon 2012-04-15 18:04:58 -0700 Created attachment 137258 Patch 602860 2 137258 eric 2012-04-15 19:48:08 -0700 Comment on attachment 137258 Patch LGTM. 602872 3 137258 webkit.review.bot 2012-04-15 20:54:43 -0700 Comment on attachment 137258 Patch Clearing flags on attachment: 137258 Committed r114221: <http://trac.webkit.org/changeset/114221> 602873 4 webkit.review.bot 2012-04-15 20:54:47 -0700 All reviewed patches have been landed. Closing bug. 137258 2012-04-15 18:04:58 -0700 2012-04-15 20:54:43 -0700 Patch bug-84003-20120416110456.patch text/plain 2101 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY1ZDExYjNkNDgwYmQ1 ZDEwOWNhMTQ4MjM2YWU0YTk3Yzg1MTM2ZS4uNTY1NzRmMmFkNzgyMWM1NTZkMDk3YWZjODU1ZmU0 YzYzY2E4MmUyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTE1ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBBbGlnbiBKU0MvVjgg YmluZGluZ3MgY2FudmFzLnRvRGF0YVVSTCgpIGNvZGUgZmxvd3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MDAzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxpZ24gSlNDL1Y4IGJpbmRpbmdzIGNhbnZh cy50b0RhdGFVUkwoKSBjb2RlIGZsb3cgc28gdGhhdCB0aGUgYmluZGluZworICAgICAgICBjb2Rl IGltcGxlbWVudGF0aW9ucyByZWFkIGFsaWtlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gQ292 ZXJlZCBieSBleGlzdGluZyBjbmF2YXMgdG9EYXRhVVJMIHRlc3RzLgorCisgICAgICAgICogYmlu ZGluZ3MvanMvSlNIVE1MQ2FudmFzRWxlbWVudEN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpKU0hUTUxDYW52YXNFbGVtZW50Ojp0b0RhdGFVUkwpOgorCiAyMDEyLTA0LTE0ICBFbWlsIEEg RWtsdW5kICA8ZWFlQGNocm9taXVtLm9yZz4KIAogICAgICAgICBGaXggcGl4ZWxTbmFwcGluZyBm b3IgQ2FsZW5kYXJQaWNrZXIsIE1lZGlhQ29udHJvbCBhbmQgU2Nyb2xsYmFyUGFydApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MQ2FudmFzRWxlbWVudEN1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDYW52YXNFbGVtZW50Q3Vz dG9tLmNwcAppbmRleCBkZjE4NjZmNmViODgwZjFmZjRkM2IwNTFkMGVkNzgzNmRkNjI2MzY0Li5l NmU2NWY5ZDU3YzRlNjc1MmQ1ZjYwZGUzMWM0YWU5YzE4ZWJlNWViIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxDYW52YXNFbGVtZW50Q3VzdG9tLmNw cApAQCAtODAsMTEgKzgwLDEwIEBAIEpTVmFsdWUgSlNIVE1MQ2FudmFzRWxlbWVudDo6Z2V0Q29u dGV4dChFeGVjU3RhdGUqIGV4ZWMpCiAKIEpTVmFsdWUgSlNIVE1MQ2FudmFzRWxlbWVudDo6dG9E YXRhVVJMKEV4ZWNTdGF0ZSogZXhlYykKIHsKLSAgICBjb25zdCBTdHJpbmcmIHR5cGUgPSB2YWx1 ZVRvU3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDAp KTsKICAgICBIVE1MQ2FudmFzRWxlbWVudCogY2FudmFzID0gc3RhdGljX2Nhc3Q8SFRNTENhbnZh c0VsZW1lbnQqPihpbXBsKCkpOwogICAgIEV4Y2VwdGlvbkNvZGUgZWMgPSAwOwotICAgIAotICAg IEpTQzo6SlNWYWx1ZSByZXN1bHQ7CisKKyAgICBjb25zdCBTdHJpbmcmIHR5cGUgPSB2YWx1ZVRv U3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKGV4ZWMsIGV4ZWMtPmFyZ3VtZW50KDApKTsK ICAgICBkb3VibGUgcXVhbGl0eTsKICAgICBkb3VibGUqIHF1YWxpdHlQdHIgPSAwOwogICAgIGlm IChleGVjLT5hcmd1bWVudENvdW50KCkgPiAxKSB7CkBAIC05NSw3ICs5NCw3IEBAIEpTVmFsdWUg SlNIVE1MQ2FudmFzRWxlbWVudDo6dG9EYXRhVVJMKEV4ZWNTdGF0ZSogZXhlYykKICAgICAgICAg fQogICAgIH0KICAgICAKLSAgICByZXN1bHQgPSBqc1N0cmluZyhleGVjLCBjYW52YXMtPnRvRGF0 YVVSTCh0eXBlLCBxdWFsaXR5UHRyLCBlYykpOworICAgIEpTVmFsdWUgcmVzdWx0ID0ganNTdHJp bmcoZXhlYywgY2FudmFzLT50b0RhdGFVUkwodHlwZSwgcXVhbGl0eVB0ciwgZWMpKTsKICAgICBz ZXRET01FeGNlcHRpb24oZXhlYywgZWMpOwogICAgIHJldHVybiByZXN1bHQ7CiB9Cg==