83975 2012-04-14 04:14:04 -0700 [Cairo] Separate image encoding from dataURL construction 2012-04-15 19:14:31 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 noel.gordon noel.gordon bfulgham eric mrobinson senorblanco webkit.review.bot oldest_to_newest 602648 0 noel.gordon 2012-04-14 04:14:04 -0700 [Cairo] Separate image encoding from dataURL construction 602649 1 137204 noel.gordon 2012-04-14 04:37:52 -0700 Created attachment 137204 Patch 602819 2 137204 webkit.review.bot 2012-04-15 17:16:15 -0700 Comment on attachment 137204 Patch Rejecting attachment 137204 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/12409692 602822 3 137256 noel.gordon 2012-04-15 17:29:46 -0700 Created attachment 137256 Patch for landing 602849 4 137256 webkit.review.bot 2012-04-15 19:14:26 -0700 Comment on attachment 137256 Patch for landing Clearing flags on attachment: 137256 Committed r114216: <http://trac.webkit.org/changeset/114216> 602850 5 webkit.review.bot 2012-04-15 19:14:31 -0700 All reviewed patches have been landed. Closing bug. 137204 2012-04-14 04:37:52 -0700 2012-04-15 17:29:37 -0700 Patch bug-83975-20120414213750.patch text/plain 3098 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUwOTNkYTRlNjI2MTA3 YmEzODdiYjA5NjM3MDk5MDdiMTdmM2Y3OC4uNWVkODNmMDIxZmIwYWFlYzM2MmZlNzIwYzFlMzQw OGRjMGY5NWM0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA0LTE0ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KIAorICAgICAgICBbQ2Fpcm9dIFNlcGFy YXRlIGltYWdlIGVuY29kaW5nIGZyb20gZGF0YVVSTCBjb25zdHJ1Y3Rpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzOTc1CisKKyAgICAgICAgUmVt b3ZlIHRoZSBpbXBsaWNpdCBhc3N1bXB0aW9uIHRoYXQgYSBkYXRhVVJMIGlzIHRoZSBvbmx5IGRl c2lyZWQgb3V0cHV0IGZvcm1hdAorICAgICAgICBvZiB0aGUgaW1hZ2UgZW5jb2RpbmcgcGhhc2Uu CisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGJ5IGV4aXN0aW5nIGNhbnZhcyB0b0Rh dGFVUkwgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9JbWFnZUJ1 ZmZlckNhaXJvLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndyaXRlRnVuY3Rpb24pOiBSZW5hbWUg Y2xvc3VyZSB0byBvdXRwdXQuCisgICAgICAgIChXZWJDb3JlOjplbmNvZGVJbWFnZSk6IE91dHB1 dCB0aGUgZW5jb2RlZCBpbWFnZSB0byB0aGUgcHJvdmlkZWQgVmVjdG9yPGNoYXI+LgorICAgICAg ICBQTkcgZm9ybWF0IGlzIG9ubHkgc3VwcG9ydGVkIHBlciB0aGUgQ2Fpcm8gZW5jb2RpbmcgTUlN RVR5cGVSZWdpc3RyeS4KKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAoV2ViQ29yZTo6SW1h Z2VCdWZmZXI6OnRvRGF0YVVSTCk6IFJlZmFjdG9yIHRvIHVzZSBlbmNvZGVJbWFnZSgpLgorCisy MDEyLTA0LTE0ICBOb2VsIEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKwogICAgICAg ICBbQ2Fpcm9dIEltYWdlQnVmZmVyOjp0b0RhdGFVUkwoKTogaW1wcm92ZSBlcnJvciBoYW5kbGlu ZywgYWRkIG1pbWVUeXBlIEFTU0VSVHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTgzNTY5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVyQ2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKaW5kZXggMzc3OGIx ZDVkYWQwOWU1YTliY2ZhNTdhYWM4ZjcxNzE5MmFhZDUzMi4uYzA2MzE4ZTI1MjUwYjBjY2MzOWVi OWIxMzNhYjc2OGZjOGVkZGY0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHAKQEAgLTI1OCwyNSAr MjU4LDI4IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OnB1dEJ5dGVBcnJheShNdWx0aXBseSBtdWx0aXBs aWVkLCBCeXRlQXJyYXkqIHNvdXJjZSwgY29uc3QgSW50CiB9CiAKICNpZiAhUExBVEZPUk0oR1RL KQotc3RhdGljIGNhaXJvX3N0YXR1c190IHdyaXRlRnVuY3Rpb24odm9pZCogY2xvc3VyZSwgY29u c3QgdW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQgaW50IGxlbmd0aCkKK3N0YXRpYyBjYWly b19zdGF0dXNfdCB3cml0ZUZ1bmN0aW9uKHZvaWQqIG91dHB1dCwgY29uc3QgdW5zaWduZWQgY2hh ciogZGF0YSwgdW5zaWduZWQgaW50IGxlbmd0aCkKIHsKLSAgICBpZiAoIXJlaW50ZXJwcmV0X2Nh c3Q8VmVjdG9yPHVuc2lnbmVkIGNoYXI+Kj4oY2xvc3VyZSktPnRyeUFwcGVuZChkYXRhLCBsZW5n dGgpKQorICAgIGlmICghcmVpbnRlcnByZXRfY2FzdDxWZWN0b3I8dW5zaWduZWQgY2hhcj4qPihv dXRwdXQpLT50cnlBcHBlbmQoZGF0YSwgbGVuZ3RoKSkKICAgICAgICAgcmV0dXJuIENBSVJPX1NU QVRVU19XUklURV9FUlJPUjsKICAgICByZXR1cm4gQ0FJUk9fU1RBVFVTX1NVQ0NFU1M7CiB9CiAK K3N0YXRpYyBib29sIGVuY29kZUltYWdlKGNhaXJvX3N1cmZhY2VfdCogaW1hZ2UsIGNvbnN0IFN0 cmluZyYgbWltZVR5cGUsIFZlY3RvcjxjaGFyPiogb3V0cHV0KQoreworICAgIEFTU0VSVChtaW1l VHlwZSA9PSAiaW1hZ2UvcG5nIik7IC8vIE9ubHkgUE5HIG91dHB1dCBpcyBzdXBwb3J0ZWQgZm9y IG5vdy4KKworICAgIHJldHVybiBjYWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZ19zdHJlYW0oaW1h Z2UsIHdyaXRlRnVuY3Rpb24sIG91dHB1dCkgPT0gQ0FJUk9fU1RBVFVTX1NVQ0NFU1M7Cit9CisK IFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJMKGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNv bnN0IGRvdWJsZSosIENvb3JkaW5hdGVTeXN0ZW0pIGNvbnN0CiB7CiAgICAgQVNTRVJUKE1JTUVU eXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VNSU1FVHlwZUZvckVuY29kaW5nKG1pbWVUeXBl KSk7CiAKICAgICBjYWlyb19zdXJmYWNlX3QqIGltYWdlID0gY2Fpcm9fZ2V0X3RhcmdldChjb250 ZXh0KCktPnBsYXRmb3JtQ29udGV4dCgpLT5jcigpKTsKLSAgICBpZiAoIWltYWdlKQotICAgICAg ICByZXR1cm4gImRhdGE6LCI7Ci0KLSAgICBBU1NFUlQobWltZVR5cGUgPT0gImltYWdlL3BuZyIp OyAvLyBPbmx5IFBORyBvdXRwdXQgaXMgc3VwcG9ydGVkIGZvciBub3cuCiAKICAgICBWZWN0b3I8 Y2hhcj4gZW5jb2RlZEltYWdlOwotICAgIGlmIChjYWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZ19z dHJlYW0oaW1hZ2UsIHdyaXRlRnVuY3Rpb24sICZlbmNvZGVkSW1hZ2UpICE9IENBSVJPX1NUQVRV U19TVUNDRVNTKQorICAgIGlmICghaW1hZ2UgfHwgIWVuY29kZUltYWdlKGltYWdlLCBtaW1lVHlw ZSwgJmVuY29kZWRJbWFnZSkpCiAgICAgICAgIHJldHVybiAiZGF0YTosIjsKIAogICAgIFZlY3Rv cjxjaGFyPiBiYXNlNjREYXRhOwo= 137256 2012-04-15 17:29:46 -0700 2012-04-15 19:14:26 -0700 Patch for landing bug-83975-20120416102943.patch text/plain 3068 noel.gordon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MjE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmY1ZDExYjNkNDgwYmQ1 ZDEwOWNhMTQ4MjM2YWU0YTk3Yzg1MTM2ZS4uNGE4NmQ0YTJiNTk5NjdiNzQ1M2VjNDhlYzVjNzM5 MGU4MjE2ZmMxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA0LTE1ICBOb2Vs IEdvcmRvbiAgPG5vZWwuZ29yZG9uQGdtYWlsLmNvbT4KKworICAgICAgICBbQ2Fpcm9dIFNlcGFy YXRlIGltYWdlIGVuY29kaW5nIGZyb20gZGF0YVVSTCBjb25zdHJ1Y3Rpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzOTc1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTWFydGluIFJvYmluc29uLgorCisgICAgICAgIFJlbW92ZSB0aGUgaW1wbGljaXQg YXNzdW1wdGlvbiB0aGF0IGEgZGF0YVVSTCBpcyB0aGUgb25seSBkZXNpcmVkIG91dHB1dCBmb3Jt YXQKKyAgICAgICAgb2YgdGhlIGltYWdlIGVuY29kaW5nIHBoYXNlLgorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gQ292ZXJlZCBieSBleGlzdGluZyBjYW52YXMgdG9EYXRhVVJMIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWlyby5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjp3cml0ZUZ1bmN0aW9uKTogUmVuYW1lIGNsb3N1cmUgdG8gb3V0cHV0 LgorICAgICAgICAoV2ViQ29yZTo6ZW5jb2RlSW1hZ2UpOiBPdXRwdXQgdGhlIGVuY29kZWQgaW1h Z2UgdG8gdGhlIHByb3ZpZGVkIFZlY3RvcjxjaGFyPi4KKyAgICAgICAgUE5HIGZvcm1hdCBpcyBv bmx5IHN1cHBvcnRlZCBwZXIgdGhlIENhaXJvIGVuY29kaW5nIE1JTUVUeXBlUmVnaXN0cnkuCisg ICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlQnVmZmVyOjp0b0RhdGFV UkwpOiBSZWZhY3RvciB0byB1c2UgZW5jb2RlSW1hZ2UoKS4KKwogMjAxMi0wNC0xNCAgRW1pbCBB IEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgRml4IHBpeGVsU25hcHBpbmcg Zm9yIENhbGVuZGFyUGlja2VyLCBNZWRpYUNvbnRyb2wgYW5kIFNjcm9sbGJhclBhcnQKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ltYWdlQnVmZmVy Q2Fpcm8uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VC dWZmZXJDYWlyby5jcHAKaW5kZXggMzc3OGIxZDVkYWQwOWU1YTliY2ZhNTdhYWM4ZjcxNzE5MmFh ZDUzMi4uYzA2MzE4ZTI1MjUwYjBjY2MzOWViOWIxMzNhYjc2OGZjOGVkZGY0NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VCdWZmZXJDYWly by5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8vSW1hZ2VC dWZmZXJDYWlyby5jcHAKQEAgLTI1OCwyNSArMjU4LDI4IEBAIHZvaWQgSW1hZ2VCdWZmZXI6OnB1 dEJ5dGVBcnJheShNdWx0aXBseSBtdWx0aXBsaWVkLCBCeXRlQXJyYXkqIHNvdXJjZSwgY29uc3Qg SW50CiB9CiAKICNpZiAhUExBVEZPUk0oR1RLKQotc3RhdGljIGNhaXJvX3N0YXR1c190IHdyaXRl RnVuY3Rpb24odm9pZCogY2xvc3VyZSwgY29uc3QgdW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWdu ZWQgaW50IGxlbmd0aCkKK3N0YXRpYyBjYWlyb19zdGF0dXNfdCB3cml0ZUZ1bmN0aW9uKHZvaWQq IG91dHB1dCwgY29uc3QgdW5zaWduZWQgY2hhciogZGF0YSwgdW5zaWduZWQgaW50IGxlbmd0aCkK IHsKLSAgICBpZiAoIXJlaW50ZXJwcmV0X2Nhc3Q8VmVjdG9yPHVuc2lnbmVkIGNoYXI+Kj4oY2xv c3VyZSktPnRyeUFwcGVuZChkYXRhLCBsZW5ndGgpKQorICAgIGlmICghcmVpbnRlcnByZXRfY2Fz dDxWZWN0b3I8dW5zaWduZWQgY2hhcj4qPihvdXRwdXQpLT50cnlBcHBlbmQoZGF0YSwgbGVuZ3Ro KSkKICAgICAgICAgcmV0dXJuIENBSVJPX1NUQVRVU19XUklURV9FUlJPUjsKICAgICByZXR1cm4g Q0FJUk9fU1RBVFVTX1NVQ0NFU1M7CiB9CiAKK3N0YXRpYyBib29sIGVuY29kZUltYWdlKGNhaXJv X3N1cmZhY2VfdCogaW1hZ2UsIGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIFZlY3RvcjxjaGFyPiog b3V0cHV0KQoreworICAgIEFTU0VSVChtaW1lVHlwZSA9PSAiaW1hZ2UvcG5nIik7IC8vIE9ubHkg UE5HIG91dHB1dCBpcyBzdXBwb3J0ZWQgZm9yIG5vdy4KKworICAgIHJldHVybiBjYWlyb19zdXJm YWNlX3dyaXRlX3RvX3BuZ19zdHJlYW0oaW1hZ2UsIHdyaXRlRnVuY3Rpb24sIG91dHB1dCkgPT0g Q0FJUk9fU1RBVFVTX1NVQ0NFU1M7Cit9CisKIFN0cmluZyBJbWFnZUJ1ZmZlcjo6dG9EYXRhVVJM KGNvbnN0IFN0cmluZyYgbWltZVR5cGUsIGNvbnN0IGRvdWJsZSosIENvb3JkaW5hdGVTeXN0ZW0p IGNvbnN0CiB7CiAgICAgQVNTRVJUKE1JTUVUeXBlUmVnaXN0cnk6OmlzU3VwcG9ydGVkSW1hZ2VN SU1FVHlwZUZvckVuY29kaW5nKG1pbWVUeXBlKSk7CiAKICAgICBjYWlyb19zdXJmYWNlX3QqIGlt YWdlID0gY2Fpcm9fZ2V0X3RhcmdldChjb250ZXh0KCktPnBsYXRmb3JtQ29udGV4dCgpLT5jcigp KTsKLSAgICBpZiAoIWltYWdlKQotICAgICAgICByZXR1cm4gImRhdGE6LCI7Ci0KLSAgICBBU1NF UlQobWltZVR5cGUgPT0gImltYWdlL3BuZyIpOyAvLyBPbmx5IFBORyBvdXRwdXQgaXMgc3VwcG9y dGVkIGZvciBub3cuCiAKICAgICBWZWN0b3I8Y2hhcj4gZW5jb2RlZEltYWdlOwotICAgIGlmIChj YWlyb19zdXJmYWNlX3dyaXRlX3RvX3BuZ19zdHJlYW0oaW1hZ2UsIHdyaXRlRnVuY3Rpb24sICZl bmNvZGVkSW1hZ2UpICE9IENBSVJPX1NUQVRVU19TVUNDRVNTKQorICAgIGlmICghaW1hZ2UgfHwg IWVuY29kZUltYWdlKGltYWdlLCBtaW1lVHlwZSwgJmVuY29kZWRJbWFnZSkpCiAgICAgICAgIHJl dHVybiAiZGF0YTosIjsKIAogICAgIFZlY3RvcjxjaGFyPiBiYXNlNjREYXRhOwo=