83960 2012-04-13 16:38:24 -0700 [CSS Filters] Do not use clipping rect when calculating the bounds of a layer 2012-04-18 09:37:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achicu achicu dino gustavo.noronha gustavo simon.fraser xan.lopez oldest_to_newest 602511 0 achicu 2012-04-13 16:38:24 -0700 WebKit should not clip the bounding box of a layer when it draws it into a memory buffer in order to compute the CSS Filter for it. That's because the drop-shadow or blur effects might reference pixels outside the initial clipping box. This should fix the results for two tests that are already checked in: LayoutTests/css3/filters/filter-repaint-shadow-clipped.html LayoutTests/css3/filters/filter-repaint-shadow-rotated.html 602538 1 137184 achicu 2012-04-13 17:29:59 -0700 Created attachment 137184 Patch V1 602547 2 137184 simon.fraser 2012-04-13 17:36:27 -0700 Comment on attachment 137184 Patch V1 View in context: https://bugs.webkit.org/attachment.cgi?id=137184&action=review > Source/WebCore/ChangeLog:14 > + No new tests added in this patch, but this patch fixes two existing tests that fail. > + LayoutTests/css3/filters/filter-repaint-shadow-clipped.html > + LayoutTests/css3/filters/filter-repaint-shadow-rotated.html Do these tests need to be unskipped or given new pixel results? 602589 3 137184 gyuyoung.kim 2012-04-13 19:50:09 -0700 Comment on attachment 137184 Patch V1 Attachment 137184 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/12406117 602616 4 137184 gustavo 2012-04-13 20:45:06 -0700 Comment on attachment 137184 Patch V1 Attachment 137184 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12408037 602631 5 137184 gustavo.noronha 2012-04-13 23:07:36 -0700 Comment on attachment 137184 Patch V1 Attachment 137184 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/12408069 604500 6 achicu 2012-04-17 17:10:54 -0700 I need to also update the #else branch. I will do that before committing. 604822 7 achicu 2012-04-18 09:36:50 -0700 (In reply to comment #2) > (From update of attachment 137184 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137184&action=review > > > Source/WebCore/ChangeLog:14 > > + No new tests added in this patch, but this patch fixes two existing tests that fail. > > + LayoutTests/css3/filters/filter-repaint-shadow-clipped.html > > + LayoutTests/css3/filters/filter-repaint-shadow-rotated.html > > Do these tests need to be unskipped or given new pixel results? The results seem to be up-to-date and no failure in Skipped tests were added. 604823 8 achicu 2012-04-18 09:37:04 -0700 Landed in http://trac.webkit.org/changeset/114518 . 137184 2012-04-13 17:29:59 -0700 2012-04-13 23:07:36 -0700 Patch V1 bug83960.patch text/plain 6064 achicu ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBkMzk3MzA5Li43Y2NhYWI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTItMDQtMTMgIEFsZXhhbmRydSBDaGljdWxpdGEgIDxhY2hpY3VAYWRvYmUuY29tPgor CisgICAgICAgIFtDU1MgRmlsdGVyc10gRG8gbm90IHVzZSBjbGlwcGluZyByZWN0IHdoZW4gY2Fs Y3VsYXRpbmcgdGhlIGJvdW5kcyBvZiBhIGxheWVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mzk2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGhlIGxvY2FsIGNsaXAgcmVjdCBzaG91bGQg bm90IGJlIHVzZWQgd2hlbiBjYWxjdWxhdGluZyB0aGUgYm91bmRzIG9mIGEgZmlsdGVyIGFyZWEu IE90aGVyd2lzZQorICAgICAgICBkcm9wLXNoYWRvdyBtaWdodCBub3Qga25vdyBhYm91dCB0aGUg cGl4ZWxzIG91dHNpZGUgdGhlIGNsaXBwaW5nIHJlY3RhbmdsZSwgZXZlbiB0aG91Z2ggdGhlIGFj dHVhbCBzaGFkb3cgbWlnaHQKKyAgICAgICAgYmUgaW5zaWRlIGl0LgorCisgICAgICAgIE5vIG5l dyB0ZXN0cyBhZGRlZCBpbiB0aGlzIHBhdGNoLCBidXQgdGhpcyBwYXRjaCBmaXhlcyB0d28gZXhp c3RpbmcgdGVzdHMgdGhhdCBmYWlsLgorICAgICAgICBMYXlvdXRUZXN0cy9jc3MzL2ZpbHRlcnMv ZmlsdGVyLXJlcGFpbnQtc2hhZG93LWNsaXBwZWQuaHRtbAorICAgICAgICBMYXlvdXRUZXN0cy9j c3MzL2ZpbHRlcnMvZmlsdGVyLXJlcGFpbnQtc2hhZG93LXJvdGF0ZWQuaHRtbAorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxh eWVyOjpwYWludExheWVyQ29udGVudHMpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6 OmNhbGN1bGF0ZUxheWVyQm91bmRzKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXIu aDoKKwogMjAxMi0wNC0xMyAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAg ICAgICBWaWRlbyBhdCBhcHBsZS5jb20gZ2V0cyBzdGFuZGFyZCBjb250cm9scyBpbiBhZGRpdGlv biB0byBjdXN0b20gY29udHJvbHMgYWZ0ZXIgcmV0dXJuaW5nIGZyb20gZnVsbCBzY3JlZW4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCmluZGV4IDc3YjcwMTEuLmUzNDUw MTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcApAQCAtMjk3Niw3 ICsyOTc2LDcgQEAgdm9pZCBSZW5kZXJMYXllcjo6cGFpbnRMYXllckNvbnRlbnRzKFJlbmRlckxh eWVyKiByb290TGF5ZXIsIEdyYXBoaWNzQ29udGV4dCogY28KICAgICAgICAgTGF5b3V0UG9pbnQg cm9vdExheWVyT2Zmc2V0OwogICAgICAgICBjb252ZXJ0VG9MYXllckNvb3Jkcyhyb290TGF5ZXIs IHJvb3RMYXllck9mZnNldCk7CiAgICAgICAgIG1fZmlsdGVyUmVwYWludFJlY3QubW92ZShyb290 TGF5ZXJPZmZzZXQueCgpLCByb290TGF5ZXJPZmZzZXQueSgpKTsKLSAgICAgICAgTGF5b3V0UmVj dCBmaWx0ZXJQYWludERpcnR5UmVjdCA9IGZpbHRlclBhaW50ZXIucHJlcGFyZUZpbHRlckVmZmVj dCh0aGlzLCBjYWxjdWxhdGVMYXllckJvdW5kcyh0aGlzLCByb290TGF5ZXIsIGZhbHNlLCBmYWxz ZSksIHBhcmVudFBhaW50RGlydHlSZWN0LCBtX2ZpbHRlclJlcGFpbnRSZWN0KTsKKyAgICAgICAg TGF5b3V0UmVjdCBmaWx0ZXJQYWludERpcnR5UmVjdCA9IGZpbHRlclBhaW50ZXIucHJlcGFyZUZp bHRlckVmZmVjdCh0aGlzLCBjYWxjdWxhdGVMYXllckJvdW5kcyh0aGlzLCByb290TGF5ZXIsIDAp LCBwYXJlbnRQYWludERpcnR5UmVjdCwgbV9maWx0ZXJSZXBhaW50UmVjdCk7CiAgICAgICAgIG1f ZmlsdGVyUmVwYWludFJlY3QgPSBJbnRSZWN0KCk7CiAgICAgICAgIC8vIFJld2lyZSB0aGUgb2xk IGNvbnRleHQgdG8gYSBtZW1vcnkgYnVmZmVyLCBzbyB0aGF0IHdlIGNhbiBjYXB0dXJlIHRoZSBj b250ZW50cyBvZiB0aGUgbGF5ZXIuCiAgICAgICAgIC8vIE5PVEU6IFdlIHNhdmVkIHRoZSBvbGQg Y29udGV4dCBpbiB0aGUgInRyYW5zcGFyZW5jeUxheWVyQ29udGV4dCIgbG9jYWwgdmFyaWFibGUs IHRvIGJlIGFibGUgdG8gc3RhcnQgYSB0cmFuc3BhcmVuY3kgbGF5ZXIKQEAgLTQwOTMsNyArNDA5 Myw3IEBAIEludFJlY3QgUmVuZGVyTGF5ZXI6OmFic29sdXRlQm91bmRpbmdCb3goKSBjb25zdAog ICAgIHJldHVybiBwaXhlbFNuYXBwZWRJbnRSZWN0KGJvdW5kaW5nQm94KHJvb3QoKSkpOwogfQog Ci1JbnRSZWN0IFJlbmRlckxheWVyOjpjYWxjdWxhdGVMYXllckJvdW5kcyhjb25zdCBSZW5kZXJM YXllciogbGF5ZXIsIGNvbnN0IFJlbmRlckxheWVyKiBhbmNlc3RvckxheWVyLCBib29sIGluY2x1 ZGVTZWxmVHJhbnNmb3JtLCBib29sIGluY2x1ZGVMYXllckZpbHRlck91dHNldHMpCitJbnRSZWN0 IFJlbmRlckxheWVyOjpjYWxjdWxhdGVMYXllckJvdW5kcyhjb25zdCBSZW5kZXJMYXllciogbGF5 ZXIsIGNvbnN0IFJlbmRlckxheWVyKiBhbmNlc3RvckxheWVyLCBDYWxjdWxhdGVMYXllckJvdW5k c0ZsYWdzIGZsYWdzKQogewogICAgIGlmICghbGF5ZXItPmlzU2VsZlBhaW50aW5nTGF5ZXIoKSkK ICAgICAgICAgcmV0dXJuIEludFJlY3QoKTsKQEAgLTQxMTQsMTIgKzQxMTQsMTQgQEAgSW50UmVj dCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZHMoY29uc3QgUmVuZGVyTGF5ZXIqIGxh eWVyLCBjb25zdCBSZW5kZXIKIAogICAgIExheW91dFJlY3QgdW5pb25Cb3VuZHMgPSBib3VuZGlu Z0JveFJlY3Q7CiAKLSAgICBMYXlvdXRSZWN0IGxvY2FsQ2xpcFJlY3QgPSBsYXllci0+bG9jYWxD bGlwUmVjdCgpOwotICAgIGlmIChsb2NhbENsaXBSZWN0ICE9IFBhaW50SW5mbzo6aW5maW5pdGVS ZWN0KCkpIHsKLSAgICAgICAgTGF5b3V0UG9pbnQgYW5jZXN0b3JSZWxPZmZzZXQ7Ci0gICAgICAg IGxheWVyLT5jb252ZXJ0VG9MYXllckNvb3JkcyhhbmNlc3RvckxheWVyLCBhbmNlc3RvclJlbE9m ZnNldCk7Ci0gICAgICAgIGxvY2FsQ2xpcFJlY3QubW92ZUJ5KGFuY2VzdG9yUmVsT2Zmc2V0KTsK LSAgICAgICAgcmV0dXJuIHBpeGVsU25hcHBlZEludFJlY3QobG9jYWxDbGlwUmVjdCk7CisgICAg aWYgKGZsYWdzICYgVXNlTG9jYWxDbGlwUmVjdElmUG9zc2libGUpIHsKKyAgICAgICAgTGF5b3V0 UmVjdCBsb2NhbENsaXBSZWN0ID0gbGF5ZXItPmxvY2FsQ2xpcFJlY3QoKTsKKyAgICAgICAgaWYg KGxvY2FsQ2xpcFJlY3QgIT0gUGFpbnRJbmZvOjppbmZpbml0ZVJlY3QoKSkgeworICAgICAgICAg ICAgTGF5b3V0UG9pbnQgYW5jZXN0b3JSZWxPZmZzZXQ7CisgICAgICAgICAgICBsYXllci0+Y29u dmVydFRvTGF5ZXJDb29yZHMoYW5jZXN0b3JMYXllciwgYW5jZXN0b3JSZWxPZmZzZXQpOworICAg ICAgICAgICAgbG9jYWxDbGlwUmVjdC5tb3ZlQnkoYW5jZXN0b3JSZWxPZmZzZXQpOworICAgICAg ICAgICAgcmV0dXJuIHBpeGVsU25hcHBlZEludFJlY3QobG9jYWxDbGlwUmVjdCk7CisgICAgICAg IH0KICAgICB9CiAKICAgICBpZiAoUmVuZGVyTGF5ZXIqIHJlZmxlY3Rpb24gPSBsYXllci0+cmVm bGVjdGlvbkxheWVyKCkpIHsKQEAgLTQxNzIsNyArNDE3NCw3IEBAIEludFJlY3QgUmVuZGVyTGF5 ZXI6OmNhbGN1bGF0ZUxheWVyQm91bmRzKGNvbnN0IFJlbmRlckxheWVyKiBsYXllciwgY29uc3Qg UmVuZGVyCiAgICAgLy8gRklYTUU6IFdlIGNhbiBvcHRpbWl6ZSB0aGUgc2l6ZSBvZiB0aGUgY29t cG9zaXRlZCBsYXllcnMsIGJ5IG5vdCBlbmxhcmdpbmcKICAgICAvLyBmaWx0ZXJlZCBhcmVhcyB3 aXRoIHRoZSBvdXRzZXRzIGlmIHdlIGtub3cgdGhhdCB0aGUgZmlsdGVyIGlzIGdvaW5nIHRvIHJl bmRlciBpbiBoYXJkd2FyZS4KICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9ODEyMzkKLSAgICBpZiAoaW5jbHVkZUxheWVyRmlsdGVyT3V0c2V0cyAmJiBsYXll ci0+cmVuZGVyZXIoKS0+c3R5bGUoKS0+aGFzRmlsdGVyT3V0c2V0cygpKSB7CisgICAgaWYgKChm bGFncyAmIEluY2x1ZGVMYXllckZpbHRlck91dHNldHMpICYmIGxheWVyLT5yZW5kZXJlcigpLT5z dHlsZSgpLT5oYXNGaWx0ZXJPdXRzZXRzKCkpIHsKICAgICAgICAgaW50IHRvcE91dHNldDsKICAg ICAgICAgaW50IHJpZ2h0T3V0c2V0OwogICAgICAgICBpbnQgYm90dG9tT3V0c2V0OwpAQCAtNDE4 NSw3ICs0MTg3LDcgQEAgSW50UmVjdCBSZW5kZXJMYXllcjo6Y2FsY3VsYXRlTGF5ZXJCb3VuZHMo Y29uc3QgUmVuZGVyTGF5ZXIqIGxheWVyLCBjb25zdCBSZW5kZXIKICAgICBVTlVTRURfUEFSQU0o aW5jbHVkZUxheWVyRmlsdGVyT3V0c2V0cyk7CiAjZW5kaWYKIAotICAgIGlmIChpbmNsdWRlU2Vs ZlRyYW5zZm9ybSAmJiBsYXllci0+cGFpbnRzV2l0aFRyYW5zZm9ybShQYWludEJlaGF2aW9yTm9y bWFsKSkgeworICAgIGlmICgoZmxhZ3MgJiBJbmNsdWRlU2VsZlRyYW5zZm9ybSkgJiYgbGF5ZXIt PnBhaW50c1dpdGhUcmFuc2Zvcm0oUGFpbnRCZWhhdmlvck5vcm1hbCkpIHsKICAgICAgICAgVHJh bnNmb3JtYXRpb25NYXRyaXgqIGFmZmluZVRyYW5zID0gbGF5ZXItPnRyYW5zZm9ybSgpOwogICAg ICAgICBib3VuZGluZ0JveFJlY3QgPSBhZmZpbmVUcmFucy0+bWFwUmVjdChib3VuZGluZ0JveFJl Y3QpOwogICAgICAgICB1bmlvbkJvdW5kcyA9IGFmZmluZVRyYW5zLT5tYXBSZWN0KHVuaW9uQm91 bmRzKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5o IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKaW5kZXggOTBiMDExYS4u Yzk0YmQyNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmgKQEAgLTQ4OCw3 ICs0ODgsMTQgQEAgcHVibGljOgogICAgIC8vIFBpeGVsIHNuYXBwZWQgYm91bmRpbmcgYm94IHJl bGF0aXZlIHRvIHRoZSByb290LgogICAgIEludFJlY3QgYWJzb2x1dGVCb3VuZGluZ0JveCgpIGNv bnN0OwogCi0gICAgc3RhdGljIEludFJlY3QgY2FsY3VsYXRlTGF5ZXJCb3VuZHMoY29uc3QgUmVu ZGVyTGF5ZXIqLCBjb25zdCBSZW5kZXJMYXllciogYW5jZXN0b3JMYXllciwgYm9vbCBpbmNsdWRl U2VsZlRyYW5zZm9ybSA9IHRydWUsIGJvb2wgaW5jbHVkZUxheWVyRmlsdGVyT3V0c2V0cyA9IHRy dWUpOworICAgIGVudW0gQ2FsY3VsYXRlTGF5ZXJCb3VuZHNGbGFnIHsKKyAgICAgICAgSW5jbHVk ZVNlbGZUcmFuc2Zvcm0gPSAxIDw8IDAsCisgICAgICAgIFVzZUxvY2FsQ2xpcFJlY3RJZlBvc3Np YmxlID0gMSA8PCAxLAorICAgICAgICBJbmNsdWRlTGF5ZXJGaWx0ZXJPdXRzZXRzID0gMSA8PCAy LAorICAgICAgICBEZWZhdWx0Q2FsY3VsYXRlTGF5ZXJCb3VuZHNGbGFncyA9ICBJbmNsdWRlU2Vs ZlRyYW5zZm9ybSB8IFVzZUxvY2FsQ2xpcFJlY3RJZlBvc3NpYmxlIHwgSW5jbHVkZUxheWVyRmls dGVyT3V0c2V0cworICAgIH07CisgICAgdHlwZWRlZiB1bnNpZ25lZCBDYWxjdWxhdGVMYXllckJv dW5kc0ZsYWdzOworICAgIHN0YXRpYyBJbnRSZWN0IGNhbGN1bGF0ZUxheWVyQm91bmRzKGNvbnN0 IFJlbmRlckxheWVyKiwgY29uc3QgUmVuZGVyTGF5ZXIqIGFuY2VzdG9yTGF5ZXIsIENhbGN1bGF0 ZUxheWVyQm91bmRzRmxhZ3MgPSBEZWZhdWx0Q2FsY3VsYXRlTGF5ZXJCb3VuZHNGbGFncyk7CiAg ICAgCiAgICAgdm9pZCB1cGRhdGVIb3ZlckFjdGl2ZVN0YXRlKGNvbnN0IEhpdFRlc3RSZXF1ZXN0 JiwgSGl0VGVzdFJlc3VsdCYpOwogCg==