83925 2012-04-13 11:46:14 -0700 REGRESSION (XHR Caching): Uncacheable responses sent by Rails through Apache are cached 2012-04-13 13:58:09 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap japhet koivisto oldest_to_newest 602283 0 ap 2012-04-13 11:46:14 -0700 When using Rails with Apache, it's common to have two max-age directives (one is added by Rails, another by mod_expires): max-age=0, private, must-revalidate, max-age=60 We appear to honor the last directive instead of the first,like other browsers do. Steps to reproduce: 1. Terminal: sudo gem install sinatra 2. Download and unzip the attached archive. 3. In Terminal, cd to the archive's directory and run 'ruby app.rb' 4. In Safari, open a new window and navigate to http://localhost:4567 5. Click the button on the page and observe the output from the ruby command above. I confirmed that this test started to fail in r107672, although the root cause is really a pre-existing issue with memory cache (the same is reproducible with script elements). Nate, is this something you'd be willing to look into? <rdar://problem/11231790> 602291 1 japhet 2012-04-13 11:51:58 -0700 I'd be happy to. Fair warning though, I don't know all that much about the part of the cache that actually handles caching headers, so I may be slow to figure it out. 602367 2 ap 2012-04-13 13:36:51 -0700 Actually, this might be as easy as adjusting precedence in ResourceResponseBase::parseCacheControlDirectives(). I'll take a look. 602380 3 137141 ap 2012-04-13 13:54:32 -0700 Created attachment 137141 proposed fix 602382 4 137141 koivisto 2012-04-13 13:55:56 -0700 Comment on attachment 137141 proposed fix r=me 602383 5 ap 2012-04-13 13:58:09 -0700 Committed <http://trac.webkit.org/changeset/114165>. 137141 2012-04-13 13:54:32 -0700 2012-04-13 13:55:56 -0700 proposed fix MaxAge.txt text/plain 4257 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDE2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTEzICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKFhIUiBD YWNoaW5nKTogVW5jYWNoZWFibGUgcmVzcG9uc2VzIHNlbnQgYnkgUmFpbHMgdGhyb3VnaCBBcGFj aGUgYXJlIGNhY2hlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9ODM5MjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzExMjMxNzkwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIHN1YnRlc3RzIHRv IGh0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtZXhwaXJhdGlvbi0yLmh0bWwuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2VCYXNlOjpwYXJzZUNhY2hlQ29udHJvbERpcmVjdGl2 ZXMpOiBIb25vciBmaXJzdCBtYXgtYWdlCisgICAgICAgIGluc3RlYWQgb2YgdGhlIGxhc3QuIE5l dyBiZWhhdmlvciBtYXRjaGVzIGJvdGggRmlyZWZveCBhbmQgSUUuCisKIDIwMTItMDQtMTMgIEph bWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1d IE1vdmUgV2ViVmlkZW9GcmFtZSBpbnRvIFBsYXRmb3JtIGFuZCByZW1vdmUgV2ViQ29yZTo6Vmlk ZW9GcmFtZUNocm9taXVtIHdyYXBwZXIgQVBJCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVzcG9uc2VCYXNlLmNwcAkocmV2aXNp b24gMTE0MDUyKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl c3BvbnNlQmFzZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzOSw2ICszMzksMTAgQEAgdm9pZCBS ZXNvdXJjZVJlc3BvbnNlQmFzZTo6cGFyc2VDYWNoZUNvbgogICAgICAgICAgICAgZWxzZSBpZiAo ZXF1YWxJZ25vcmluZ0Nhc2UoZGlyZWN0aXZlc1tpXS5maXJzdCwgbXVzdFJldmFsaWRhdGVEaXJl Y3RpdmUpKQogICAgICAgICAgICAgICAgIG1fY2FjaGVDb250cm9sQ29udGFpbnNNdXN0UmV2YWxp ZGF0ZSA9IHRydWU7CiAgICAgICAgICAgICBlbHNlIGlmIChlcXVhbElnbm9yaW5nQ2FzZShkaXJl Y3RpdmVzW2ldLmZpcnN0LCBtYXhBZ2VEaXJlY3RpdmUpKSB7CisgICAgICAgICAgICAgICAgaWYg KCFpc25hbihtX2NhY2hlQ29udHJvbE1heEFnZSkpIHsKKyAgICAgICAgICAgICAgICAgICAgLy8g Rmlyc3QgbWF4LWFnZSBkaXJlY3RpdmUgd2lucyBpZiB0aGVyZSBhcmUgbXVsdGlwbGUgb25lcy4K KyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAgfQogICAgICAg ICAgICAgICAgIGJvb2wgb2s7CiAgICAgICAgICAgICAgICAgZG91YmxlIG1heEFnZSA9IGRpcmVj dGl2ZXNbaV0uc2Vjb25kLnRvRG91YmxlKCZvayk7CiAgICAgICAgICAgICAgICAgaWYgKG9rKQpJ bmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0No YW5nZUxvZwkocmV2aXNpb24gMTE0MTY0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMDQtMTMgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFu ZCBidWcgVVJMIChPT1BTISkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGh0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtZXhwaXJhdGlvbi0yLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNlLWV4cGly YXRpb24tMi5odG1sOgorCiAyMDEyLTA0LTEzICBSb2IgRmxhY2sgIDxmbGFja3JAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIENocm9taXVtOiBTaG91bGQgZW5hYmxlIC13ZWJraXQtaW1hZ2Utc2V0 CkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNlLWV4cGlyYXRp b24tMi1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9j YWNoZS9zdWJyZXNvdXJjZS1leHBpcmF0aW9uLTItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAxMTQw NTIpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2NhY2hlL3N1YnJlc291cmNlLWV4cGlyYXRp b24tMi1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTQsNiArNCw4IEBAIENhY2hlLWNv bnRyb2w6IG1heC1hZ2U9MTAsIG11c3QtcmV2YWxpZGEKIEFnZTogMTAwOyBDYWNoZS1jb250cm9s OiBtYXgtYWdlPTEwOyAocmVzdWx0PVVuY2FjaGVkIGV4cGVjdGVkPVVuY2FjaGVkKSBQQVNTCiBB Z2U6IDE7IENhY2hlLWNvbnRyb2w6IG1heC1hZ2U9MTA7IChyZXN1bHQ9Q2FjaGVkIGV4cGVjdGVk PUNhY2hlZCkgUEFTUwogQ2FjaGUtY29udHJvbDogbWF4LWFnZT0xMDsgUHJhZ21hOiBuby1jYWNo ZTsgKHJlc3VsdD1VbmNhY2hlZCBleHBlY3RlZD1VbmNhY2hlZCkgUEFTUworQ2FjaGUtY29udHJv bDogbWF4LWFnZT0wLCBwcml2YXRlLCBtdXN0LXJldmFsaWRhdGUsIG1heC1hZ2U9NjA7IChyZXN1 bHQ9VW5jYWNoZWQgZXhwZWN0ZWQ9VW5jYWNoZWQpIFBBU1MKK0NhY2hlLWNvbnRyb2w6IG1heC1h Z2U9NjAsIHByaXZhdGUsIG11c3QtcmV2YWxpZGF0ZSwgbWF4LWFnZT0wOyAocmVzdWx0PUNhY2hl ZCBleHBlY3RlZD1DYWNoZWQpIFBBU1MKIEV4cGlyZXM6IFtub3ctMTBzXTsgQ2FjaGUtY29udHJv bDogbWF4LWFnZT0xMDsgKHJlc3VsdD1DYWNoZWQgZXhwZWN0ZWQ9Q2FjaGVkKSBQQVNTCiBFeHBp cmVzOiBbbm93KzEwc107IENhY2hlLWNvbnRyb2w6IG1heC1hZ2U9MDsgKHJlc3VsdD1VbmNhY2hl ZCBleHBlY3RlZD1VbmNhY2hlZCkgUEFTUwogTGFzdC1tb2RpZmllZDogW25vdy0zNjAwc107IFtk ZWxheT0xLjVzXSAocmVzdWx0PUNhY2hlZCBleHBlY3RlZD1DYWNoZWQpIFBBU1MKSW5kZXg6IExh eW91dFRlc3RzL2h0dHAvdGVzdHMvY2FjaGUvc3VicmVzb3VyY2UtZXhwaXJhdGlvbi0yLmh0bWwK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1l eHBpcmF0aW9uLTIuaHRtbAkocmV2aXNpb24gMTE0MDUyKQorKysgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9jYWNoZS9zdWJyZXNvdXJjZS1leHBpcmF0aW9uLTIuaHRtbAkod29ya2luZyBjb3B5KQpA QCAtNDQsNiArNDQsMTggQEAgdGVzdHMgPSBbCiAgICAgfSwKICAgICB7CiAgICAgICAgIHRlc3RI ZWFkZXJzOiB7CisgICAgICAgICAgICAnQ2FjaGUtY29udHJvbCc6ICdtYXgtYWdlPTAsIHByaXZh dGUsIG11c3QtcmV2YWxpZGF0ZSwgbWF4LWFnZT02MCcsCisgICAgICAgIH0sCisgICAgICAgIGV4 cGVjdGVkUmVzdWx0OiAnVW5jYWNoZWQnLAorICAgIH0sCisgICAgeworICAgICAgICB0ZXN0SGVh ZGVyczogeworICAgICAgICAgICAgJ0NhY2hlLWNvbnRyb2wnOiAnbWF4LWFnZT02MCwgcHJpdmF0 ZSwgbXVzdC1yZXZhbGlkYXRlLCBtYXgtYWdlPTAnLAorICAgICAgICB9LAorICAgICAgICBleHBl Y3RlZFJlc3VsdDogJ0NhY2hlZCcsCisgICAgfSwKKyAgICB7CisgICAgICAgIHRlc3RIZWFkZXJz OiB7CiAgICAgICAgICAgICAnRXhwaXJlcyc6ICdbbm93LTEwc10nLAogICAgICAgICAgICAgJ0Nh Y2hlLWNvbnRyb2wnOiAnbWF4LWFnZT0xMCcKICAgICAgICAgfSwK