83920 2012-04-13 11:13:40 -0700 [chromium] There is no Color(float, float, float) constructor, fix an attempt to call it. 2012-04-13 20:07:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis webkit.review.bot oldest_to_newest 602244 0 thakis 2012-04-13 11:13:40 -0700 [chromium] There is no Color(float, float, float) constructor, fix an attempt to call it. 602248 1 137108 thakis 2012-04-13 11:14:40 -0700 Created attachment 137108 Patch 602259 2 137108 jamesr 2012-04-13 11:21:58 -0700 Comment on attachment 137108 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137108&action=review > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508 > + EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f, 1.0f))); Since you're fixing nits here, these should be (0.4, 0.4, 0.4, 1) - no "f" or ".0f" http://www.webkit.org/coding/coding-style.html#float-suffixes 602302 3 thakis 2012-04-13 12:10:42 -0700 Thanks! (In reply to comment #2) > (From update of attachment 137108 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137108&action=review > > > Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508 > > + EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f, 1.0f))); > > Since you're fixing nits here, these should be (0.4, 0.4, 0.4, 1) - no "f" or ".0f" http://www.webkit.org/coding/coding-style.html#float-suffixes That page says "unless required". It's required here: test.cc:9:3: error: call to constructor of 'Color' is ambiguous Color(0.4, 0.4, 0.4, 1.0); ^ ~~~~~~~~~~~~~~~~~~ test.cc:4:5: note: candidate constructor Color(int r, int g, int b, int a) { } ^ test.cc:5:5: note: candidate constructor Color(float r, float g, float b, float a) { } ^ 1 error generated. hummer:src thakis$ third_party/llvm-build/Release+Asserts/bin/clang -c test.cc test.cc:9:9: warning: implicit conversion turns literal floating-point number into integer: 'double' to 'int' [-Wliteral-conversion] Color(0.4, 0.4, 0.4, 1); ~~~~~ ^~~ test.cc:9:14: warning: implicit conversion turns literal floating-point number into integer: 'double' to 'int' [-Wliteral-conversion] Color(0.4, 0.4, 0.4, 1); ~~~~~ ^~~ test.cc:9:19: warning: implicit conversion turns literal floating-point number into integer: 'double' to 'int' [-Wliteral-conversion] Color(0.4, 0.4, 0.4, 1); ~~~~~ ^~~ 3 warnings generated. 602560 4 137108 webkit.review.bot 2012-04-13 17:43:26 -0700 Comment on attachment 137108 Patch Rejecting attachment 137108 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: t/webkit-commit-queue/ Parsed 2 diffs from patch file(s). patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/tests/LayerChromiumTest.cpp Hunk #1 FAILED at 505. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/chromium/tests/LayerChromiumTest.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'James Robi..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/12406079 602567 5 137190 thakis 2012-04-13 18:06:50 -0700 Created attachment 137190 Patch for landing 602600 6 137190 webkit.review.bot 2012-04-13 20:07:43 -0700 Comment on attachment 137190 Patch for landing Clearing flags on attachment: 137190 Committed r114201: <http://trac.webkit.org/changeset/114201> 602601 7 webkit.review.bot 2012-04-13 20:07:47 -0700 All reviewed patches have been landed. Closing bug. 137108 2012-04-13 11:14:40 -0700 2012-04-13 18:06:45 -0700 Patch bug-83920-20120413111439.patch text/plain 2373 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzNjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGVhZTU1ZWY2MjliNzAwNWYzNDA1N2M5ZDEyYjljY2RjOTQwYzlhNGMuLjhiZWIwYzUxNjg0ZDg2 M2NiMWViZTE2NDgxNTRhZGJlYTVmMDJlMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMTMgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gVGhlcmUgaXMgbm8gQ29sb3IoZmxvYXQsIGZsb2F0 LCBmbG9hdCkgY29uc3RydWN0b3IsIGZpeCBhbiBhdHRlbXB0IHRvIGNhbGwgaXQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzkyMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvdW5kIGJ5IGNsYW5nOgor ICAgICAgICAgIHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0xheWVyQ2hyb21pdW1UZXN0LmNwcDo1MDg6ODk6ZXJyb3I6IGltcGxpY2l0IGNvbnZlcnNpb24g dHVybnMgbGl0ZXJhbCBmbG9hdGluZy1wb2ludCBudW1iZXIgaW50byBpbnRlZ2VyOiAnZmxvYXQn IHRvICdpbnQnIFstV2Vycm9yLC1XbGl0ZXJhbC1jb252ZXJzaW9uXQorICAgICAgICAgIEVYRUNV VEVfQU5EX1ZFUklGWV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXllci0+c2V0 QmFja2dyb3VuZENvbG9yKENvbG9yKDAuNGYsIDAuNGYsIDAuNGYpKSk7CisgICAgICAgICAgfn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Xn5+fn5+fn5+fn5+fn5+fn5+fgorCisgICAgICAgICog dGVzdHMvTGF5ZXJDaHJvbWl1bVRlc3QuY3BwOgorCiAyMDEyLTA0LTA5ICBTaGVyaWZmIEJvdCAg PHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xs aW5nIG91dCByMTEzNjU2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9MYXllckNocm9taXVtVGVzdC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0xh eWVyQ2hyb21pdW1UZXN0LmNwcAppbmRleCA1ODdhMGZhMzI0NjAxOGU0NWVhNGY0MGQzMGZkZDdh MjY2ODdkYjk5Li41OTg0ZWY4YzBmMzhjZjNjNjM5YzEyYjk5MDJhZGYxZDYwNzNlZDc2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0xheWVyQ2hyb21pdW1UZXN0LmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0xheWVyQ2hyb21pdW1UZXN0LmNw cApAQCAtNTA1LDcgKzUwNSw3IEBAIFRFU1RfRihMYXllckNocm9taXVtVGVzdCwgY2hlY2tQcm9w ZXJ0eUNoYW5nZUNhdXNlc0NvcnJlY3RCZWhhdmlvcikKICAgICAvLyBBbGwgcHJvcGVydGllcyBu ZWVkIHRvIGJlIHNldCB0byBuZXcgdmFsdWVzIGluIG9yZGVyIGZvciBzZXROZWVkc0NvbW1pdCB0 byBiZSBjYWxsZWQuCiAgICAgRVhFQ1VURV9BTkRfVkVSSUZZX1NFVF9ORUVEU19DT01NSVRfQkVI QVZJT1IoMSwgdGVzdExheWVyLT5zZXRBbmNob3JQb2ludChGbG9hdFBvaW50KDEuMjNmLCA0LjU2 ZikpKTsKICAgICBFWEVDVVRFX0FORF9WRVJJRllfU0VUX05FRURTX0NPTU1JVF9CRUhBVklPUigx LCB0ZXN0TGF5ZXItPnNldEFuY2hvclBvaW50WigwLjdmKSk7Ci0gICAgRVhFQ1VURV9BTkRfVkVS SUZZX1NFVF9ORUVEU19DT01NSVRfQkVIQVZJT1IoMSwgdGVzdExheWVyLT5zZXRCYWNrZ3JvdW5k Q29sb3IoQ29sb3IoMC40ZiwgMC40ZiwgMC40ZikpKTsKKyAgICBFWEVDVVRFX0FORF9WRVJJRllf U0VUX05FRURTX0NPTU1JVF9CRUhBVklPUigxLCB0ZXN0TGF5ZXItPnNldEJhY2tncm91bmRDb2xv cihDb2xvcigwLjRmLCAwLjRmLCAwLjRmLCAxLjBmKSkpOwogICAgIEVYRUNVVEVfQU5EX1ZFUklG WV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXllci0+c2V0QmFja2dyb3VuZENv dmVyc1ZpZXdwb3J0KHRydWUpKTsKICAgICBFWEVDVVRFX0FORF9WRVJJRllfU0VUX05FRURTX0NP TU1JVF9CRUhBVklPUigxLCB0ZXN0TGF5ZXItPnNldE1hc2tzVG9Cb3VuZHModHJ1ZSkpOwogICAg IEVYRUNVVEVfQU5EX1ZFUklGWV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXll ci0+c2V0TWFza0xheWVyKGR1bW15TGF5ZXIuZ2V0KCkpKTsK 137190 2012-04-13 18:06:50 -0700 2012-04-13 20:07:43 -0700 Patch for landing bug-83920-20120413180648.patch text/plain 2378 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDZjY2JiZTJhMWY4M2Q1NmFjMGJhM2FhZTM4NGIzNTYwNTAwOTZjZmUuLjcwYjE5ZmIxOTE0YTFj MTM5NDBmZTMwNzMyZTVlNGM2Y2EzMzM1YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMDQtMTMgIE5pY28gV2ViZXIgIDx0aGFraXNAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gVGhlcmUgaXMgbm8gQ29sb3IoZmxvYXQsIGZsb2F0 LCBmbG9hdCkgY29uc3RydWN0b3IsIGZpeCBhbiBhdHRlbXB0IHRvIGNhbGwgaXQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzkyMAorCisgICAgICAg IFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgorCisgICAgICAgIEZvdW5kIGJ5IGNsYW5nOgor ICAgICAgICAgIHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0xheWVyQ2hyb21pdW1UZXN0LmNwcDo1MDg6ODk6ZXJyb3I6IGltcGxpY2l0IGNvbnZlcnNpb24g dHVybnMgbGl0ZXJhbCBmbG9hdGluZy1wb2ludCBudW1iZXIgaW50byBpbnRlZ2VyOiAnZmxvYXQn IHRvICdpbnQnIFstV2Vycm9yLC1XbGl0ZXJhbC1jb252ZXJzaW9uXQorICAgICAgICAgIEVYRUNV VEVfQU5EX1ZFUklGWV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXllci0+c2V0 QmFja2dyb3VuZENvbG9yKENvbG9yKDAuNGYsIDAuNGYsIDAuNGYpKSk7CisgICAgICAgICAgfn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+Xn5+fn5+fn5+fn5+fn5+fn5+fgorCisgICAgICAgICog dGVzdHMvTGF5ZXJDaHJvbWl1bVRlc3QuY3BwOgorCiAyMDEyLTA0LTEzICBCZXJuaGFyZCBCYXVl ciAgPGJhdWVyYkBnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gUmVtb3ZlIGZhbGxi YWNrIGNvZGUgZm9yICJNaXNzaW5nIHBsdWctaW4iIHN0cmluZy4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvTGF5ZXJDaHJvbWl1bVRlc3QuY3BwIGIvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9MYXllckNocm9taXVtVGVzdC5jcHAKaW5kZXggNDIyNmM5NWU1 MTY5NTQzYzQ5ODZlZWQwNGZhYjFlNmUyY2U4MzM1Ni4uYTkzZWFjN2ZhZTM5NDc1OWVhYTY0MTA3 ZWVlNTBhZDYxYWM5YWYxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9MYXllckNocm9taXVtVGVzdC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0 cy9MYXllckNocm9taXVtVGVzdC5jcHAKQEAgLTUwNSw3ICs1MDUsNyBAQCBURVNUX0YoTGF5ZXJD aHJvbWl1bVRlc3QsIGNoZWNrUHJvcGVydHlDaGFuZ2VDYXVzZXNDb3JyZWN0QmVoYXZpb3IpCiAg ICAgLy8gQWxsIHByb3BlcnRpZXMgbmVlZCB0byBiZSBzZXQgdG8gbmV3IHZhbHVlcyBpbiBvcmRl ciBmb3Igc2V0TmVlZHNDb21taXQgdG8gYmUgY2FsbGVkLgogICAgIEVYRUNVVEVfQU5EX1ZFUklG WV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXllci0+c2V0QW5jaG9yUG9pbnQo RmxvYXRQb2ludCgxLjIzZiwgNC41NmYpKSk7CiAgICAgRVhFQ1VURV9BTkRfVkVSSUZZX1NFVF9O RUVEU19DT01NSVRfQkVIQVZJT1IoMSwgdGVzdExheWVyLT5zZXRBbmNob3JQb2ludFooMC43Zikp OwotICAgIEVYRUNVVEVfQU5EX1ZFUklGWV9TRVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRl c3RMYXllci0+c2V0QmFja2dyb3VuZENvbG9yKENvbG9yKDAuNGYsIDAuNGYsIDAuNGYpKSk7Cisg ICAgRVhFQ1VURV9BTkRfVkVSSUZZX1NFVF9ORUVEU19DT01NSVRfQkVIQVZJT1IoMSwgdGVzdExh eWVyLT5zZXRCYWNrZ3JvdW5kQ29sb3IoQ29sb3IoMC40ZiwgMC40ZiwgMC40ZiwgMS4wZikpKTsK ICAgICBFWEVDVVRFX0FORF9WRVJJRllfU0VUX05FRURTX0NPTU1JVF9CRUhBVklPUigxLCB0ZXN0 TGF5ZXItPnNldE1hc2tzVG9Cb3VuZHModHJ1ZSkpOwogICAgIEVYRUNVVEVfQU5EX1ZFUklGWV9T RVRfTkVFRFNfQ09NTUlUX0JFSEFWSU9SKDEsIHRlc3RMYXllci0+c2V0TWFza0xheWVyKGR1bW15 TGF5ZXIuZ2V0KCkpKTsKICAgICBFWEVDVVRFX0FORF9WRVJJRllfU0VUX05FRURTX0NPTU1JVF9C RUhBVklPUigxLCB0ZXN0TGF5ZXItPnNldE9wYWNpdHkoMC41ZikpOwo=