83874 2012-04-13 03:05:24 -0700 [GTK] r114021 triggered media flakyness 2012-04-19 02:38:35 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84254 1 pnormand pnormand eric.carlson feature-media-reviews spena webkit.review.bot oldest_to_newest 601943 0 pnormand 2012-04-13 03:05:24 -0700 At least on GTK skipping: media/video-load-require-user-gesture.html media/video-play-require-user-gesture.html works around the issue but a proper solution is required. I won't have time to work on it this week though. Skipping those two for now. 601947 1 pnormand 2012-04-13 03:13:13 -0700 The flaky tests list: Unexpected flakiness: text diff mismatch (25) fast/forms/text-input-event.html = TEXT PASS media/track/track-mode.html = TEXT PASS media/video-loop.html = TEXT PASS media/video-muted.html = TEXT PASS media/video-pause-immediately.html = TEXT PASS media/video-play-empty-events.html = TEXT PASS media/video-play-pause-events.html = TEXT PASS media/video-play-pause-exception.html = TEXT PASS media/video-playbackrate.html = TEXT PASS media/video-played-collapse.html = TEXT PASS media/video-played-ranges-1.html = TEXT PASS media/video-played-reset.html = TEXT PASS media/video-preload.html = TEXT PASS media/video-reverse-play-duration.html = TEXT PASS media/video-seek-past-end-paused.html = TEXT PASS media/video-seek-past-end-playing.html = TEXT PASS media/video-set-rate-from-pause.html = TEXT PASS media/video-source-load.html = TEXT PASS media/video-src-invalid-poster.html = TEXT PASS media/video-src-none.html = TEXT PASS media/video-timeupdate-during-playback.html = TEXT PASS media/video-timeupdate-reverse-play.html = TEXT PASS media/video-transformed.html = TEXT PASS media/video-volume.html = TEXT PASS media/video-zoom-controls.html = TEXT PASS 604639 2 spena 2012-04-18 02:00:50 -0700 Running the tests with --run-singly (so each test uses its own DumpRenderTree) works fine. That reinforces the idea that the MediaPlaybackRequiresUserGesture property, set on the following tests: media/video-load-require-user-gesture.html media/video-play-require-user-gesture.html is affecting the others. 604734 3 137687 spena 2012-04-18 07:58:33 -0700 Created attachment 137687 Patch 604741 4 137687 mrobinson 2012-04-18 08:07:17 -0700 Comment on attachment 137687 Patch The API looks good to me. We just need one more GTK+ reviwer to approve the API and give the official r+. 604744 5 137687 pnormand 2012-04-18 08:12:40 -0700 Comment on attachment 137687 Patch Thanks! 604777 6 137687 webkit.review.bot 2012-04-18 08:44:33 -0700 Comment on attachment 137687 Patch Clearing flags on attachment: 137687 Committed r114506: <http://trac.webkit.org/changeset/114506> 604778 7 webkit.review.bot 2012-04-18 08:44:37 -0700 All reviewed patches have been landed. Closing bug. 604897 8 137687 eric.carlson 2012-04-18 11:04:16 -0700 Comment on attachment 137687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137687&action=review > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:430 > + "media-playback-requires-user-gesture", FALSE, This shouldn't be necessary because both tests *should* call window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false) before ending. Also, I don't believe that any of the other DRT implementations does this cleanup. Does the problem reproduce without this? 604928 9 pnormand 2012-04-18 11:31:47 -0700 Reopening because the patch was rolled out. 605157 10 pnormand 2012-04-18 15:27:55 -0700 (In reply to comment #8) > (From update of attachment 137687 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=137687&action=review > > > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:430 > > + "media-playback-requires-user-gesture", FALSE, > > This shouldn't be necessary because both tests *should* call window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false) before ending. Also, I don't believe that any of the other DRT implementations does this cleanup. > Right. > Does the problem reproduce without this? No, but I don't think it's an issue to keep this line anyway. I've been trying Simon's patch, after some investigation I think the tests are actually badly calling the InternalSettings API :) Idl file has: void setMediaPlaybackRequiresUserGesture(in boolean enabled) raises(DOMException); And the tests do: window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false); Fixing the tests fixes flakyness here. But I think we still need Simon's patch anyway, maybe in a new bugzilla entry Simon? 605167 11 137788 pnormand 2012-04-18 15:35:30 -0700 Created attachment 137788 Patch 605241 12 eric.carlson 2012-04-18 17:06:20 -0700 (In reply to comment #10) > > I've been trying Simon's patch, after some investigation I think the tests are actually badly calling the InternalSettings API :) > > Idl file has: void setMediaPlaybackRequiresUserGesture(in boolean enabled) raises(DOMException); > > And the tests do: window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false); > Oops :-( 605246 13 137788 eric.carlson 2012-04-18 17:07:23 -0700 Comment on attachment 137788 Patch Thanks for fixing my mistake! 605247 14 137788 pnormand 2012-04-18 17:12:03 -0700 Comment on attachment 137788 Patch Clearing flags on attachment: 137788 Committed r114586: <http://trac.webkit.org/changeset/114586> 605248 15 pnormand 2012-04-18 17:12:08 -0700 All reviewed patches have been landed. Closing bug. 605462 16 spena 2012-04-19 02:38:35 -0700 (In reply to comment #10) > (In reply to comment #8) > > (From update of attachment 137687 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=137687&action=review > > > > > Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:430 > > > + "media-playback-requires-user-gesture", FALSE, > > > > This shouldn't be necessary because both tests *should* call window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false) before ending. Also, I don't believe that any of the other DRT implementations does this cleanup. > > > > Right. > > > Does the problem reproduce without this? > > No, but I don't think it's an issue to keep this line anyway. When I added that line to the DumpRenderTree, I was assuming that, under some concurrency situations, some tests were run with that setting enabled. Since they passed fine when I used the --run-singly option, I though I was right. However, after Phil's findings: > I've been trying Simon's patch, after some investigation I think the tests are actually badly calling the InternalSettings API :) > > Idl file has: void setMediaPlaybackRequiresUserGesture(in boolean enabled) raises(DOMException); > > And the tests do: window.internals.settings.setMediaPlaybackRequiresUserGesture(document, false); This does seem the cause for flakyness, and not the other. > Fixing the tests fixes flakyness here. But I think we still need Simon's patch anyway, maybe in a new bugzilla entry Simon? Yes, I guess we should still provide the API to enable/disable the mediaPlaybackRequiresUserGesture setting (it is provided in other ports), but we no longer need to clean up that setting from the DumpRenderTree. I'll file a new bug for that, and attaching this patch without the DumpRenderTree part. Thanks for the investigation, and sorry for the trouble! 137687 2012-04-18 07:58:33 -0700 2012-04-18 15:35:25 -0700 Patch bug-83874-20120418165831.patch text/plain 9921 spena U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKaW5kZXggMWM5ZjUwMjEw YTFkNDhmZDAzZjExOThlYTBlYWZjN2RhYWUwM2E4Yy4uYjdiODZkZjc0NzYyZmU3ZjhmMzAyYWIx YmFjODVkZmNkNTUzZmNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ndGsvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEy LTA0LTE4ICBTaW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBy MTE0MDIxIHRyaWdnZXJlZCBtZWRpYSBmbGFreW5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzODc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB0aGUgTWVkaWFQbGF5YmFja1JlcXVpcmVzVXNl ckdlc3R1cmUgc2V0dGluZyB3YXMgYWRkZWQsIG5vIGd0aworICAgICAgICBBUEkgd2FzIGltcGxl bWVudGVkIHRvIGFjY2VzcyBpdC4KKworICAgICAgICBUaGlzIGFkZHMgYSBwcm9wZXJ0eSB0byBn dGsgV2ViS2l0IFdlYlNldHRpbmdzLCBhbmQgY29ubmVjdHMgaXQgdG8KKyAgICAgICAgV2ViS2l0 IFdlYlZpZXcsIHRodXMgYWxsb3dpbmcgY2xpZW50cyB0byBwcm9ncmFtbWF0aWNhbGx5IG1vZGlm eSBpdC4KKworICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5ncy5jcHA6CisgICAgICAg ICh3ZWJraXRfd2ViX3NldHRpbmdzX2NsYXNzX2luaXQpOgorICAgICAgICAod2Via2l0X3dlYl9z ZXR0aW5nc19zZXRfcHJvcGVydHkpOgorICAgICAgICAod2Via2l0X3dlYl9zZXR0aW5nc19nZXRf cHJvcGVydHkpOgorICAgICAgICAqIHdlYmtpdC93ZWJraXR3ZWJzZXR0aW5nc3ByaXZhdGUuaDoK KyAgICAgICAgKiB3ZWJraXQvd2Via2l0d2Vidmlldy5jcHA6CisgICAgICAgICh3ZWJraXRfd2Vi X3ZpZXdfdXBkYXRlX3NldHRpbmdzKToKKyAgICAgICAgKHdlYmtpdF93ZWJfdmlld19zZXR0aW5n c19ub3RpZnkpOgorCiAyMDEyLTA0LTA2ICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBBY2NlbGVyYXRlZCBjb21wb3NpdGluZyBpcyBicm9r ZW4gYWZ0ZXIgcmVjZW50IFRleHR1cmVNYXBwZXIgcmVvcmdhbml6YXRpb25zCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0dGluZ3MuY3BwIGIvU291cmNl L1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnNldHRpbmdzLmNwcAppbmRleCAxYTNhMjdlYjQx MGQwZmRhOGYzMzIyZWQ2YTU4OTk2MjUwYzJhNzc4Li41YjQ3ODQyMTZmZDAyNzA2MDgwNzMxMzMy NGNkZWQ2MDI4MGRiYzMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Vi a2l0d2Vic2V0dGluZ3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3 ZWJzZXR0aW5ncy5jcHAKQEAgLTEyMSw3ICsxMjEsOCBAQCBlbnVtIHsKICAgICBQUk9QX0VOQUJM RV9XRUJHTCwKICAgICBQUk9QX0VOQUJMRV9XRUJfQVVESU8sCiAgICAgUFJPUF9FTkFCTEVfQUND RUxFUkFURURfQ09NUE9TSVRJTkcsCi0gICAgUFJPUF9FTkFCTEVfU01PT1RIX1NDUk9MTElORwor ICAgIFBST1BfRU5BQkxFX1NNT09USF9TQ1JPTExJTkcsCisgICAgUFJPUF9NRURJQV9QTEFZQkFD S19SRVFVSVJFU19VU0VSX0dFU1RVUkUKIH07CiAKIC8vIENyZWF0ZSBhIGRlZmF1bHQgdXNlciBh Z2VudCBzdHJpbmcKQEAgLTk3Miw2ICs5NzMsMjQgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dlYl9z ZXR0aW5nc19jbGFzc19pbml0KFdlYktpdFdlYlNldHRpbmdzQ2xhc3MqIGtsYXNzKQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXygiV2hl dGhlciB0byBlbmFibGUgc21vb3RoIHNjcm9sbGluZyIpLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRkFMU0UsCiAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBmbGFncykpOworCisg ICAgLyoqCisgICAgKiBXZWJLaXRXZWJTZXR0aW5nczptZWRpYS1wbGF5YmFjay1yZXF1aXJlcy11 c2VyLWdlc3R1cmUKKyAgICAqCisgICAgKiBXaGV0aGVyIGFuIHVzZXIgZ2VzdHVyZSB3b3VsZCBi ZSByZXF1aXJlZCB0byBzdGFydCBtZWRpYSBwbGF5YmFjayBvciBsb2FkCisgICAgKiBtZWRpYS4g VGhpcyBpcyBvZmYgYnkgZGVmYXVsdCwgc28gbWVkaWEgcGxheWJhY2sgY291bGQgc3RhcnQKKyAg ICAqIGF1dG9tYXRpY2FsbHkuIFNldHRpbmcgaXQgb24gcmVxdWlyZXMgYSBnZXN0dXJlIGJ5IHRo ZSB1c2VyIHRvIHN0YXJ0CisgICAgKiBwbGF5YmFjaywgb3IgdG8gbG9hZCB0aGUgbWVkaWEuCisg ICAgKgorICAgICogU2luY2U6IDEuMTAuMAorICAgICovCisgICAgZ19vYmplY3RfY2xhc3NfaW5z dGFsbF9wcm9wZXJ0eShnb2JqZWN0X2NsYXNzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgUFJPUF9NRURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkUsCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnX3BhcmFtX3NwZWNfYm9vbGVhbigibWVk aWEtcGxheWJhY2stcmVxdWlyZXMtdXNlci1nZXN0dXJlIiwKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF8oIk1lZGlhIHBsYXliYWNrIHJl cXVpcmVzIHVzZXIgZ2VzdHVyZSIpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgXygiV2hldGhlciBtZWRpYSBwbGF5YmFjayByZXF1aXJl cyB1c2VyIGdlc3R1cmUiKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIEZBTFNFLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZmxhZ3MpKTsKIH0KIAogc3RhdGljIHZvaWQgd2Vi a2l0X3dlYl9zZXR0aW5nc19pbml0KFdlYktpdFdlYlNldHRpbmdzKiB3ZWJfc2V0dGluZ3MpCkBA IC0xMTUwLDYgKzExNjksOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2ViX3NldHRpbmdzX3NldF9w cm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIGNvbgogICAgIGNhc2UgUFJP UF9FTkFCTEVfU01PT1RIX1NDUk9MTElORzoKICAgICAgICAgcHJpdi0+ZW5hYmxlU21vb3RoU2Ny b2xsaW5nID0gZ192YWx1ZV9nZXRfYm9vbGVhbih2YWx1ZSk7CiAgICAgICAgIGJyZWFrOworICAg IGNhc2UgUFJPUF9NRURJQV9QTEFZQkFDS19SRVFVSVJFU19VU0VSX0dFU1RVUkU6CisgICAgICAg IHByaXYtPm1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlID0gZ192YWx1ZV9nZXRfYm9v bGVhbih2YWx1ZSk7CisgICAgICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6CiAgICAgICAgIEdfT0JK RUNUX1dBUk5fSU5WQUxJRF9QUk9QRVJUWV9JRChvYmplY3QsIHByb3BfaWQsIHBzcGVjKTsKICAg ICAgICAgYnJlYWs7CkBAIC0xMzE4LDYgKzEzNDAsOSBAQCBzdGF0aWMgdm9pZCB3ZWJraXRfd2Vi X3NldHRpbmdzX2dldF9wcm9wZXJ0eShHT2JqZWN0KiBvYmplY3QsIGd1aW50IHByb3BfaWQsIEdW YQogICAgIGNhc2UgUFJPUF9FTkFCTEVfU01PT1RIX1NDUk9MTElORzoKICAgICAgICAgZ192YWx1 ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+ZW5hYmxlU21vb3RoU2Nyb2xsaW5nKTsKICAgICAg ICAgYnJlYWs7CisgICAgY2FzZSBQUk9QX01FRElBX1BMQVlCQUNLX1JFUVVJUkVTX1VTRVJfR0VT VFVSRToKKyAgICAgICAgZ192YWx1ZV9zZXRfYm9vbGVhbih2YWx1ZSwgcHJpdi0+bWVkaWFQbGF5 YmFja1JlcXVpcmVzVXNlckdlc3R1cmUpOworICAgICAgICBicmVhazsKICAgICBkZWZhdWx0Ogog ICAgICAgICBHX09CSkVDVF9XQVJOX0lOVkFMSURfUFJPUEVSVFlfSUQob2JqZWN0LCBwcm9wX2lk LCBwc3BlYyk7CiAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsv d2Via2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdC9ndGsvd2Vi a2l0L3dlYmtpdHdlYnNldHRpbmdzcHJpdmF0ZS5oCmluZGV4IDQ1ZjgyMjM3MTAxMTYwMjNjMmI1 ODRkNDExOGUxNWYxMWZjNWUyZjQuLjcxZWI4M2M2NjFlYWMwNmYwNjg5ZjRiM2NkMDEyYjVhZjNj Y2QyNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJzZXR0 aW5nc3ByaXZhdGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vic2V0 dGluZ3Nwcml2YXRlLmgKQEAgLTgxLDYgKzgxLDcgQEAgc3RydWN0IF9XZWJLaXRXZWJTZXR0aW5n c1ByaXZhdGUgewogICAgIGdib29sZWFuIGVuYWJsZVdlYkF1ZGlvOwogICAgIGdib29sZWFuIGVu YWJsZUFjY2VsZXJhdGVkQ29tcG9zaXRpbmc7CiAgICAgZ2Jvb2xlYW4gZW5hYmxlU21vb3RoU2Ny b2xsaW5nOworICAgIGdib29sZWFuIG1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlOwog fTsKIAogV0VCS0lUX0FQSSB2b2lkIHdlYmtpdF93ZWJfc2V0dGluZ3NfYWRkX2V4dHJhX3BsdWdp bl9kaXJlY3RvcnkoV2ViS2l0V2ViVmlldyosIGNvbnN0IGdjaGFyKiBkaXJlY3RvcnkpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwIGIvU291 cmNlL1dlYktpdC9ndGsvd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwCmluZGV4IDdhZDYzZTU0ZTVi ZGY1MmQ0NzBlM2ZhY2ZmYjQzYzYyOGMzODMyNzEuLjVmMWM0YzNlYTRkNThmM2RmNTI4ZWY3ZTQx NTM1ZmVmMWIxMzEzOTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJr aXR3ZWJ2aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmll dy5jcHAKQEAgLTMzODQsNiArMzM4NCw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld191 cGRhdGVfc2V0dGluZ3MoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBjb3JlU2V0dGluZ3Mt PnNldEphdmFFbmFibGVkKHNldHRpbmdzUHJpdmF0ZS0+ZW5hYmxlSmF2YUFwcGxldCk7CiAgICAg Y29yZVNldHRpbmdzLT5zZXRIeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWQoc2V0dGluZ3NQcml2YXRl LT5lbmFibGVIeXBlcmxpbmtBdWRpdGluZyk7CiAgICAgY29yZVNldHRpbmdzLT5zZXRETlNQcmVm ZXRjaGluZ0VuYWJsZWQoc2V0dGluZ3NQcml2YXRlLT5lbmFibGVETlNQcmVmZXRjaGluZyk7Cisg ICAgY29yZVNldHRpbmdzLT5zZXRNZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZShzZXR0 aW5nc1ByaXZhdGUtPm1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKTsKIAogI2lmIEVO QUJMRShTUUxfREFUQUJBU0UpCiAgICAgQWJzdHJhY3REYXRhYmFzZTo6c2V0SXNBdmFpbGFibGUo c2V0dGluZ3NQcml2YXRlLT5lbmFibGVIVE1MNURhdGFiYXNlKTsKQEAgLTM1MjIsNiArMzUyMyw4 IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19zZXR0aW5nc19ub3RpZnkoV2ViS2l0V2Vi U2V0dGluZ3MqIHdlYlNldHRpbmdzLCBHUGFyCiAgICAgICAgIHNldHRpbmdzLT5zZXRKYXZhRW5h YmxlZChnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkpOwogICAgIGVsc2UgaWYgKG5hbWUgPT0g Z19pbnRlcm5fc3RyaW5nKCJlbmFibGUtaHlwZXJsaW5rLWF1ZGl0aW5nIikpCiAgICAgICAgIHNl dHRpbmdzLT5zZXRIeXBlcmxpbmtBdWRpdGluZ0VuYWJsZWQoZ192YWx1ZV9nZXRfYm9vbGVhbigm dmFsdWUpKTsKKyAgICBlbHNlIGlmIChuYW1lID09IGdfaW50ZXJuX3N0cmluZygibWVkaWEtcGxh eWJhY2stcmVxdWlyZXMtdXNlci1nZXN0dXJlIikpCisgICAgICAgIHNldHRpbmdzLT5zZXRNZWRp YVBsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVyZShnX3ZhbHVlX2dldF9ib29sZWFuKCZ2YWx1ZSkp OwogCiAjaWYgRU5BQkxFKFNQRUxMQ0hFQ0spCiAgICAgZWxzZSBpZiAobmFtZSA9PSBnX2ludGVy bl9zdHJpbmcoInNwZWxsLWNoZWNraW5nLWxhbmd1YWdlcyIpKSB7CmRpZmYgLS1naXQgYS9Ub29s cy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzdlZjdiZGUxZGE3OGJiMzg3ZjJj YTc1MGQ1MjQyMDhlN2FjMGUzMy4uYzgyYWUxMGZlODdjMDc0Y2MwNGQ2ZGU3ODMzMTdkZTZhZjAz OTRlZSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEyLTA0LTE4ICBTaW1vbiBQZW5hICA8c3BlbmFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSByMTE0MDIxIHRyaWdnZXJlZCBtZWRpYSBmbGFreW5lc3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzODc0CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm93IHRoYXQgdGhl cmUgaXMgZ3RrIEFQSSB0byB1cGRhdGUgdGhlCisgICAgICAgIE1lZGlhUGxheWJhY2tSZXF1aXJl c1VzZXJHZXN0dXJlIHByb3BlcnR5LCBzZXQgaXQgdG8gZmFsc2UgZnJvbSB0aGUKKyAgICAgICAg RHVtcFJlbmRlclRyZWUgdG9vbCB3aGVuIHJlc2V0dGluZyBkZWZhdWx0cyB0byBjb25zaXN0ZW50 IHZhbHVlcy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5j cHA6CisgICAgICAgIChyZXNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzKToKKwogMjAxMi0w NC0xNiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUg Q3JlYXRlV2ViS2l0QnVpbGREaXJlY3Rvcnkgc3RlcCB0byBmaXggQ2hyb21pdW0gV2luZG93cyBQ ZXJmIGJvdApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0R1bXBSZW5kZXJU cmVlLmNwcCBiL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9EdW1wUmVuZGVyVHJlZS5jcHAKaW5k ZXggODQ0NTU1ZmJiMjk4ZDAyNjNjYWQ5Nzg2NzQwZjk2MjhhYjI5MmM1Zi4uZTM0OWM2YzVkYjMz YTZkZTJiYjkzMmU3ODExZmVkMjhlM2VhYjNhZSAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRl clRyZWUvZ3RrL0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9n dGsvRHVtcFJlbmRlclRyZWUuY3BwCkBAIC00MjcsNiArNDI3LDcgQEAgc3RhdGljIHZvaWQgcmVz ZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlcygpCiAgICAgICAgICAgICAgICAgICJlbmFibGUt aHlwZXJsaW5rLWF1ZGl0aW5nIiwgRkFMU0UsCiAgICAgICAgICAgICAgICAgICJlZGl0aW5nLWJl aGF2aW9yIiwgV0VCS0lUX0VESVRJTkdfQkVIQVZJT1JfVU5JWCwKICAgICAgICAgICAgICAgICAg ImVuYWJsZS1mdWxsc2NyZWVuIiwgVFJVRSwKKyAgICAgICAgICAgICAgICAgIm1lZGlhLXBsYXli YWNrLXJlcXVpcmVzLXVzZXItZ2VzdHVyZSIsIEZBTFNFLAogICAgICAgICAgICAgICAgICBOVUxM KTsKICAgICB3ZWJraXRfd2ViX3ZpZXdfc2V0X3NldHRpbmdzKHdlYlZpZXcsIHNldHRpbmdzKTsK ICAgICB3ZWJraXRfc2V0X2NhY2hlX21vZGVsKFdFQktJVF9DQUNIRV9NT0RFTF9ET0NVTUVOVF9C Uk9XU0VSKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCAxNTk0MDI1ZjE4NDI4YjUzMjkwMzJkMGExZDEwOTU3ZWNlNjlhMzNi Li41ODM4NGRmNjlkNWUzZmVkOWY2NmM0ZWE4MTVmMWI2ZjIyZTZmMzc4IDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjQgQEAKKzIwMTItMDQtMTggIFNpbW9uIFBlbmEgIDxzcGVuYUBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtHVEtdIHIxMTQwMjEgdHJpZ2dlcmVkIG1lZGlhIGZsYWt5bmVzcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM4NzQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBtZWRpYS92aWRlby1sb2FkLXJl cXVpcmUtdXNlci1nZXN0dXJlLmh0bWwgYW5kCisgICAgICAgIG1lZGlhL3ZpZGVvLXBsYXktcmVx dWlyZS11c2VyLWdlc3R1cmUuaHRtbCB3aGVyZSBlbmFibGluZworICAgICAgICBNZWRpYVBsYXli YWNrUmVxdWlyZXNVc2VyR2VzdHVyZSB3aGVuIHJ1biwgc28gdGVzdHMgcnVubmluZworICAgICAg ICBjb25jdXJyZW50bHkgd291bGQgZmFpbCAtdGhleSB3b3VsZCBwYXNzIHdoZW4gcnVuIGluZGVw ZW5kZW50bHkuCisKKyAgICAgICAgU2luY2UgbmV3IEFQSSBpcyBhZGRlZCB0byBlbnN1cmUgRHVt cFJlbmRlclRyZWUgaXMgYWJsZSB0byByZXNldAorICAgICAgICB0aGF0IHNldHRpbmcsIGhhdmlu ZyBtZWRpYS92aWRlby1sb2FkLXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwgYW5kCisgICAgICAg IG1lZGlhL3ZpZGVvLXBsYXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbCBubyBsb25nZXIgY2F1 c2VzCisgICAgICAgIGZsYWtpbmVzcy4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay90ZXN0X2V4 cGVjdGF0aW9ucy50eHQ6IFVuc2tpcAorICAgICAgICBtZWRpYS92aWRlby1sb2FkLXJlcXVpcmUt dXNlci1nZXN0dXJlLmh0bWwgYW5kCisgICAgICAgIG1lZGlhL3ZpZGVvLXBsYXktcmVxdWlyZS11 c2VyLWdlc3R1cmUuaHRtbAorCiAyMDEyLTA0LTE3ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5 QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBVbnJldmlld2VkIGdhcmRlbmluZywgc2tpcCB0 ZXN0cyBiZWNhdXNlIEVOQUJMRShTSEFET1dfRE9NKSBpcyBkaXNhYmxlZC4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0X2V4cGVjdGF0aW9ucy50eHQgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9ndGsvdGVzdF9leHBlY3RhdGlvbnMudHh0CmluZGV4IGFmZTQyNGNlNTkz NjM1OTVjYzJiMzkyYmU0NGFmZGM0YzhkZDkwZjQuLmI3ZGMwMjhiYmI2YmExNDVjZGVkZTA5OTFj ODI3ZTFhOTk4YjVhODEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0 X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhw ZWN0YXRpb25zLnR4dApAQCAtMTU0MCwxMSArMTU0MCw2IEBAIEJVR1dLR1RLIDogZWRpdGluZy9z cGVsbGluZy9zcGVsbGluZy1tYXJrZXItZGVzY3JpcHRpb24uaHRtbCA9IEZBSUwKIEJVR1dLNjk5 MzMgOiBmYXN0L2JvcmRlcnMvaW5saW5lLW1hc2stb3ZlcmxheS1pbWFnZS1vdXRzZXQtdmVydGlj YWwtcmwuaHRtbCA9IEZBSUwKIEJVR1dLNjk5MzMgOiBmYXN0L2JvcmRlcnMvaW5saW5lLW1hc2st b3ZlcmxheS1pbWFnZS1vdXRzZXQuaHRtbCA9IEZBSUwKIAotLy8gUnVubmluZyB0aG9zZSB0d28g bWFrZSBvdGhlciBtZWRpYSB0ZXN0cyBmbGFreSwgc28gc2tpcCB1bnRpbAotLy8gcHJvcGVyIGlu dmVzdGlnYXRpb24gY2FuIGJlIG1hZGUuCi1CVUdXSzgzODc0IFNLSVAgOiBtZWRpYS92aWRlby1s b2FkLXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwgPSBGQUlMCi1CVUdXSzgzODc0IFNLSVAgOiBt ZWRpYS92aWRlby1wbGF5LXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwgPSBGQUlMCi0KIEJVR1dL ODQwMjUgOiBtZWRpYS9zb3VyY2VzLWZhbGxiYWNrLWNvZGVjcy5odG1sID0gRkFJTAogCiBCVUdX SzgzOTA2IDogaWV0ZXN0Y2VudGVyL2NzczMvZ3JpZC9ncmlkLWNvbHVtbi0wMDEuaHRtID0gSU1B R0UK 137788 2012-04-18 15:35:30 -0700 2012-04-18 17:12:03 -0700 Patch bug-83874-20120418153529.patch text/plain 3767 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0NTM2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDRhMWJkMjNmOTdkM2E2OWFhNWZh M2JiMzBjODRiNDkzNjJjMjUxYS4uOTYwMjAzNTBhOTBlM2FmNGQ0ZjY1YzBhZjdkZTlhNTFjMDA5 ZTdjYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA0LTE4ICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSByMTE0MDIxIHRyaWdnZXJl ZCBtZWRpYSBmbGFreW5lc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTgzODc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRml4LXVwIHVzZSBvZiBzZXRNZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyR2VzdHVy ZSgpIGluIHR3byBtZWRpYQorICAgICAgICB0ZXN0cy4KKworICAgICAgICAqIG1lZGlhL3ZpZGVv LWxvYWQtcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbDoKKyAgICAgICAgKiBtZWRpYS92aWRlby1w bGF5LXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL3Rl c3RfZXhwZWN0YXRpb25zLnR4dDoKKworMjAxMi0wNC0xOCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBu b3JtYW5kQGlnYWxpYS5jb20+CisKICAgICAgICAgVW5yZXZpZXdlZCwgR1RLIHRlc3RfZXhwZWN0 YXRpb25zIHVwZGF0ZS4KIAogICAgICAgICAqIHBsYXRmb3JtL2d0ay90ZXN0X2V4cGVjdGF0aW9u cy50eHQ6IFNraXAgc29tZSBmYWlsaW5nIHRlc3RzIGFuZApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sIGIvTGF5b3V0VGVz dHMvbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sCmluZGV4IGQxY2I3 NDNlZTlhZmJlN2ZlYjVjNTE4N2YxYWJkNWEwNGQwYmM4YjEuLjgxYzViOWM3OGJhZDJhZGExZjA0 ZDdlZDQ2ZTU2ZjQ4Mzg5YTdjMzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL21lZGlhL3ZpZGVv LWxvYWQtcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS92 aWRlby1sb2FkLXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwKQEAgLTcsMTIgKzcsMTIgQEAKICAg ICAgICAgICAgIHZhciB1c2VyR2VzdHVyZUluaXRpYXRlZCA9IDA7CiAKICAgICAgICAgICAgIGlm ICh3aW5kb3cuaW50ZXJuYWxzKSAKLSAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNl dHRpbmdzLnNldE1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGRvY3VtZW50LCB0cnVl KTsKKyAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNldHRpbmdzLnNldE1lZGlhUGxh eWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKHRydWUpOwogCiAgICAgICAgICAgICBmdW5jdGlvbiBm aW5pc2hUZXN0KHN1Y2Nlc3MpCiAgICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgaWYgKHdp bmRvdy5pbnRlcm5hbHMpIAotICAgICAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJuYWxzLnNl dHRpbmdzLnNldE1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGRvY3VtZW50LCBmYWxz ZSk7CisgICAgICAgICAgICAgICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0TWVk aWFQbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUoZmFsc2UpOwogCiAgICAgICAgICAgICAgICAg aWYgKHN1Y2Nlc3MpCiAgICAgICAgICAgICAgICAgICAgIGVuZFRlc3QoKTsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbCBi L0xheW91dFRlc3RzL21lZGlhL3ZpZGVvLXBsYXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbApp bmRleCBkZDNhODY4ZTQ0YjE5ZjE4YjVlODFhNjdiMTA4NjE5NzFlNDRhYmRjLi5iZWM4YjRiN2U0 YjlkMzNhNTQxOTk1YmNkMjhmZDk5NTI2YWYyZTM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9t ZWRpYS92aWRlby1wbGF5LXJlcXVpcmUtdXNlci1nZXN0dXJlLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvbWVkaWEvdmlkZW8tcGxheS1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG1sCkBAIC03LDExICs3 LDExIEBACiAgICAgICAgIDxzY3JpcHQ+CiAgICAgICAgICAgICB2YXIgdXNlckdlc3R1cmVJbml0 aWF0ZWQgPSAwOwogICAgICAgICAgICAgaWYgKHdpbmRvdy5pbnRlcm5hbHMpIAotICAgICAgICAg ICAgICAgIHdpbmRvdy5pbnRlcm5hbHMuc2V0dGluZ3Muc2V0TWVkaWFQbGF5YmFja1JlcXVpcmVz VXNlckdlc3R1cmUoZG9jdW1lbnQsIHRydWUpOworICAgICAgICAgICAgICAgIHdpbmRvdy5pbnRl cm5hbHMuc2V0dGluZ3Muc2V0TWVkaWFQbGF5YmFja1JlcXVpcmVzVXNlckdlc3R1cmUodHJ1ZSk7 CiAKICAgICAgICAgICAgIGZ1bmN0aW9uIGNsZWFuR2VzdHVyZVJlcXVpcmVtZW50KCkgewogICAg ICAgICAgICAgICAgIGlmICh3aW5kb3cuaW50ZXJuYWxzKSAKLSAgICAgICAgICAgICAgICAgICAg d2luZG93LmludGVybmFscy5zZXR0aW5ncy5zZXRNZWRpYVBsYXliYWNrUmVxdWlyZXNVc2VyR2Vz dHVyZShkb2N1bWVudCwgZmFsc2UpOworICAgICAgICAgICAgICAgICAgICB3aW5kb3cuaW50ZXJu YWxzLnNldHRpbmdzLnNldE1lZGlhUGxheWJhY2tSZXF1aXJlc1VzZXJHZXN0dXJlKGZhbHNlKTsK ICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgZnVuY3Rpb24gY2xpY2soKQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rlc3RfZXhwZWN0YXRpb25zLnR4dCBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2d0ay90ZXN0X2V4cGVjdGF0aW9ucy50eHQKaW5kZXggYTEwYjVlYTA0 MTUwNzlmZWViN2Q5NGQ1YzFkNzQxYTZmNzNmODk0OS4uMDlmZDA4ODNjMzk3NjhhMDgyNjIzNThj OGFkMjIxZmNkMTdkODEwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL3Rl c3RfZXhwZWN0YXRpb25zLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvdGVzdF9l eHBlY3RhdGlvbnMudHh0CkBAIC0xNTQ5LDExICsxNTQ5LDYgQEAgQlVHV0tHVEsgOiBlZGl0aW5n L3NwZWxsaW5nL3NwZWxsaW5nLW1hcmtlci1kZXNjcmlwdGlvbi5odG1sID0gRkFJTAogQlVHV0s2 OTkzMyA6IGZhc3QvYm9yZGVycy9pbmxpbmUtbWFzay1vdmVybGF5LWltYWdlLW91dHNldC12ZXJ0 aWNhbC1ybC5odG1sID0gRkFJTAogQlVHV0s2OTkzMyA6IGZhc3QvYm9yZGVycy9pbmxpbmUtbWFz ay1vdmVybGF5LWltYWdlLW91dHNldC5odG1sID0gRkFJTAogCi0vLyBSdW5uaW5nIHRob3NlIHR3 byBtYWtlIG90aGVyIG1lZGlhIHRlc3RzIGZsYWt5LCBzbyBza2lwIHVudGlsCi0vLyBwcm9wZXIg aW52ZXN0aWdhdGlvbiBjYW4gYmUgbWFkZS4KLUJVR1dLODM4NzQgU0tJUCA6IG1lZGlhL3ZpZGVv LWxvYWQtcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbCA9IEZBSUwKLUJVR1dLODM4NzQgU0tJUCA6 IG1lZGlhL3ZpZGVvLXBsYXktcmVxdWlyZS11c2VyLWdlc3R1cmUuaHRtbCA9IEZBSUwKLQogQlVH V0s4NDAyNSA6IG1lZGlhL3NvdXJjZXMtZmFsbGJhY2stY29kZWNzLmh0bWwgPSBGQUlMCiAKIEJV R1dLODM5MDYgOiBpZXRlc3RjZW50ZXIvY3NzMy9ncmlkL2dyaWQtY29sdW1uLTAwMS5odG0gPSBJ TUFHRQo=