83862 2012-04-12 23:12:18 -0700 [EFL] Fix wrong parameter order in function call for EWebLauncher 2012-04-16 04:20:48 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 seokju.kwon webkit-unassigned gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 601848 0 seokju.kwon 2012-04-12 23:12:18 -0700 EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key. But it doesn't work properly because of wrong parameter order in function call. 601861 1 137045 seokju.kwon 2012-04-12 23:59:30 -0700 Created attachment 137045 Patch 601929 2 137045 gyuyoung.kim 2012-04-13 02:20:57 -0700 Comment on attachment 137045 Patch LGTM. 602079 3 137045 rakuco 2012-04-13 08:23:11 -0700 Comment on attachment 137045 Patch Makes sense. 603035 4 137045 webkit.review.bot 2012-04-16 04:20:44 -0700 Comment on attachment 137045 Patch Clearing flags on attachment: 137045 Committed r114238: <http://trac.webkit.org/changeset/114238> 603036 5 webkit.review.bot 2012-04-16 04:20:48 -0700 All reviewed patches have been landed. Closing bug. 137045 2012-04-12 23:59:30 -0700 2012-04-16 04:20:43 -0700 Patch bug-83862-20120413155929.patch text/plain 1685 seokju.kwon U3VidmVyc2lvbiBSZXZpc2lvbjogMTE0MDkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGM5NmU0NmUxMmVlNzdiZGFlZTUyYmZhMTk1NDJmMjBm Y2FmZmExMS4uZDMxNmRmZmMyMGI0YzI3YjFkZDhjZTViNDQyZTkyODVkMjc5MWI4YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA0LTEzICBTZW9ranUgS3dvbiAgPHNlb2tqdS5rd29uQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdIEVXZWJMYXVjaGVyIDogRml4IHdyb25nIHBhcmFtZXRlciBvcmRlciBp biBmdW5jdGlvbiBjYWxsIGZvciBtdWx0aXBsZSB3aW5kb3dzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM4NjIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFV2ViTGF1bmNoZXIgY3JlYXRlcyBtdWx0aXBs ZSB3aW5kb3dzLCBsaWtlIG11bHRpcGxlIHRhYnMgd2hlbiBwcmVzc2luZyBGOSBrZXkuCisgICAg ICAgIEl0IGRvZXNuJ3Qgd29yayBwcm9wZXJseSBiZWNhdXNlIG9mIHdyb25nIHBhcmFtZXRlciBv cmRlciBpbiBmdW5jdGlvbiBjYWxsLgorCisgICAgICAgICogRVdlYkxhdW5jaGVyL21haW4uYzoK KwogMjAxMi0wNC0xMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAg ICBFeHRyYWN0IFBlcmZUZXN0IGNsYXNzIGZyb20gUGVyZlRlc3RSdW5uZXIKZGlmZiAtLWdpdCBh L1Rvb2xzL0VXZWJMYXVuY2hlci9tYWluLmMgYi9Ub29scy9FV2ViTGF1bmNoZXIvbWFpbi5jCmlu ZGV4IGY1NDUzZjcyMDhmZDY1MTFhNGU4OTRhMjE1ZDY3N2Y4OWZmMTgyNGIuLjhjYzIyODM3YjIz YjYxM2NkYTc2YTY1NGMwODk1OWI5NzM2NmVkZGEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0VXZWJMYXVu Y2hlci9tYWluLmMKKysrIGIvVG9vbHMvRVdlYkxhdW5jaGVyL21haW4uYwpAQCAtNTI2LDggKzUy Niw4IEBAIG9uX2tleV9kb3duKHZvaWQgKmRhdGEsIEV2YXMgKmUsIEV2YXNfT2JqZWN0ICpvYmos IHZvaWQgKmV2ZW50X2luZm8pCiAgICAgICAgIGluZm8oIkNyZWF0ZSBuZXcgd2luZG93IChGOSkg d2FzIHByZXNzZWQuXG4iKTsKICAgICAgICAgRWluYV9SZWN0YW5nbGUgZ2VvbWV0cnkgPSB7MCwg MCwgMCwgMH07CiAgICAgICAgIGJyb3dzZXJDcmVhdGUoImh0dHA6Ly93d3cuZ29vZ2xlLmNvbSIs Ci0gICAgICAgICAgICAgICAgICAgICAgIGFwcC0+dGhlbWUsIGFwcC0+dXNlckFnZW50LCBnZW9t ZXRyeSwgYXBwLT4gYmFja2luZ1N0b3JlLAotICAgICAgICAgICAgICAgICAgICAgICBOVUxMLCBh cHAtPmlzRmxhdHRlbmluZywgMCwgTlVMTCk7CisgICAgICAgICAgICAgICAgICAgICAgIGFwcC0+ dGhlbWUsIGFwcC0+dXNlckFnZW50LCBnZW9tZXRyeSwgTlVMTCwKKyAgICAgICAgICAgICAgICAg ICAgICAgYXBwLT5iYWNraW5nU3RvcmUsIGFwcC0+aXNGbGF0dGVuaW5nLCAwLCBOVUxMKTsKICAg ICB9IGVsc2UgaWYgKCFzdHJjbXAoZXYtPmtleSwgImciKSAmJiBjdHJsUHJlc3NlZCApIHsKICAg ICAgICAgRXZhc19Db29yZCB4LCB5LCB3LCBoOwogICAgICAgICBFdmFzX09iamVjdCAqZnJhbWUg PSBld2tfdmlld19mcmFtZV9tYWluX2dldChvYmopOwo=