83841 2012-04-12 18:14:59 -0700 replaceUsingStringSearch: delay the creation of the replace string until needed 2012-04-18 10:08:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin barraclough ggaren oldest_to_newest 601699 0 benjamin 2012-04-12 18:14:59 -0700 To avoid a couple of instructions when there is no match. 601716 1 137016 benjamin 2012-04-12 18:26:48 -0700 Created attachment 137016 Patch 604762 2 137016 ggaren 2012-04-18 08:26:07 -0700 Comment on attachment 137016 Patch r=me 604850 3 benjamin 2012-04-18 10:08:51 -0700 Committed r114521: <http://trac.webkit.org/changeset/114521> 137016 2012-04-12 18:26:48 -0700 2012-04-18 08:26:07 -0700 Patch bug-83841-20120412182647.patch text/plain 3687 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MTE3ZDg5NTVkMTUzY2VmZTQ4NGMxMTk0NDU4NTAzZDU3ZmM2MzlhLi5iOTI3ZGI3ZDU3MTc0MDBj NGM2NzYxNjM4ZTI3YjM0YWM3NzdiMjJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxMi0wNC0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICByZXBsYWNlVXNpbmdTdHJpbmdTZWFyY2g6IGRlbGF5IHRoZSBjcmVh dGlvbiBvZiB0aGUgcmVwbGFjZSBzdHJpbmcgdW50aWwgbmVlZGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04Mzg0MQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRvIG5vdCBuZWVkIHRvIG9idGFpbiB0 aGUgcmVwbGFjZVZhbHVlIHVudGlsIHdlIGhhdmUgYSBtYXRjaC4gQnkgbW92aW5nIHRoZSBpbnRp YWxpemF0aW9uCisgICAgICAgIG9mIHJlcGxhY2VWYWx1ZSB3aGVuIG5lZWRlZCwgd2Ugc2F2ZSBh IGZldyBpbnN0cnVjdGlvbnMgd2hlbiB0aGVyZSBpcyBubyBtYXRjaC4KKworICAgICAgICAqIHJ1 bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6cmVwbGFjZVVzaW5nUmVn RXhwU2VhcmNoKToKKyAgICAgICAgKEpTQzo6cmVwbGFjZVVzaW5nU3RyaW5nU2VhcmNoKToKKyAg ICAgICAgKEpTQzo6c3RyaW5nUHJvdG9GdW5jUmVwbGFjZSk6CisKIDIwMTItMDQtMTEgIEJlbmph bWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wcm92ZSByZXBs YWNlVXNpbmdTdHJpbmdTZWFyY2goKSBmb3IgY2FzZSBvZiBhIHNpbmdsZSBjaGFyYWN0ZXIgc2Vh cmNoVmFsdWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmlu Z1Byb3RvdHlwZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQcm90 b3R5cGUuY3BwCmluZGV4IGYxMWU2NDFjYWE1OTdhMTNhNmM2ZDlmYWUwYjFjOTU0NjEyOGRiNzku LjExOWEwMjE1NzA5YjgxMmJhZTk2NDQ3YTRkNTI5YjM0ZDI1NDIzZDggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlwZS5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcApAQCAtNDQxLDgg KzQ0MSw5IEBAIHN0YXRpYyBORVZFUl9JTkxJTkUgRW5jb2RlZEpTVmFsdWUgcmVtb3ZlVXNpbmdS ZWdFeHBTZWFyY2goRXhlY1N0YXRlKiBleGVjLCBKU1N0CiAgICAgcmV0dXJuIEpTVmFsdWU6OmVu Y29kZShqc1NwbGljZVN1YnN0cmluZ3MoZXhlYywgc3RyaW5nLCBzb3VyY2UsIHNvdXJjZVJhbmdl cy5kYXRhKCksIHNvdXJjZVJhbmdlcy5zaXplKCkpKTsKIH0KIAotc3RhdGljIE5FVkVSX0lOTElO RSBFbmNvZGVkSlNWYWx1ZSByZXBsYWNlVXNpbmdSZWdFeHBTZWFyY2goRXhlY1N0YXRlKiBleGVj LCBKU1N0cmluZyogc3RyaW5nLCBKU1ZhbHVlIHNlYXJjaFZhbHVlLCBKU1ZhbHVlIHJlcGxhY2VW YWx1ZSkKK3N0YXRpYyBORVZFUl9JTkxJTkUgRW5jb2RlZEpTVmFsdWUgcmVwbGFjZVVzaW5nUmVn RXhwU2VhcmNoKEV4ZWNTdGF0ZSogZXhlYywgSlNTdHJpbmcqIHN0cmluZywgSlNWYWx1ZSBzZWFy Y2hWYWx1ZSkKIHsKKyAgICBKU1ZhbHVlIHJlcGxhY2VWYWx1ZSA9IGV4ZWMtPmFyZ3VtZW50KDEp OwogICAgIFVTdHJpbmcgcmVwbGFjZW1lbnRTdHJpbmc7CiAgICAgQ2FsbERhdGEgY2FsbERhdGE7 CiAgICAgQ2FsbFR5cGUgY2FsbFR5cGUgPSBnZXRDYWxsRGF0YShyZXBsYWNlVmFsdWUsIGNhbGxE YXRhKTsKQEAgLTYyNSw3ICs2MjYsNyBAQCBzdGF0aWMgTkVWRVJfSU5MSU5FIEVuY29kZWRKU1Zh bHVlIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaChFeGVjU3RhdGUqIGV4ZWMsIEpTUwogICAgIHJl dHVybiBKU1ZhbHVlOjplbmNvZGUoanNTcGxpY2VTdWJzdHJpbmdzV2l0aFNlcGFyYXRvcnMoZXhl Yywgc3RyaW5nLCBzb3VyY2UsIHNvdXJjZVJhbmdlcy5kYXRhKCksIHNvdXJjZVJhbmdlcy5zaXpl KCksIHJlcGxhY2VtZW50cy5kYXRhKCksIHJlcGxhY2VtZW50cy5zaXplKCkpKTsKIH0KIAotc3Rh dGljIGlubGluZSBFbmNvZGVkSlNWYWx1ZSByZXBsYWNlVXNpbmdTdHJpbmdTZWFyY2goRXhlY1N0 YXRlKiBleGVjLCBKU1N0cmluZyoganNTdHJpbmcsIEpTVmFsdWUgc2VhcmNoVmFsdWUsIEpTVmFs dWUgcmVwbGFjZVZhbHVlKQorc3RhdGljIGlubGluZSBFbmNvZGVkSlNWYWx1ZSByZXBsYWNlVXNp bmdTdHJpbmdTZWFyY2goRXhlY1N0YXRlKiBleGVjLCBKU1N0cmluZyoganNTdHJpbmcsIEpTVmFs dWUgc2VhcmNoVmFsdWUpCiB7CiAgICAgY29uc3QgVVN0cmluZyYgc3RyaW5nID0ganNTdHJpbmct PnZhbHVlKGV4ZWMpOwogICAgIFVTdHJpbmcgc2VhcmNoU3RyaW5nID0gc2VhcmNoVmFsdWUudG9V U3RyaW5nKGV4ZWMpOwpAQCAtNjUwLDYgKzY1MSw3IEBAIHN0YXRpYyBpbmxpbmUgRW5jb2RlZEpT VmFsdWUgcmVwbGFjZVVzaW5nU3RyaW5nU2VhcmNoKEV4ZWNTdGF0ZSogZXhlYywgSlNTdHJpbmcq CiAgICAgaWYgKG1hdGNoU3RhcnQgPT0gbm90Rm91bmQpCiAgICAgICAgIHJldHVybiBKU1ZhbHVl OjplbmNvZGUoanNTdHJpbmcpOwogCisgICAgSlNWYWx1ZSByZXBsYWNlVmFsdWUgPSBleGVjLT5h cmd1bWVudCgxKTsKICAgICBDYWxsRGF0YSBjYWxsRGF0YTsKICAgICBDYWxsVHlwZSBjYWxsVHlw ZSA9IGdldENhbGxEYXRhKHJlcGxhY2VWYWx1ZSwgY2FsbERhdGEpOwogICAgIGlmIChjYWxsVHlw ZSAhPSBDYWxsVHlwZU5vbmUpIHsKQEAgLTY4NSwxMSArNjg3LDEwIEBAIEVuY29kZWRKU1ZhbHVl IEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG9GdW5jUmVwbGFjZShFeGVjU3RhdGUqIGV4ZWMpCiAg ICAgICAgIHJldHVybiB0aHJvd1ZNVHlwZUVycm9yKGV4ZWMpOwogICAgIEpTU3RyaW5nKiBzdHJp bmcgPSB0aGlzVmFsdWUudG9TdHJpbmcoZXhlYyk7CiAgICAgSlNWYWx1ZSBzZWFyY2hWYWx1ZSA9 IGV4ZWMtPmFyZ3VtZW50KDApOwotICAgIEpTVmFsdWUgcmVwbGFjZVZhbHVlID0gZXhlYy0+YXJn dW1lbnQoMSk7CiAKICAgICBpZiAoc2VhcmNoVmFsdWUuaW5oZXJpdHMoJlJlZ0V4cE9iamVjdDo6 c19pbmZvKSkKLSAgICAgICAgcmV0dXJuIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaChleGVjLCBz dHJpbmcsIHNlYXJjaFZhbHVlLCByZXBsYWNlVmFsdWUpOwotICAgIHJldHVybiByZXBsYWNlVXNp bmdTdHJpbmdTZWFyY2goZXhlYywgc3RyaW5nLCBzZWFyY2hWYWx1ZSwgcmVwbGFjZVZhbHVlKTsK KyAgICAgICAgcmV0dXJuIHJlcGxhY2VVc2luZ1JlZ0V4cFNlYXJjaChleGVjLCBzdHJpbmcsIHNl YXJjaFZhbHVlKTsKKyAgICByZXR1cm4gcmVwbGFjZVVzaW5nU3RyaW5nU2VhcmNoKGV4ZWMsIHN0 cmluZywgc2VhcmNoVmFsdWUpOwogfQogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIHN0 cmluZ1Byb3RvRnVuY1RvU3RyaW5nKEV4ZWNTdGF0ZSogZXhlYykK