83837 2012-04-12 17:51:08 -0700 [chromium][refactoring] merge CCSingleThreadProxy::{commitIfNeeded,doComposite} into commitAndComposite() 2012-04-12 20:01:33 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 caseq caseq cc-bugs enne jamesr nduca webkit.review.bot oldest_to_newest 601669 0 caseq 2012-04-12 17:51:08 -0700 Both call sites of commitIfNeeded() used to call doComposite() immediately in case commitIfNeeded() returned true. Having these two merged into a single method will keep things slightly more compact and will simplify instrumentation of the code -- we'd like to report them together to the instrumentation layer. 601674 1 137003 caseq 2012-04-12 17:56:13 -0700 Created attachment 137003 Patch 601677 2 137003 jamesr 2012-04-12 17:59:45 -0700 Comment on attachment 137003 Patch Ooh, that is nice. R=me 601692 3 caseq 2012-04-12 18:08:38 -0700 Committed r114063: <http://trac.webkit.org/changeset/114063> 601784 4 nduca 2012-04-12 20:01:33 -0700 Coolies. Nice one. 137003 2012-04-12 17:56:13 -0700 2012-04-12 17:59:45 -0700 Patch bug-83837-20120412175612.patch text/plain 3329 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTEzOTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk5NTYxYzQwNjZjYjc5 MGQzZTY3ZDY5NGEzNWZjYzI3M2MyMDNlMy4uZWQ3OWI3YjJlNGM4NTBlYTZiMzc4YmI0OTUxOWFj MWFlZmUyOTU2OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA0LTEyICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXVty ZWZhY3RvcmluZ10gbWVyZ2UgQ0NTaW5nbGVUaHJlYWRQcm94eTo6e2NvbW1pdElmTmVlZGVkLGRv Q29tcG9zaXRlfSBpbnRvIGNvbW1pdEFuZENvbXBvc2l0ZSgpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04MzgzNworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gbWVyZ2UgQ0NTaW5nbGVUaHJlYWRQcm94eTo6 Y29tbWl0SWZOZWVkZWQoKSBhbmQgQ0NTaW5nbGVUaHJlYWRQcm94eTo6ZG9Db21wb3NpdGUoKSBp bnRvIGNvbW1pdEFuZENvbXBvc2l0ZSgpCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkND U2luZ2xlVGhyZWFkUHJveHk6OmNvbXBvc2l0ZUFuZFJlYWRiYWNrKTogY2FsbCBzaXRlIHVwZGF0 ZWQuCisgICAgICAgIChXZWJDb3JlOjpDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21wb3NpdGVJbW1l ZGlhdGVseSk6IGRpdHRvLgorICAgICAgICAoV2ViQ29yZTo6Q0NTaW5nbGVUaHJlYWRQcm94eTo6 Y29tbWl0QW5kQ29tcG9zaXRlKToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1 bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5Lmg6CisKIDIwMTItMDQtMTEgIEFuZHJleSBLb3N5YWtv diAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBzaG93IHdh bGwgdGltZSBmcmFtZSBkdXJhdGlvbiBvbiB0aGUgdmVydGljYWwgb3ZlcnZpZXcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDU2luZ2xl VGhyZWFkUHJveHkuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5jcHAKaW5kZXggOTIyM2M1ZjZiMDBkMWVkZDFlYTYz NDYwYzlmMDk5OWE0ZGZkYmQwOS4uM2U1M2VmZTZiOTAxM2FlZTAzMTgxNTZmMGU3MTAwNGNmY2U4 MTJlYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJlYWRQcm94eS5jcHAKQEAgLTcyLDEw ICs3Miw3IEBAIGJvb2wgQ0NTaW5nbGVUaHJlYWRQcm94eTo6Y29tcG9zaXRlQW5kUmVhZGJhY2so dm9pZCAqcGl4ZWxzLCBjb25zdCBJbnRSZWN0JiByZWN0CiAgICAgVFJBQ0VfRVZFTlQoIkNDU2lu Z2xlVGhyZWFkUHJveHk6OmNvbXBvc2l0ZUFuZFJlYWRiYWNrIiwgdGhpcywgMCk7CiAgICAgQVNT RVJUKENDUHJveHk6OmlzTWFpblRocmVhZCgpKTsKIAotICAgIGlmICghY29tbWl0SWZOZWVkZWQo KSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCi0gICAgaWYgKCFkb0NvbXBvc2l0ZSgpKQorICAg IGlmICghY29tbWl0QW5kQ29tcG9zaXRlKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAg IG1fbGF5ZXJUcmVlSG9zdEltcGwtPnJlYWRiYWNrKHBpeGVscywgcmVjdCk7CkBAIC0yNzIsMTYg KzI2OSwxMyBAQCB2b2lkIENDU2luZ2xlVGhyZWFkUHJveHk6OnBvc3RBbmltYXRpb25FdmVudHNU b01haW5UaHJlYWRPbkltcGxUaHJlYWQoUGFzc093blB0cgogLy8gQ2FsbGVkIGJ5IHRoZSBsZWdh Y3kgc2NoZWR1bGluZyBwYXRoIChlLmcuIHdoZXJlIHJlbmRlcl93aWRnZXQgZG9lcyB0aGUgc2No ZWR1bGluZykKIHZvaWQgQ0NTaW5nbGVUaHJlYWRQcm94eTo6Y29tcG9zaXRlSW1tZWRpYXRlbHko KQogewotICAgIGlmICghY29tbWl0SWZOZWVkZWQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAg aWYgKGRvQ29tcG9zaXRlKCkpIHsKKyAgICBpZiAoY29tbWl0QW5kQ29tcG9zaXRlKCkpIHsKICAg ICAgICAgbV9sYXllclRyZWVIb3N0SW1wbC0+c3dhcEJ1ZmZlcnMoKTsKICAgICAgICAgZGlkU3dh cEZyYW1lKCk7CiAgICAgfQogfQogCi1ib29sIENDU2luZ2xlVGhyZWFkUHJveHk6OmNvbW1pdElm TmVlZGVkKCkKK2Jvb2wgQ0NTaW5nbGVUaHJlYWRQcm94eTo6Y29tbWl0QW5kQ29tcG9zaXRlKCkK IHsKICAgICBBU1NFUlQoQ0NQcm94eTo6aXNNYWluVGhyZWFkKCkpOwogCkBAIC0yOTEsNyArMjg1 LDcgQEAgYm9vbCBDQ1NpbmdsZVRocmVhZFByb3h5Ojpjb21taXRJZk5lZWRlZCgpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAogICAgIGRvQ29tbWl0KHVwZGF0ZXIpOwotICAgIHJldHVybiB0cnVl OworICAgIHJldHVybiBkb0NvbXBvc2l0ZSgpOwogfQogCiBib29sIENDU2luZ2xlVGhyZWFkUHJv eHk6OmRvQ29tcG9zaXRlKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL2NjL0NDU2luZ2xlVGhyZWFkUHJveHkuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDU2luZ2xlVGhyZWFkUHJveHkuaAppbmRl eCA5ZGVjNGY0NzNlZDU5MGI5YmQ0ODBlYzZjZjEyZGY2NzE1YWViMTYwLi4zMzliZWFhMzZlMjE0 OTU1ODZlZWRmNzkyNTZmZTQ3N2ZjNmNjNTVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1NpbmdsZVRocmVhZFByb3h5LmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NTaW5nbGVUaHJl YWRQcm94eS5oCkBAIC03NSw3ICs3NSw3IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAgICAgZXhwbGlj aXQgQ0NTaW5nbGVUaHJlYWRQcm94eShDQ0xheWVyVHJlZUhvc3QqKTsKIAotICAgIGJvb2wgY29t bWl0SWZOZWVkZWQoKTsKKyAgICBib29sIGNvbW1pdEFuZENvbXBvc2l0ZSgpOwogICAgIHZvaWQg ZG9Db21taXQoQ0NUZXh0dXJlVXBkYXRlciYpOwogICAgIGJvb2wgZG9Db21wb3NpdGUoKTsKICAg ICB2b2lkIGRpZFN3YXBGcmFtZSgpOwo=