83835 2012-04-12 17:27:52 -0700 window.open should prepare for seamless navigation by using findFrameForNavigation 2012-04-12 17:42:45 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric japhet webkit.review.bot oldest_to_newest 601658 0 abarth 2012-04-12 17:27:52 -0700 window.open should prepare for seamless navigation by using findFrameForNavigation 601660 1 137000 abarth 2012-04-12 17:30:48 -0700 Created attachment 137000 Patch 601663 2 137000 rniwa 2012-04-12 17:37:48 -0700 Comment on attachment 137000 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=137000&action=review > Source/WebCore/loader/FrameLoader.cpp:2947 > + // FIXME: Eventually all callers should supply the actual activeDocument > + // so we can call canNavigate with the right document. OMG! This might be the culprit of the bug I've been haunting for ages. 601665 3 137000 abarth 2012-04-12 17:42:41 -0700 Comment on attachment 137000 Patch Clearing flags on attachment: 137000 Committed r114057: <http://trac.webkit.org/changeset/114057> 601666 4 abarth 2012-04-12 17:42:45 -0700 All reviewed patches have been landed. Closing bug. 137000 2012-04-12 17:30:48 -0700 2012-04-12 17:42:41 -0700 Patch bug-83835-20120412173046.patch text/plain 4723 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDA1NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBACisyMDEyLTA0LTEyICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgd2luZG93Lm9wZW4gc2hvdWxkIHBy ZXBhcmUgZm9yIHNlYW1sZXNzIG5hdmlnYXRpb24gYnkgdXNpbmcgZmluZEZyYW1lRm9yTmF2aWdh dGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM4 MzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCZWZv cmUgdGhpcyBwYXRjaCwgd2luZG93Lm9wZW4gY2FsbGVkIEZyYW1lVHJlZTo6ZmluZCBhbmQKKyAg ICAgICAgRG9jdW1lbnQ6OmNhbk5hdmlnYXRlIHNlcGFyYXRlbHkuICBUaGlzIHBhdGNoIHJlZmFj dG9ycyB0aGUgY29kZSB0bworICAgICAgICBjYWxsIEZyYW1lTG9hZGVyOjpmaW5kRnJhbWVGb3JO YXZpZ2F0aW9uLCB3aGljaCBkb2VzIGJvdGguICBUaGlzCisgICAgICAgIHJlZmFjdG9yaW5nIHBy ZXBhcmVzIHdpbmRvdy5vcGVuIHRvIHVuZGVyc3RhbmQgc2VhbWxlc3MgbmF2aWdhdGlvbiwKKyAg ICAgICAgd2hpY2ggd2lsbCBoYXBwZW4gaW4gZmluZEZyYW1lRm9yTmF2aWdhdGlvbi4KKworICAg ICAgICBUaGlzIHBhdGNoIHNob3VsZCBoYXZlIG5vIGJlaGF2aW9yIGNoYW5nZSB0b2RheSwgYnV0 IG9uY2Ugd2UgbWVyZ2UgdGhlCisgICAgICAgIHNlYW1sZXNzIGJyYW5jaCwgdGhpcyBjaGFuZ2Ug d2lsbCBiZSB0ZXN0ZWQgYnkKKyAgICAgICAgaHR0cHM6Ly9naXRodWIuY29tL2VzZWlkZWwvd2Vi a2l0L2Jsb2Ivc2VhbWxlc3MvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvc2VhbWxlc3Mvc2VhbWxl c3Mtd2luZG93LW9wZW4uaHRtbAorCisgICAgICAgIFNlZSBodHRwczovL2dpdGh1Yi5jb20vZXNl aWRlbC93ZWJraXQvY29tbWl0L2EwZDhiN2RlZmJiNjMwNDc5MTJhZWZiYzhlMjJiY2E0ZjA2Mzhj MzcgZm9yIGNvbnRleHQuCisKKyAgICAgICAgKiBXZWJDb3JlLmV4cC5pbjoKKyAgICAgICAgKiBs b2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OmZp bmRGcmFtZUZvck5hdmlnYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlV2luZG93KToK KyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuaDoKKyAgICAgICAgKEZyYW1lTG9hZGVyKToK KwogMjAxMi0wNC0xMiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAg UkVHUkVTU0lPTiAocjEwMjI2Mik6IGlBZCBQcm9kdWNlciByZWxpZXMgb24gQ1NTU3R5bGVEZWNs YXJhdGlvbiBwcm9wZXJ0eSBzZXR0ZXJzIHJlc3BlY3RpbmcgJyFpbXBvcnRhbnQnCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gMTE0MDQyKQorKysgU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5leHAuaW4JKHdvcmtpbmcgY29weSkKQEAgLTE3Nyw3ICsxNzcsNyBAQCBfX1pON1dlYkNv cmUxMUZyYW1lTG9hZGVyMTZkZXRhY2hGcm9tUGFyCiBfX1pON1dlYkNvcmUxMUZyYW1lTG9hZGVy MTZsb2FkRnJhbWVSZXF1ZXN0RVJLTlNfMTZGcmFtZUxvYWRSZXF1ZXN0RWJiTjNXVEYxMFBhc3NS ZWZQdHJJTlNfNUV2ZW50RUVFTlM1X0lOU185Rm9ybVN0YXRlRUVFTlNfMThTaG91bGRTZW5kUmVm ZXJyZXJFCiBfX1pON1dlYkNvcmUxMUZyYW1lTG9hZGVyMTdzdG9wRm9yVXNlckNhbmNlbEViCiBf X1pON1dlYkNvcmUxMUZyYW1lTG9hZGVyMjFsb2FkVVJMSW50b0NoaWxkRnJhbWVFUktOU180S1VS TEVSS04zV1RGNlN0cmluZ0VQTlNfNUZyYW1lRQotX19aTjdXZWJDb3JlMTFGcmFtZUxvYWRlcjIy ZmluZEZyYW1lRm9yTmF2aWdhdGlvbkVSS04zV1RGMTJBdG9taWNTdHJpbmdFCitfX1pON1dlYkNv cmUxMUZyYW1lTG9hZGVyMjJmaW5kRnJhbWVGb3JOYXZpZ2F0aW9uRVJLTjNXVEYxMkF0b21pY1N0 cmluZ0VQTlNfOERvY3VtZW50RQogX19aTjdXZWJDb3JlMTFGcmFtZUxvYWRlcjIzdGltZU9mTGFz dENvbXBsZXRlZExvYWRFdiAgICAKIF9fWk43V2ViQ29yZTExRnJhbWVMb2FkZXIyNnJlbG9hZFdp dGhPdmVycmlkZUVuY29kaW5nRVJLTjNXVEY2U3RyaW5nRQogX19aTjdXZWJDb3JlMTFGcmFtZUxv YWRlcjMyc2V0T3JpZ2luYWxVUkxGb3JEb3dubG9hZFJlcXVlc3RFUk5TXzE1UmVzb3VyY2VSZXF1 ZXN0RQpJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCShyZXZpc2lvbiAx MTQwNDIpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0yOTM1LDE0ICsyOTM1LDIwIEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNoZWNrRGlk UGVyZm9ybUZpcnN0TmEKICAgICB9CiB9CiAKLUZyYW1lKiBGcmFtZUxvYWRlcjo6ZmluZEZyYW1l Rm9yTmF2aWdhdGlvbihjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpCitGcmFtZSogRnJhbWVMb2Fk ZXI6OmZpbmRGcmFtZUZvck5hdmlnYXRpb24oY29uc3QgQXRvbWljU3RyaW5nJiBuYW1lLCBEb2N1 bWVudCogYWN0aXZlRG9jdW1lbnQpCiB7CiAgICAgRnJhbWUqIGZyYW1lID0gbV9mcmFtZS0+dHJl ZSgpLT5maW5kKG5hbWUpOwotICAgIC8vIEZJWE1FOiBXZSBjYWxsaW5nIGNhbk5hdmlnYXRlIG9u IHRoZSBEb2N1bWVudCB0aGF0J3MgcmVxdWVzdGluZyB0aGUKLSAgICAvLyBuYXZpZ2F0aW9uLCBu b3QgYmFzZWQgb24gdGhlIGRvY3VtZW50IHRoYXQgaGFwcGVucyB0byBiZSBkaXNwbGF5ZWQgaW4K LSAgICAvLyB0aGlzIEZyYW1lLgotICAgIGlmICghbV9mcmFtZS0+ZG9jdW1lbnQoKS0+Y2FuTmF2 aWdhdGUoZnJhbWUpKQotICAgICAgICByZXR1cm4gMDsKKworICAgIGlmIChhY3RpdmVEb2N1bWVu dCkgeworICAgICAgICBpZiAoIWFjdGl2ZURvY3VtZW50LT5jYW5OYXZpZ2F0ZShmcmFtZSkpCisg ICAgICAgICAgICByZXR1cm4gMDsKKyAgICB9IGVsc2UgeworICAgICAgICAvLyBGSVhNRTogRXZl bnR1YWxseSBhbGwgY2FsbGVycyBzaG91bGQgc3VwcGx5IHRoZSBhY3R1YWwgYWN0aXZlRG9jdW1l bnQKKyAgICAgICAgLy8gc28gd2UgY2FuIGNhbGwgY2FuTmF2aWdhdGUgd2l0aCB0aGUgcmlnaHQg ZG9jdW1lbnQuCisgICAgICAgIGlmICghbV9mcmFtZS0+ZG9jdW1lbnQoKS0+Y2FuTmF2aWdhdGUo ZnJhbWUpKQorICAgICAgICAgICAgcmV0dXJuIDA7CisgICAgfQorCiAgICAgcmV0dXJuIGZyYW1l OwogfQogCkBAIC0zMTk0LDggKzMyMDAsNyBAQCBGcmFtZSogY3JlYXRlV2luZG93KEZyYW1lKiBv cGVuZXJGcmFtZSwgCiAgICAgQVNTRVJUKCFmZWF0dXJlcy5kaWFsb2cgfHwgcmVxdWVzdC5mcmFt ZU5hbWUoKS5pc0VtcHR5KCkpOwogCiAgICAgaWYgKCFyZXF1ZXN0LmZyYW1lTmFtZSgpLmlzRW1w dHkoKSAmJiByZXF1ZXN0LmZyYW1lTmFtZSgpICE9ICJfYmxhbmsiKSB7Ci0gICAgICAgIEZyYW1l KiBmcmFtZSA9IGxvb2t1cEZyYW1lLT50cmVlKCktPmZpbmQocmVxdWVzdC5mcmFtZU5hbWUoKSk7 Ci0gICAgICAgIGlmIChmcmFtZSAmJiBvcGVuZXJGcmFtZS0+ZG9jdW1lbnQoKS0+Y2FuTmF2aWdh dGUoZnJhbWUpKSB7CisgICAgICAgIGlmIChGcmFtZSogZnJhbWUgPSBsb29rdXBGcmFtZS0+bG9h ZGVyKCktPmZpbmRGcmFtZUZvck5hdmlnYXRpb24ocmVxdWVzdC5mcmFtZU5hbWUoKSwgb3BlbmVy RnJhbWUtPmRvY3VtZW50KCkpKSB7CiAgICAgICAgICAgICBpZiAoUGFnZSogcGFnZSA9IGZyYW1l LT5wYWdlKCkpCiAgICAgICAgICAgICAgICAgcGFnZS0+Y2hyb21lKCktPmZvY3VzKCk7CiAgICAg ICAgICAgICBjcmVhdGVkID0gZmFsc2U7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJh bWVMb2FkZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2Fk ZXIuaAkocmV2aXNpb24gMTE0MDQyKQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9h ZGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTI0NSw3ICsyNDUsNyBAQCBwdWJsaWM6CiAKICAgICBG cmFtZUxvYWRlclN0YXRlTWFjaGluZSogc3RhdGVNYWNoaW5lKCkgY29uc3QgeyByZXR1cm4gJm1f c3RhdGVNYWNoaW5lOyB9CiAKLSAgICBGcmFtZSogZmluZEZyYW1lRm9yTmF2aWdhdGlvbihjb25z dCBBdG9taWNTdHJpbmcmIG5hbWUpOworICAgIEZyYW1lKiBmaW5kRnJhbWVGb3JOYXZpZ2F0aW9u KGNvbnN0IEF0b21pY1N0cmluZyYgbmFtZSwgRG9jdW1lbnQqIGFjdGl2ZURvY3VtZW50ID0gMCk7 CiAKICAgICB2b2lkIGFwcGx5VXNlckFnZW50KFJlc291cmNlUmVxdWVzdCYpOwogCg==