83827 2012-04-12 15:40:30 -0700 Preprocessing text files with modern clang treats double slashes as comments 2012-04-12 18:54:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap mrowe webkit.review.bot oldest_to_newest 601589 0 ap 2012-04-12 15:40:30 -0700 In files such as com.apple.WebProcess.sb.in, we mention rdar:// URLs in comments. The existing invocation of preprocessor treats these double slashes as comments. 601591 1 ap 2012-04-12 15:42:04 -0700 Related to <rdar://problem/11222169>. 601593 2 136986 ap 2012-04-12 15:43:31 -0700 Created attachment 136986 proposed patch 601743 3 136986 webkit.review.bot 2012-04-12 18:54:27 -0700 Comment on attachment 136986 proposed patch Clearing flags on attachment: 136986 Committed r114069: <http://trac.webkit.org/changeset/114069> 601744 4 webkit.review.bot 2012-04-12 18:54:31 -0700 All reviewed patches have been landed. Closing bug. 136986 2012-04-12 15:43:31 -0700 2012-04-12 18:54:27 -0700 proposed patch preprocessor.txt text/plain 3594 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDA0MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA0LTEyICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFByZXByb2Nlc3NpbmcgdGV4 dCBmaWxlcyB3aXRoIG1vZGVybiBjbGFuZyB0cmVhdHMgZG91YmxlIHNsYXNoZXMgaW4gY29tbWVu dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzODI3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBEZXJp dmVkU291cmNlcy5tYWtlOiBQYXNzIGFwcHJvcHJpYXRlIGZsYWdzIHRvIGJvdGggbGx2bSBhbmQg Z2NjLgorCiAyMDEyLTA0LTEyICBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4K IAogICAgICAgICBbUXRdIEZpeCBXZWJLaXQxIGJ1aWxkIHdpdGggVjgKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv RGVyaXZlZFNvdXJjZXMubWFrZQkocmV2aXNpb24gMTEzOTAwKQorKysgU291cmNlL1dlYkNvcmUv RGVyaXZlZFNvdXJjZXMubWFrZQkod29ya2luZyBjb3B5KQpAQCAtNjQ3LDYgKzY0NywxMiBAQCBp ZmVxICgkKE9TKSxNQUNPUykKIEZSQU1FV09SS19GTEFHUyA9ICQoc2hlbGwgZWNobyAkKEJVSUxU X1BST0RVQ1RTX0RJUikgJChGUkFNRVdPUktfU0VBUkNIX1BBVEhTKSB8IHBlcmwgLWUgJ3ByaW50 ICItRiAiIC4gam9pbigiIC1GICIsIHNwbGl0KCIgIiwgPD4pKTsnKQogSEVBREVSX0ZMQUdTID0g JChzaGVsbCBlY2hvICQoQlVJTFRfUFJPRFVDVFNfRElSKSAkKEhFQURFUl9TRUFSQ0hfUEFUSFMp IHwgcGVybCAtZSAncHJpbnQgIi1JIiAuIGpvaW4oIiAtSSIsIHNwbGl0KCIgIiwgPD4pKTsnKQog CitpZmVxICgkKFRBUkdFVF9HQ0NfVkVSU0lPTiksTExWTV9DT01QSUxFUikKKwlURVhUX1BSRVBS T0NFU1NPUl9GTEFHUz0tRSAtUCAteCBjIC10cmFkaXRpb25hbAorZWxzZQorCVRFWFRfUFJFUFJP Q0VTU09SX0ZMQUdTPS1FIC1QIC14IGMgLXN0ZD1jODkKK2VuZGlmCisKIGlmZXEgKCQoc2hlbGwg JChDQykgLXggYysrIC1FIC1QIC1kTSAkKEZSQU1FV09SS19GTEFHUykgJChIRUFERVJfRkxBR1Mp IC1pbmNsdWRlICJ3dGYvUGxhdGZvcm0uaCIgL2Rldi9udWxsIHwgZ3JlcCBFTkFCTEVfREFTSEJP QVJEX1NVUFBPUlQgfCBjdXQgLWQnICcgLWYzKSwgMSkKICAgICBFTkFCTEVfREFTSEJPQVJEX1NV UFBPUlQgPSAxCiBlbHNlCkBAIC02NjMsNyArNjY5LDcgQEAgYWxsOiBEZWZhdWx0Rm9udHMucGxp c3QKIAogRGVmYXVsdEZvbnRzLnBsaXN0IDogRGVmYXVsdEZvbnRzLnBsaXN0LmluCiAJQGVjaG8g UHJlLXByb2Nlc3NpbmcgRGVmYXVsdEZvbnRzLnBsaXN0Li4uCi0JJChDQykgLUUgLVAgLXcgLXgg YyAtc3RkPWM4OSAkKEZSQU1FV09SS19GTEFHUykgJChIRUFERVJfRkxBR1MpIC1pbmNsdWRlICJ3 dGYvUGxhdGZvcm0uaCIgJDwgPiAkQAorCSQoQ0MpICQoVEVYVF9QUkVQUk9DRVNTT1JfRkxBR1Mp ICQoRlJBTUVXT1JLX0ZMQUdTKSAkKEhFQURFUl9GTEFHUykgLWluY2x1ZGUgInd0Zi9QbGF0Zm9y bS5oIiAkPCA+ICRACiAKIGVsc2UKIApJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMTE0MDQyKQor KysgU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIg QEAKKzIwMTItMDQtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CisKKyAg ICAgICAgUHJlcHJvY2Vzc2luZyB0ZXh0IGZpbGVzIHdpdGggbW9kZXJuIGNsYW5nIHRyZWF0cyBk b3VibGUgc2xhc2hlcyBpbiBjb21tZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9ODM4MjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIERlcml2ZWRTb3VyY2VzLm1ha2U6IFBhc3MgYXBwcm9wcmlhdGUg ZmxhZ3MgdG8gYm90aCBsbHZtIGFuZCBnY2MuCisKIDIwMTItMDQtMTIgIEJlYXIgVHJhdmlzICA8 YmV0cmF2aXNAYWRvYmUuY29tPgogCiAgICAgICAgIFtDU1MgRXhjbHVzaW9uc10gQWRkIGZsYWcg dG8gZW5hYmxlIC8gZGlzYWJsZSBleGNsdXNpb25zIGF0IHJ1bnRpbWUKSW5kZXg6IFNvdXJjZS9X ZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLm1ha2UKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv RGVyaXZlZFNvdXJjZXMubWFrZQkocmV2aXNpb24gMTEzODk5KQorKysgU291cmNlL1dlYktpdDIv RGVyaXZlZFNvdXJjZXMubWFrZQkod29ya2luZyBjb3B5KQpAQCAtMTE4LDYgKzExOCwxMiBAQCBp ZmVxICgkKE9TKSxNQUNPUykKIEZSQU1FV09SS19GTEFHUyA9ICQoc2hlbGwgZWNobyAkKEJVSUxU X1BST0RVQ1RTX0RJUikgJChGUkFNRVdPUktfU0VBUkNIX1BBVEhTKSB8IHBlcmwgLWUgJ3ByaW50 ICItRiAiIC4gam9pbigiIC1GICIsIHNwbGl0KCIgIiwgPD4pKTsnKQogSEVBREVSX0ZMQUdTID0g JChzaGVsbCBlY2hvICQoQlVJTFRfUFJPRFVDVFNfRElSKSAkKEhFQURFUl9TRUFSQ0hfUEFUSFMp IHwgcGVybCAtZSAncHJpbnQgIi1JIiAuIGpvaW4oIiAtSSIsIHNwbGl0KCIgIiwgPD4pKTsnKQog CitpZmVxICgkKFRBUkdFVF9HQ0NfVkVSU0lPTiksTExWTV9DT01QSUxFUikKKwlURVhUX1BSRVBS T0NFU1NPUl9GTEFHUz0tRSAtUCAteCBjIC10cmFkaXRpb25hbAorZWxzZQorCVRFWFRfUFJFUFJP Q0VTU09SX0ZMQUdTPS1FIC1QIC14IGMgLXN0ZD1jODkKK2VuZGlmCisKIFNBTkRCT1hfUFJPRklM RVMgPSBcCiAJY29tLmFwcGxlLldlYlByb2Nlc3Muc2IgXAogCWNvbS5hcHBsZS5XZWJLaXQuUGx1 Z2luUHJvY2Vzcy5zYgpAQCAtMTI2LDcgKzEzMiw3IEBAIGFsbDogJChTQU5EQk9YX1BST0ZJTEVT KQogCiAlLnNiIDogJS5zYi5pbgogCUBlY2hvIFByZS1wcm9jZXNzaW5nICQqIHNhbmRib3ggcHJv ZmlsZS4uLgotCSQoQ0MpIC1FIC1QIC13IC14IGMgLXN0ZD1jODkgJChGUkFNRVdPUktfRkxBR1Mp ICQoSEVBREVSX0ZMQUdTKSAtaW5jbHVkZSAid3RmL1BsYXRmb3JtLmgiICQ8ID4gJEAKKwkkKEND KSAkKFRFWFRfUFJFUFJPQ0VTU09SX0ZMQUdTKSAkKEZSQU1FV09SS19GTEFHUykgJChIRUFERVJf RkxBR1MpIC1pbmNsdWRlICJ3dGYvUGxhdGZvcm0uaCIgJDwgPiAkQAogCiBlbmRpZiAjIE1BQ09T CiAK