83819 2012-04-12 14:08:00 -0700 Remove FrameLoading::m_isLoadingMainResource 2012-04-12 18:07:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 japhet japhet abarth ap webkit.review.bot oldest_to_newest 601517 0 japhet 2012-04-12 14:08:00 -0700 It's only read by DocumentWriter::endIfNotLoadingMainResource(), which is only called by a function that sets m_isLoadingMainResource to false first. 601525 1 136970 japhet 2012-04-12 14:12:37 -0700 Created attachment 136970 patch 601635 2 136970 abarth 2012-04-12 16:57:29 -0700 Comment on attachment 136970 patch Really! 601689 3 136970 webkit.review.bot 2012-04-12 18:07:45 -0700 Comment on attachment 136970 patch Clearing flags on attachment: 136970 Committed r114062: <http://trac.webkit.org/changeset/114062> 601690 4 webkit.review.bot 2012-04-12 18:07:50 -0700 All reviewed patches have been landed. Closing bug. 136970 2012-04-12 14:12:37 -0700 2012-04-12 18:07:45 -0700 patch writer.txt text/plain 4904 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDExNDAzMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTEyICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVtb3ZlIEZyYW1lTG9hZGVy Om1faXNMb2FkaW5nTWFpblJlc291cmNlLCBzaW5jZSBpdCBpcyBhbHdheXMKKyAgICAgICAgZmFs c2UgYXQgdGhlIG9ubHkgcG9pbnQgaXQgaXMgY2hlY2tlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTgzODE5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBmdW5jdGlvbmFsaXR5 IGNoYW5nZSBpbnRlbmRlZC4KKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudFdyaXRlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudFdyaXRlcjo6ZW5kKTogTWVyZ2Ugd2l0aCBlbmRJ Zk5vdExvYWRpbmdNYWluUmVzb3VyY2UoKSwgYWx3YXlzIGVuZCwgYXNzZXJ0IHRoYXQgd2UncmUg c3RpbGwgYXR0YWNoZWQuCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50V3JpdGVyLmg6CisgICAg ICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2Fk ZXIuaDogUmVtb3ZlIGlzTG9hZGluZ01haW5SZXNvdXJjZSgpLCBkaWRFbmREb2N1bWVudCgpLCBh bmQgbV9pc0xvYWRpbmdNYWluUmVzb3VyY2UuCisKIDIwMTItMDQtMTIgIExldmkgV2VpbnRyYXVi ICA8bGV2aXdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIE1ha2UgQWNjZXNzaWJpbGl0eU9iamVj dDo6c2l6ZSBub24tdmlydHVhbCBhbmQgZml4IHBsYXRmb3JtIGFjY2Vzc2liaWxpdHkgY29kZSdz IExheW91dFVuaXQgdXNhZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNw cAkocmV2aXNpb24gMTE0MDE3KQorKysgU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg0LDcgKzE4NCw2IEBACiAgICAgLCBtX3dhc1VubG9h ZEV2ZW50RW1pdHRlZChmYWxzZSkKICAgICAsIG1fcGFnZURpc21pc3NhbEV2ZW50QmVpbmdEaXNw YXRjaGVkKE5vRGlzbWlzc2FsKQogICAgICwgbV9pc0NvbXBsZXRlKGZhbHNlKQotICAgICwgbV9p c0xvYWRpbmdNYWluUmVzb3VyY2UoZmFsc2UpCiAgICAgLCBtX2hhc1JlY2VpdmVkRmlyc3REYXRh KGZhbHNlKQogICAgICwgbV9uZWVkc0NsZWFyKGZhbHNlKQogICAgICwgbV9jaGVja1RpbWVyKHRo aXMsICZGcmFtZUxvYWRlcjo6Y2hlY2tUaW1lckZpcmVkKQpAQCAtNDAyLDcgKzQwMSw2IEBACiAg ICAgfQogCiAgICAgbV9pc0NvbXBsZXRlID0gdHJ1ZTsgLy8gdG8gYXZvaWQgY2FsbGluZyBjb21w bGV0ZWQoKSBpbiBmaW5pc2hlZFBhcnNpbmcoKQotICAgIG1faXNMb2FkaW5nTWFpblJlc291cmNl ID0gZmFsc2U7CiAgICAgbV9kaWRDYWxsSW1wbGljaXRDbG9zZSA9IHRydWU7IC8vIGRvbid0IHdh bnQgdGhhdCBvbmUgZWl0aGVyCiAKICAgICBpZiAobV9mcmFtZS0+ZG9jdW1lbnQoKSAmJiBtX2Zy YW1lLT5kb2N1bWVudCgpLT5wYXJzaW5nKCkpIHsKQEAgLTQ2NSw3ICs0NjMsNiBAQAogICAgIG1f ZnJhbWUtPmVkaXRvcigpLT5jbGVhckxhc3RFZGl0Q29tbWFuZCgpOwogCiAgICAgbV9pc0NvbXBs ZXRlID0gZmFsc2U7Ci0gICAgbV9pc0xvYWRpbmdNYWluUmVzb3VyY2UgPSB0cnVlOwogICAgIG1f ZGlkQ2FsbEltcGxpY2l0Q2xvc2UgPSBmYWxzZTsKIAogICAgIC8vIElmIHdlIGFyZSBzdGlsbCBp biB0aGUgcHJvY2VzcyBvZiBpbml0aWFsaXppbmcgYW4gZW1wdHkgZG9jdW1lbnQgdGhlbgpAQCAt NjEzLDcgKzYxMCw2IEBACiAgICAgbV9uZWVkc0NsZWFyID0gdHJ1ZTsKICAgICBtX2lzQ29tcGxl dGUgPSBmYWxzZTsKICAgICBtX2RpZENhbGxJbXBsaWNpdENsb3NlID0gZmFsc2U7Ci0gICAgbV9p c0xvYWRpbmdNYWluUmVzb3VyY2UgPSB0cnVlOwogICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPnNl dFJlYWR5U3RhdGUoRG9jdW1lbnQ6OkxvYWRpbmcpOwogCiAgICAgaWYgKG1fcGVuZGluZ1N0YXRl T2JqZWN0KSB7CkBAIC02NDYsMTEgKzY0Miw2IEBACiAgICAgaGlzdG9yeSgpLT5yZXN0b3JlRG9j dW1lbnRTdGF0ZSgpOwogfQogCi12b2lkIEZyYW1lTG9hZGVyOjpkaWRFbmREb2N1bWVudCgpCi17 Ci0gICAgbV9pc0xvYWRpbmdNYWluUmVzb3VyY2UgPSBmYWxzZTsKLX0KLQogdm9pZCBGcmFtZUxv YWRlcjo6ZmluaXNoZWRQYXJzaW5nKCkKIHsKICAgICBtX2ZyYW1lLT5pbmplY3RVc2VyU2NyaXB0 cyhJbmplY3RBdERvY3VtZW50RW5kKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudFdyaXRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dFdyaXRlci5oCShyZXZpc2lvbiAxMTQwMTcpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRXcml0ZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNzAsNyArNzAsNiBAQAogcHJpdmF0ZToK ICAgICBQYXNzUmVmUHRyPERvY3VtZW50PiBjcmVhdGVEb2N1bWVudChjb25zdCBLVVJMJik7CiAg ICAgdm9pZCBjbGVhcigpOwotICAgIHZvaWQgZW5kSWZOb3RMb2FkaW5nTWFpblJlc291cmNlKCk7 CiAKICAgICBGcmFtZSogbV9mcmFtZTsKIApJbmRleDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0Rv Y3VtZW50V3JpdGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9j dW1lbnRXcml0ZXIuY3BwCShyZXZpc2lvbiAxMTQwMTcpCisrKyBTb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRG9jdW1lbnRXcml0ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMjAsMTcgKzIyMCw5IEBA CiAKIHZvaWQgRG9jdW1lbnRXcml0ZXI6OmVuZCgpCiB7Ci0gICAgbV9mcmFtZS0+bG9hZGVyKCkt PmRpZEVuZERvY3VtZW50KCk7Ci0gICAgZW5kSWZOb3RMb2FkaW5nTWFpblJlc291cmNlKCk7Ci19 CisgICAgQVNTRVJUKG1fZnJhbWUtPnBhZ2UoKSk7CisgICAgQVNTRVJUKG1fZnJhbWUtPmRvY3Vt ZW50KCkpOwogCi12b2lkIERvY3VtZW50V3JpdGVyOjplbmRJZk5vdExvYWRpbmdNYWluUmVzb3Vy Y2UoKQotewotICAgIC8vIEZJWE1FOiBUaGlzIGlzbid0IHJlYWxseSB0aGUgY2hlY2sgd2Ugc2hv dWxkIGJlIGRvaW5nLiBXZSBzaG91bGQgcmUtd29yawotICAgIC8vIGhvdyB3ZSBlbmQgcGFyc2lu ZyB0byBtYXRjaCB0aGUgbW9kZWwgaW4gSFRNTDUuCi0gICAgaWYgKG1fZnJhbWUtPmxvYWRlcigp LT5pc0xvYWRpbmdNYWluUmVzb3VyY2UoKSB8fCAhbV9mcmFtZS0+cGFnZSgpIHx8ICFtX2ZyYW1l LT5kb2N1bWVudCgpKQotICAgICAgICByZXR1cm47Ci0KICAgICAvLyBUaGUgcGFyc2VyIGlzIGd1 YXJhbnRlZWQgdG8gYmUgcmVsZWFzZWQgYWZ0ZXIgdGhpcyBwb2ludC4gYmVnaW4oKSB3b3VsZAog ICAgIC8vIGhhdmUgdG8gYmUgY2FsbGVkIGFnYWluIGJlZm9yZSB3ZSBjYW4gc3RhcnQgd3JpdGlu ZyBtb3JlIGRhdGEuCiAgICAgbV9zdGF0ZSA9IEZpbmlzaGVkV3JpdGluZ1N0YXRlOwpJbmRleDog U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmgJKHJldmlzaW9uIDExNDAxNykKKysrIFNvdXJj ZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzEsNyAr MTMxLDYgQEAKICAgICB2b2lkIGNhbmNlbEFuZENsZWFyKCk7CiAgICAgdm9pZCBjbGVhcihib29s IGNsZWFyV2luZG93UHJvcGVydGllcyA9IHRydWUsIGJvb2wgY2xlYXJTY3JpcHRPYmplY3RzID0g dHJ1ZSwgYm9vbCBjbGVhckZyYW1lVmlldyA9IHRydWUpOwogCi0gICAgYm9vbCBpc0xvYWRpbmdN YWluUmVzb3VyY2UoKSBjb25zdCB7IHJldHVybiBtX2lzTG9hZGluZ01haW5SZXNvdXJjZTsgfQog ICAgIGJvb2wgaXNMb2FkaW5nKCkgY29uc3Q7CiAgICAgYm9vbCBmcmFtZUhhc0xvYWRlZCgpIGNv bnN0OwogCkBAIC0yMDAsNyArMTk5LDYgQEAKIAogICAgIC8vIENhbGxiYWNrcyBmcm9tIERvY3Vt ZW50V3JpdGVyCiAgICAgdm9pZCBkaWRCZWdpbkRvY3VtZW50KGJvb2wgZGlzcGF0Y2hXaW5kb3dP YmplY3RBdmFpbGFibGUpOwotICAgIHZvaWQgZGlkRW5kRG9jdW1lbnQoKTsKICAgICB2b2lkIHdp bGxTZXRFbmNvZGluZygpOwogCiAgICAgdm9pZCBoYW5kbGVkT25sb2FkRXZlbnRzKCk7CkBAIC00 MDIsNyArNDAwLDYgQEAKICAgICBib29sIG1fd2FzVW5sb2FkRXZlbnRFbWl0dGVkOwogICAgIFBh Z2VEaXNtaXNzYWxUeXBlIG1fcGFnZURpc21pc3NhbEV2ZW50QmVpbmdEaXNwYXRjaGVkOwogICAg IGJvb2wgbV9pc0NvbXBsZXRlOwotICAgIGJvb2wgbV9pc0xvYWRpbmdNYWluUmVzb3VyY2U7CiAK ICAgICBSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBtX3BlbmRpbmdTdGF0ZU9iamVjdDsK IAo=