83814 2012-04-12 13:27:39 -0700 [BlackBerry] Web Inspector cookie expiry is showing the wrong date. 2012-04-12 14:14:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kpiascik webkit-unassigned joenotcharles rwlbuis tonikitoo webkit.review.bot oldest_to_newest 601480 0 kpiascik 2012-04-12 13:27:39 -0700 [BlackBerry] Web Inspector cookie expiry is showing the wrong date. 601484 1 136959 kpiascik 2012-04-12 13:30:31 -0700 Created attachment 136959 Patch 601488 2 136959 rwlbuis 2012-04-12 13:33:08 -0700 Comment on attachment 136959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=136959&action=review Since Konrad is almost but not quite a committer, I have to r- this, looks good except the typo. > Source/WebCore/ChangeLog:9 > + to millieconds by multiplying by 1000. Typo. 601490 3 136961 kpiascik 2012-04-12 13:34:44 -0700 Created attachment 136961 Patch 601491 4 136961 rwlbuis 2012-04-12 13:35:23 -0700 Comment on attachment 136961 Patch LGTM. 601526 5 136961 webkit.review.bot 2012-04-12 14:14:24 -0700 Comment on attachment 136961 Patch Clearing flags on attachment: 136961 Committed r114035: <http://trac.webkit.org/changeset/114035> 601527 6 webkit.review.bot 2012-04-12 14:14:28 -0700 All reviewed patches have been landed. Closing bug. 136959 2012-04-12 13:30:31 -0700 2012-04-12 13:34:38 -0700 Patch bug-83814-20120412163152.patch text/plain 1979 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk1ZWI5ZDJiMTk1YTg4 MzcyNGI0ZDE3OTRjMjJlOGE4YTI1OGM0ZS4uODg4N2Y5Nzk4MmE3ODQ5OGIwY2ZhOTRiNGE1ODVj NTcxNjAzNDJhNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTEyICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFdl YiBJbnNwZWN0b3IgY29va2llIGV4cGlyeSBpcyBzaG93aW5nIHRoZSB3cm9uZyBkYXRlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM4MTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaW50ZXJuYWwg cmVwcmVzZW50YXRpb24gZm9yIGV4cGlyeSBpcyBzZWNvbmRzLCB3ZSBuZWVkIHRvIGNvbnZlcnQg aXQKKyAgICAgICAgdG8gbWlsbGllY29uZHMgYnkgbXVsdGlwbHlpbmcgYnkgMTAwMC4KKworICAg ICAgICBUaGUgdmFsdWUgZnJvbSB0aGlzIG1ldGhvZCBkb2Vzbid0IGdldCB1c2VkIGFueXdoZXJl IGV4Y2VwdCBXZWIgSW5zcGVjdG9yLgorICAgICAgICBNYW51YWxseSB0ZXN0ZWQgd2l0aCBXZWIg SW5zcGVjdG9yIGJ5IGV4YW1pbmluZyB0aGUgQ29va2llSXRlbVZpZXcgaW4gdGhlIFJlc291cmNl cyBQYW5lbC4KKworICAgICAgICAqIHBsYXRmb3JtL2JsYWNrYmVycnkvUGFyc2VkQ29va2llLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlBhcnNlZENvb2tpZTo6YXBwZW5kV2ViQ29yZUNvb2tpZSk6 CisKIDIwMTItMDMtMjAgIFcuIEphbWVzIE1hY0xlYW4gIDx3am1hY2xlYW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFtjaHJvbWl1bV0gVHVuZSBmbGluZyBwaHlzaWNzIGN1cnZlLiBbTm90IGZv ciByZXZpZXcgeWV0XQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2ti ZXJyeS9QYXJzZWRDb29raWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJy eS9QYXJzZWRDb29raWUuY3BwCmluZGV4IDg0YmY2MDMyMTJhOGY1N2I4YTE1ZWIwZDljOTdjOWE2 NmVhY2FmMDUuLmUyODlmNTVhMTkyMTdhNjA3YTU4NGY0ZjEyNDc4NjhlNWQxZjlkNjYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvUGFyc2VkQ29va2llLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BhcnNlZENvb2tpZS5j cHAKQEAgLTE4NSw2ICsxODUsOCBAQCBTdHJpbmcgUGFyc2VkQ29va2llOjp0b05hbWVWYWx1ZVBh aXIoKSBjb25zdAogdm9pZCBQYXJzZWRDb29raWU6OmFwcGVuZFdlYkNvcmVDb29raWUoVmVjdG9y PENvb2tpZT4mIGNvb2tpZVZlY3RvcikgY29uc3QKIHsKICAgICBjb29raWVWZWN0b3IuYXBwZW5k KENvb2tpZShTdHJpbmcobV9uYW1lKSwgU3RyaW5nKG1fdmFsdWUpLCBTdHJpbmcobV9kb21haW4p LAotICAgICAgICAgICAgU3RyaW5nKG1fcGF0aCksIG1fZXhwaXJ5LCBtX2lzSHR0cE9ubHksIG1f aXNTZWN1cmUsIG1faXNTZXNzaW9uKSk7CisgICAgICAgICAgICAvLyBXZSBtdWx0aXBseSBtX2V4 cGlyeSBieSAxMDAwIHRvIGNvbnZlcnQgZnJvbSBzZWNvbmRzIHRvIG1pbGxpc2Vjb25kcy4KKyAg ICAgICAgICAgIC8vIFRoaXMgdmFsdWUgaXMgcGFzc2VkIHRvIFdlYiBJbnNwZWN0b3IgYW5kIHVz ZWQgaW4gdGhlIEphdmFTY3JpcHQgRGF0ZSBjb25zdHJ1Y3Rvci4KKyAgICAgICAgICAgIFN0cmlu ZyhtX3BhdGgpLCAobV9leHBpcnkgKiAxMDAwKSwgbV9pc0h0dHBPbmx5LCBtX2lzU2VjdXJlLCBt X2lzU2Vzc2lvbikpOwogfQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 136961 2012-04-12 13:34:44 -0700 2012-04-12 14:14:23 -0700 Patch bug-83814-20120412163604.patch text/plain 1980 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTExMzk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTk1ZWI5ZDJiMTk1YTg4 MzcyNGI0ZDE3OTRjMjJlOGE4YTI1OGM0ZS4uM2ZhYjY2ZTFkNmJhZTQzNzIxMTY1NTc0YjcxODE5 M2E4ZGE2NzJhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA0LTEyICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFdl YiBJbnNwZWN0b3IgY29va2llIGV4cGlyeSBpcyBzaG93aW5nIHRoZSB3cm9uZyBkYXRlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9ODM4MTQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgaW50ZXJuYWwg cmVwcmVzZW50YXRpb24gZm9yIGV4cGlyeSBpcyBzZWNvbmRzLCB3ZSBuZWVkIHRvIGNvbnZlcnQg aXQKKyAgICAgICAgdG8gbWlsbGlzZWNvbmRzIGJ5IG11bHRpcGx5aW5nIGJ5IDEwMDAuCisKKyAg ICAgICAgVGhlIHZhbHVlIGZyb20gdGhpcyBtZXRob2QgZG9lc24ndCBnZXQgdXNlZCBhbnl3aGVy ZSBleGNlcHQgV2ViIEluc3BlY3Rvci4KKyAgICAgICAgTWFudWFsbHkgdGVzdGVkIHdpdGggV2Vi IEluc3BlY3RvciBieSBleGFtaW5pbmcgdGhlIENvb2tpZUl0ZW1WaWV3IGluIHRoZSBSZXNvdXJj ZXMgUGFuZWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ibGFja2JlcnJ5L1BhcnNlZENvb2tpZS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpQYXJzZWRDb29raWU6OmFwcGVuZFdlYkNvcmVDb29raWUp OgorCiAyMDEyLTAzLTIwICBXLiBKYW1lcyBNYWNMZWFuICA8d2ptYWNsZWFuQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbY2hyb21pdW1dIFR1bmUgZmxpbmcgcGh5c2ljcyBjdXJ2ZS4gW05vdCBm b3IgcmV2aWV3IHlldF0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvUGFyc2VkQ29va2llLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNrYmVy cnkvUGFyc2VkQ29va2llLmNwcAppbmRleCA4NGJmNjAzMjEyYThmNTdiOGExNWViMGQ5Yzk3Yzlh NjZlYWNhZjA1Li5lMjg5ZjU1YTE5MjE3YTYwN2E1ODRmNGYxMjQ3ODY4ZTVkMWY5ZDY2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L1BhcnNlZENvb2tpZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxhY2tiZXJyeS9QYXJzZWRDb29raWUu Y3BwCkBAIC0xODUsNiArMTg1LDggQEAgU3RyaW5nIFBhcnNlZENvb2tpZTo6dG9OYW1lVmFsdWVQ YWlyKCkgY29uc3QKIHZvaWQgUGFyc2VkQ29va2llOjphcHBlbmRXZWJDb3JlQ29va2llKFZlY3Rv cjxDb29raWU+JiBjb29raWVWZWN0b3IpIGNvbnN0CiB7CiAgICAgY29va2llVmVjdG9yLmFwcGVu ZChDb29raWUoU3RyaW5nKG1fbmFtZSksIFN0cmluZyhtX3ZhbHVlKSwgU3RyaW5nKG1fZG9tYWlu KSwKLSAgICAgICAgICAgIFN0cmluZyhtX3BhdGgpLCBtX2V4cGlyeSwgbV9pc0h0dHBPbmx5LCBt X2lzU2VjdXJlLCBtX2lzU2Vzc2lvbikpOworICAgICAgICAgICAgLy8gV2UgbXVsdGlwbHkgbV9l eHBpcnkgYnkgMTAwMCB0byBjb252ZXJ0IGZyb20gc2Vjb25kcyB0byBtaWxsaXNlY29uZHMuCisg ICAgICAgICAgICAvLyBUaGlzIHZhbHVlIGlzIHBhc3NlZCB0byBXZWIgSW5zcGVjdG9yIGFuZCB1 c2VkIGluIHRoZSBKYXZhU2NyaXB0IERhdGUgY29uc3RydWN0b3IuCisgICAgICAgICAgICBTdHJp bmcobV9wYXRoKSwgKG1fZXhwaXJ5ICogMTAwMCksIG1faXNIdHRwT25seSwgbV9pc1NlY3VyZSwg bV9pc1Nlc3Npb24pKTsKIH0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK